- 10 Jun, 2020 40 commits
-
-
Lukasz Anforowicz authored
The same header file may be included in multiple compilation units. When the rewriter emits replacement/edit directives for such header file, then the replacements may be emitted multiple times - once for each compilation unit that includes the header. There is a risk that the replacements will refer to the file using different paths. If apply_edits.py doesn't consistently normalize file paths, then it won't deduplicate replacement/edit directives applying to a given file. This will mean that edits using the first filename will shift offsets within the file and cause edits using the second filename to be applied to random chunks of the file. It is not well understood what may lead the rewriter to use different paths when emitting replacements for the same file (from different compilation units). One hypothesis is that include paths passed to the compiler may differ (e.g. use absolute VS relative paths). Whatever the root cause, varying file paths do happen in the wild - for example: $ grep gl_bindings.h rewriter.out | \ sed -e 's/[^:]*::://' | sed -e 's/:::.*//' | sort | uniq ../../ui/gl/gl_bindings.h /usr/local/google/home/bartekn/chromium3/src/out/rewrite/../../ui/gl/gl_bindings.h Bug: 1069567 Change-Id: Ie67cfaaeaa5c958875733634826c9bb46782c73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222542 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#776812}
-
Koji Ishii authored
This patch has no behavior changes. Bug: 982194 Change-Id: Id4318d42c90bc4aee277c8ca167067664cabe6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154629 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776811}
-
Koji Ishii authored
It turned out that |{Logical,Physical}Rect| versions of |ConvertTo{Logical,Physical}| are not working properly, and lacks tests. This patch moves tests for |{Logical,Physical}Offset| to prepare adding those tests. Bug: 1091797 Change-Id: I1d98adaf11ac2742a619904332231c619c97f6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237569Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776810}
-
Koji Ishii authored
This patch ensures that |CalculateSizeBasedLayoutCacheStatus| can downgrade |kHit| to |kNeedsSimplifiedLayout|, but not to upgrade |kCanReuseLines|. Upgrading can run simplified layout even when previously we determined changes in inline content cannot run the simplified layout. This fixes |PrintPreviewPagesSettingsTest.InvalidPageRanges|. Bug: 982194 Change-Id: Ie9fe75a64f7c24cc0bedc8647b38a8c33d8529bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237433Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#776809}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/437c78593cb5..f43da14878ea 2020-06-10 jvanverth@google.com Add D3D descriptor tables and bind to command list. 2020-06-10 reed@google.com Revert "Switch persistent cache to use SkReadBuffer/SkWriteBuffer" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I388fe1c4ec27b29758fa95ee1b7c356ea6c900c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776808}
-
Prashant Nevase authored
DarkModeImageClassifier class does primary classification based on blink::Image derived classes. For this it calls CheckTypeSpecificConditionsForDarkMode() function on image and every derived class needs to override this method. This requires writing dark mode code in derived classes of blink::Image. This is simplified by creating different element roles for different image types and creating different image classifiers for those. The image classifiers do the initial classification based on image type and further classification is done common for all classifiers. Bug: 1091095 Change-Id: I67137f6a44802c833d380be93bf568943ece493c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172149Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#776807}
-
Arthur Eubanks authored
Change-Id: Id2f645e869506c8a5870131cdb3b9921e37bace2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238889Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#776806}
-
dpapad authored
Instead use the auto-generated bookmarks.js externs file. Bug: 1081815 Change-Id: I626971c485237bd9668665b4774d6adb6a182903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229016Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776805}
-
Wei Lee authored
This is a reland of c027dce3 Original change's description: > [CCA WebUI] Move CCA and its WebUI to chromeos/components > > In this CL, we move some CCA related components to > //chromeos/components/camera_app_ui > > to make it consistent to Help app and Media app. > > 1. CCA resources > From: //chrome/browser/resources/chromeos/camera/ > To: //chromeos/components/camera_app_ui/resources/ > > 2. CCA WebUI > From: //chrome/browser/ui/webui/chromeos/camera/ > To: //chromeos/components/camera_app_ui/ > > 3. Camera App Helper Implementation > From: //components/chromeos_camera/ > To: //chromeos/components/camera_app_ui/ > > Bug: 980846 > Test: Launch CCA and CCA works normally as a platform app > Test: tast run [DUT] camera.CCAUI* > Change-Id: Ic70bd54b35194e3c3398e9f3de9af200346491d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131542 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775987} Bug: 980846 Change-Id: If8421c04573c567c2f2e7d8842f022609fab2a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235263 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#776804}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8d477f73bf8b..a7858e6eb347 2020-06-10 tsepez@chromium.org Pass v8::Platform across public APIs. 2020-06-09 thestig@chromium.org Make length parameter in FPDFAttachment_SetFile() non-const. 2020-06-09 nigi@chromium.org Add expected results for Skia in 2 embedder tests. 2020-06-09 nigi@chromium.org Consolidate repetitive constants in fpdf_edit_embeddertest.cpp. 2020-06-08 tsepez@chromium.org Pump V8 foreground tasks queued to platform message loop. 2020-06-08 awscreen@chromium.org Roll third_party/zlib/ 21c6af6f1..a68151fd9 (11 commits) 2020-06-08 thestig@chromium.org Simplify more code in CFDE_TextOut. 2020-06-08 awscreen@chromium.org Roll v8/ 6a91312c4..9912e35d5 (629 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I0dbf90a8f944b883564935cb2d962dcb4e878e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776803}
-
Daniel Rubery authored
This metric is expired and not expected to be useful in the near future. Fixed: 1037229 Change-Id: I2e83b9f4cd8b652c4b9b4c0f8f70e216a3b96bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238965 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#776802}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2911cba7a7a2..60cf022c0223 2020-06-09 taylori@google.com Merge "perfetto-ui: Roll catapult version" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1a986af5ae60b24cd880d3fc15efe1945e5d1349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776801}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifcc225ca87e8c1e1ef368e22af34d8e2006eaa6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776800}
-
Rachel Wong authored
This change moves kSuccess to the lowest non-default value, so that it doesn't get buried when more error codes are added. Change-Id: Iaa33fd80a3149936d3401b40d9eee2966ab44560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235144 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776799}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e14d9f0c8d0..ae07c9b0fa7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dimich@google.com,ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1027382,chromium:1052567,chromium:1085525,chromium:834134 Tbr: dimich@google.com,ksakamoto@google.com Change-Id: I95421a2daf766f6a6b9634809cab8c3e1a644d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776798}
-
Hitoshi Yoshida authored
In the spec draft[1], |signal| and |priority| has null default values. This CL updates the IDL file to follow it, and updates some C++ code around them. [1] https://docs.google.com/document/d/1Apz-SD-pOagGeyWxIpgOi0ARNkrCrELhPdm18eeu9tw/edit# Bug: 839389, 1070871 Change-Id: Ie398985fd582494b21cdd39b42ac15bc1f4129af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237022Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#776797}
-
Tomasz Wiszkowski authored
Change-Id: I736c4531e8dd7f29c6b7cbce49522e9bde0dcf3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229598 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#776796}
-
Nicholas Hollingum authored
Enables force close in crostini. Looking back at this I definitely didn't know the difference between a flag and a feature when I made the original code. Also fixes a bug where cancelling the dialog multiple times crashes chrome. Bug: 1086424 Change-Id: I84b60ef6d361f9d08a96e1995dde6cbc5ba1b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235576 Commit-Queue: Nic Hollingum <hollingum@google.com> Auto-Submit: Nic Hollingum <hollingum@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#776795}
-
Nasko Oskov authored
Error pages in subframes are currently not isolated, but there is work under way to do so. This CL updates the test to ensure that it works with both modes and will not break once isolation is enabled. Bug: 1092524 Change-Id: I26916c2f15692c842b4989cb76ebab5d5c034baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236924 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#776794}
-
Wei-Yin Chen (陳威尹) authored
When running a small set of tests, the proportion of time running the test can be very low. Both "--copies N" and "--copies N/M --repeat M" should give the same results, but the later can be more cost effective. Bug: None Change-Id: I0bfa07f80d2b8f2985cd15153d355bd0aedf2dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206221 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#776793}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I91c1c34089a6bf01744966f35f4f0e2fd1cd2603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238857 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#776792}
-
Bailey Berro authored
This change removes the DisplayChangeModal flag now that the feature has launched to stable and we no longer need to support both the notification and the dialog. Change-Id: Ic6c0996a8c12d6246ed6e81e3573c94f35e21ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212546 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#776791}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/990a04ecd5e8..437c78593cb5 2020-06-09 liyl@google.com [fuchsia] Always use full name of FIDL libraries. 2020-06-09 csmartdalton@google.com Add an interactive sample that fits cubics to circular arcs 2020-06-09 brianosman@google.com Switch persistent cache to use SkReadBuffer/SkWriteBuffer 2020-06-09 johnstiles@google.com Update GrAlphaThresholdFragmentProcessor to use a child FP. 2020-06-09 johnstiles@google.com Update GrCircleBlurFragmentProcessor to use a child FP. 2020-06-09 mtklein@google.com Reland "remove unnecessary hsw opts" 2020-06-09 mtklein@google.com remove -Fast bots 2020-06-09 jcgregorio@google.com Move Pixel4 Perf jobs to the 4XL. 2020-06-09 egdaniel@google.com Update vulkan linux sdk version on bots. 2020-06-09 adlai@google.com Allow surfaces to validate against matching contexts, not ptr equality 2020-06-09 herb@google.com make GrAtlasTextOp a friend of GrRenderTargetContext 2020-06-09 robertphillips@google.com Auto-resolve DDL targets in flushSurfaces 2020-06-09 fmalita@chromium.org [skrive] Initial artboard plumbing 2020-06-09 jlavrova@google.com Removing fOffsets array from Run; optimizing copyTo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: bungeman@google.com Change-Id: I7cfe11e24be042dc4350738c47a19775b7b0001f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776790}
-
Austin Eng authored
This also updates the roll script to explicitly rsync the desired directories and files instead of using an exclude list. Bug: dawn:433 Change-Id: I5d2404042b419b01e76c73738888cbacf612d350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238626 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#776789}
-
Jimmy Gong authored
- PrinterErrorCode is an enum that details the error that the printer reported when a print job either completes successfully or ran into an error with printing the print job. - This enum is also added to PrintingMetrics API. - Existing stored print jobs will not have this field available as we previously were not storing this information to the local database. Bug: 1053704 Test: unit_tests Change-Id: I6e851bd1def6ae522fc413d8df1ccbe53d421a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207778 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#776788}
-
Hitoshi Yoshida authored
Bindings team is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes such potential crash issues in VideoEncoder. Bug: 839389 Change-Id: Id9b730fb79099bd55b7d1870937691df1269418b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235585Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#776787}
-
wutao authored
This patch resizes the photo to fill the widget bounds and keeps the aspect ratio. Bug: b/158020131, b/140066694 Test: new AmbientPhotoViewTest Change-Id: I80ff174ac9eb224f22b4bc1a669d66557605c9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231982 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#776786}
-
Henrique Ferreiro authored
Migrate the legacy IPC message DragMsg_TargetDragOver to the DragTargetDragOver Mojo message in blink.mojom.FrameWidget. Bug: 1039255 Change-Id: I64bd8c9017e7c283f1c3934725ab830175dbaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212122 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#776785}
-
Hitoshi Yoshida authored
Bindings team is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes such potential crash issues in OscillatorNode Bug: 839389 Change-Id: I00b82cb290bfe2bc89b7354ff4e19aea80b3b10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237025Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#776784}
-
Rakib M. Hasan authored
TBR: robertma@chromium.org Bug: 1050760, 1050754 Change-Id: I266dde105e6faaba75fd23881dd942d6b3baab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238365 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#776783}
-
Kunihiko Sakamoto authored
This reverts commit 84c360e5. Reason for revert: Suspect this CL causes OOPBrowserTest.Basic failure on linux-trusty-rel https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12426 Original change's description: > Ignore CanvasResourceProvider::Clear in OOPR Mode > > In OOPR Canvas2D we no longer have access to Skia in the client process. > We need to update CanvasResourceProvider::Clear to not access SkCanvas > in the case of OOPR. A more ideal fix is tracked in > https://crbug.com/1090081 but simply ignoring it is fine for now as > OOPR automatically handles clearing the canvas during initialization. > > Bug: 1090083 > Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776618} TBR=khushalsagar@chromium.org,nazabris@microsoft.com Change-Id: Ib906f07089a6b48eaf3e4b1f13fcfeae9d9b0896 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237572Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776782}
-
Sadrul Habib Chowdhury authored
A few related changes in this CL: . Improve trace-events, so that there's one FrameSequenceTracker trace-event corresponding to each UMA report. This is done by making sure merged FrameSequenceMetrics instances continue to report to the same trace-event, rather than creating a new one. . Update |frame_trackers_| to be tracked by both the sequence-type as well as the associated thread-type. This only affects scrolls, since the 'thread type' can change only for scrolls. BUG=1087630, 1092119 Change-Id: Ifa9e316899ce2dcf2d22e813985a62cab7e94558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236635 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776781}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40aeb1db6b53ee5b5ffc0a9f4145658ed195d334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776780}
-
Keith Lee authored
Complete the TODO to send the suggestion via this API to the chrome extensions listening for it. BUG=1042084 Change-Id: Ia8877a700d5f5a53b22b5c34df76d502c81cb611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208774 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776779}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/70439a4af4be..9d2399ea2761 $ git log 70439a4af..9d2399ea2 --date=short --no-merges --format='%ad %ae %s' 2020-06-07 joelhockey system_api: Add seneschal share type ARCHIVE 2020-06-03 clarkchung system_api: add technology field in battery fields 2020-05-28 briannorris system_api, shill: add WPA3 security option 2020-05-24 ahassani dlcservice: Deprecate DlcModuleList 2020-05-21 ahassani dlcservice: Deprecate OnInstallStatus signal Created with: roll-dep src/third_party/cros_system_api Bug: 1091611 Change-Id: Ieb00db563f488102fa4a42731e1e029fee5e5c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237287 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776778}
-
David Bertoni authored
The SearchId and SearchIdAndFilename tests were disabled on MSAN for flakiness. Testing 3000 iterations of each one resulted in no flaky failures on the MSAN bots. Bug: 508949 Change-Id: I98a3f9077aff3218e94c2de8b506125175182761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229154Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776777}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I435286712428d3ce5f9ae170e9b4e52f1df788a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776776}
-
Rakina Zata Amni authored
When we do a back navigation that gets served from the back-forward cache, we should preserve the preview state/UI that we previously used when we originally navigated to that page before (so that we will show preview UI if and only if we showed it when we originally navigated to that page). Currently that information is deleted after the original navigation finished, but this CL is adding PreviewsUserData::DocumentDataHolderHolder that will save the information and use it when needed. Bug: 1014148 Change-Id: If70cba0d65ed0f8119eb9c245c1c8ae7104a8876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220415Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#776775}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6db44eab83a6231837551a8e90da04b2e01073c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776774}
-
Fergus Dall authored
https://chromium.googlesource.com/external/anongit.freedesktop.org/git/wayland/wayland-protocols.git/+log/630fb089103a..684cd23ae31f $ git log 630fb0891..684cd23ae --date=short --no-merges --format='%ad %ae %s' 2020-04-07 contact xdg-shell: explain how clients need to perform an initial commit 2020-04-07 contact xdg-shell: describe how to re-map an unmapped toplevel 2020-02-29 jadahl configure.ac: Bump version to 1.20 2020-02-29 jadahl Makefile.am: Also distribute README.md, GOVERNANCE.md and MEMBERS.md 2020-02-29 jadahl configure.ac: Bump version to 1.19 2020-01-13 jadahl xdg-shell: Add support for explicit popup repositioning 2020-01-13 jadahl xdg-shell: Add support for implicit popup repositioning 2020-01-13 jadahl xdg-shell: Remove left-over paragraph from pre positioner versions 2020-02-25 johanhelsing Update point-of-contact for Qt 2020-01-22 yalterz xdg-shell: add missing enum attribute to resize 2019-11-21 contact Convert plaintext documents to Markdown 2019-11-21 contact Add .gitlab-ci.yml 2019-11-20 contact readme: changes should be submitted via GitLab 2019-11-20 contact Add .editorconfig 2019-11-15 contact Add governance document 2019-08-19 yalterz presentation-time: add missing bitfield marker Created with: roll-dep src/third_party/wayland-protocols/src Bug: 1022716 Change-Id: Ic0daf595d72b170122ea562e435de10c7dfcc39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237427Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#776773}
-