- 11 Aug, 2011 40 commits
-
-
evan@chromium.org authored
Ninja now puts all build files under out/, which is already in gitignore. Review URL: http://codereview.chromium.org/7587010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96412 0039d316-1c4b-4281-b951-d872f2087c98
-
mrossetti@chromium.org authored
TEST= BUG= TBR=bauerb@chromium.org,mnissler@chromium.org Review URL: http://codereview.chromium.org/7627001 TBR=mnissler@chromium.org Review URL: http://codereview.chromium.org/7618013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96411 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
TEST= BUG= TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/7627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96409 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them. 1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|. 2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview| BUG=84383 TEST=print preview works after code changes. Review URL: http://codereview.chromium.org/7544018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96406 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/7613004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96403 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This removes the code to control "Headphone" and "Speaker" elements simultaneously for ARM, and makes us instead just look for "Master" (x86) or "Digital" (ARM). BUG=chromium-os:18578 TEST=manual: still works on x86 Review URL: http://codereview.chromium.org/7582024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96402 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelbai@google.com authored
BUG= TEST= Review URL: http://codereview.chromium.org/7538029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96401 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7619006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96400 0039d316-1c4b-4281-b951-d872f2087c98
-
jond@google.com authored
Review URL: http://codereview.chromium.org/7553026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96399 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96398 0039d316-1c4b-4281-b951-d872f2087c98
-
andreip@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/7622013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96397 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
It was occasionally timing out because I wasn't decreasing BrowserBridge's polling timer. That is now fixed. Along with some prerender history fixes, this should deflake the test. I've also split the net-internals prerender view test into two tests, one for the success case and one for the failure case. This simplifies the test a little, and now the success case visits the page. BUG=91799 TEST=NetInternalsTest.NetInternalsPrerenderViewSucceed, NetInternalsTest.NetInternalsPrerenderViewFail Review URL: http://codereview.chromium.org/7558011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96396 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=92410 TEST=unit_tests TBR=avi Review URL: http://codereview.chromium.org/7619009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96395 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Fix the audio and video code which shouldn't have derived from the ResourceObjectBase class. This produced a diamond inheritance on refcounted. The refcounting for resources is no longer threadsafe. We weren't doing any thread stuff with these, so this should be fine. There should be no behavior change. BUG= TEST= Review URL: http://codereview.chromium.org/7608033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96394 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=92410 TEST=Open bookmark folder menus. Don't see '&' signs. Review URL: http://codereview.chromium.org/7619007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96393 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=92482 TEST= TBR=jkummerow@chromium.org, chaitanyag@chromium.org Review URL: http://codereview.chromium.org/7622011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96392 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
* Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ . Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome. * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*. This also allows doing string operations on them. * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety. * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation). * Avoid #define and "using". * Use standard algorithms for similar reasons as using string ops. * Use file_util functions to significantly abbreviate file reading/writing code. * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue). * Avoid casting where possible. Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate. * Convert non-error uses of stderr to the chrome-standard VLOG(1). * Correctly handle hostnames with trailing dots in the input file. * In general, shorten code where possible. Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly. It would be nice if we could avoid this but I guess gyp would have to be smarter or something. BUG=none TEST=none Review URL: http://codereview.chromium.org/7550002 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7623015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96391 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
The concept of some WebUIs not being based on TabContents lived for two weeks (added r62478, removed r63713) but this support code was never removed. BUG=76788 TEST=no change visible Review URL: http://codereview.chromium.org/7554008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96390 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Roll new ffmpeg, libvpx and gyp. Also modify remoting.gyp so that everything should builds. BUG=70688, 47285 TBR=scherkus TEST=All buildbots are green Review URL: http://codereview.chromium.org/7621013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96389 0039d316-1c4b-4281-b951-d872f2087c98
-
epoger@google.com authored
control group is http://codereview.chromium.org/7461150 Review URL: http://codereview.chromium.org/7613007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96388 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
BUG=88353 TEST=On Lion, scroll past the edge of the web content area and see textured over-scroll area. Review URL: http://codereview.chromium.org/7582009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96387 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
Mark the binaries' EULA as having been accepted when GCF is installed via quick-enable. This causes Google Update to start updating the multi-install. Chrome's EULA will still be required on first-run. BUG=88544 TEST=1) Do a multi-install OEM install of Chrome for which the EULA is required. Alternatively, install system-level multi-install Chrome and then manually add eulaaccepted=0 to Chrome's and the binaries' ClientState keys. 2) Visit the GCF download page and install GCF via quick-enable. 3) Verify that eulaaccepted=1 is written to the binaries' ClientStateMedium key. Review URL: http://codereview.chromium.org/7600023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96386 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=92478 TEST= TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/7622010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96385 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
Added Autofix, Exposure, Blur, Sharpen. Also improved appearance a bit by avoiding non-integer coordinates and fixed W3C compatibility (a standalone demo now works on Opera and Firefox allowing for performance comparisons). BUG= TEST= Review URL: http://codereview.chromium.org/7552035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96384 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
Review URL: http://codereview.chromium.org/7618011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96383 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Note: This was a TODO for akalin. BUG=None TEST=None R=akalin@chromium.org Review URL: http://codereview.chromium.org/7612015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96382 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
```--------------------------------------------------------------------- r825 | mark@chromium.org | 2011-08-11 09:47:38 -0400 (Thu, 11 Aug 2011) | 6 lines The process_id field is unsigned, so we need this cast in c++0x. Patch by Rafael Ávila de Espíndola <respindola@mozilla.com> https://bugzilla.mozilla.org/show_bug.cgi?id=677644 ``` --------------------------------------------------------------------- r824 | mark@chromium.org | 2011-08-11 09:45:30 -0400 (Thu, 11 Aug 2011) | 8 lines The first field in a MDLocationDescriptor is a u_int32_t, so change this cast to the correct type. This fixes an error newer clang versions find in c++ 0x mode. Patch by Rafael Ávila de Espíndola <respindola@mozilla.com> https://bugzilla.mozilla.org/show_bug.cgi?id=677641 ------------------------------------------------------------------------ r823 | mark@chromium.org | 2011-08-11 09:40:13 -0400 (Thu, 11 Aug 2011) | 2 lines Fix clang warnings. Review URL: http://breakpad.appspot.com/298002 ------------------------------------------------------------------------ r822 | mark@chromium.org | 2011-08-11 09:39:44 -0400 (Thu, 11 Aug 2011) | 3 lines Zero out the entire context on MD5_Final, not just the number of bytes in a pointer. Review URL: http://breakpad.appspot.com/298001 ------------------------------------------------------------------------ Review URL: http://codereview.chromium.org/7619005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96381 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=92300 TEST=None Review URL: http://codereview.chromium.org/7599028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96380 0039d316-1c4b-4281-b951-d872f2087c98
-
andreip@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/7617007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96379 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
BUG=92307 TEST=Steps described in the bug should not crash a debug build of chromium. Review URL: http://codereview.chromium.org/7608024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96378 0039d316-1c4b-4281-b951-d872f2087c98
-
bashi@chromium.org authored
It looks that the CL still causes interactive_ui tests failures, even though I cannot reproduce failures on my machine. Reverting this to be safe. TBR=bashi@chromium.org Review URL: http://codereview.chromium.org/7622008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96376 0039d316-1c4b-4281-b951-d872f2087c98
-
jkummerow@chromium.org authored
Review URL: http://codereview.chromium.org/7626001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96374 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
Make the determination of whether or not Chrome Frame is in use on-demand rather than during initialization. BUG=92146 TEST=GCF quick-enable should work again. Review URL: http://codereview.chromium.org/7600021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96370 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=92467 TEST= TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/7616007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96369 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=92314 TEST=see bug R=yoshiki@chromium.org Review URL: http://codereview.chromium.org/7608028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96367 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
BUG=91715 TEST= TBR=mpcomplete@chromium.org, jochen@chromium.org Review URL: http://codereview.chromium.org/7618008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96365 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=80794 TEST=none Review URL: http://codereview.chromium.org/7564006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96364 0039d316-1c4b-4281-b951-d872f2087c98
-
torne@chromium.org authored
There's no need to use wstring or printf for this; the l10n code already knows how to substitute values into translated strings and will do it in less conversions. R=rogerta@chromium.org Review URL: http://codereview.chromium.org/7590023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96363 0039d316-1c4b-4281-b951-d872f2087c98
-
arthurhsu@chromium.org authored
BUG=92270 TEST=none Review URL: http://codereview.chromium.org/7610005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96362 0039d316-1c4b-4281-b951-d872f2087c98
-
mkwst@chromium.org authored
BUG=92148 TEST=Read the docs. Do they make sense? Review URL: http://codereview.chromium.org/7601024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96361 0039d316-1c4b-4281-b951-d872f2087c98
-