GitLab

* Add WizardController::SkipEnrollmentPromptsForTesting to skip
enrollment prompts.
* Do not automatically log in after enrollment.
* Some additional logging.

BUG=chromium:651249
TEST=enterprise_FakeEnrollment

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie8516d3b97055c9435697a0071ddf66e5e7dac07
Reviewed-on: https://chromium-review.googlesource.com/696296Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505882}

This test may be simplified by using a promise_test rather than an
async_test.  Additionally, using promise_test will simplify the
transition to new mojo bindings and the migration to Web Platform
Tests.

BUG=769412

Change-Id: I4ae41fa5e5fb43ee611cefc8527bb2e078f1bb71
Reviewed-on: https://chromium-review.googlesource.com/690602Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505881}

BUG=None

Change-Id: Ib8982c19f02e36181b0936d1ed63cffdbb5ad108
Reviewed-on: https://chromium-review.googlesource.com/695716Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505880}

Otherwise crash can occur.

R=pfeldman@chromium.org

Bug: chromium:757778
Change-Id: Idbe43f15bf620af41738e6e27c7a5ddf5bbf3067
Reviewed-on: https://chromium-review.googlesource.com/685270
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505879}

Removes a bunch of long-unused entries and adds a new one
for some upcoming internal-only stuff.

TBR=yzshen@chromium.org

Bug: 673417
Change-Id: I380283ed7b2daae36f6c35529d8ea8a7fda7040d
Reviewed-on: https://chromium-review.googlesource.com/696129Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505878}

This reverts commit e724b177.

Reason for revert: There have been a series of flakes on the trybots, that were no occurring on the Mojo FYI bots. Removing these tests from the trybots until we can find out why.

Original change's description:
> Add Telemetry to linux-chromiumos bot
> 
> We've been running telemetry_unittests and telemetry_perf_unittests on the Mojo
> FYI bots. They've been cycling green for a week, so we'd like to add them to
> the main linux_chromeos bot.
> 
> TBR=sky@chromium.org
> 
> Bug: 758065
> Change-Id: I6ea2c3f619237124ebba5b691ac08bffb93652a6
> Reviewed-on: https://chromium-review.googlesource.com/657858
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503031}

TBR=sadrul@chromium.org,sky@chromium.org,jonross@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 758065
Change-Id: I682ef5e4c7ac45384ce4b4c435ab19f23f0b80ec
Reviewed-on: https://chromium-review.googlesource.com/696301Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505877}

GetAvatarIcon, GetAvatarIconIndex, SetAvatarIconIndex, and
GetHighResAvatar are migrated to ProfileAttributesEntry. Old accessors
are still here (with some extra comment) because they are still used by
ProfileInfoCache tests.

Two high-res avatar tests are migrated and one test about avatar icon
index is added.

An existing observer notifier method in ProfileAttributesStorage is
changed because it was not good enough.

Bug: 305720
Change-Id: I93b3e765cd1131f7ddb905c884db6d23390786bb
Reviewed-on: https://chromium-review.googlesource.com/694062Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: WC Leung <lwchkg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505876}

Bug: 768256
Change-Id: Ie965ca7eae7fa094e23e0d9e294a341136975300
Reviewed-on: https://chromium-review.googlesource.com/683241Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505875}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 666525
Change-Id: Ic44b6d3465e3affd405f188c7743fbe543f846c4
Reviewed-on: https://chromium-review.googlesource.com/688898Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505874}

Objects such as 'NodeList', 'HTMLAllCollection', and 'Arguments' are all
'array'-subtype, and require the same formatting logic as normal arrays.

However, unlike normal Arrays, they should print their name as part of
their result. For example, 'NodeList(5) [...]' instead of '(5) [...]'.

Screenshot: https://imgur.com/a/I41jb

Bug: 769998
Change-Id: I898e4e2be6c9a1bc5f05c341ab2bcc83e57deb2d
Reviewed-on: https://chromium-review.googlesource.com/691355
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505873}

When a ChromeVox user touch explores, the resulting hit node is
sometimes a container.

For example,
<div>
  <div>
    hello
  </div>
  </div>

The outer div can be much larger than the inner div.

Since the div itself isn't usually encountered during keyboard
navigation, it is safe to re-target the hover that touches it into an
object inside.

e.g. 'a' once and can't touch both its container and the text inside.

Test: touch explore in the vk. Verify we only ever hear the key
Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iae6a43c436f37b2adf3ee4c82f824d6e6bfbec2f
Reviewed-on: https://chromium-review.googlesource.com/695905Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505872}

The RenderPass::output_rect and host window bounds for SurfaceTreeHost
were set to the content size of the root surface. Hence, surfaces were
clipped to the viewport (0, 0) × (W, H), where (W, H) is the size of
the root surface. The root surface of ARC windows is sized to match
the Android display.

This CL computes the output_rect as the bounding box of the surface
tree, and resizes the host window to match the output_rect.

Bug: b:64893967
Test: Windows whose bounds exceed the bottom/right edges of the display
      are not clipped in overview mode.

Change-Id: I51ddf7405e703f5c546aec88a01cc004d105b18a
Reviewed-on: https://chromium-review.googlesource.com/639472
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505871}

https://pdfium.googlesource.com/pdfium.git/+log/951b1119d4c7..c2ae41abd16a

$ git log 951b1119d..c2ae41abd --date=short --no-merges --format='%ad %ae %s'
2017-10-02 rharrison Replace GetWord_LSBFirst with FXWORD_GET_LSBFIRST

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I5a1ab9282e05f355622b5d2f5abb183c7872a8b1
Reviewed-on: https://chromium-review.googlesource.com/695719
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505870}

Software decoder will always convert mono to stereo, so setup
the output backend to stereo in the case of mono input.

Bug: b/67158736
Test: manual
Change-Id: Ibaa59b1a5c8532f28e7a8e2d82352942e4508110
Reviewed-on: https://chromium-review.googlesource.com/695847Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505869}

In JUnit3, CommandLine is initialized before a test run, we should do
the same to avoid test flakiness.

Bug: 640116
Change-Id: If9ac3945680060125cfc86b63cf79a91e21d13dc
Reviewed-on: https://chromium-review.googlesource.com/685811Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505868}

The current_buffer_ member variable always points to the front
of the queue. The code can be simplified slightly be removing it.

Change-Id: I4c4101b91d8df7a0640547b3f6f8ecd7dfcd0049
Reviewed-on: https://chromium-review.googlesource.com/695813Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505867}

Bug: None

Change-Id: Ifc8bcd58f5f65af62dbf38226f360ef6b2a94ee9
Reviewed-on: https://chromium-review.googlesource.com/695003Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505866}

Currently, these live in .grd resource files, which won't be available
under the service manager. Putting these into the binary has the added
benefit that they may be harder to tamper with.

A subsequent patch will move the mac sandbox content/common stuff to
service manager, cleaning up some of the DEPS.

Change-Id: I22473e63f762a55a0e9f99b6d5d66186ed84da7c
Reviewed-on: https://chromium-review.googlesource.com/693287
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505865}

(This is the format used by der2ascii and ascii2der.)

Bug: 
Change-Id: I025281f85a5953e69c3485da554be514aaa7b47f
Reviewed-on: https://chromium-review.googlesource.com/693348
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505864}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 666525
Change-Id: I233ff68af8f61aebb07aaed58fbe2c197b970322
Reviewed-on: https://chromium-review.googlesource.com/689136Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505863}

Bug: 769568, 769567
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I80710e77d7568acbfb28f402dea4bcd20c07d972
Reviewed-on: https://chromium-review.googlesource.com/691047
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505862}

The story seems to be failing, so disabling it on mac for now.

TBR=rnephew

Bug: 770904
Change-Id: I5516cd57f726361e09ac976fdc32da1bd87abcfa
Reviewed-on: https://chromium-review.googlesource.com/696283Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505861}

webkit_layout_tests failing on Win7

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/56163

TBR=mkwst@chromium.org

Bug: 770971
Notry: True
Change-Id: I35034ffbbd1a0d727920855544b8d8519895156d
Reviewed-on: https://chromium-review.googlesource.com/696131Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505860}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 666525
Change-Id: I168b6fe1b435c1df42affb65266a9e1099d4cb90
Reviewed-on: https://chromium-review.googlesource.com/688171Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505859}

Bug: 768924
Change-Id: I1136888cf78b4fcec7bc357eb494ed83946d9f0f
Reviewed-on: https://chromium-review.googlesource.com/696035Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505858}

Chrome now requires Xcode 8, macOS 10.12, and 10.12 SDK.

Bug: 669240
Change-Id: I71b0f4238ac3b7baa657bb469480c1a17eaf1e77
Reviewed-on: https://chromium-review.googlesource.com/696291Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505857}

HttpUtils is looking for "\n\n" and "\n\r\n" as the end of the header.
So if the headers are already ending with "\n\n", we shouldn't append "\r\n" to it.
Otherwise, the appended "\r\n" will be treated as the body

BUG=715630

Change-Id: Ia087f3ec7f7644c088635f375782841f2c6a32d0
Reviewed-on: https://chromium-review.googlesource.com/693323Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505856}

BUG=None

Change-Id: I8d0d23a9947b5e4eb56ba02e16c1561076276f08
Reviewed-on: https://chromium-review.googlesource.com/695747Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505855}

This CL makes the paths in the code coverage html report relative so
that the reports are portable.

Bug: 757515
Change-Id: I5685437a4b946ec30c3fcab17fa3bb5ddeb7c744
Reviewed-on: https://chromium-review.googlesource.com/696294Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505854}

From 30m to 40m.

It's hovering pretty close to 30 min currently:
https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=user&c=bot&c=duration&et=1506978420000&f=buildername%3AKitKat%20Tablet%20Tester&f=name%3Achrome_public_test_apk&l=50&n=true&q=dura&s=created_ts%3Adesc&st=1506892020000

R=dpranke@chromium.org

Bug: 
Change-Id: I6c050bdb6ca5a8528b132de5bdaad98ab6aeadbd
Reviewed-on: https://chromium-review.googlesource.com/695837Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505853}

* Changes the accessibility focus order to Cancel button->PIN input->
  Pairing switch->Continue button.
* Makes the status label the default focus instead of the cancel button.

Bug: 770841
Change-Id: I02f0261a7b20da71485dacb4f7a09506fc09976b
Reviewed-on: https://chromium-review.googlesource.com/695838Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505852}

With this CL we start to track our progress through the frame lifecycle
in order to check that we don't use values that are stale or invalid.

Bug: 770401
Change-Id: I50ffc569a6baeae9d0d43e2ed0b84b7a5b701cc0
Reviewed-on: https://chromium-review.googlesource.com/693226
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505851}

Converting Latin-1 to UTF-8 is reasonably straightforward. Note this
converts actual Latin-1, not CP-1252, so a text expectation had to
be fixed. Based on the test, my impression is the pre-use_byte_certs
code treated TeletexString as Latin-1, not CP-1252, so this should
be fine?

Bug: none
Change-Id: Ida9d3439536bbd742ba9814f19b753b5ede067b3
Reviewed-on: https://chromium-review.googlesource.com/693090Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505850}

https://skia.googlesource.com/skia.git/+log/d4b32ba384da..b30d11319bac

$ git log d4b32ba38..b30d11319 --date=short --no-merges --format='%ad %ae %s'
2017-10-02 scroggo Do not try to time kFailedLoops
2017-10-02 csmartdalton CCPR: Add WAR for an Intel GLSL compiler assertion
2017-10-02 robertphillips Temporarily disable deferred texture proxies

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Ie66aefeaf17a15d95acd5f786ae3cea8e017aea7
Reviewed-on: https://chromium-review.googlesource.com/695936Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505849}

The code coverage script fails when top level directory is the
source root('.'), and this CL fixes it.

Bug: 757515
Change-Id: I965cf24d4d2b71227657e490c97a7c76de41439f
Reviewed-on: https://chromium-review.googlesource.com/695828Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505848}

This CL reverts commits
- d01fe371.
- 5fc67636.

The memory corruption should be fixed by
https://chromium-review.googlesource.com/688035

Bug=750267, 754946
TBR=rockot@chromium.org

Change-Id: I8474a5d9f85c2a552cbaac74771aea9ff9e43faa
Reviewed-on: https://chromium-review.googlesource.com/695831Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505847}

Currently, both Chrome and Skia maintain independent blacklists
for MSAA on certain GPUs. When Chrome believes MSAA is available
and Skia believes it is not, we can end up with rendering glitches,
as Skia will be given an MSAA buffer to use, and it will believe
it cannot raster into it.

This change reads the MSAA status from Skia and only enables MSAA
in Chrome if Skia also believes MSAA is available.

Bug: 751919
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id8e119aab1cf9459013c300137c6aa2179528feb
Reviewed-on: https://chromium-review.googlesource.com/629897Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505846}

For code health removes @unrestricted closure doc from
NetworkConfigView.js.

R=dgozman,luoe,einbinder
BUG=None

Change-Id: Ia7ffd3260602fc892e5a16df44642cab7fc1975e
Reviewed-on: https://chromium-review.googlesource.com/691188
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505845}

Refactor checks of whether a menu item id is an extension custom id or
not. The static ContextMenuMatcher::IsExtensionsCustomCommandId()
function is used instead.

Bug: 765829
Change-Id: I2143e9449beb82a2e6580d82e86055b83c6ca41c
Reviewed-on: https://chromium-review.googlesource.com/695718Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: catmullings <catmullings@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505844}

This reverts commit fa1f0b26.

Reason for revert: Looks to have broken the build.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Mac%2F26445%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

In file included from ../../sandbox/mac/mojom/seatbelt_extension_token_struct_traits.cc:5:
../../sandbox/mac/mojom/seatbelt_extension_token_struct_traits.h:10:10: fatal error: 'sandbox/mac/mojom/seatbelt_extension_token.mojom-shared.h' file not found
#include "sandbox/mac/mojom/seatbelt_extension_token.mojom-shared.h"

Original change's description:
> Create sandbox::SeatbeltExtension to dynamically expand the Mac sandbox policy.
> 
> Sandbox policy extensions can be issued for resources in a trusted process,
> which generates a token that may be passed over Mojo IPC. The receiving process
> can then consume the token to be granted access to the resource. Currently only
> file-read extensions are permitted.
> 
> Bug: 510604
> Change-Id: Iaa92c48c120e051c5df72602d09329ebe84ea317
> Reviewed-on: https://chromium-review.googlesource.com/685583
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Justin Schuh <jschuh@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Justin Schuh <jschuh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505819}

TBR=jschuh@chromium.org,rockot@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

Change-Id: Ic0fc32e651db586169ecd127c1674cd8dc205915
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 510604
Reviewed-on: https://chromium-review.googlesource.com/696343Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505843}