- 22 Sep, 2020 40 commits
-
-
Kevin Marshall authored
Removes large libraries that were pulled in as a result of an indirect but necessary dep on Blink. The exclusions can be removed along with the Blink MessagePort dependency, once a fix for crbug.com/1126571 lands and is integrated with NamedMessagePortConnector. Bug: 1131102 Bug: 1126571 Change-Id: I7b25d50470d667f44424b925d3982efa268c24ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424512 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#809544}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600754349-faa1edece0f28695a43c5cb3d7e6ca8a741e4346.profdata to chrome-win32-master-1600775907-34bfad4572405dae937638ebe3b1eeb7936a17be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id2efa8cde75209a04b77414b6c39703745487806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809543}
-
Sammie Quon authored
Test: none Bug: 1111445 Change-Id: I8ee9546149c0c052677f897efedd7f950cd95c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417370Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809542}
-
Ken Rockot authored
We weren't properly checking for backward-compatibility (but were rather checking for strict equality) of types nested within generics. So if a stable structure S has a field of type `array<T>` and T is changing in a backward-compatible way, S would trigger a presubmit failure. This change corrects the logic here to properly nest such backward-compatibility checks. Fixed: 1130671 Change-Id: If739bac2440927fbaf24f7feae5bbd04f9b29c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422189Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#809541}
-
Erik Staab authored
Bug: 1112539 Change-Id: I4cd0774d2728b14559d7f45cab221b0c809713d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425103Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#809540}
-
Azeem Arshad authored
https://chrome-internal.googlesource.com/chrome/deps/barhopper.git/+log/47934f2c634c..d5422b6ec462 $ git log 47934f2c6..d5422b6ec --date=short --no-merges --format='%ad %ae %s' 2020-09-21 azeemarshad [Barhopper] Fix tezcode build issues. Created with: roll-dep src/third_party/barhopper Change-Id: Id3113e08277cce3e34f0ba9da4528c93dae7c635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424683Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809539}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: Id53fa88b0181ec746d37d00677f2eeef045e300d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424847 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809538}
-
Lukasz Anforowicz authored
This CL changes BrowserURLHandlerImpl::RewriteURLIfNecessary so that it returns early(and doesn't mutate the |url| in the in-out argument) if |url| is invalid. This helps avoid scenarios where RewriteUrlForNavigation (in navigation_controller_impl.cc) ends up generating a NavigationEntry with an invalid virtual URL that (accidentally/incorrectly) gets rewritten into a valid URL. Bug: 1116280 Change-Id: I114cf8c8d9459b6931ae659f62a100679b994d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385921Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#809537}
-
Haiyang Pan authored
Bug: 1068326 Change-Id: I53d9b967f9304dcc02e1ee650bc68831f3b5d1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332845Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#809536}
-
Kalvin Lee authored
This change enables the v3 PpdProvider. Bug: chromium:888189 Test: simple-chrome deployment; set up printers Change-Id: I01ec409ad8e53b9b733f46f5d7eeff45946e5bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424855Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#809535}
-
Kyle Horimoto authored
This CL implements a TODO in PendingConnectionManagerImpl to handle incoming requests for connections via the Nearby Connections library. When a request is received, we create a NearbyInitiatorConnectionAttempt (if one does not already exist), then add a new PendingNearbyInitiatorConnectionRequest to it. Additionally, this CL updates the initialization flow for the SecureChannel service so that it now creates an instance of NearbyConnectionManager. Bug: 1106937 Change-Id: Ibe56476babfb201b748beed1fefc80efda7e304e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419374 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#809534}
-
Erik Chen authored
This will allow lacros to synchronously determine ash's version. This allows Lacros to avoid using unsupported APIs. Bug: 1130810 Change-Id: I57fb355861b70b082499e123606f97366e0c3670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423203Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809533}
-
Ryan Sturm authored
Change-Id: I996797624258a2966f621befab5cfb9f9003cd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424856Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#809532}
-
Victor Vasiliev authored
Change-Id: I52691a6d8cb82341a08e0331081ec8a00b3c3d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424831Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809531}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If0bbf09a5520b9c86c816050f920f7fcd64a58c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424664Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809530}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600754349-e20db2f8d281c7f1a24165725105bb03ea6ece36.profdata to chrome-win64-master-1600775907-3f1dcf02f5358f2c935175c2f1e643612d0cf1c1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I715833bd9b7c42dc64eb1bfa48e69d7f196d3024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809529}
-
Jazz Xu authored
This CL adds media controls detailed view. When media controls is clicked outside of action buttons, we will navigate user to a detailed view showing all playing media. Bug: 1129784 Change-Id: I9b84089caacc36229664096af0fbf4f8a31b3f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416682 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809528}
-
evliu authored
This CL moves the Speech On-Device API (SODA) internal repo to the Chromium repo in preparation for dogfooding in accordance with LGPL. Change-Id: I0d073f4e98a2423b86e43b069320dd61546f39d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404156 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809527}
-
David Black authored
Unpinning an item from its view may result in that view being deleted. If the view is deleted, we shouldn't attempt to update its pin. Bug: 1130086 Change-Id: Ib5c8dbe086b4446161569924b3c81a9bd37d272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422247 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#809526}
-
Daniel Classon authored
Fixes a bug where the "Remove Account" search tag showed up in search when there was no second account to remove. Bug: 1116553 Change-Id: I800ebc0d667d0417303f0d11458ea152e1849589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422457 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#809525}
-
David Black authored
This CL also adds focus ring for indication of focus. Bug: 1129694 Change-Id: I0140b01dd6d6ef758176b942622d222005a5710e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424824Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#809524}
-
Nina Satragno authored
Add support for PinUvAuthToken on large blobs. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I57a094eed4cb0cd3d8b20722804826a46ccf0e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422707 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#809523}
-
Leonard Grey authored
This reverts commit f2f4de88. Reason for revert: Crashing on Win7 bots Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868424013558569488/+/steps/capture_unittests/0/logs/Deterministic_failure:_VideoCaptureDeviceMFWinTestWithDXGI.SimpleInit__status_CRASH_/0 Original change's description: > [Win Camera Capture] Use D3D11 with Media Foundation Video Capture > > This CL updates the VideoCaptureDeviceFactoryWin/VideoCaptureDeviceMFWin > implementations to use D3D11 with the MF device source and capture > engine. The VideoCaptureDeviceFactoryWin creates and manages an > IMFDXGIDeviceManager and associated D3D11 device instance. It provides > the IMFDXGIDeviceManager to the MF device source and also plumbs it to > the VideoCaptureDeviceMFWin implementation. The VideoCaptureDeviceMFWin > implementation subsequently provides the IMFDXGIDeviceManager to the MF > capture engine on initialization. > > Providing a MF DXGI device manager to the MF device source and capture > engine is required for zero-copy capture (it allows the Windows frame > server service and MF capture engine to keep captured video frames in > GPU memory and expose MF samples backed by D3D11 textures). > > Bug: 1120900 > Change-Id: Ic5367d03f337daab2220f8d87d1bfe51f6ca8b72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370092 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Markus Handell <handellm@google.com> > Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> > Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Isuru Pathirana <Isuru.Pathirana@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#809472} TBR=mcasas@chromium.org,stefan@webrtc.org,sunnyps@chromium.org,rafael.cintron@microsoft.com,guidou@chromium.org,chfremer@chromium.org,ilnik@chromium.org,handellm@google.com,Isuru.Pathirana@microsoft.com,handellm@chromium.org Change-Id: I8d3559eb85d195d76263f905ce3884c879254e7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424898Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809522}
-
Yulun Wu authored
All search results will be displayed using primary text coloring. Bug: 1130822 Change-Id: Id55060e52e62d263da50ec8d507b742e812902c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421441Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809521}
-
Fredrik Söderqvist authored
For some LayoutObjects that are "SVG children", we will not create and associate a SVGResourceClient. Check for the presence of such an object FragmentPaintPropertyTreeBuilder::UpdateFilter(). Bug: 109224, 1130986 Change-Id: Iab6e73b26a302282ecbe5235d671fbfe90753d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424124Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#809520}
-
Mason Freed authored
It seems that the kDefaultDocumentClass should work just the same, as nothing currently checks for kViewSourceDocumentClass. Bug: 920571 Change-Id: I63088c00c0fa773f8c597f0f88768a984a6fc994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424628 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809519}
-
Natalie Chouinard authored
By default, GMS Core will use best effort matching to provide a font within the same family if the exact match is not available. For this use case, providing a font match for the renderer, only exact matches are valid results, so the query now includes besteffort=false. Bug: 1111148 Change-Id: I9bad598b7c4d9d64ebf3ce9297015e335185b928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419592 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809518}
-
Xianzhu Wang authored
- Combine kEnableOnly into kDefault. The difference between them was that kDefault respects field trial settings and both --enable-feature and --disable-feature, while kEnableOnly didn't respect the disabled status of field trial and --disable-feature. This doesn't affect the default status of the features. 35 features are changed from kEnableOnly to kDefault. - If applicable, use kDefault for features that used kDisableOnly. The difference between kDisableOnly and kDefault was similar to the above, but for enabled status of field trial and --enable-features. All of the changed features are already enabled by default in Chromium and have status:"stable" in Blink, so the change doesn't affect the default status of the features. The following features are changed from kDisableOnly to kDefault: WebUsb, BackgroundFetch, InstallApp, BlockCredentialedSubresources. - Remove kDisableOnly and kEnableOnlyIfOverriddenFromCommandLine, and add kSetOnlyIfOverridden for origin trial features that require the Chromium feature to be enabled by default and the blink feature to be controlled by origin trials, or for features that are enabled by default in Chromium but not in Blink. The following features are changed to kSetOnlyIfOverridden: NotificationContentImage, Portals, IdleDetection, SmsReceiver, WebNfc. Bug: 1048656 Change-Id: Ifa3e590773212411097d07233b68b3c7a199a54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419579 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#809517}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/ca11026a032c..2be1c17fda0d $ git log ca11026a0..2be1c17fd --date=short --no-merges --format='%ad %ae %s' 2020-09-22 junyer Migrate from Kokoro to GitHub Actions for Bazel. 2020-09-22 junyer Migrate from Kokoro to GitHub Actions for CMake. 2020-09-22 junyer Remove Travis CI configuration. 2020-09-22 junyer Initial GitHub Actions CI configuration. 2020-09-22 junyer Improve the comments for RE2::FullMatch() et al. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I4d48c7bf56494987ce64ad8a68a672fdff80da1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424706 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#809516}
-
Andrew Grieve authored
The previous code worked for .apk files created by our build system (where Python performs alignment), but did not work for .apk files that are aligned using Android's zipalign tool (as is the case for bundles). Also changes zipalign overhead to be stored in metadata rather than as a symbol so that the supersize symbols sum matches normalized apk size. Bug: 1130754 Change-Id: Ia852ec1efec4e7a13faa5072cd67cd204148c8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423409 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#809515}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb373a50..041c9519 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie832f62eb46c50209ab1aafc841df335e025563c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424446Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809514}
-
Stephen McGruer authored
Bug: 1127055 Change-Id: I656ecf3b2de8962a0d020b2a2548967a18f194bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419131 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#809513}
-
Ken Rockot authored
Generated by running the command in //third_party/metrics_proto/README.chromium Bug: 1127134 Change-Id: I0afff9e9bd3e4e74a0bc547ac397bffcefc67046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424553 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#809512}
-
rbpotter authored
This will prevent possible collisions, and ensures that files generated by a target all live in that target's output. Note that unpack_pak.py, previously used to create the folder of preprocessed Web UI files, has an equivalent assert. Bug: 1071641 Change-Id: Ic24e2a6c98cc35957c692bfa1a0d40fca1b7423e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424846 Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809511}
-
Omid Tourzan authored
Bug: 491043 Change-Id: I491dab8627493b91bf4b109707d03130b09c6c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402850 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#809510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/02ffb6f47a21..407b5a54a9b5 2020-09-22 syoussefi@chromium.org Use rstrip when getting footer tags If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130601 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I66129b9cdef90334a4bbf5e99934b722c4deaa7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809509}
-
Rune Lillesveen authored
According to spec[1], a mismatching used color-scheme for embedding iframe element and iframe document root element should cause an opaque canvas background for the color-scheme to be painted behind the document background. Modify the ViewPainter to allow painting the base background in an iframe for these cases. Bug: 1058822 Change-Id: I0097d8207c2f697367c477b795bfb2443ebd5cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418322 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#809508}
-
Ghazale Hosseinabadi authored
chrome://extensions/ supports inspect views for the background page. This CL adds the capability to inspect views for an active service worker. Inspecting views of an inactive service worker will be added in a separate CL. Bug: 1107596 Change-Id: I63ba5029817f49955657038e260fe3dac3224d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337075Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#809507}
-
Daniel Classon authored
Fix the "Touchpad scroll acceleration" search tag to only show up when the corresponding kAllowScrollSettings flag is enabled. Bug: 1116553 Change-Id: Idc553770da77b33ed7799811798b6bb0e055e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424828Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#809506}
-
Mohamed Amir Yosef authored
This reverts commit 7e032ee2. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel/2954 Original change's description: > [Autofill] Fully migrate to the new Autofill server > > The feature "AutofillUseApi" is now enabled by default. > This CL removes it and starts removing dead code upon the removal of > this feature flag. > > Follow up CLs will do more cleanup! > > Bug: 1114655 > Change-Id: Iff96e341280fe35562469d32660446f5568887f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401040 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808917} TBR=battre@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114655 Change-Id: If370b23b4040ddab1cbde7da0429724ff8a23f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424259Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#809505}
-