- 14 Sep, 2020 40 commits
-
-
Christopher Cameron authored
GpuMemoryBuffers from capture are backed by CVPixelBuffers, which need to be specially annotated because their IOSurfaces will always report IOSurfaceIsInUse as true. The MACOS_VIDEO_TOOLBOX usage flag can be used to indicate that IOSurfaceIsInUse is not usable. Bug: 1125879 Change-Id: I9cdcb57d6c47a8ac0aa5cd3bb120b7b91113a508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409215Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#806561}
-
Henrik Boström authored
This reverts commit ca1323fe. Reason for revert: When resolving a merge conflict, some of the changes were accidentally not included in the patch that landed, causing NV12 not to be recognized. Original change's description: > [macOS Capture] Recognize NV12 and prefer it by default. > > The current default is YUVY, which despite not being supported by any > cameras we've tested, is preferred[1] over the currently recognized > YUY2, which IS supported by most cameras we've tested. See [2] and > https://crbug.com/1124647. > > This CL changes the default to NV12 and makes it a recognized format. > This pixel format is more preferred (according to [1]) than both YUVY > and YUY2. An alternative would be to default to YUY2 instead, and YUVY > wouldn't be picked because it isn't in the list of supported formats, > but we have reason to believe that NV12 is a better choice for future > WebRTC patches and that this format is supported by the Chrome > rendering pipeline. > > NV12 is a planar pixel format, it has 2 planes and is contiguous in > memory. To support this, this CL adds support for planar (along with > the old nonplanar) contiguous buffers. We don't care how many planes > there are, as long as the buffer remains contiguous. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:media/capture/video_capture_types.cc;l=18;drc=9e9c1706881c9a04f124ade622c10460d14fd9f5?q=media::VideoCaptureFormat::ComparePixelFormatPreference&originalUrl=https:%2F%2Fcs.chromium.org%2F > > [2] https://docs.google.com/document/d/1kcJ0Km5kAvrNFB6o7RG89bpvjOhgEo-0qorg5qm7KyA/edit?usp=sharing > > Bug: chromium:1124647 > Change-Id: I5c92e1de73922fd9ee87d8a5892438f61f2f56bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391064 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806084} TBR=ccameron@chromium.org,hbos@chromium.org,guidou@chromium.org,handellm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1124647 Change-Id: Ic18244136bd9ddb4144b2ff077bbb8198b457cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408313Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806560}
-
Kuo-Hsin Yang authored
Implement the OOM Kills histogram by checking the oom_kill field in /proc/vmstat instead of monitoring the kernel log. Bug: 1124182 Change-Id: I8e992933e394104658ac01c4f123ece411f7bc26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402778Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806559}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600041484-c6ff66b09b98954e0f795d944deaf8a778f8e0c8.profdata to chrome-mac-master-1600062449-eb397872f2f81f98b45c4ec794b206b9a087897d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I901b2c550c54dd303f5a6e25698602a807fdc04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806558}
-
Makoto Shimazu authored
Bug: 824858 Change-Id: I28cae38ddfa0dd451917ce699868e722f5ffb177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407628 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#806557}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6e621a98a0b7..01a6665d9a38 2020-09-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I054fd18992cddaf5772a78d593c41aa7af9cd323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409162Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6faa7b6726fa85a8e4bd65785fe3ce98a9c93be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409164Reviewed-by:
-
Antonio Sartori authored
The feature out-of-blink-CSPEE moves the check for Content-Security-Policy: Embedded Enforcement from blink to the browser. The feature has been fully implemented in several CLs, and it should now be safe to turn it on by default. Bug: 1094909 Change-Id: Ifa59513a5e2bb97d47b197866af492fedaf44c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397697Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#806554}
-
Mark Cogan authored
This CL enables iPad multi-window on trunk by default. Change-Id: I919f62fc8f0068071358a9148ba0533a9abedbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404929 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806553}
-
Matt Falkenhagen authored
The crash is likely because the function posted a task to call the callback. By the time the task runs, the registration may no longer be ready. The callback accesses active_version() which is now null. The fix is to require the function to be called on the core thread, so the callback can be called on that thread without posting a task. We should do this for all the Find* functions too, in subsequent commits. Bug: 1062538, 1127724 Change-Id: I5b2f943c50be576dbd1dfb89eee5536e83b41766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405754Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#806552}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81a7629b202f..081bc32703b7 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d14e6a0b to 2ab7a04e (486 revisions) 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0c8f66c7169c to 183a454b9d54 (14 revisions) 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 41974f57973e to dc552fcef1fe (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1078754 Tbr: scroggo@google.com Change-Id: If045c5eb0f9778ecd5824ed6c75c96be23b23793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409163Reviewed-by:
-
sandromaggi authored
This continues the effort to make |WebController| actions use |ElementFinder::Result| instead of |Selector|. It also adds some missing tests to cover the new scenarios. Bug: b/168107066 Change-Id: If4dd4271972ae30f9c3344d976342f9f6d864024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406165 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#806550}
-
Khushal Sagar authored
Currently the logic is limited to cases with multiple videos onscreen but we can be more aggressive with enabling this for single video cases as well if the site opts-in. R=zmo@chromium.org Bug: 1114184 Change-Id: Ic418132e960a8f98e3cf722a406100639c023bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405993 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#806549}
-
Rune Lillesveen authored
Bug: 891944, 881752 Change-Id: Ib1f291cf6c19adf50c97138d3bb1e9705aafee7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409292Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#806548}
-
John Chen authored
Unit test Device.StartStopApp is failing on msan builds due to an uninitialized variable, introduced by crrev.com/806405. Fixing it. TBR=shengfa@google.com Bug: chromedriver:2421 Change-Id: I26e5bceb30d3ba82de5c6502f71a5297617240be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408884Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806547}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600041484-5728f1bbdb3072c9a2ada1afd02e69514bec4d41.profdata to chrome-linux-master-1600062449-3179a4da9bad3e513a066b6120519028fcbec2a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia3282bdca7304442edf5026b71fb5e20fbc627b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409167Reviewed-by:
-
Ben Wells authored
In a multiprofile session, windows can be sent to other desktops. This can be done to the Files app, and when files are opened when it is in this state the apps may open on the original desktop (i.e. that of the profile that owns the files). When this occurs an info message is displayed as otherwise it appears to the user as though nothing happened. The files app shows this message for web apps even though they are opened on the current desktop. This change stops the info message being shown in this case. This change also adds some clarifying comments and also adds some TODOs for other situations that might have similar bugs. Bug: 1109589 Change-Id: I9ceab68fc6547813d4e83f879e04adbcf07a1093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359870Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#806545}
-
Alexey Baskakov authored
Disable CrExtensionsManagerTestWithIdQueryParam.UrlNavigationToActivityLogFail TBR=rdevlin.cronin@chromium.org Bug: 1127741 Change-Id: I43680caf65185718fcfce1e2d2f3a8484b6a1c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409055Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#806544}
-
Alexey Baskakov authored
TBR=dpapad@chromium.org Bug: 1127733 Change-Id: I7b8f2b17f503e5360f807faca4fd3d1ec9b4e09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408600Reviewed-by:
-
Yoichi Osato authored
This CL refactors ResourceFetcher::CreateURLLoader() to receive ResourceRequestHead instead of ResourceRequest. That change reduced the redundant instance creation. Change-Id: Ia1c64a39c480ea4f7ad298bc60160d78707be38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404286Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#806542}
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1110367 Change-Id: I7095c3cfa3e1614f52f11b8dfd4869129a7b7b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408239Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806541}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b711737c1384..81a7629b202f 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 948b3a05550b to dbd34449af20 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I67f8cee0875ae74e13dbee97825db9b7b9d6a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409154Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e53ee0c93173..534924ed9ee5 2020-09-14 fancl@chromium.org auto-triage: Only reopen issues closed by pinpoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1113800 Tbr: wenbinzhang@google.com Change-Id: Ic92b9142361231a3b4319e16eeb2724bc851f8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409153Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/87a2e015f06e..6e621a98a0b7 2020-09-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I051a539d9ac95df58d92135800b75d6322d15565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409152Reviewed-by:
-
Joel Hockey authored
Bug: 971967 Change-Id: Ie7c609750401cffcc23b0850125ef50b4e04a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407677 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806537}
-
My Nguyen authored
Copied over from languages_page/edit_dictionary_page.js Mock: http://go/cros-lang-settings-ux-slide#slide=29 Duplicated word: http://screen/7ptBk8NJEDqhzEc Length limit reached: http://screen/5XQF6ePt4ctSgia Bug: 1113439 Change-Id: If17744293c18d6cb2b33c51373452bbe6d9a9848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397056 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806536}
-
Bo Majewski authored
- Remove unnecessary explicit construction. - Replace DISALLOW_COPY_AND_ASSIGN deprecated macro with explicit deletions - Replace constructed optional value with a constant Bug: 903742 Change-Id: I486f5976c32dd4af312b9d9efa5941c7bd18ce09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389481 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#806535}
-
Alan Cutter authored
This CL makes - MigrateDefaultChromeAppToWebAppsGSuite - MigrateDefaultChromeAppToWebAppsNonGSuite available for enabling via about:flags for the purposes of manual testing. Bug: 1058265 Change-Id: Ia5e386564b9be7f56489980c35d9bd3881f469c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405716 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#806534}
-
Kent Tamura authored
* Add missing dependencies * Move html_media_test_helper.* from html:unit_tests to core:unit_test_support * Move fake_canvas_resource_host.h from platform:unit_tests to platform:test_support Because they are used in modules:unit_tests, and it can't depend on html:unit_tests and platform:unit_tests. This CL has no behavior changes. Bug: 800764 Change-Id: Ia97540cb14b51dabd36fe70bbb74c2c3abf21fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406233 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806533}
-
Meredith Lane authored
Fixes a null dereference crash on MacOS. Bug: 1126394 Change-Id: I8c8f4387cb4c424e17e5900f1faf1660e5d01bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400785 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600019602-ed2e256fac899ca1dee4e6eb48fd53d99ebb14eb.profdata to chrome-win64-master-1600041484-a30af8f2a2acd0d94a4d04ce1984e089b193fca0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib8cb6bb4ce987cde838c561d4c4416c06717f97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408720Reviewed-by:
-
tby authored
The suggested files v2 and soon-to-be file search projects will share code. This CL makes a new directory that we can gradually migrate all file-related search providers into, and adds a common result class for all files. Bug: 1034842 Change-Id: I29026120ec47382155125d1cf225388d233b4117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407675Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#806530}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96d76ad2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ib8eb7a7354ba60fdb83d22a7c977a47eb10b0f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407581Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806529}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I94958f62f8ff8db0cb769ecffe22024eec7923db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409133Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806528}
-
Alexandre Courbot authored
When setting a new resolution, the V4L2 VD calls the pipeline's PickDecoderOutputFormat(), which is in charge of picking an output format that we can eventually display, if needed with the help of an image processor. However the image processor's requirements in terms of buffer size might be different from those of the decoder. Make PickDecoderOutputFormat() return the adjusted size along with the selected pixel format, so the decoder can align to it and set a resolution that the image processor can use as input. BUG=b:168193954 TEST=video.DecodeAccelVD.h264_resolution_switch passes on hana-kernelnext. Change-Id: Id92e75b3d8a3b0e1291f0638fb41ddd5956e6879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405347 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806527}
-
Yuki Yamada authored
This is a follow-up for https://crrev.com/c/2402459/. Bug: 1125952 Change-Id: Iea5bcf36d21e3ab4dd6584d0d46b436ea7e9b780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404231Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806526}
-
Tal Pressman authored
As part of MBI, most widget/view/frame-related messages will go through the AgentSchedulingGroup instead of RenderProcess/RenderThread. That can change the ordering in which messages are handled, and may break some assumptions we are currently making. In order to enable testing and experimentation with this ordering change, this CL makes the ASG interfaces channel-associated, thus preserving the current message order. This will allow us to migrate all the currently channel-associated interfaces to be associated with the ASG, and control the ordering via a flag. Bug: 1111231 Change-Id: Id04d90c748a2ce2cbb47d1cde7892fa99b1aac70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386859 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#806525}
-
Luciano Pacheco authored
Change FileTransferController.canCutOrDrag() to check for util.isNonModifiable() so folders that shouldn't be renamed/moved can't be moved via drag and drop. NOTE #1: With this change Downloads will be copied upon this drag and drop use case, but that's the normal behavior because users are allowed to copy Downloads. NOTE #2: This couldn't be tested with the integration tests because our test function fakeDragAndDrop() cannot emulate the DataTransfer required for this issue. Manually tested in the device dragging and dropping Downloads in another folder Test: browser_tests --gtest-filter=" FileManagerJsTest.FileTransferController" Bug: 1007234 Change-Id: I3ed28465c3d21abd34334b33c0dd65c68a47ea7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404226 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
My Nguyen authored
Copied over from languages_page/edit_dictionary_page.js One change: use computed property for hasWords_, for this to work iron-list can't be under template dom-if. Empty iron-list should not have too much impact on performance. Mock: http://go/cros-lang-settings-ux-slide#slide=28 and http://go/cros-lang-settings-ux-slide#slide=31 No word view: http://screen/34mebiVZeEXru8k With words view: http://screen/9mDdiNFpPv4avpu Bug: 1113439 Change-Id: Ide9edc3cbd95f055fd50109d1a17973152b3076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395903 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600019602-70deeea6efa76ec6386c7bc7963d060c951bcf80.profdata to chrome-mac-master-1600041484-c6ff66b09b98954e0f795d944deaf8a778f8e0c8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4058a59de85c8bbabc44f20cfc92a08c20afd3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408961Reviewed-by:
-
