- 18 Nov, 2019 40 commits
-
-
Livvie Lin authored
This CL unblocks crrev.com/c/1918837, where the original CL was reverted due to a failed DCHECK in CheckFeatureIdentity that caused VR tests to fail. The fix here is similar to the one mentioned in crbug.com/872073. Bug: 1008219 Change-Id: Ic84d05e4e14d2f9cf188a623176f37d589e65a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919832Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716203}
-
Sergio Villar Senin authored
Undefined values for inherited_time (which is a double) are represented with NaN (NullValue()). We could instead use a base::Optional<double> which can explicitly represent and undefined double value. A new temporary utility function was added which converts from a double with a potential NaN value to an Optional<double> where the NaN is represented as an undefined value of the Optional. This function will be removed in a followup once all the callers are properly migrated. Bug: 737867 Change-Id: I1977e0060744600e4d78de92ba00c56734aac3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913418 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#716202}
-
Lindsay Pasricha authored
Also roll upstream ios13-beta-simulator trybot config. Bug: 1018869b Change-Id: Ie2464fc58c8b0a558bd448cce54585f7f5639778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921695Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Auto-Submit: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#716201}
-
Toby Huang authored
Currently, ScreenTimeControllerTest uses LoginPolicyTestBase to log in as child user for tests. We should deprecate LoginPolicyTestBase in favor of LoggedInUserMixin instead. This CL converts ScreenTimeControllerTest to replace LoginPolicyTestBase with LoggedInUserMixin for logging in as child user for tests. Bug: 1014663 Change-Id: Ia7bcac8b9302bf27726c1f47d580c0cf1510aadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911230Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716200}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c9dcd09f24db..d4fb7c7b140d git log c9dcd09f24db..d4fb7c7b140d --date=short --no-merges --format='%ad %ae %s' 2019-11-18 robertphillips@google.com Rename opPODAllocator to recordTimeAllocator 2019-11-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 69610187..c30db006 (480 commits) 2019-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5f4db6a76640..51b5a3222b60 (9 commits) 2019-11-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 102fd19c65f4..aba1020d3914 (7 commits) 2019-11-18 rosasco@google.com SKQP Build for Fuchsia SDK 2019-11-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-18 kjlubick@google.com [canvaskit] Roll to 0.9.0 2019-11-16 csmartdalton@google.com Revert "Enable msaa ccpr on vulkan" 2019-11-16 csmartdalton@google.com Enable msaa ccpr on vulkan 2019-11-15 herb@google.com Add subspan() to SkZip 2019-11-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@d4fb7c7b140d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I16db143e442582356fa8613f952574b4ad3c66be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716199}
-
Peng Huang authored
Bug: 1022495 Change-Id: I687b7174f40cfae14608ab1e3378fd563f1ea1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919993 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#716198}
-
Joe Mason authored
This is a reland of 71d76ec9 with one change: fix the unit test on Windows 7. Original change's description: > Kill the software_reporter_tool process if the browser exits early > > Assign the software_reporter_tool process to a job object with the > KILL_ON_JOB_CLOSE flag, so that the process will automatically be killed > if it's still running when the browser exits. > > R=proberge > > Bug: 1016939 > Change-Id: I87dfc907cc853add1721f80c589051896ed4e857 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918106 > Commit-Queue: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: proberge <proberge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715997} Bug: 1016939 Change-Id: I03bf2781d3ef38e993310a3ec72fbdefd294fcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921694Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#716197}
-
Charlene Yan authored
This involves: - Not changing color circles on hover - Showing a selected color when opening the bubble if the current color matches the colors in the color picker - Focusing the text field when dialog is initially opened - Updating the spacing above to be 16 px Still todo: - Styling the menu items; need to determine if this should be a context menu - Centering the color picker beneath the text (might be a layout manager feature) Bug: 1015634 Change-Id: I2ecf6e1d176990cfb77d5bea8a688f94a2736462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900131 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#716196}
-
Chris Mumford authored
Both state-update and frame-ready callbacks were called multiple times so switch explicitly to RepeatingCallback. Bug: 1007835 Change-Id: Ie430bacc40a49fe517d9c5e46d6c02e7c1ec4ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913041 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#716195}
-
Evan Stade authored
Bug: none Change-Id: If10abc359bf10cffa1809cc166e05a9fb5bcf7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918289Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#716194}
-
Daniel Vogelheim authored
Element::setAttribute will perform trusted types checks, which (currently) can be circumvented by obtaining the DOM's attribute node and setting the value directly. This fixes this bypass, by performing identical checks when the attribute node values are set, and/or the attribute node is attached to an element. Bug: 1008012 Bug: https://github.com/w3c/webappsec-trusted-types/issues/47 Change-Id: I1d8ead85b3fa11821c329e1f4af60c1e85ea8298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911215 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#716193}
-
Majid Valipour authored
Add a basic keyboard snapping to WPT. This is based on the blink internal test: fast/scroll-snap/snaps-after-keyboard-scrolling.html Changes from original test: - The new tests uses test_driver to send key events. - Add common style and script that I expect to be used in upcoming tests. - Add clean up logic with add_cleanup to ensure they run even if a test fail. # Keeping Original Test This CL does not remove the original test. This is because current CQ wpt runner does not support testdriver.js fully so the new test fails to run in CQ/trybots. Also the original test uses gpuBenchmarking which injects the input at the browser process while current wpt runner input injection uses devtool input protocol which injects directly in renderer thus it covers a slightly different code path. There is ongoing work to support testdriver.js in CQ, and have it inject input from browser process. Until those changes land keeping both version of the tests makes sense. BUG: 1011066 Change-Id: I83db1708277d2d469c940a32ea549edec8c62d23 Fixed: 1011066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893142Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#716192}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/650a1a772186..24d371f4ac97 git log 650a1a772186..24d371f4ac97 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 hjd@google.com Merge "Update to use new UUID format" Created with: gclient setdep -r src/third_party/perfetto@24d371f4ac97 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0ff77dbaccf6de2fceaabebbd528f5581591e9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921876Reviewed-by:
-
Erik Chen authored
The builder is slow and does not provide positive utility. It's mostly a duplicate of the builder android_compile_dbg, but with asan enabled. The build artifacts are not used. Bug: 1022084 Change-Id: Ifc5ed9b5e92c4cd13ef32eb45adfbcf970cd0a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921209 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716190}
-
Chris Mumford authored
All users of CancelableClosureHolder explicitly passed repeating closures, so switching it to be explicitly repeating as well. Bug: 1007835 Change-Id: I47896818101cee07e86f22f6b01130394b70731d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919491Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#716189}
-
Chris Mumford authored
blink::WebPlatformMediaStreamSource::SourceStoppedCallback is only ever called once, so converting it to a base::OnceCallback. Bug: 1007835 Change-Id: I727d751e18fd724db58962dd9b095064dde2c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913173Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#716188}
-
Navid Zolghadr authored
Move the pointerevents extension tests to the main folder following the spec merge. Change-Id: I0b91fb0760cf36ce36e8ba988367878d427bd08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906903 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#716187}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8df0aaf24931..51f08312782b git log 8df0aaf24931..51f08312782b --date=short --no-merges --format='%ad %ae %s' 2019-11-18 bclayton@google.com Reactor: Handle more implicit casting for Call() arguments Created with: gclient setdep -r src/third_party/swiftshader@51f08312782b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/143479561 Change-Id: Ie0b54e66952a4121f02b1b8aec5ada4bfc1879db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921875Reviewed-by:
-
Danan S authored
Added to GaiaAuthFetcher/GaiaAuthConsumer. This implementation only includes support for the parent/child ReAuth delegation use case at this time, to support the ability for parents to give permission for requests by child accounts within the same family. Bug: 957832 Change-Id: I69165e5c9300a30b32516ec76cbe728365b3063b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872768 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Dan S <danan@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#716185}
-
Antonio Gomes authored
... down to third_party/blink/renderer/platform/peerconnection/ and renamed to rtc_rtp_sender_platform.h. Note that the class is also renamed to RTCRtpSender to RTCRtpSenderPlatform. This way, the well defined interface for base classes is kept, and not exposed out of Blink. BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7993529f6314faa1da49519ae50e33da884211fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882132 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#716184}
-
Chris Mumford authored
InvokeOnSignalingThread only ever runs its callback parameter once so switching to WTF::Bind. Bug: 1007835 Change-Id: I289c191197b4740ad4f2cbbd099b175c1ade2c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913040 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
-
Etienne Bergeron authored
The following code is deprecated and no longer use. It's deadcode. The last use of this code got removed here: https://chromium-review.googlesource.com/c/chromium/src/+/1902477 Bug: 1025561 Change-Id: Ia24f4ffab7e6371173efa57147a71d3f5fca1e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921649 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#716182}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c6d66df..6cec4557 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4bf59569f6e6c3fd35529a4c28aa6e2a314b79f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921537 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716181}
-
Peter Wen authored
This reverts commit 25949c9f. Reason for revert: Presubmit checks encountering file not found infra failures: https://crbug.com/1025763 Original change's description: > Android: Use checked-in JDK to run checkstyle > > Bug: 693079 > Change-Id: Ie50b217c572ff63b6a8b1db233e2ede0d7741b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921547 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716152} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I880624356555105688e9e50c0350137b69d90ff0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 693079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920475Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716180}
-
Alex Chau authored
- Add sharing_p256dh and sharing_auth_secret to SharingSpecificFields - DeviceInfo::SharingInfo now stores SharingTargetInfo for VAPID and Sharing sender ID - Retrieve encryption info for Sharing sender ID in registration - Simplified registration by removing expiration check, and instead call InstanceID::GetToken at every start up, similar to other services - Simplified implementation of SharingSyncPreference Bug: 1018145 Change-Id: I40bbc8093fe198bad108dcd78bbf63c6e9af64e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920044 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#716179}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9c2e77d9113f..f2221403e098 git log 9c2e77d9113f..f2221403e098 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 perezju@chromium.org [Telemetry] Simplify Telemetry progress reporter Created with: gclient setdep -r src/third_party/catapult@f2221403e098 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:973837 Change-Id: Ib029bdcccf8e20d539339f0688699581e9c1d32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921873Reviewed-by:
-
Richard Knoll authored
This moves the phone number regex to a new file to prepare for multiple variants. Also moves the metrics collection to sharing_metrics. Bug: 1001033 Change-Id: Ie4b2e7e287345d078c8be18ecd21867d50eb1c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919923Reviewed-by:
-
sczs authored
Bug: 1014652 Change-Id: I0408a21e9206d13a0abc222c5dcdde5b14abafa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921549Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#716176}
-
Richard Knoll authored
This adds a feature flag to enable V2 of the phone number detection for Click to Call. Bug: 1001033 Change-Id: I1f44cd5a9bd1b4107e1e24a4e6eba0f6d60fc54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919922 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Benoît Lizé authored
Bug: 983348 Change-Id: Iecbe6fc0fead4a89af149ec7c2b018a3cfd3aeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920043Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#716174}
-
Jonathan Ross authored
Three test have begun failing consistently. This will suppress those failures as we work to determine the root cause. TBR=ynovikov@chromium.org TEST=webgl2_conformance_gl_passthrough_tests conformance/extensions/get-extension.html conformance2/extensions/webgl-multi-draw-instanced-base-vertex-base-instance.html deqp/functional/gles3/stringquery.html Bug:1025719 Change-Id: I5128d935943ac8bead95a1f2158e0911ee8f08be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921555 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#716173}
-
Owen Min authored
The feature is going to be rolled out in M79. Raise the expire milestone just in case. Bug: 1009677 Change-Id: I3adb6592641674ca2f7cb790e885b024b176e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918272Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716172}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/954888135395..430d4059adb3 git log 954888135395..430d4059adb3 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src d42d0747ee1b..ba6cbb047868 (1 commits) Created with: gclient setdep -r src/third_party/angle@430d4059adb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: chromium:None Change-Id: I5b2dcafab09d2ed6d1d33201c0d60b120d87e329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921874Reviewed-by:
-
Joe Mason authored
* Always test with registry keys found. * No need to test all combinations of crash point x prompt user values. Cuts the number of test combinations from 38 to 11. R=proberge Bug: 1016939 Change-Id: Ib3a039f42aaf3a83dd2ccc3fba088667cd3d43b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918947 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Fixes incremental_install=true on Android Q Bug: 1025117 Change-Id: I8945f8dbc5327f5cdbcd13b43ebf09dba8978768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919728 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#716169}
-
Chris Lu authored
Exposing this property will be necessary when the banner is presenting while an Infobar action is processing and the modal should not be opened. Bug: 1014959 Change-Id: I964d5ec1d2513cefd4b84cf04377877ac3ac8ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907594 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#716168}
-
Sebastien authored
Upon installation of the Games component, the installer will update this pref with the paths to data files. This CL adds the consumption side of the pref, where the GamesService will check for the existence of the pref as a sign that the component was correctly installed. Bug: 1018201 Change-Id: I24253170228beb8247cb8317d405b6ce54029781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912808Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#716167}
-
Fredrik Söderquist authored
Add a DecodeSVG API to Blink's WebImage to provide for decoding, parsing and rendering of a blob of (hopefully) SVG data. In the process, relocate WebImage to public/web (from public/platform), since that makes it easier to interface with SVGImage (which is in the "core complex"), and there appears to be no strong ties on the WebImage interface as such to have it in public/platform. The ImageDownloader component is extended to be able to decode data with the MIME type using the new WebImage::DecodeSVG API. The WebContents::DownloadImage interface (as used for favicons and other things) is extended to allow specifying a "preferred size". This size is used when determining which size to render a scalable image format into. This is different from the pre-existing "max (bitmap) size" which acts as hard upper bound on (either of) the dimensions of the rendered results. Based on some of the users of this interface there seems to be a need to have both. Intent-to-Implement-and-Ship thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/IKe_SAgdNAA/discussion Bug: 294179 Change-Id: I8d4f27c563b97cdd57e3fe9d42d3c82f1e087eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541185Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#716166}
-
Jonathan Ross authored
Recently the two tests concerned here were suppressed on [ mac no-passthrough ] however they also fail on Android. I'm updating to be just [ no-passthrough ] until the root cause can be addressed. TBR=ynovikov@chromium.org TEST=webgl2_conformance_tests WebglExtension_WEBGL_draw_instanced_base_vertex_base_instance WebglExtension_WEBGL_multi_draw_instanced_base_vertex_base_instance Bug: 1025719 Change-Id: Ia6389b4456b4a231e26014e18dccb28fa9b0165c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921558Reviewed-by:
-
Raphael Kubo da Costa authored
Instead of having a TODO with my name in it, point to the relevant bug I filed at the time so that it is easier to follow up in the future. TBR=haraken, yukishiino Change-Id: Ieadd90b2d1fa8991b62abf5d7d87a11c5fb01a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921975Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#716164}
-
