GitLab

This patch makes it possible to request a copy output before the first
frame has been submitted. These requests are queued and are processed
when the frame is received. Also, this ensures to read the surface id
which is at or greater than the requested surface id.

This patch is a part of the work to make OOPIF pixel dumps work in
layout tests. Specifically, we're transitioning from using non-production
code that synchronously composites and reads back the surface to using
the copy output / readback from surface code. However, because of the
sensitive timing, it is likely that the layout test driver would issue
a request before the latest frame has been processed.

R=fsamuel@chromium.org

Bug: 667551
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ibc1a79cf38db54b34853e41e19d6721475371220
Reviewed-on: https://chromium-review.googlesource.com/978870
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547837}

Browser needs information about selection to be able to show selection
touch handles. When Viz display compositor is enabled, browser does not
receive CompositorFrameMetadata which contains this info and it needs to
be added to RenderFrameMetadata.

BUG=777882
TEST= content_browsertests:
       - TouchSelectionControllerClientAuraScaleFactorTest.*
       - TouchSelectionControllerClientAuraTest.*
      cc_unittests:
       - LayerTreeHostImplTest.SelectionBoundsPassedToRenderFrameMetadata

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8d1d03efb22d308048bfa8939af57658cee28b15
Reviewed-on: https://chromium-review.googlesource.com/980583Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547836}

BUG=824964

Change-Id: I4a3fb472361b8548317c42afbe09b117e25fd178
Reviewed-on: https://chromium-review.googlesource.com/984879
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547835}

The tab switch button won't show background changes after being hidden
and re-shown. This is to work-around that, by recreating it on each set
match that needs it. (Creating it is needed if the match type is a tab
switch and the tab switch button behavior was enabled.) This change
also restores the strategy of not creating a tab switch button unless
and until needed.

Bug: 825372
Change-Id: I0b808969ee5e9b91e3ca292fa929447da148d75c
Reviewed-on: https://chromium-review.googlesource.com/992356
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547834}

Using wpt-import in Chromium 9e0153d9.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15341

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=ajuma

No-Export: true
Change-Id: I1b0e3210a1a333a3e010c3cad13c3dd6ebcf1d74
Reviewed-on: https://chromium-review.googlesource.com/993035
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547833}

Bug: 828584
Change-Id: Ib1ceebf2c486c424ad71e4ca84bac1c94b0a3aba
NoTry: true
Reviewed-on: https://chromium-review.googlesource.com/993932Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547832}

The group ID for the default/communications input device should be based on
the device ID of the corresponding real device.
This was working correctly for input devices that had an associated output
device, but it was using the default ID instead of the real ID when there
was no associated device.

Bug: 828377
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id3ff8d30dc6857d73beb55f216fbe52d89b9f2c0
Reviewed-on: https://chromium-review.googlesource.com/992319Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547831}

OfflinePageTabHelper implements a Mojo service that is notified
of the URL and creation date of the MHTML main resource at the
time that the MHTML document is installed by ResourceLoader.  The
information is discovered during MHTML parsing.
OfflinePageTabHelper records that the metadata was derived from
the MHTML content of an archive and that it should not be trusted.

Change-Id: I4890c003caf3687777917743f02b48c2b315ca4b
Reviewed-on: https://chromium-review.googlesource.com/946729
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547830}

Bug: 790915
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3f1455a61d27e59ac2b5dc49da049044119b6245
Reviewed-on: https://chromium-review.googlesource.com/990236
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547829}

Bug: 824182
Change-Id: I928f8c010ab4b2f51efb9d5599c4a48fcca4b30b
Reviewed-on: https://chromium-review.googlesource.com/993593Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547828}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c7d0b34084e5..668c1d8d1f1a

$ git log c7d0b3408..668c1d8d1 --date=short --no-merges --format='%ad %ae %s'
2018-04-03 agable Reland "Remove Rietveld support from presubmit"

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:770408


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I53ce76b816ba6f936c0e1bbf43218203325f1cca
Reviewed-on: https://chromium-review.googlesource.com/992856Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547827}

If a file URL has a hostname, treat it like an http/https hostname.  In
other words, don't special-case the file scheme, and ensure we show the
rightmost portion of the hostname if present.

BUG=805026

Change-Id: I609198db5523d0ec9085e4a4942e7276ee2c273e
Reviewed-on: https://chromium-review.googlesource.com/993496Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547826}

This replaces external reference of Play Store logo in ARC OOBE OptIn to
internal static icon.

Test: Manually
Bug: 824952
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I351967a7b8738dbc1a7bd64adf0cf8c4d6b68926
Reviewed-on: https://chromium-review.googlesource.com/991470
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547825}

Stop calling a second AppendExtraCommandLineSwitches() method from
CastContentBrowserClient::AppendExtraCommandLineSwitches().

Bug: 67735190
Test: None
Change-Id: Ifc045882cb48c92a67631bec60a3ddb6044cb34e
Reviewed-on: https://chromium-review.googlesource.com/969623Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547824}

BUG=790709,790645

Change-Id: Id016975e6dc286b8b48d368980e5d27c7e273d59
Reviewed-on: https://chromium-review.googlesource.com/993352Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547823}

Bug: 827797
Change-Id: Ib5e0e272844961704d1565293e4401bec8c1077c
Tbr: mathp@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/993693Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547822}

The WebVR frame lifecycle transition from "animating" to "processing" was
confusing due to use of deferred SubmitFrame. Add a new ProcessWebVrCall at
the end of SubmitFrame that can be deferred if needed. A frame counts as
"animating" until that executes.

Refactor VSync logic. WebVrCanAnimateFrame checks if all necessary resources
are available. All the places that provide resources call
WebVrTryStartAnimatingFrame which runs SendVSyncNow if CanAnimateFrame returns
true.

Resources include pending_vsync_ and get_vsync_callback_ along with the
ShouldSkipVSync heuristics and the ui_->CanSendWebVrVSync() check. It should be
generally equivalent, but with reduced wait time if not VSync aligned since it
now reschedules after webvr_deferred_start_processing_ becomes false instead of
waiting for the next OnVSync.

Change-Id: I32f920d3147b0032037b03f72b18df6cf7195751
Reviewed-on: https://chromium-review.googlesource.com/985652
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547821}

     animation after 'Power off' item has focused for
     a while after showing.

focus related spec:
https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view

changes in this cl,
- Set pre_shutdown_timer_ in PowerButtonController to start the cancellable
  pre-shutdown animation after power menu has been shown for 650ms. And remove
  the previous shutdown_timer_ which will start the clean shutdown after
  pressing power button for 3s.

- Add power button menu item focus. Focus on the 'Power off' item after menu is
  shown.

- Since we add the cancellable pre-shutdown animation back in this cl. Add the
  related tests in LockStateControllerTest back which removed in the previous cl
  https://chromium-review.googlesource.com/c/chromium/src/+/916838

- Modify related tests.

Bug: 826064
Change-Id: Ibefb22067f5bd37849eb1b8c3fb3143f5d3b8dc8
Reviewed-on: https://chromium-review.googlesource.com/991398
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547820}

ProfileHelperTest.DeleteInactiveProfile and UkmBrowserTest.HistoryDeleteCheck
need the waiting thread to process tasks or they will deadlock.

BUG=749312

Change-Id: I9d18fd55647d32e6e6a33a72be2a0fa8fcd89524
Reviewed-on: https://chromium-review.googlesource.com/988243
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547819}

The right command key shares a key code with the windows context menu
key. For key event purposes, we don't want to collapse it together
with the left command key in case users have remapped it.

Instead, disable the entire keyboard context menu code path, since
neither of those shortcuts should work on Mac.

Bug: 827618
Change-Id: I05123bde9cd43cf5ba01aaf33d406d8300cbe27b
Reviewed-on: https://chromium-review.googlesource.com/988392
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547818}

Bug: 818832
Change-Id: If7ff297aeed7f138fbf79769d04981bfbb5f6d47
Reviewed-on: https://chromium-review.googlesource.com/985193
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547817}

Bug: 782863
Change-Id: If74a5d771c96eb1d6047f657f863562392ff697a
Reviewed-on: https://chromium-review.googlesource.com/988816
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547816}

15 rebaselines from manual review of 960 IMAGE and IMAGE+TEXT
failures in:
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4542

As in CL:986036, round borders and transformed lines are not included.

TBR=eae@chromium.org, mstensho@chromium.org, atotic@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ic36a11decbfa29e7cb623e93ff48f13a01165221
Reviewed-on: https://chromium-review.googlesource.com/993212
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547815}

Also removes fakebox calls within UI Refresh, since
there is only one omnibox visible at any given time
the ::FAKEBOX focus source should not be used.

Bug: 823862
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c68cdbf5cf6ca2cfbfa3e446b9bdb66390f8335
Reviewed-on: https://chromium-review.googlesource.com/976395Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547814}

By shortening "Developer Tools" to "DevTools", we make it easier for a
user to distinguish multiple instances in the Windows task bar, and
better align to DevTools branding.

Bug: 729910
Change-Id: I961cdd9890ca3569d67cf6ed98697f5dbed79086
Reviewed-on: https://chromium-review.googlesource.com/949781Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547813}

https://chromium-review.googlesource.com/c/chromium/tools/build/+/988694/
will turn it on for the simple chrome bots (Right now they invoke all of
gclient inside the chrome-sdk.)

Bug: 732531, 828392
Change-Id: I1f892970cd19fd8f64dcfb6615d3033301ac2fcb
Reviewed-on: https://chromium-review.googlesource.com/989235
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547812}

https://chromium.googlesource.com/catapult.git/+log/29a751ceced1..1fcfd9b6d53d

$ git log 29a751cec..1fcfd9b6d --date=short --no-merges --format='%ad %ae %s'
2018-04-03 bsheedy Add start service functionality on Android
2018-04-03 simonhatch Dashboard - Add default filters back to skip_files.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828190,chromium:828405


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I9315a557b61fd7e3028cd623a9839640bddd7215
Reviewed-on: https://chromium-review.googlesource.com/992863Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547811}

This CL adds members and update handlers to OmniboxSeparatedLineView.
This code is currently inactive.

Bug: None
Change-Id: I5e601c17eb00e815269c9682a29105164d1f86c4
Reviewed-on: https://chromium-review.googlesource.com/991462Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547810}

Remove the SSLConfig flag to enable RFC 6962 support, since it's
always set to true.

BUG=none

Change-Id: I35c8002d3e4b68ed498f1707cd4c8f3d0ea66949
Reviewed-on: https://chromium-review.googlesource.com/993072
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547809}

Actually remove the Select-to-Speak event handler instead of
trying to add it a second time.

TBR=dmazzoni@chromium.org

Change-Id: Ie8a8dd15adfa16e58ef8d46c60ba3f9b3471b0e6
Reviewed-on: https://chromium-review.googlesource.com/993473Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547808}

When line breaker hits the end edge and looking for trailing items
such as trailing spaces, close tags, forced break, etc., under
certain conditions, it only includes trailing spaces and assume
it's done. When a forced break follows trailing spaces, this
behavior sends the forced break to the next line, causing an
unnecessary empty line inserted.

This patch fixes by setting the LineBreakState properly after it
handled trailing spaces.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Idf591de35800479fe2be18dc5fc3a31f205b76b2
Reviewed-on: https://chromium-review.googlesource.com/992832Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547807}

VK_APPS is mapped to context menu key, which activates legacy menu on Android

Bug: b/822960
Test: manually tested with app in the solitia CQ app
Change-Id: Ic4ce4c5c0d3f0408cc2d1cb4c8601ec1a84c68df
Reviewed-on: https://chromium-review.googlesource.com/992355Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547806}

This updates the root stores for the 2018-01 update from Microsoft,
the macOS 10.13.0, 10.13.1, and 10.13.2 releases, the NSS CKBI 2.20
root store (part of NSS 3.35), and Android Oreo MR1.

This also introduces the concept of a 'legacy' SPKI, which is an SPKI
that is not trusted in the current Android or ChromiumOS root store.
This can be used to set more permissive policies for legacy Enterprises
that have relied on certain CAs being publicly trusted, despite not
adhering to the expectations of a publicly trusted CA.

BUG=none

Change-Id: Id2b358f1e46503deceaf9cd83256c8cd53ffe556
Reviewed-on: https://chromium-review.googlesource.com/990496Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547805}

Some more tests have started flaking on Windows in viz_browser_tests
with unknown timeouts. This disables them.

TBR=kylechar@chromium.org
TEST=viz_browser_tests

Change-Id: I7cc2c4a589d9517fcaf787f4a6aaa1642a1d6485
Reviewed-on: https://chromium-review.googlesource.com/993633Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547804}

This may resolve crashes seen in the WindowServer on swarming.

Tbr: miu@chromium.org
Bug: 828031
Change-Id: Iadbb4bcd74b03ab6abe75efc9b1f02a704ca3b74
Reviewed-on: https://chromium-review.googlesource.com/992453
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547803}

This works around a crash where a layout box references a filter that
contains a feImage filter primitive, which in turn reference content
that has a mask applied.

Bug: 814815, 825538
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2433b3ba48b3ea56462a1eb64209d36aa37cfa4
Reviewed-on: https://chromium-review.googlesource.com/982114Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#547802}

In this part, we add the code to actually move the offline page,
update ADM, update the OfflinePageModel, and call back to the
java side code.

There is also a small refactoring to use the same symbol everywhere
for our database table name, it has moved into offline_store_utils.h.

Bug: 758690
Change-Id: Ia540cfdd9f94ac93a1211eb8b7184507b3906080
Reviewed-on: https://chromium-review.googlesource.com/985208
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547801}

Mac menus don't use a margin around the contents at all - the menu items
(especially their highlights) draw hard up to the menu edge.

TBR=sky@chromium.org

Bug: 828117
Change-Id: I0165bc8987d0f7d6c1ba29660098f91ad9478984
Reviewed-on: https://chromium-review.googlesource.com/993418Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547800}

gn analyze does not use depfile information, which causes it to not know
that builds need to happen when proguard flags change.

To work around this, this change marks the proguard_configs as inputs to
(somewhat arbitrary) java actions.

Bug: 827197
Change-Id: I1522daa0e3782ac1989cf4e234d8409663bf1357
Reviewed-on: https://chromium-review.googlesource.com/985900Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547799}

The race condition happens when UrlLoader::OnReceiveResponse() is
received, but the request is canceled in the meantime. In this case, there
are no more request and we must abort the loading.

It fixes the Android test:
android.webkit.cts.WebViewTest#testSetDownloadListener
in the Android compatibility test suite (CTS).

Bug: 828156
Change-Id: I6bd6c2e89ab055f05ddab51b5cddebf4ff93bb47
Reviewed-on: https://chromium-review.googlesource.com/993057
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547798}