- 08 Jan, 2020 40 commits
-
-
Hesen Zhang authored
- Throttle by extending the interval if user has two consecutive dismiss on notification. Bug: 1013685 Change-Id: If476dc4aeda7bcd6eff7ecd47e2428605fcd6c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988898 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729533}
-
Elly Fong-Jones authored
Since a couple of possible root causes in chrome have been hacked out, let's continue this experiment. Bug: 899286 Change-Id: I9dacb9f28be3af654836eca2beb1aa0f867ac66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976291Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729532}
-
Josh Karlin authored
What: PageLoad.Clients.ThirdParty.Frames.NavigationToFirstContentfulPaint considers a frame to be third-party if its origin differs from the top frame. Change it to be based on eTLD+1 comparison instead. Why: eTLD+1 is the more natural delinitation between same-site and not, as it's what is used by cookies and site isolation. Bug: 1030795 Change-Id: I182e4ae0457b44706498a3f25f825117b969dbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951334 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#729531}
-
Justin Donnelly authored
These features (GroupSuggestionsBySearchVsUrl and PreserveDefaultMatchScore) are now 100% launched on all platforms. Bug: 966462 Change-Id: If7ce8f0766f6bb8b4ef4b584514e9860a9eef5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967555Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#729530}
-
Tim Song authored
Currently, the work area in tablet mode doesn't take into account the hotseat, so the volume/brightness sliders are clipped by the hotseat. We need to take this special case into account. TEST=manually verified BUG=1039909 Change-Id: I221791ff4bb8d9e775b6c641148a81877dde42d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989711 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729529}
-
Randy Rossi authored
This CL fixes two issues with side gesture pass through on display assistants when the screen reader is enabled. 1) When the finger left the top or bottom edges of the screen, the final release touch event was being dropped. This needs to be passed through for underlying gesture logic to work properly. 2) The pass through offset was not being reset. So the first attempt to bring top / bottom trays into view worked. But immediately after pass through mode was invoked and the offset was set, subsequent attempts were failing because all the motion events were sent with wrong coordinates. Also adding myself as owners in this dir. Bug: 1040206 Test: Manual display assistant with screen reader Change-Id: Ic392aaf875b9465e9de22bc985887b1e71779608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992348Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729528}
-
Jeff Yoon authored
The existing setup does not allow for unit testing the logic contained for arg parsing. Refactoring the existing setup, such that we can unit test those components in isolation. * Encapsulate argument parsing and test runner invocation in a Runner class. * Have __main__ create a Runner object, and call main(), which is the central coordinating method. test_args * Unit tests for the argument parsing logic. Change-Id: I3ca576f99aa7dc36b38579dbce40cd7ac4e67c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975302 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#729527}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07c5cd8f..1f5e1e29 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c8338e474694da78e434a3b38221a47d323c13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992282Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729526}
-
Tarun Bansal authored
Bug: 1039309,1037171 Change-Id: Iba3be9ca90fa41d960a9538f603ad473f8c4de40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988848 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#729525}
-
John Budorick authored
Bug: 1039873 Change-Id: I2ccb3666310bf8b61cedfa84fd0717821e6664e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992186Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#729524}
-
Azeem Arshad authored
This CL fixes issue with IPv6 address value flashing "Not available" on connecting when IP address details are configured manually. This was caused because an additional check to not show IPv6 in this case was mistakenly removed in a previous CL (https://crrev.com/c/1954929). Fixed this by restoring the extra check. Fixed: 1039581 Change-Id: Id6d9d18034577c30da86d9bbb0cf84cfb3eda737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988743Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#729523}
-
nancy authored
BUG=1011235 Change-Id: Id02f5cefbcd5db88bda7cb2cc64d43500da0171c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989709Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729522}
-
Tsuyoshi Horo authored
To use this class from other tests. Bug: 1038346 Change-Id: I14ac4ec270219314a8a096319cc023842a01f55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989206Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#729521}
-
Samuel Huang authored
This CL moves 31.6 kB of "long tail" resources to the Developer WebUI Dynamic Feature Module (DevUI DFM), for 9 chrome:// pages whose resources were in components_resources.pak. These resource reside in GRDP files. The new PAK file is created by moving GRDP <part> from the components_resources.grd to newly file dev_ui_components_resources.grd. 7 chrome:// pages that are directly moved are: autofill-internals = password-manager-internals (IDR_AUTOFILL_AND_PASSWORD_MANAGER_INTERNALS_*) crashes (IDR_CRASH_CRASHES_*) gcm-internals (IDR_GCM_DRIVER_GCM_INTERNALS_*) net-export (IDR_NET_LOG_NET_EXPORT_*) policy (IDR_POLICY_*) signin-internals (IDR_SIGNIN_INTERNALS_INDEX_*) user-actions (IDR_USER_ACTIONS_*) 2 chrome:// pages that needed new GRDP files (to separate DevUI resources from end user-facing resources) are: ntp-tiles-internals (IDR_NTP_TILES_INTERNALS_*) interstitials (IDR_SECURITY_INTERSTITIAL_UI_*) These resources are moved to new file dev_ui_components_resources.pak, which then feeds into dev_ui_resources.pak. WebUI .cc and .mm files have their resource include headers updated. Bug: 927131 Change-Id: I4834288d4d6f64a1b5c21ab66402bb20b60844e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959770 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#729520}
-
Toni Barzic authored
When handling shelf drag with extended hotseat, do not start window drag unless the current drag is moving downwards. While ShelfLayoutManager::MaybeStartDragWindowFromShelf already checked whether the scroll direction is not down, it was bypassed when the method was called from StartShelfDrag (because the scroll value was not known at this point). This updates MaybeStartDragWindowFromShelf no to start window drag until it's clear that the drag is upward drag when hotseat is extended. Also, removes MaybeStartDragWindowFromShelf call in StartShelfDrag as it's expected to be no-op with this change. * the method is no-op in kShown hotseat state * in kHidden hotseat state, drag is started only if drag gets above kExtended hotseat bounds (which will not be the case when the drag starts) * in kExtended hotseat state, the window drag will not start as the drag direction is not yet known at this point. BUG=1039906 Change-Id: Ia8087422d61726316a99cc11cc011b9f90d42d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992347Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#729519}
-
dalyk authored
This is a reland of 834f2092 Original change's description: > Squash top level error code returned from host resolver. > > If the host resolution process fails, the top level error code should > now be only ERR_NAME_NOT_RESOLVED. A more specific error code (e.g. > ERR_CONNECTION_REFUSED if a secure mode DoH server was offline) may be > found in ResolveErrorInfo. > > Bug: 1016325 > Change-Id: I9f5f857fffd71be6485d05280239cd0b649d7a8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974678 > Commit-Queue: Katharine Daly <dalyk@google.com> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728725} Bug: 1016325, 1039639 Change-Id: Ifcf5d1c8d3e5558e81b9efc784d234d034ee9a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990249Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#729518}
-
Manuel Rego Casasnovas authored
This patch fixes an under paint invalidation issue related to border-radius on a scrolling element. Before this change we were applying border radius clipping twice, on the container and on the scrolling background. This was producing an unnecessary change of background painting when border radius changes, thus the under-invalidation problem. To fix this we're avoiding to apply the border radius clipping when painting the scrolling background. The main change is at BoxPainterBase::FillLayerInfo::FillLayerInfo() which gets a new parameter is_painting_scrolling_background, we use it to avoid setting is_rounded_fill to true. The test expectation is modified so it also uses composition by setting "will-change: transform" on the "scroller". Also the "fixed" elements is moved out of the "scroller" as the "scroller" is now its containing block, otherwise it wouldn't be visible, BUG=1025019 TEST=compositing/overflow/scroller-with-border-radius.html Change-Id: Ib9b6e2e8b4e8ee42dec413c69b853a3f06336774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984312 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#729517}
-
Tom Sepez authored
They have become unused. Change-Id: I1090f20a31c9f72dc494fff07b08ff49d206d8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989868 Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#729516}
-
Adenilson Cavalcanti authored
This will allow to remove some duplicated code (i.e. thread synchronization) while at same time removing unnecessary use of inline ASM for Intel features detection. A few other advantages: - remove some extra logic (e.g. no need to test the platform to include the correct CPU detection header). - simplifies the buildsystem (i.e. we always include cpu_features.c) - get rid of the simd_stub file. Bug: 1032721 Change-Id: I9427b34ec09dddc41925844a6ec4e6aa4d8f3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987190Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729515}
-
Renjie Tang authored
Change-Id: I6f8dafe320998b1a624678d0d232f771fdde198e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992359Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729514}
-
Anqing Zhao authored
Most TestingDeviceStatusCollector test cases use similar callbacks. It is unnecessary to assign them explicitly into the constructor every time. Introducing a struct with all default callbacks, then change one of them respectively can simplify the codes. Bug: 1034980 Change-Id: Iea3d9ea3e8a25197dd17eb6d7f95536b5c1e36ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980209Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#729513}
-
Toni Barzic authored
ShelfLayoutManager may change display work area while updating shelf bounds - this can cause a call to OnDisplayMetricsChanged(), which starts another bounds update. To prevent reentry into bounds update, ShelfLayoutManager::OnDisplayMetricsChanged() should exit early if shelf bounds update is already in progress. BUG=1040177 Change-Id: I6d5bb49e7d333fd83bd87df8a1e7f12dd3c2a983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992584Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#729512}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3624da9ce38b..625b71f2a1fc Created with: gclient setdep -r src-internal@625b71f2a1fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic57b64a650c8c35cf747a861f28b29b6d49aa471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992346Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729511}
-
Jon Mann authored
Bug: 966270 Change-Id: I193e7b33f60846d488c9d08b62f23d2432710a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794147 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#729510}
-
Natalie Chouinard authored
Extract ChromeBasePreference.java to Settings build target, along with owned resources. Bug: 1035928 Change-Id: Icbc92b6b412a33a741ae528b27d70004b359ccc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991730Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729509}
-
Anastasia Helfinstein authored
TBR=dmazzoni@chromium.org Bug: None Change-Id: If3eab1d8c1ea9bb33d86a5ba69903f7a3be9a3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990196Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#729508}
-
John Budorick authored
Bug: 1039873 Change-Id: I114ea6f03b57911b510e449a356907207d21ac32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992163 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#729507}
-
Vladimir Levin authored
This patch cleans up the find request queue when the main RenderFrameHost is removed from the FindRequestManager. This ensures that we don't try to dispatch more requests, which causes a DCHECK. Note that this patch only affects main frame removal, so it shouldn't have any user-observable behavior changes. R=creis@chromium.org Bug: 1032576 Change-Id: I4d09ba2cf68a71213704b9d2a4a189f5ae2b5489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988679Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#729506}
-
Xiang Ji authored
Also adding new flag 'enrollToken' which allows overriding the default token Change-Id: Idf5d5abee4b8fb885f73c046c3d1440511e35aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988953Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#729505}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a498c649. With Chromium commits locally applied on WPT: aa30315c "Reject cookies with empty names and values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure garykac@chromium.org, pwnall@chromium.org, jsbell@chromium.org: external/wpt/clipboard-apis NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iced7a4074188879783a38305c2a5d7988a5ce196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992281Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729504}
-
Daniel Nicoara authored
Webviews will be explicitly sized. No need to size them by parent size. This will allow the embedding window to be sized based on the viewport such that it allows us to clip contents. Bug: b/143612326 Test: Manual Change-Id: Ie3382c094e11b31b3515c7ef3ee76e55169b7a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962980Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#729503}
-
Mia Glaese authored
If Tabswitcher is shown, we switch to HomePage which owns fakebox. Bug: 1039467 Change-Id: I9a59c9dba89acc9a2644a12663fafaba054d0d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989867Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#729502}
-
Avery Musbach authored
The present CL moves the comment "Attempt to move a window to a different desk" because the code "item_->SetOpacity(original_opacity_);" is equally relevant to just dropping the window back into overview. Bug: None Change-Id: I9fe75292dbb85280ba89c6fdeee55982524edad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991982Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#729501}
-
Elly Fong-Jones authored
This is fairly straightforward. Bug: 1011446 Change-Id: I75ce7abc27d51e32028c27354fa621de98d05470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990126Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#729500}
-
Maksym Onufriienko authored
Set `"shard size": 20` value in tests-config, expecting to have 2 swarming tasks as there are 31 test classes in ios_chrome_ui_eg2tests_module.app Bug: 1033541 Change-Id: I2a3dba9f53bc58d8b9cc7124d795be807c93a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962636Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#729499}
-
Caroline Rising authored
This fixes pinned extensions becoming visible and their widgets anchoring correctly when the extension is not visible because of extensions container size constraints. The effect of this change is that non-visible pinned extensions will pop in as the furthest left icon in the container and all other non-visible extensions will pop up on the right (just left of the extensions button). Once the anchored widget is dismissed, any previously non-visible icon will then disappear and the container would return to its previous state. Bug: 995448 Change-Id: I42d9a710dc89a82706e5b8014f823cbb3ee01a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977390 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#729498}
-
Anton Bikineev authored
Stores in Member constructors are initializing, which means: 1) for Dikstra barrier: the source object is white and the tri-color invariant is preserved; 2) for generational barrier: the target is older than the source and doesn't have to be remembered. This reduces number of executed barriers from 115M to 78M (31%) on speedometer. Design doc summarizing results: https://bit.ly/2QTmOly. Bug: 1021889 Change-Id: I975afeb42eef53f583ce9bb45faf410a0914d264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991622 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#729497}
-
Daniel Vogelheim authored
This applies the CSP of the context document to any doc created by calling DOMParser.parseFromString. The original implementation, as it returned a pointer to the CSP instance of the context document, which (in some circumstances) could mean that the CSP of the context document itself was modified. This makes a copy of the context document's CSP, before assigning it to the newly created document. This re-reverts / re-lands 1975710: Revert CSP application to `DOMParser.parseFromString`. 1917532: [Trusted Types] Fix Trusted Types for other document types Bug: 1030830, 951536 Change-Id: I33adff8c376a6f37788c9aee0ef7ca0c3441785f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980183 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#729496}
-
Yuwei Huang authored
Currently if user puts their mouse cursor on the top of the screen and press F11 to enter fullscreen mode, the Exit Fullscreen X button and the "Press [ESC] to exit fullscreen" prompt will overlap (see bug for demo). This CL fixes this by putting the fullscreen control X button in cooldown mode if the exit prompt is still in showing-animation. In this case the user will need to withdraw the cursor from the top buffer area then move it back to the top of the screen to trigger the X button. Screen cast: https://screencast.googleplex.com/cast/NjU1MTk3NDQzMjQ3MzA4OHwzNTUxNWRmYi1kZA A simpler alternative design would be just to suppress the X button whenever the prompt is showing, and never bother with the cooldown mode, but that would end up having the X button immediately pop up even if the user just moves the cursor a little bit after the prompt is fully shown. Bug: 1038026 Change-Id: If42517c7e87e8b9ab240ac5635f8f7cd33991447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986307Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#729495}
-
Chase Phillips authored
AppCache stores cache data on and reads data from disk using async functions across multiple interfaces. This makes accessing the cached data for tests cumbersome. This CL adds an AppCacheCacheTestHelper class along with a unit test to simplify the write and read stages of cache info and data on disk. AppCacheCacheTestHelper will be used by a later CL that modifies AppCacheUpdateJobTest to verify that, after a 304 request, cached headers are correctly updated to match the server's response. Both the response info and the data has to be verified because our plan is to create a new cache entry for the updated headers and we'll want to verify that the data itself is also correctly saved in the new AppCache cache entry. Bug: 989611 Change-Id: Ic38880bc17e6fc2dcdbed048e2453649cde0e5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988380 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#729494}
-