- 21 Jan, 2021 40 commits
-
-
Ben Mason authored
Change-Id: I712a3fe59be4f72d6033d745931f99d0c2ea32ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642878 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845696}
-
Ehsan Kia authored
This CL cleans up and submits a script originally written by engedy@chromium.org with a few speed and convenience improvements: - use multi-threading to reduce runtime from ~45m to ~8m - add flags for controlling a few options - automatically run the config formatter - reduce the number of false positives - make the script py2 (since chromium is still on py2) Bug: 1053702 Change-Id: Ie5d211d0374f5db6352677821e27defa415c7d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637405Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ehsan Kia <ehsankia@google.com> Cr-Commit-Position: refs/heads/master@{#845695}
-
Garrett Beaty authored
Change-Id: Iec3d74ae1c0e78de49df7a89b3f12402d40ecc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641335 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845694}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30152edff696..1890f38f2471 2021-01-21 leese@chromium.org Deduplicate memory tabs by backing store 2021-01-21 andoli@chromium.org [module.json extensions] settings views 2021-01-21 petermarshall@chromium.org [surveys] Move SurveyLink component into ui/components If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738,chromium:1134103,chromium:1163802,chromium:1169143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie909efd2a11e7730319e1704a25a63e9fd79e9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845693}
-
Reilly Grant authored
This directory has been fully converted to choose between Once and Repeating for all callback types and calls to base::Bind(). Bug: 1007654 Change-Id: I9fd5a20aea036e0e5f6e93a7eed325b8c2a7cc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641159 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845692}
-
Nick Burris authored
* Records SecurePaymentConfirmation.Funnel.AuthenticationDialog metric based on the user action performed on the dialog. * Adds test coverage of the metric to the existing dialog view test. Bug: 1163574 Change-Id: If1fac8ec81225c3227fff1f84f1f97eefe1914fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639140Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#845691}
-
Regan Hsu authored
If after sending the phone status to the phone, and CrOS does not receive a response from the phone that updates the phone status model, resend the phone status after waiting 2 secs, then 4 sec, then 8 sec, etc until the phone status model is populated or the connection status is no longer connected. Bug: 1166844 Change-Id: Icf456c941a48704119af2beb3c5a694b2e39b2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639307 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845690}
-
Ben Kelly authored
This CL factors out the code to write an entry's metadata into its own method. This is in preparation for a later CL that will need to rewrite the metadata with an updated value. Bug: 1143526 Change-Id: I887bbd5f631e41c19c1e863c04d531764de807c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634124 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#845689}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I7c0855e4d362934d7273ca44973dd5e0cce62cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640538Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#845688}
-
Marc Treib authored
Sync.URLFetchTimedOut is extended by 6 months. I also updated the description to point out a (small) caveat with the numbers. Sync.SessionTabs is marked as obsolete. Bug: 1160835 Change-Id: If5fd2501742197aa0c09fa1794b828705277a03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640035Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Eugene But authored
Replace eugenebut who is leaving the team with kazinova Change-Id: I26cc79efbd932c73866ffbd509381c6472a571a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639146Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845686}
-
Stefan Zager authored
When a site-isolated iframe moves to a new process, we need to ensure that the browser sends it an initial set of properties that are generated by the parent frame, even if those properties have not changed. Previously, we redundantly re-sent the properties every time frame rects for the iframe changed. With this patch, we send the initial properties only once, after the first time VisualProperties is sent to the frame. This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2628746 Bug: 1135714 Change-Id: I72e2f30d12525ab3f8cfb97a178b5185a9f6ca13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640893Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#845685}
-
Dan McArdle authored
Change-Id: I34aefab0097426efd47a07062e5a448530c66a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626510 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#845684}
-
Hidehiko Abe authored
crrev.com/c/2617229 enabled libaom, and Lacros was the target, too. However, it couldn't be built for the device. TBR=jzern@chromium.org BUG=1169028 TEST=Built lacros and ran on a device. Change-Id: I0cfda8eddaa778cda72e1fa0b6965b4b84a996f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642045Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#845683}
-
Takuto Ikuta authored
Bug: 1127205 Change-Id: I1c9aab15909f49b163563b17ef9d2888546b7081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642636 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#845682}
-
Katie Dektar authored
Bug: 994384 Change-Id: Ie106d0ba2362f58caaae8669bde7af1ca3f6e53e AX-Relnotes: Fixes crash Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638929 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#845681}
-
Austin Sullivan authored
GetDatabaseNames was refactored to use GetDatabaseInfo here [1]. GetDatabaseNames was formerly special-cased to not create the database if one didn't exist, but this was lost in the refactor. [1] https://crrev.com/c/2557571 Bug: 1163336 Change-Id: I61f1fb0e6ab60c00143ca1471690bf869119aaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622988Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#845680}
-
Thomas Lukaszewicz authored
This CL adds RenderProcessHost sharing support for WebUI URLs of the form chrome://foo.bar/. This is achieved through an update to ComputeSiteInfo() that allows WebUIType to continue to be differentiated via SiteURL but allows sharing of a RenderProcessHost via ensuring the LockURL is based on the WebUI URLs TLD (chrome://bar/ in the example above). RPHI::GetExistingProcessHost() has been updated to skip selection of the spare RenderProcessHost as this will have been considered in the previous call to MaybeTakeSpareRenderProcessHost(). This skip replaces a DCHECK that ensured that the spare RenderProcessHost was not selected as a suitable renderer. Updates to ChromeContentBrowserClient have been made to add support for process sharing between WebUIs with the "top-chrome" TLD. Bug: 1162282 Change-Id: I6b8c07b3bdb6f790ca79e43eded7142ceface290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628027 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#845679}
-
Maksim Moskvitin authored
Note: |connection_| in BrailleControllerImpl never reset and CreateBrlapiConnectionFunction never returns nullptr, thus OnceCallback can be used. Bug: 1152279 Change-Id: I3a7044c7b4143698fb363aa5a4a694156754a0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640537Reviewed-by:
-
Michael Lippautz authored
Funnel MaybeValid() through a trait instead of imposing an API on the receiver. This allows us to avoid implementing a MaybeValid() API on Persistents in the Oilpan library. Bug: 1056170 Change-Id: I05f2497a6a10a8324980e5b82b4c40c785af8331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642680 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845677}
-
Evan Stade authored
Bug: 1161031 Change-Id: I87886fe6c86580299474fafab76a70eaf74964fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639940Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845676}
-
Yashar Dabiran authored
This CL adds a new metric that records the number back navigations to a Google search result page in a search session. This is part of efforts to record metrics for CSN stage 1. See go/csn-design for more details on the project. Change-Id: Ida5ac7358764a8c13da5aea8890957f77c6e2a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616325Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845675}
-
Wan-Teh Chang authored
Change-Id: I9c2cca98c3d48bc0e948ddddf67622277a459c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638545Reviewed-by:
-
Gavin Williams authored
This change also removes the progress bar and cancel print button in print notifications. These are permanently handled by print job management app now. Fixed: 1165993 Change-Id: I408093add0618f2bd0b9994c41d96feb262a00d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626111 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#845673}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 134c4eda. With Chromium commits locally applied on WPT: 898dcda5 "Move CSPEE to the NavigationRequest." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I7e3f074814ec9a6d5b1022938992121e0f4f7880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642307Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845672}
-
Matthew Denton authored
The ReconnectsAfterURLLoaderFactoryDisconnection test checks that there have been at most two requests after the URLLoaderFactory disconnects and reconnects, but it should have been checking for at least two requests. Bug: 1168193 Change-Id: I7c816e433a10e043e70dc1032519b8795253dd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641141 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845671}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.101. R=hypan@google.com Bug: 1041619 Change-Id: I9a62d5ac6f4dc2d6a741571192442fa79b493327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641114 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Alexander Surkov authored
Bug: 1136957 Change-Id: I8840cc3a469c55fbde6a7f78e1ce5158f5afa4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637716 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#845669}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..79b1b0af2eb9 2021-01-21 fmayer@google.com Add .cache to gitignore. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I445ce914f1b5fbcad6887ececa1c940489f0a762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642810Reviewed-by:
-
Alex Ilin authored
This reverts commit e23f231d. Reason for revert: crash https://crbug.com/1169047 that was caused by the original version of this CL was fixed Original change's description: > Revert "[profiles] Don't show a profile being created in the picker and menu" > > This reverts commit e2de939b. > > Reason for revert: causes crash https://crbug.com/1169047 > > Original change's description: > > [profiles] Don't show a profile being created in the picker and menu > > > > This CL leverages the already existing kIsOmittedFromProfileListKey > > preference in ProfileAttributesEntry to mark profiles that shouldn't > > be shown to the user. > > > > kIsOmittedFromProfileListKey was created for profiles in the middle of > > being set up as new legacy supervised users. The preference was dead > > because it was never set to true. This CL revives it and adds additional > > checks to profile_picker_handler.cc and profile_menu_view.cc to not > > display omitted profiles. > > > > Bug: 1126913, 1166809 > > Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845372} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I5133c4502f02b68c4e707fa7c86072bdabce4ff2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1126913 > Bug: 1166809 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642328 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845616} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1126913 Bug: 1166809 Change-Id: I8aba3d3ffef4e01a51228d449e7e0bac24b8f7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642329Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845667}
-
Sylvain Defresne authored
This function is useful to check whether the device supports having multiple scenes (which has impact on core behaviour of the application and not just on the UI). Move it besides other multi-window related functions. Fix compilation when targeting iOS x86 platform caused by the inclusion of partition_alloc header in base/memory/checked_ptr.h even when user_partition_alloc is disabled (which is always the case on iOS). Bug: none Change-Id: I31f7abb6479438176ed72467ddf9811624001911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640455 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845666}
-
Tamer Tas authored
R=johnchen@chromium.org,machenbach@chromium.org CC=almuthanna@chromium.org,mythria@chromium.org Bug: 1158374 Change-Id: I2532943acfd955e9e956a5c3a12ab654a76c2614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642350 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845665}
-
Sylvain Defresne authored
To simplify the API of SessionServiceIOS in preparation of next refactoring, change it to always require a session identifier. Passing an empty string or nil will result in the same code path as calling the methods that took no session identifier. Bug: 1165798 Change-Id: I9739baf91cbcfcd21be61cd487c24b0d375289bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632760 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845664}
-
Todd Sahl authored
A change was introduced in http://crrev.com/c/2536794 to clean up RenderFrameHostManager::speculative_render_frame_host_ when a renderer aborts a NavigationRequest. However, the aborted request may or may not have been associated with the speculative RFH, and there may remain one or more active NavigationRequests that are associated with the speculative RFH. This change modifies the regressed call site that cleans up the speculative RFH to be conditional on there being no remaining NavigationRequests that are associated with it. Bug: 1159916: Crash report - NavigationRequest::OnStartChecksComplete Change-Id: Ifebe8361cf08480d170598e7c3fa973b3bb693d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595806 Commit-Queue: Todd Sahl <toddsahl@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845663}
-
Leonard Grey authored
Bug: 1143589 Change-Id: Ic9d59025575fa264c81384dbc11b531d0b7a227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640834Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845662}
-
Stepan Khapugin authored
Improves blocking UI in the following ways: 1. Fix handling of large fonts 2. Adjust font size when it's changed in settings 3. Add pointer support 4. Rounded corners are now round irrespectfully of the font size For this, the authenticate button gets its title as a subview label, and both buttons are width-constrained to fit. Bug: 1164922 Change-Id: Ib807ca40e544ec3bc016753b8cfe1501c69c61cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640439 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845661}
-
Peter Kasting authored
This reverts commit eb5180b3. Bug: 1169051 TBR: weili Change-Id: I145d7abe9d186abeb847fcbdb278fe378aaf829a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642743Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#845660}
-
Dave Tapuska authored
WebRect should go away with usage of gfx::Rect. This change removes WebRect usage on WebViewClient, WebPluginContainer, WebPlugin, WebRemoteFrame and WebLocalFrameClient. BUG=738465 Change-Id: I3f82b9356457c8438035308057fab302f3388411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639866Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#845659}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101210600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/rr1ZMp2yx7vK_LvYABkJ9aZLOr-jLutWfSkwC4lZUjMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/178042652 Tbr: help-app@grotations.appspotmail.com Change-Id: Ieff34bd95632df9b78790fe68d98826308e6891c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642809Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845658}
-
Mathias Carlen authored
Before this patch users in autofill feature AutofillEnableSupportForMoreStructureInNames were not properly populating first and last names in forms. This patch finalizes the profiles proactively before they are being used to fill fields on the website. This has manually been verified to work on a few websites. The end goal would be to already receive finalized profiles from autofill. Meanwhile this patch addresses this regression until that is solved. Bug: b/175942816 Change-Id: I86579455b36538e32ca133f61b3f2a24defa498c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642356Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845657}
-
