- 14 Aug, 2019 40 commits
-
-
Andreea Costinas authored
As part of a feature to side-load machine keys verified by remote attestation into the system-wide token using the enterprise.platformKeys.challengeMachineKey API, the SignEnterpriseChallenge method needs another argument that specifies the key name used for SignedPublicKeyAndChallenge. When challenging machine key with register = true, the EMK cannot be registered as that would relinquish it and the DMServer relies on it to remain stable. This CL generates a new machine key to side-load into the system-wide token in this case. The key will be used for SignedPublicKeyAndChallenge but the challenge response will still be singed using the stable EMK. Depends on CL:1714597. BUG=b:35580115 TEST=manually tested, unit_tests --gtest_filter=EPKChallengeMachineKeyTest.KeyRegisteredSuccess Change-Id: I4c426f06d1ff32333bf1383a54d4840f119aeeeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708948 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#686730}
-
Nigel Tao authored
Also add another nullptr check for the AppConnectionHolder, similar to crrev.com/c/1750467 Change-Id: Id6c8fc6a02aa21908fa89e6d624cd94cf099712f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752568Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686729}
-
Anand K. Mistry authored
crrev.com/683909 introduced a regression where the dropdown remains open when the user clicks on an item. This is happening because the dropdown is now a child of the cr-input (via a shadow DOM slot). When an item is clicked, onSelect_() closes the dropdown. However, the event bubbles up to the cr-input and its click handler, onClick_(), opens it again. This change makes onClick_() ignore clicks that occurred on the dropdown element. BUG=977313,982230 Change-Id: I55725b4bc6e5f5529f29b2b904d34ad0d9878a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745669Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#686728}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1db609ad72d7..4ca9f410b731 git log 1db609ad72d7..4ca9f410b731 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9e4b116ccc40..99cffe5db419 (6 commits) 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ae2445b..3f00da8c (378 commits) Created with: gclient setdep -r src/third_party/skia@4ca9f410b731 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:None,chromium:None Change-Id: Ib0ce2cadb2567c8f783799c4eff3417257844b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686727}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5e4e8b0af5fa..30ee92ec5163 git log 5e4e8b0af5fa..30ee92ec5163 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 bclayton@google.com Pipeline: Cleanup and simplify setting of SpirvShader input builtins 2019-08-14 bclayton@google.com SpirvShader: Implement GroupNonUniformShuffleRelative capability 2019-08-14 bclayton@google.com SpirvShader: Implement GroupNonUniformShuffle capability 2019-08-14 bclayton@google.com SpirvShader: Refactor AllTrueMask() / AnyTrueMask() 2019-08-14 bclayton@google.com SpirvShader: Implement GroupNonUniformVote capability 2019-08-14 bclayton@google.com SpirvShader: Implement GroupNonUniformBallot capability 2019-08-14 bclayton@google.com SpirvShader: Expose shader capabilities. Created with: gclient setdep -r src/third_party/swiftshader@30ee92ec5163 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/133510501,chromium:b/133510501,chromium:b/133510501,chromium:b/133510501,chromium:b/133510501,chromium:b/139207336 Change-Id: If236c3b161920360a8c7386a3cc32297806150b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753723Reviewed-by:
-
Eliot Courtney authored
If (like in tests), entering tablet mode requires taking a screenshot, we need to rebuild property trees and submit the copy request to viz. Without allowing nested tasks, this can't run and we get a deadlock. Bug: b/139186625 Bug: b/135956156 Test: tast -verbose run dut-4 arc.PIP passes Change-Id: I4af9836fa562835e6d866015ceeaf47772e4270c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753783Reviewed-by:
Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#686725}
-
Stefan Zager authored
The call to HitTestClippedOutByClipPath is an early-return for hit testing cases where the hit test location is disjoint from the clip area. However, the SVG hit test code does not support rect-based hit testing; instead, it performs the hit test on the center point of the hit test rect. The result is that the early-return path is erroneously taken for rect-based hit tests where the hit test rect overlaps the visible area of the clipped element, but the center point of the hit test rect does not. This kind of "false miss" error is acceptable when hit testing to determine touch event targets -- in the worst case, a touch will not target an svg shape even when the expanded touch event location partially overlaps the shape. But for IntersectionObserver V2, false miss errors are unacceptable -- we will fail to detect that an element is occluded by an svg shape. This patch disables the early-return path when the hit test is checking for occlusion. BUG=983460 R=pdr@chromium.org Change-Id: I15887585a24a9a9874582a39b56437152deca202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752701 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686724}
-
David Jean authored
Bug: 992365, 908776, 903635, 874017 Change-Id: I950ce29c49a6161d5761fa711ec74a82310645f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732081 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686723}
-
Alan Cutter authored
Looks like this test is inherently flaky (setTimeout) and something made it start flaking more frequently. TBR=guidou@chromium.org Bug: 993669 Change-Id: I1757b80c9c54031e2a54d8388c1c39b25190980e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752501Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#686722}
-
arthursonzogni authored
Bug: 511340 Change-Id: I5dc810270f2255516feaff4777650d01f2f9c5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749011 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7e48c9eb9993..99cffe5db419 git log 7e48c9eb9993..99cffe5db419 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 timvp@google.com Vulkan: Fix glCopyTexSubImage3D() Created with: gclient setdep -r src/third_party/angle@99cffe5db419 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I1d4bc31eccff68f4c3552aefb52dab6d7511b02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753724Reviewed-by:
-
Rakina Zata Amni authored
Previously we skip devtools/inspector tests because we're using a virtual test suite for the DisplayLocking flag, which is no longer the case. Bug: 882663 Change-Id: I31e4a879bf9dae82401984b2434ae67e306ac918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752493Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#686719}
-
Hitoshi Yoshida authored
A follow-up cleaning up of https://chromium-review.googlesource.com/c/chromium/src/+/1728511 Bug: 839389 Change-Id: Id338c898a4d01bb20e6bb17d3be30cabcbd5c2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752279Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#686718}
-
Peter Kotwicz authored
BUG=None Change-Id: Ib9d60302b836ef28afe75205dc13f70947214b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752547 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
nancy authored
Reuse the uncompress image process, apply the icon_effects, and recompress the image. BUG=988321 Change-Id: I2e4161b64c3db47414dbb4e97744fb953dc9b252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732171 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/283aa6a07c39..903705aad6d9 Created with: gclient setdep -r src-internal@903705aad6d9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:954450,chromium:956776,chromium:None Change-Id: I262bc77a60350e3c50f1314963d8fcfed9a8c0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753662Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686715}
-
Jordan Bayles authored
This patch rolls open screen to latest, and fixes build issues introduced by API changes. Change-Id: Ia66f52dece07328c2546cf68f7804602ccbe913b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749822 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#686714}
-
Yuki Shiino authored
Implements Database.{read_from,write_to}_file. Also fixes pydeps settings and its around. Makes web_idl module set up the sys.path on its own so that action_with_pydeps in *.gn and print_python_deps.py (via PRESUBMIT.py) work. Note that PRESUBMIT.py (and print_python_deps.py) never checks *.gn(i) file so only the way to specify the sys.path is PYTHONPATH, which is out of control. So, this patch lets the module set up the sys.path on its own. Bug: 839389 Change-Id: I6f5bab73a36d64d2fe7826d54e642ae8308270ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746122Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686713}
-
Kenichi Ishibashi authored
Service workers do not depend on shadow pages any more. Note that WebEmbeddedWorker::AddMessageToConsole() still seemed to depend on shadow page but it wasn't. After crrev.com/c/1636110, DevTools are no longer attached to shadow pages. This means that calling AddConsoleMessage() for shadow pages has no effect. Bug: 538751 Change-Id: I0592c682f7a97934a25542bd446860c9e3f20a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748972 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#686712}
-
Nigel Tao authored
Change-Id: I0b0b5d4680ebd4c78d362fa62ecec72629835ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752492 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
Because of CustomTab, it is possible for ARC IME to lose IME focus even though window focus does not change. To prevent that, we should ensure the IME focus is set again when the custom tab child window is removed. TEST=manual(Open a custom tab in Gmail, type something in web contents, close the tab, and type again in Gmail search box in the app.) BUG=b:135281220 Change-Id: I7ee383cdf952c349264725e5691323ce0ee609fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752272Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#686710}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1cd23288. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor kojii@chromium.org: external/wpt/css/css-rhythm NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5e3a88bbd97fee5a683c2db4c3db39f2a92f887a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752885Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f75996469d02..1db609ad72d7 git log f75996469d02..1db609ad72d7 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 34c59c9b88b7..5e4e8b0af5fa (2 commits) 2019-08-13 bsalomon@google.com Remove GrRenderable param from GrProxyProvider::createTextureProxy() Created with: gclient setdep -r src/third_party/skia@1db609ad72d7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: chromium:None Change-Id: Ia6e9ce6ea4079d15fd88103309a650bd05f7da3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753664Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2fb628da46f1..40618d0b93aa git log 2fb628da46f1..40618d0b93aa --date=short --no-merges --format='%ad %ae %s' 2019-08-14 enga@chromium.org Implement RenderBundle in the backend 2019-08-13 hob@chromium.org Update BUILD flags to support Chrome OS 2019-08-13 rharrison@chromium.org Rolling 2 dependencies 2019-08-13 enga@chromium.org Implement RenderBundle in the frontend Created with: gclient setdep -r src/third_party/dawn@40618d0b93aa The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:993457 Change-Id: I9d83d3c039b59a888e70ec56ff3e5a718fa02c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753663Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/565082dac784..d74e2c39cff9 git log 565082dac784..d74e2c39cff9 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 treehugger-gerrit@google.com Merge "Fix start stop buttons visibility" Created with: gclient setdep -r src/third_party/perfetto@d74e2c39cff9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibddcc6aa49d52faa651d7eb772aff31fa2b04ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753665Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f20959283711..60044886a393 git log f20959283711..60044886a393 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 nigi@chromium.org [SkiaPaths] Fix issue that non-Windows cannot load font correctly. Created with: gclient setdep -r src/third_party/pdfium@60044886a393 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia9431e800430865300b584c30676d1f03a1a0199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752336Reviewed-by:
-
James Hollyer authored
This is the second part to a BluetoothDiscoverySession refactoring. The intention of this refactor is to properly keep track of all discovery session inside the parent bluetooth adapter class. The OS specific children should now only be used for OS specific stops, starts, and filter updates and will have no knowledge of the individual sessions. This will more easily allow for filters to be pushed to the OS level filtering. This CL deals with the removing of discovery sessions and the queueing of multiple discovery requests at the same time. Bug: 490401 Change-Id: I80648a76b2dedffe6b1466a06172f99f29c25011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699214 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ovidio de Jesús Ruíz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#686704}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14ef7d57c13d..d6195b651b19 git log 14ef7d57c13d..d6195b651b19 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 saklein@chromium.org uprev_lib: create and move the overlay uprev manager. Created with: gclient setdep -r src/third_party/chromite@d6195b651b19 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I912a5beec025e67f2d7a1d99f1b04bfbbc466a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753090Reviewed-by:
-
Kouhei Ueno authored
This CL prevents the pages capturing audio from entering BFCache. We now taint RenderFrameHost which has granted MediaStream [1] access, and BackForwardCache::CanStoreDocument will return false for those RFHs. I *think* the change should be enough to block other media playing/recording pages from entering the BFCache, but to be confirmed by subsequent CLs which adds the browser tests. [1] MediaStream as in https://w3c.github.io/mediacapture-main/#mediastream which includes microphone/camera/tab/desktop capture. Bug: 989379 Change-Id: I1be4b64d6947058c0e37da7685eeb699a01b1ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729581Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#686702}
-
Hiroshige Hayashizaki authored
This CL imports more tests from upstream: - Test files from https://github.com/WICG/import-maps/tree/master/reference-implementation/__tests__ are imported to import-maps/imported/resources/. - Generated test HTMLs are placed in import-maps/imported/. - To support more tests, the glue code in resolving.tentative.html is moved into `jest-test-helper.js` and extended to support new tests. The current test failures are added as -expected.txt, and will be fixed in the future when import map functionalities are implemented or fixed. Bug: 990561 Change-Id: I087df82355513584a0cf1891da648dd2155f53c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734024 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686701}
-
edchin authored
Previously, simultaneously tapping on a recent tab and "enable sync" in tab grid's recent tab panel would leave the UI in an unusable state. The cause of the bug is that both touches are processed, and then both actions attempt to present view controllers. Simultaneous touch is a grey area, in which the user's intent is unclear and therefore, the best approach to handling the touches is also unclear. One approach is to disable one UI element when another UI element is tapped first. I think that should be a last resort because it makes the UI feel less responsive, and it is difficult to keep track of all the UI states of each button and tappable region. Instead, this CL takes the approach of allowing the taps, processing the first tap, then the second. Then the second tap attempts to present a view controller. It is reasonable to ignore this second tap's attempt because another view controller has already been presented. This CL fixes these simultaneous touches from recent tabs: 1) a recently closed tab and "enable sync" 2) a tab from another device and "enable sync" 3) "show full history" and "enable sync" Note that this CL only applies to the sync settings being shown first, because in practice it seems that the sync settings button tap registers first before a table view tap. If the other way also happens in practice, we can add further code in the future. Also note that I thought about adding tests. But it is not possible to add an egtest that tests simultaneous taps. And a unittest is too contrived in this scenario. TEST: from recent tabs (in tab grid or from menu), simultaneously tap a recently closed tab, a tab from another device, or "show full history" with "enable sync". Bug: 961050 Change-Id: Id388eaeb80173e3ba2f9800a571e990b9d75181b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750190 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686700}
-
Yoshisato Yanagisawa authored
The CL also removes unnecessary mb_config.pyl. Bug: b/137246264 Change-Id: Ib241089a5c6c1a0c67e5effe6ef9efb1f7d30db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732095Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#686699}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b3eeb2a40354..7e48c9eb9993 git log b3eeb2a40354..7e48c9eb9993 --date=short --no-merges --format='%ad %ae %s' 2019-08-14 jdarpinian@chromium.org Add explicit integer casts Created with: gclient setdep -r src/third_party/angle@7e48c9eb9993 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:3439 Change-Id: Ia15361caeed91b8a5c87e30237a5b2230f939ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753444Reviewed-by:
-
Vikas Soni authored
Skip 2 pixel tests for android webview : 1. Pixel_OffscreenCanvasTransferToImageBitmapWorker 2. Pixel_OffscreenCanvasTransferToImageBitmap Also update tags on existing tests to prevent pattern conflict asserts. Bug: 992599 Change-Id: Ieba42b646719d039a36f36c8551cd2585a344e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753115Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#686697}
-
Cliff Smolinsky authored
If a delayloaded function is patched using IATPatchFunction and then later there are method calls to the same DLL, the delayloadhelper will fully realize the IAT for that DLL, overwriting the patch. This change forces all of the imports to get loaded before the patch is created. The primary scenario for this is the GDI patch for GetFontData done in InitializePDF(). This presents a problem, however, because this method is currently called during startup for every child process, thus negating the work done to make GDI delayloaded in the first place. As such, this change also makes two optimizations to prevent losing the delayload perf benefits: 1. For PDF (ppapi) processes, ensures InitializePDF's patches only run on Win7 and Win8. This is done because Win10 uses different font retrieval mechanisms because of win32k process mitigations. 2a. Ensures InitializePDF runs for ppapi processes. Since this code is only actually needed for PDF rendering, there's no reason to do it for every child process. The LoadAllImports + patching then becomes pay-for-play when a PDF is being viewed. 2b. Ensures InitializePDF runs for printing utility processes which use the GDI-based font information on all Windows versions. Bug: 988164 Change-Id: I4d3c560a7c022c09251773c2a0d1cb4585da2145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731175 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#686696}
-
Yun Liu authored
Java coverage is working now on release build. We need to change the configs of android-kitkat-arm-coverage-dbg(rel) the same as current android-kitkat-arm-rel, except with coverage on, to further merge android-kitkat-arm-coverage-rel in android-kitkat-arm-rel later. Bug: 988116 Change-Id: I0cdee70745896f6e291cf172aa2f641ccf254c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746080 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686695}
-
May Lippert authored
Fix: CrSettingsLanguagesPageTest.InputMethods CrSettingsPeoplePageAccountManagerTest.All CrSettingsRouteTest.All SettingsAccessibilityTest.MANAGE_ACCESSIBILITY_* BUG=950007 TEST=Ran browser tests with and without flag Change-Id: I3c23ffc7bbc1fae7946b1c816f67f70b9a309492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748067Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#686694}
-
Peter Kasting authored
Verified that reverting the patch on that bug causes the test to fail. Bug: 969099, 980496 Change-Id: Ie6a26d0a18e1e6533989b776ae24575ffc4a8fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752878 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#686693}
-
Kazuki Takise authored
Some Tast Tests need to know whether Chrome animation is running or not because, for example, Chrome animation is applied to PIP windows when they are moved or resized, but currently there's no way to tell if when it's done completely. In case we need more information in the future, this CL adds an API that queries "window information", instead of adding more specific APIs such as getWindowAnimationState or getWindowBounds. BUG=b:131248000 BUG=b:135956156 BUG=b:135160409 TEST=tast -verbose dut my_crbook arc.PIP Change-Id: Idb0cdba9110127c3b24736d18b326963b929f25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728513 Auto-Submit: Kazuki Takise <takise@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#686692}
-
Gyuyoung Kim authored
This CL converts implementations of idle_manager.mojom both the browser process(IdleMonitor) and the renderer process (IdleDetector) in idle_manager.mojom. - Change mojo::Binding with mojo::Receiver - Change IdleManagerPtr with mojo::Remote<IdleManager> Bug: 955171 Change-Id: I5e5b33cef0ee01b86e44e0778dbb2cd5ab9ac45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750508 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#686691}
-
