- 18 Feb, 2020 40 commits
-
-
Bret Sepulveda authored
I investigated the tests that failed in this build: https://ci.chromium.org/p/chromium/builders/try/fuchsia_x64/496805 and noticed basically all of them are timeout-flaky on Fuchsia, filed under different bugs. So this patch marks all of them. Also marks some previously-marked tests as also crashing. TBR=wez@chromium.org Bug: 1050893, 1051014, 1051370, 1051015, 1050995, 1051774, 1051133, 1051131, 1053512 Change-Id: Ib7e72afeb426612b32a60702c1b4505be29d6520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061758 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#742156}
-
Nohemi Fernandez authored
This CL is part of a series of refactors to move the existing sign-in architecture to the Coordinator-Mediator design paradigm. Fore more information, see go/chrome-ios-signin-migration. Bug: 971989 Change-Id: I3131d6f20fa230b1c55cf9f979d3ed34aa38ccc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047249 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742155}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f0e349172618..fced1b9a3942 git log f0e349172618..fced1b9a3942 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 tvanderlippe@chromium.org Remove typedefs from timeline{_model}-legacy.js 2020-02-18 tvanderlippe@chromium.org Remove typedefs from web_audio-legacy.js 2020-02-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@fced1b9a3942 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id1c31fc2799d40e72112174ebf0e2d4c63032c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742154}
-
Wez authored
Migrate dependencies on SDK-provided prebuilt & C++ libraries to refer directly to the SDK-provided GN targets, rather than the old Chromium- generated rules. TBR=jochen Bug: 1050703 Change-Id: Ifc200463791e71763d04de3e3cdd394404bdfedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059008Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742153}
-
David Bienvenu authored
Change-Id: I1ddb17a4a89ddc44556d65ed8468c572f6f05bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059534Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742152}
-
Rune Lillesveen authored
The shape, forced-colors, and navigation-controls media features were accepted without a value, even if their runtime flags were disabled. Bug: 1051617 Change-Id: Ifc3c3976ac5bccc406ff327a120dd364ea674bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061253 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#742151}
-
Ilya Nikolaevskiy authored
Bug: 1027108 Change-Id: Idb394958879058c2e05da571ca4ba5f684ddd1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060976 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#742150}
-
Fredrik Söderquist authored
Bug: 658305 Change-Id: Ie12b6cd1c0e1c7b9fa5625454e25586c1d723311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061250 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#742149}
-
Antonio Gomes authored
This mojo message is sent to both blink::LocalFrame and blink::RemoteFrame. As a follow up, all calls to blink::FramePolicy will be converted to blink::mojom::FramePolicy. It will allow t_p/blink/common/frame/frame_policy.typemap and the respective traits files to be removed. Bug: 1047272 R=dtapuska@chromium.org, haraken@chromium.org, kinuko@chromium.org Change-Id: I9256ebd346ccb0238579152bb3d0648326528a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057012Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#742148}
-
Clemens Arbesser authored
This CL allows the CollectUserData action to surface generic UI which contains mandatory sections. Since currently chips can't be directly controlled by the generic UI framework, this is done with change in the action itself. In the future, this workaround will be removed. This CL also adds logical operations to the set of supported interactions. Bug: b/145043394 Change-Id: I269d44620a2b194dc3218feebfd16f38d592ecdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036100 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#742147}
-
Wez authored
Update the //tools/fuchsia/local-sdk.py script to generate the GN SDK, based on the 'core' and 'fuchsia_dart' SDK archives. Bug: 1050703 Change-Id: I32cba430b2132b3abd5870a90bd991e4a835e572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057683 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#742146}
-
Tim van der Lippe authored
These are replaced by e2etests that run in the Devtools repository. Bug: 1044632 Change-Id: Iacbb53add325d19c3f536140fcaf82801fe8d4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061158 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#742145}
-
Bo authored
This reverts commit 618c14c5. Reason for revert: Speculative deflake did not help at all. Original change's description: > weblayer: Maybe deflake TopControlsTest > > By doubling the timeout for polling scroll. > > Bug: 1035894 > Change-Id: I6088799c8dd704965e9e9c571cdf4cb919ee745c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050566 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740390} TBR=sky@chromium.org,boliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035894 Change-Id: I52aa8d78a8366de4ea4643457d777ecf7e07c321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062288Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742144}
-
Wez authored
TBR=palmer,agl,dalecurtis,spang,reed Bug: 1050703 Change-Id: I3b306c58833d94273929b8e1580c9f176f739051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056827Reviewed-by:
-
Maria Kazinova authored
New tests check whether Save/Update prompt is shown on successful submission. Change-Id: I3388e6f06c1414ba73ac4a32e8528b6839daf505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056908 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#742142}
-
Gauthier Ambard authored
The launch mask was used to prevent the user from seeing the TabGrid when a tab should have been presented as it is not possible to directly show the BVC when it is presented. Having it contained allow to remove this workaround. Bug: 1038034 Change-Id: I2cc74afe5d00406d1be4de20ed7e96f50cd839a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061759 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#742141}
-
Fredrik Söderquist authored
Split said method into two - one that does a cache lookup and one that builds the GradientData. Reorder the code a bit to eliminate the redundant check for an empty object bounding box. Bug: 109212 Change-Id: If9bdf1d771478d208debbdddf33188b5db28cf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060956Reviewed-by:
-
Omer Katz authored
The static_cast from WeakMember to Member actually constructs a Member. If this happens on a concurrent thread, it will fail during Member creation in SaveCreationThreadState (creation_thread_state_ is nullptr). Bug: 986235 Change-Id: I5d2edf3b714313a9d23663fb805f3bf8486e8f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061248 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742139}
-
Finnur Thorarinsson authored
As per documentation, it should be released as soon as we're done with it. Bug: 895776, 656015 Change-Id: Icbdcdb0fb515070d00cde1f7fac52ce1ab594993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056811Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#742138}
-
anina koehler authored
The contrast ratio should be at least 4.5 on all text. On the initialization screen of the Kiosk app it was too low on one of the strings. The color of one string was changed from gray to #666 (same as the other strings on that screen) which increases the ratio from 3.94 to 5.74. Bug: 1015832 Change-Id: I53f14c5f7831b9a7c54d817e2b28d1a277c59954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036054 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742137}
-
Gauthier Ambard authored
This CL adds the animations for entering/leaving the TabGrid when the motion is reduced. It also adds a parameter to be able to present it with no animations. Bug: 1038034 Change-Id: Idf7d4f48049137007ed9f76bae2828eb90322c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061156 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Convert IDBTransaction back to ExecutionContextLifecycleObserver after crrev.com/c/2060361 IDBTransaction uses ExecutionContextLifecycleObserver to avoid accessing ExecutionContext from the destructor. TBR=haraken@chromium.org No-Tree-Checks: true No-Try: true Bug: 1052319 Change-Id: I055550fb310e59ac99438faa7dff268d4efc6003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060447Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742135}
-
Philipp Hancke authored
adds a test case for https://github.com/w3c/webrtc-pc/pull/2155 BUG=944821 Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#742134}
-
Hiroki Nakagawa authored
This CL adds NOLINT(build/header_guard) in header files used for generating enum values to suppress Tricium warning. The comments and guard code are copied from net/base/net_error_list.h Bug: n/a Change-Id: I88df01fe3427a8b2702813457e391a18185adfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061929Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742133}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22500101fbd..f0e349172618 git log e22500101fbd..f0e349172618 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 tvanderlippe@chromium.org Revert "Extract `toBase64` into `StringUtilities`" 2020-02-18 wolfi@chromium.org Revert "Reland "Use 1000 not 1024 for kB and MB calculations"" 2020-02-18 jacktfranklin@chromium.org Fix TS build checking for bridge files 2020-02-18 jacktfranklin@chromium.org Extract `toBase64` into `StringUtilities` 2020-02-18 tvanderlippe@chromium.org Fix TS + Ninja integration 2020-02-18 wolfi@chromium.org Fix layout issue in add-location-table 2020-02-18 kimanh@chromium.org [devtools] Make wasm source url clickable 2020-02-18 wolfi@chromium.org Reland "Use 1000 not 1024 for kB and MB calculations" Created with: gclient setdep -r src/third_party/devtools-frontend/src@f0e349172618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1035309,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9a08956696b386273e0abe9566e7734cffb7ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061202Reviewed-by:
-
henrika authored
It is now more clear that this method can in fact return 0 for some unique input parameters. Tbr: olka Bug: 1052825 Change-Id: Ib7aaa66ea2f37b45fffdde89a1835ccc511d5edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060294Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#742131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c61c289c9c70..5efe7f09dc4d Created with: gclient setdep -r src-internal@5efe7f09dc4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7d4bc181d6ef55449a64e3108f74305393b0128b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061201Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742130}
-
Marc Treib authored
Bug: 1052983 Change-Id: I9c40475de027c1d7e734d142d5bbbbdaaf5e700f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061753 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742129}
-
Wez authored
Fuchsia's GN SDK provides the "compiler" configuration, but Chromium needs to override some stack properties, so retain the Chromium custom "compiler" config and have it depend upon the SDK-provided one. Bug: 1050703 Change-Id: Ia520eca69585e1ed1ed3e21bd4f62a005fbc5acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060372Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4af17e434cdc..78b471760dd9 git log 4af17e434cdc..78b471760dd9 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 benjaminwagner@google.com [infra] fix recipe bug Created with: gclient setdep -r src/third_party/skia@78b471760dd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Id512f7d6311195e3834cb4c3291f72318adaa0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062148Reviewed-by:
-
Eliot Courtney authored
This CL makes sure presentation callbacks are sent for destroyed buffers in WaylandBufferManagerHost. If a buffer is destroyed, we may not receive a presentation callback. Instead, send gfx::PresentationFeedback::Failure for destroyed buffers. This CL makes the following changes: a. Move feedback from WaylandBuffer to the presentation queue. Feedback is a property of presentation, not of the buffer. If it's possible for presentation feedback to be delayed then this fixes a potential bug where feedback can get lost. b. Send gfx::PresentationFeedback::Failure for destroyed buffers. c. Adds a test for this behaviour. Bug: 1051420 Test: resizing chrome does not cause a DCHECK in OnPresentation. Change-Id: I596f0deceadfffe74d35845046b956869908780f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056169 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#742126}
-
Koji Ishii authored
Following bot results are included. 1434 1437 1439 1441 1444 1445 1446 1447 1448 1449 1450 1451 1452 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 33 lines were removed and 23 lines were deflaked by consecutive results since 1462. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4d58447c49239a39493f21dd6f7a2cb7bfb764ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056006Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742125}
-
Christian Dullweber authored
Create PageInfo in a new tab to avoid flakiness due to navigation events. Bug: 1052395 Change-Id: I13d03a8696fcb39ce951052d6015b9880871cf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060958Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 130dc38a. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I355e31c0f4836114d3f686e04cee953fc7b0b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062089Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742123}
-
Gauthier Ambard authored
This CL fixes the TabGrid animation by animating the toolbar disappearance. Fixed: 1042200 Change-Id: I21ee9f900986cbe421a1a39afb0fc24eb20ee38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061149Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/961ac1ae..7f0638a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I71175fdeadd6ccb897b886a2a0fa4a0f701df468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062088Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742121}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7efa03ac94b5..e96da533c5df git log 7efa03ac94b5..e96da533c5df --date=short --first-parent --format='%ad %ae %s' 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 211ee9c4eec1..873e416c2d07 (3 commits) 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src c731adec183b..0bd30e43c007 (1 commits) Created with: gclient setdep -r src/third_party/angle@e96da533c5df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: If78eeac28a2416c4b5ba68b70ef03a33413187ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061199Reviewed-by:
-
Andrew Solovey authored
Add a new Chrome OS policy that allows admins to prevent access to Google web properties in an unauthenticated state. This policy will force logout users with invalid Gaia LSTs. Bug: b/146461662 Change-Id: I064aae7fadf62f9239600fd45af45062f413f562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016628 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#742119}
-
Mikel Astiz authored
This reverts commit b6a3c9f3. Reason for revert: bookmarks created around 2016, between [M44..M51] use an uppercase GUID as originator client item ID. Original change's description: > Enforce lower-case use of GUIDs for sync > > base::GenerateGUID() produces lower-case GUIDs and they should get > exposed to the sync protocol exclusively in this canonical form to avoid > running into issues. > > This patch replaces all occurrences in sync codebase with: > git grep -l 'IsValidGUID' -- components/sync* | \ > xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g' > > In addition, the implicit GUIDs used for bookmark sync, in particular > for permanent nodes, are updated to adopt lower-case GUIDs. These are > never committed to the server so there are no backward-compatibility > considerations. > > Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201 > Bug: 978430 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741381} TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 978430 Change-Id: If3a135e24cb61d15cfc7616dd1160e76ce9dd3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061749Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742118}
-
Jan Wilken Dörrie authored
This change adds the DatabaseCompromisedCredentialsObserver and CompromisedCredentialsConsumer interfaces to CompromisedCredentialsProvider, allowing it to monitor changes to the compromised credentials table in the database. Bug: 1047726 Change-Id: Ia3a9b5216fb25e563e96c6f8b1cf6e7f8a028d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060670 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742117}
-
