- 20 Oct, 2020 40 commits
-
-
Tim van der Lippe authored
They can be re-enabled as https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2475720 has landed. R=sigurds@chromium.org Bug: 1011811 Change-Id: I5089fa7a59c6f672e1f9db81563ae49f97a6737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484427 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818864}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5d9297643221..299fe92af960 2020-10-20 thestig@chromium.org Roll third_party/freetype/src/ 840ce58f9..80389cab7 (1 commit) 2020-10-20 thestig@chromium.org Roll third_party/freetype/src/ 20186d1be..840ce58f9 (14 commits) 2020-10-19 thestig@chromium.org Remove a strlen() call in CFX_FolderFontInfo::FindFont(). 2020-10-19 thestig@chromium.org Simplify CFX_FolderFontInfoTest initialization. 2020-10-19 nigi@chromium.org Improve font family name matching method. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135949 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I33e91a573012ee6c13a18354e7f0e3428ff7c123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818863}
-
sandromaggi authored
This is a reland of cb51eef7 This changes the test such that the execution will be split up into several steps to avoid hitting the timeout on slower devices. Each text filling now has its own wait and check expectation. Bug: 1139935 Original change's description: > [Autofill Assistant] Add integration test for input actions > > This adds integration tests for our current input actions. > Once we start experimenting, these should ensure that we > are not breaking currently working behaviour. > > Bug: b/168107066 > Bug: b/169924567 > Change-Id: I141f4033e0080e8c99e0b1280e8521d2bc45e837 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484422 > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Reviewed-by: Luca Hunkeler <hluca@google.com> > Cr-Commit-Position: refs/heads/master@{#818409} Bug: b/168107066 Bug: b/169924567 Change-Id: I1374ada004f960cfa360982eaf5d5e428bb974a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485264Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#818862}
-
Andy Paicu authored
This reverts commit 772dfcc1. Reason for revert: Likely cause of Mac compile failures https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16391? Original change's description: > Enable "gn check" for //third_party/blink/renderer/core > > Bug: 800764 > Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818849} TBR=tkent@chromium.org,thomasanderson@chromium.org,mstensho@chromium.org Change-Id: I4318faf69a2568af92686da13c1a42c2834870b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485065Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818861}
-
Andy Paicu authored
This reverts commit 3786076d. Reason for revert: Likely cause of Mac compilation failure https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16391? Original change's description: > Enable "gn check" for //third_party/blink/renderer/core/typed_arrays > > Bug: 800764 > Change-Id: I7e09231307f6de1c5457150581438f590b43de85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484596 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818852} TBR=haraken@chromium.org,tkent@chromium.org,thomasanderson@chromium.org,mstensho@chromium.org Change-Id: I81aaf215378e9827bcb2e63ce81f8ba695cd7732 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485221Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818860}
-
Andy Paicu authored
This reverts commit 9d4eac47. Reason for revert: Likely cause of Mac compile failure https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16391? Original change's description: > Enable "gn check" for //third_party/blink/renderer/core/probe > > Bug: 800764 > Change-Id: I60bf0ef4e620dfaec14486538886047534230309 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484597 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818853} TBR=caseq@chromium.org,tkent@chromium.org,thomasanderson@chromium.org,mstensho@chromium.org Change-Id: I587fd1b4ff3fc1780688ccdc73b1a9829a643cdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485935Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818859}
-
Hazem Ashmawy authored
This is a reland of db9be6c9 The recent flakes are most probably caused by using of UIAutomator APIs to test the developer UI service notification and pressing home button in the tearDown of tests. This reland the CL after removing all UIAutomator code including the test for persistent notification. A separate reland of that test would be done later. Original change's description: > [AW][Dev-UI] Reland "Add some espresso tests for flag UI" > > This relands https://crbug.com/c/2438534 with a couple small changes: > > - android:windowSoftInputMode="adjustPan" attribute was missing in the > test manifest but is used in prod manifest. Adding it to the tests > manifest fixes the problem of auto-showing the keyboard on M devices > which was causing the test flakiness. When the keyboard shows up it > hides the view causing espresso to fail. > > - Merge the small change from https://crrev.com/c/2455687 to > test whether the overrideFlagsMap has the correct entries. > > Fixed: 1135839, 1130599 > Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" on android M emulator > Change-Id: I973e8cd2b7a9c12651d7a6e14f11a368f6e06bad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453564 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817184} Change-Id: I9089d7e8d9b61b46b412061715abbf981da03706 Bug: 1130599, 1135839 Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" --num_retries=0 --repeat=1000 --break-on-failure Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482142Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#818858}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f0dcaca2c2d8..0c84d564df9f 2020-10-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7501f245 to 72a62c65 (438 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ia09452c80e0e4986840f406c5ef33ac384bd0b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818857}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I506782a17bf29599e9b5cadb59cbd1564c7e1b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485706Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818856}
-
harrisonsean authored
Add referrer recording for the password check issues page Bug: 1078782 Change-Id: Ie7ca81d5283fc77813864b21c8439acbafadf2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485160Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#818855}
-
Ian Struiksma authored
Adding TestExpectation Failure for Win10 for text-underline-offset-variable.html Bug: 1140324 Change-Id: Ib74b37d45bb11267aba2c6f4bf7ed5b0e5c843d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486569 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#818854}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I60bf0ef4e620dfaec14486538886047534230309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484597 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#818853}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I7e09231307f6de1c5457150581438f590b43de85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484596 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#818852}
-
Dominik Röttsches authored
As part of Flash API removal, remove instances of PreCacheFontForFlash. Generally, cache priming for GDI fonts on Windows still seems to be needed for printing and PDF processes but the flash reference can be deleted. Bug: 1139287 Change-Id: Iebaac7c48b5fddbb81219b0fcc08b091597dee2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478990 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818851}
-
Colin Blundell authored
In //weblayer, SafeBrowsingDBManager currently can can be accessed only from the IO thread. However, the subresource filter component needs to take in a scoped_refptr to the embedder's SafeBrowsingDBManager on the UI thread as part of creating a navigation throttle. This instance is then internally passed to and accessed on the IO thread. In //chrome, the ServicesDelegate class creates the SafeBrowsingDBManager on the UI thread and vends a reference to it on any thread. This CL takes an analogous approach in //weblayer, allowing the method that creates the SafeBrowsingDBManager to be called on the UI thread, with the DBManager being *started* on the IO thread as it is now (via a posted task if the current thread is not the IO thread). We add an IO-thread safeguard to ensure that the DBManager is only started once. The precise structure here is not the same as that in //chrome's SafeBrowsingService, as the underlying structure is not the same: //chrome's SafeBrowsingService has an explicit Start() method from which it posts a task to start the SafeBrowsingDBManager on the IO thread. //weblayer's SafeBrowsingService has no such method and instead the SafeBrowsingDBManager is created/started on demand. Bug: 1116095 Change-Id: If6303ee0ec36ec75109eb3917dd5cea3946d98bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478950 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#818850}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#818849}
-
arthursonzogni authored
This was computed in CommitNavigation(). We would like to expose the sandbox flags to the NavigationThrottle, which are run earlier. This patch moves the computation immediately after receiving the response. Since computing sandbox flags will depends on is_loaded_from_mhtml_archive_ in: https://chromium-review.googlesource.com/c/chromium/src/+/2452475 both are moved. Bug: 1136873,1041376 Change-Id: I98d33ea0a9367e87571644da648d40d0487a97cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467917Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818848}
-
Lei Zhang authored
This file does not get built on bots by default, so https://crrev.com/817812 broke it without anyone noticing. Update the TestPrintBackend::AddValidPrinter() call with the missing parameter. Change-Id: Iaa6118381e8743e0e052415a12bae874bf30da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483027Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818847}
-
Michele Mancina authored
Bug: b/170722915 Change-Id: Ia887555904f1eba8c039ca6460c88d42b2b9352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480522Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#818846}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If5d0a7e07078aed0a38a6eb9c745a8e710da5a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485780Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818845}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6929e8957a1..feeda66ef207 2020-10-20 changhaohan@chromium.org TypeScriptify elements/EventListenersWidget.js 2020-10-20 alexrudenko@chromium.org Inspector overlay: remove common.css resource 2020-10-20 jobay@google.com Typecheck source_frame/FontView.js with TypeScript 2020-10-20 alexrudenko@chromium.org Revert "Remove dependencies on ShortcutsScreen" 2020-10-20 alexrudenko@chromium.org Revert "Settings: Remove old ShortcutsScreen" 2020-10-20 jobay@google.com Typecheck source_frame/PreviewFactory.js with TypeScript 2020-10-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1139862,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I278f16abd5614cabba4e66c7cb444439054c9b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818844}
-
Leo Lai authored
STATUS_DBUS_ERROR is introduced to distinguish dbus error from attestation service internal error. In the near future, it will be used at consumer side for more clear error handling. BUG=b:158955123 TEST=unittests. Change-Id: I7590c8156f4098bf305cfb59ecac1551baf92994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428349 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818843}
-
Fredrik Söderqvist authored
Return a bool from LayoutSVGContainer::UpdateCachedBoundaries() to indicate if the oBB (object bounding box) has changed. This allows merging the two resource-related invalidation code-paths while making them somewhat more precise. It also allows separating the handling of the |needs_boundaries_update_| flag from the the general bounds propagation. LayoutSVGContainer::UpdateCachedBoundaries() is also called, but since that callsite matches the IsSVGHiddenContainer() is doesn't have to respond to/handle the return value. Bug: 1028061 Change-Id: I57a2ed3a3c5d8aa420eb79f67240b69352ee6a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485155Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef6ea580ba4a..b3199231953f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I999a9ef22047415433939e11587e6a29aa1b95c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486853 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818841}
-
Paula Vidas authored
This is a reland of 291faaf5 The original version of the test was flaky. The bug was in assuming the entities are ordered by arrival time. They are actually ordered by some unique id, which is random, and so the order was "wrong" about half of the time. Original change's description: > [SyncInvalidations] Add signout and signin integration test. > > This CL adds a test that checks the following: > - On signout, the FCM registration token should be cleared. > - On signin, it should be requested again. > > Bug: 1135167 > Change-Id: Ie1b1967b9ed317c0a36d4b751aef0dfeb81c45d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467979 > Commit-Queue: Paula Vidas <paulavidas@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#817408} Bug: 1135167 Change-Id: I5ea7c873d6782bf53ccff040d956c2a03845acd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485105 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818840}
-
chrome://quota-internalsdpapad authored
- Generate a JS module for cr/ui/tabs.js. In order to do so changing cr.defineProperty() to Object.defineProperty() as done for other cr.ui elements as part of crbug.com/1133198 - Include tabs.m.js, tree.m.js and ui.m.js in Desktop builds. - Fix getPropertyDescriptor() signature in cr.m.js to address JS compiler errors when used from tabs.m.js. - Update chrome://quota-internals to use the module versions of its dependencies. Bug: 1028829 Change-Id: Icf6576d4111f7bc7481b1a105b80d76ebe4d91d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478887 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818839}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/502e98295625..6fac705e7616 2020-10-19 afdx@google.com spirv-val: Fix validation of OpPhi instructions (#3919) 2020-10-19 afdx@google.com spirv-fuzz: Avoid void struct member when outlining functions (#3936) 2020-10-19 afdx@google.com spirv-fuzz: Do not allow Block-decorated structs when adding parameters (#3931) 2020-10-19 afdx@google.com spirv-fuzz: Fix to operand id type (#3937) 2020-10-19 afdx@google.com spirv-fuzz: Handle dead blocks in TransformationEquationInstruction (#3933) 2020-10-19 afdx@google.com spirv-fuzz: Do not allow sampled image load when flattening conditionals (#3930) 2020-10-19 afdx@google.com spirv-fuzz: Take care of OpPhi instructions when inlining (#3939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC jonahr@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: jonahr@google.com,radial-bots+chrome-roll@google.com Change-Id: I4f3a6977cab44d24ece2e4e364eaa7227f1dfce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818838}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac1ded033136..38688fcdba24 2020-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cb9deed9 to 60b90a0b (436 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ie10ba56d6554c25d9a03a41fb4a4aa22422f2c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485119 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818837}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1078618d07a0..749daf949871 2020-10-20 dberris@chromium.org pinpoint: Use getattr for missing properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Iff6373aea5a7ae1eac8012e64a37534c7ebb934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818836}
-
Alfonso Castaño authored
This CL enhances the existing CSP Issues with information about whether the header is report-only or not. This CL will be extended with another CL to surface those changes in the Devtools frontend. It includes the corresponding layout tests and the existing layout tests. Bug: chromium:1139223 Change-Id: Ic63c7edd68e56cb5464e451030d9fcf2900ecd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480243 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818835}
-
Luciano Pacheco authored
This is a preparation to migrate to JS modules. Bug: 1133186 Change-Id: I9e6a01f783299018bf0bce56844bfe10cd8b4a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469347Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818834}
-
Arthur Sonzogni authored
This reverts commit 61329208. Reason for revert: https://crbug.com/1140413 Original change's description: > [TTS] Fix a disabled test (OOP issue) > > Speculate fix for testLivePrefetchFailoverRequestMadeAfterOpen > which was failing with out-of-process network service error. > > BUG=1071721 > > Change-Id: I95cc3bba5ffd17e38b58fc88a3ff227045fe9feb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486072 > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Reviewed-by: Sinan Sahin <sinansahin@google.com> > Auto-Submit: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818664} TBR=donnd@chromium.org,sinansahin@google.com,jds@google.com Change-Id: I1e90b5f194fce483f3440fe125c0fd6f4c492015 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485107Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818833}
-
Andy Paicu authored
TBR: chfremer@chromium.org Bug: 840294 Change-Id: Ifd69205db90a4a8a77387d62ab812eb4d4c7f446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485159Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818832}
-
Martin Robinson authored
When an action is triggered on a container with selectable children and that container has a focused or activedescendant child, retarget the action to that child. This fixes an issue where when the VoiceOver cursor is on a tree with a focused child, triggered context menus would use the tree as the target element. menu on a tree instead of a focused child. Bug: 1114892 Change-Id: Ibe580beed93aeaac54d1dabaee28443b290fd0e2 AX-Relnotes: Fix an issue where VoiceOver would trigger a context Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466281 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#818831}
-
Luciano Pacheco authored
This is a preparation to auto-generate the JS module using polymer_modulizer() which requires the <script> tag to be inside the <dom-module>. This has no impact in the Polymer element behavior. Bug: 1133186 Change-Id: I97102f37502bd35eb7110a59633a627f022598dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470062 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818830}
-
Mason Freed authored
Change-Id: Idf58c176a453d6fc64b35fe284ac7a1cd2145dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485697 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#818829}
-
Luciano Pacheco authored
This is a preparation to auto-generate the JS module using polymer_modulizer() which requires the <script> tag to be inside the <dom-module>. This has no impact in the Polymer element behavior. Bug: 1133186 Change-Id: I80a6c3f98e5b37a2041f88bdce4990496455f5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469922 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818828}
-
Wenbin Zhang authored
Updated the logic to generate timing list. Bug: chromium:1130157 Change-Id: I285a6712ade0018bae4e1af23081827124b146ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468291Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#818827}
-
Reda Tawfik authored
This CL enables PhishGuard for passwords selected from AllPassswordBottomSheet by notifying PasswordReuseDetectionManager after filling the password field with the selected password. Bug: 1138612, 1104132, 1006430 Change-Id: I83cd6fbab78778ec7883f82011ec97a238e4ea09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472358Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#818826}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603151856-f47d024d838dc85b63fc569bff574a3f3aa4f83b.profdata to chrome-mac-master-1603172634-987778035e1cace5841998f11e79079a8a8488cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idbfc9b0fd97b6e3417fb84be66772ec08eaef2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818825}
-