GitLab

Existing code will not build when building chromeos_unittests target following the simple chrome build instruction
http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromium-browser
with BOARD=x86-generic, for example.

TEST=chromeos_unittest built successfully following the instruction above, and the test passed.

Review-Url: https://codereview.chromium.org/2344893002
Cr-Commit-Position: refs/heads/master@{#419128}

Tries to make the code a little more readable to help debugging the
associated bug.

For the OK result, BoundNetLog::EndEventWithNetErrorCode() was called
after BoundNetLog::EndEvent() in
WebSocketTransportClientSocketPool::RequestSocket(). Fixed this to call
only EndEvent().

Removed pre-condition checks before ActivateStalledRequest() which are
already performed by its while loop.

Added DCHECK_NE(error, OK) to FlushWithError() to make sure OK is never
received from that path.

Reordered some lines.

R=yhirano@chromium.org,mmenke@chromium.org
BUG=642363

Review-Url: https://codereview.chromium.org/2328453002
Cr-Commit-Position: refs/heads/master@{#419127}

Revert of Roll recipe dependencies (nontrivial). (patchset #1 id:1 of https://codereview.chromium.org/2343013004/ )

Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.

Original issue's description:
> Roll recipe dependencies (nontrivial).
>
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
>
> Please review the expectation changes, and LGTM as normal. The recipe roller
> will *NOT* CQ the change itself, so you must CQ the change manually.
>
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
> (or complain)
>
> build:
>   https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
> depot_tools:
>   https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)
>
> R=tandrii@chromium.org,recipe-roller@chromium.org
> BUG=635641,647446
> NOTRY=True
>
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Committed: https://crrev.com/fd83e754f046fe29f120103423b19bd33717e36d
> Cr-Commit-Position: refs/heads/master@{#419122}

TBR=recipe-roller@chromium.org,recipe-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446

Review-Url: https://codereview.chromium.org/2348863002
Cr-Commit-Position: refs/heads/master@{#419126}

net::WebSocketExtensionParser would accept top-bit-set characters in
tokens. Change it to use net::HttpUtil::IsTokenChar() so it accepts the same
characters as everything else.

Add some tests for top-bit-set characters and a regression test for issue
647156.

Also various minor changes to make the code more Chromey.

BUG=647156

Review-Url: https://codereview.chromium.org/2344873002
Cr-Commit-Position: refs/heads/master@{#419125}

The base::AlignedAlloc expects a alignement multiple of sizeof(void*) :

DCHECK_EQ(alignment % sizeof(void*), 0U);

This fixes this error :

[0826/162544:FATAL:aligned_memory.cc(19)] Check failed: alignment % sizeof(void*) == 0U (1 vs. 0)

BUG=647570
TEST=run video_encode_accelerator_unittest on a non ARM platform

Review-Url: https://codereview.chromium.org/2281043002
Cr-Commit-Position: refs/heads/master@{#419124}

To investigate how frequently unclean shutdown is performed.

Start recording a new UMA Shutdown.ShutdownType.
Update prefs::kShutdownType when Chrome is performing unclean shutdown with SessionEnding().

BUG=644649

Review-Url: https://codereview.chromium.org/2318373003
Cr-Commit-Position: refs/heads/master@{#419123}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org)

R=tandrii@chromium.org,recipe-roller@chromium.org
BUG=635641,647446
NOTRY=True

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2343013004
Cr-Commit-Position: refs/heads/master@{#419122}

Now using CacheHitMetrics instead of local enum. Fixup for
https://crrev.com/2289303004.

Review-Url: https://codereview.chromium.org/2347113002
Cr-Commit-Position: refs/heads/master@{#419121}

In preparation for moving metricsPrivate to //extensions, re-generate the
externs file and fix outdated types.

BUG=647397
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2346683004
Cr-Commit-Position: refs/heads/master@{#419120}

Authors: Alexander Shalamov, Mikhail Pozdnyakov

This patch introduces implementation of generic sensor interfaces
for Android platform. Support for following sensors is added:
ambient light, gyroscope, accelerometer, linear acceleration and magnetometer.

BUG=606766

Review-Url: https://codereview.chromium.org/2284613002
Cr-Commit-Position: refs/heads/master@{#419119}

xib changes:
ContentSubresourceFilter.xib: Aligned title and message fields with the Load full side button, added connection for the message.

BUG=646742

Review-Url: https://codereview.chromium.org/2334283004
Cr-Commit-Position: refs/heads/master@{#419118}

This patch converts "editing/pasteboard/5065605.html" to use w3c test harness to
simplify test script, and renames to "copy_and_paste_with_colored_text.html" to
provide a hint what this test script verifies, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2342673003
Cr-Commit-Position: refs/heads/master@{#419117}

This patch converts "editing/pasteboard/3976872.html" to use w3c test harness to
simplify test script, and renames to "paste_plain_text_to_newlines.html" to
provide a hint what this test script verifies, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2344563004
Cr-Commit-Position: refs/heads/master@{#419116}

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)

Review-Url: https://codereview.chromium.org/2345893002
Cr-Commit-Position: refs/heads/master@{#419115}

Tracking how many pages query for VR hardware, how many actually pesent anything to that hardware, and how many use a deprecated function call.

BUG=389343

Review-Url: https://codereview.chromium.org/2345783002
Cr-Commit-Position: refs/heads/master@{#419114}

Review-Url: https://codereview.chromium.org/2327793002
Cr-Commit-Position: refs/heads/master@{#419113}

Update yandex suggest urls. Also add {language} param to suggest url.

R=pkasting@chromium.org

Review-Url: https://codereview.chromium.org/2333113003
Cr-Commit-Position: refs/heads/master@{#419112}

Should have no visible effect (since the banner wasn't visible on CrOS).

This reverts commit 192a6f00.
This reverts commit c00f1d07.

BUG=576531

Review-Url: https://codereview.chromium.org/2341113003
Cr-Commit-Position: refs/heads/master@{#419111}

Theoretically shaves 78658 bytes[1] off of resources.pak's on-disk size
(which is especially helpful on Android).

R=agrieve@chromium.org,smaier@chromium.org
BUG=619091

[1] https://docs.google.com/spreadsheets/d/1iHF05utMcECxc8tb3ziHQlEJmXlk98-PFWhkGoY545Q/edit

Review-Url: https://codereview.chromium.org/2152143002
Cr-Commit-Position: refs/heads/master@{#419110}

BUG=590369

Review-Url: https://codereview.chromium.org/2338233003
Cr-Commit-Position: refs/heads/master@{#419109}

https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx
content < 360p.  Unfortunately, it did not have an exception for
encrypted content.

This CL adds an addition "encrypted only" profile that covers all
supported sizes.

BUG=647259, 642948

Review-Url: https://codereview.chromium.org/2348653002
Cr-Commit-Position: refs/heads/master@{#419108}

Make sure we set the preferred style sheet set when setting the title
attribute as long as the preferred set name is not already set.

This used to somehow work if the title was set during loading of a
stylesheet since the preferred set name was set during active
stylesheet collection. In other cases, it didn't work until another
stylesheet operation caused a re-collection of active stylesheets.

When setting the preferred name was moved into the LinkStyle::process()
code, it didn't work at all to set the title after the stylesheet
starts loading.

Make sure we set the preferred set name and trigger an active
stylesheet update when the title is changed.

BUG=645699

Review-Url: https://codereview.chromium.org/2337193004
Cr-Commit-Position: refs/heads/master@{#419107}

unittests

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2334563002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#419106}

This icon was incorrectly appearing on the right side of the page,
when it should appear on the left.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342243002
Cr-Commit-Position: refs/heads/master@{#419105}

BUG=643729
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2311473002
Cr-Commit-Position: refs/heads/master@{#419104}

The Web Animations spec now uses the name AnimationPlaybackEvent instead of
AnimationPlayerEvent:
http://w3c.github.io/web-animations/#the-animationplaybackevent-interface

This patch also makes the timelineTime property of AnimationPlaybackEvent
nullable, as specced.

BUG=624639

Review-Url: https://codereview.chromium.org/2344473002
Cr-Commit-Position: refs/heads/master@{#419103}

This histogram was added to the source in 2012, but never added to
histograms.xml. So noone ever looked at the data. Remove it.

Also add an obsolete entry to histograms.xml, so noone tries to reuse
the name.

BUG=643551

Review-Url: https://codereview.chromium.org/2345433002
Cr-Commit-Position: refs/heads/master@{#419102}

This property can be replaced with padding at the top of <history-list>,
which simplifies the code and should have a minor performance
improvement.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2333163002
Cr-Commit-Position: refs/heads/master@{#419101}

Revert of Enable whitelisting for targets other than libchrome. (patchset #2 id:90001 of https://codereview.chromium.org/2344063002/ )

Reason for revert:
Still causing GN errors on Google Chrome bots
(Win, Linux, and ChromeOS).

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10926

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:1358:19: Assignment had no effect.
    public_deps = [
                  ^
You set the variable "public_deps" here and it was unused before it went
out of scope.
See //BUILD.gn:211:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1
step returned non-zero exit code: 1

Original issue's description:
> Reland of Enable whitelisting for targets other than libchrome.
>
> Reverted in:
> https://codereview.chromium.org/2348643002/
>
> Reason for revert:
> Fixed gn gen errror
>
> This will allow monochrome to easily define its own set of the same
> targets with a different resource whitelist
>
> TBR=brettw@chromium.org,miu@chromium.org
> BUG=641032
>
> Committed: https://crrev.com/26cf65711c693aac13c897b67d0e138c3ee42ece
> Cr-Commit-Position: refs/heads/master@{#419074}

TBR=brettw@chromium.org,miu@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641032

Review-Url: https://codereview.chromium.org/2342243003
Cr-Commit-Position: refs/heads/master@{#419100}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/863250f040be..3d7a0942bcf4

$ git log 863250f04..3d7a0942b --date=short --no-merges --format='%ad %ae %s'
2016-09-15 dtu Fix utils.ServiceAccountHttp().

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2347103002
Cr-Commit-Position: refs/heads/master@{#419099}

Design doc: https://docs.google.com/document/d/14MzxMuUV9e5ZgxbZL3-jCMKa3S-UJGsbYSmRodLh9uc/edit#
PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc

BUG=591606

Review-Url: https://codereview.chromium.org/2344443003
Cr-Commit-Position: refs/heads/master@{#419098}

Additionally parsing 'starred' attribute is necessary in order to implement showing 'starred' icon for Files app.

BUG=646839
TEST=google_apis_unittests --gtest_filter=DriveAPIParserTest.FileListParser

Review-Url: https://codereview.chromium.org/2344113002
Cr-Commit-Position: refs/heads/master@{#419097}

This change adds support for handling pending substitution values to CSS
animations to allow for smooth interpolation between shorthand values
with var() references in them.

BUG=647123

Review-Url: https://codereview.chromium.org/2340893003
Cr-Commit-Position: refs/heads/master@{#419096}

String should be a thin wrapper over StringImpl and other functions.

Review-Url: https://codereview.chromium.org/2337683002
Cr-Commit-Position: refs/heads/master@{#419095}

BUG=647117

Review-Url: https://codereview.chromium.org/2347723002
Cr-Commit-Position: refs/heads/master@{#419094}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/82d4df2ea564..863250f040be

$ git log 82d4df2ea..863250f04 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 nednguyen Fix typo in TimelineBasedMeasurement's comments
2016-09-15 benjhayden Document how to write metrics.
2016-09-15 benjhayden Display zero values in value-set-table

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2341213002
Cr-Commit-Position: refs/heads/master@{#419093}

https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..8b28a8b

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2345763003
Cr-Commit-Position: refs/heads/master@{#419092}

Cr-Commit-Position: refs/heads/master@{#419091}

This prevents the user from seeing the console messages load in as they scroll.

BUG=none

Review-Url: https://codereview.chromium.org/2339293003
Cr-Commit-Position: refs/heads/master@{#419090}

This is a step towards turning all tree outlines into independent web components,
removing global styles related to it and allowing more components to encapsulate their inner details.

BUG=none

Review-Url: https://codereview.chromium.org/2349533002
Cr-Commit-Position: refs/heads/master@{#419089}