- 03 Jul, 2018 40 commits
-
-
Theresa authored
BUG=859565 Change-Id: I8193ae97172377732919851b17e227ddf1e62c79 Reviewed-on: https://chromium-review.googlesource.com/1124987Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#572333}
-
Manuel Rego Casasnovas authored
In the past we added a use counter to check the usage of percentage rows on grid containers with indefinite height. The name of the use counter is kGridRowTrackPercentIndefiniteHeight, however it was also counting the cases of percentage columns on grid containers with indefinite width. This patch removes the last case from the use counter, as it was wrong. In addition, the patch adds a new unit test for the use counter to verify that is only triggered for percentage rows. JFTR this use counter is related to issue: https://github.com/w3c/csswg-drafts/issues/1921 Change-Id: I2ab2cc28195e0b5e4f51ea37fff4c838e553cb8a Reviewed-on: https://chromium-review.googlesource.com/1124840Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#572332}
-
Sam Maier authored
We are moving to Oreo's implementation, at commit 1488a3a19d4681a41fb45570c15e14d99db1cb66 TBR=agrieve # Mechanical change to cronet Bug: 843745 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic612b7767007993a1b7761418061dbe0346afa7e Reviewed-on: https://chromium-review.googlesource.com/1117637 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572331}
-
Mark Pilgrim authored
TBR=estade@chromium.org Bug: 844930 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I554e7e68e31fd05a9aaef014886b0149f41cebb8 Reviewed-on: https://chromium-review.googlesource.com/1053869 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#572330}
-
Maks Orlovich authored
... and diagnose attempts to use the TestMockTimeTaskRunner as a target for taskrunnery other than RunsTasksInSequence after it gets destroyed. Sometimes leaky singletons end up capturing the current task runner, and it therefore ends up sticking around between tests. Previously that could leak the TestMockTimeTaskRunner, which was mostly important in kBoundToThread mode, since leaking a TestMockTimeTaskRunner in that case leaks a RunLoop::Delegate, which breaks any further test that needs RunLoop support. Change-Id: I7ba86e02a20a5fa07de40fc5f3a5adb3bee35ab3 Reviewed-on: https://chromium-review.googlesource.com/1118532 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572329}
-
Cole Winstanley authored
Making GetWindowSize return the desired values when running ChromeDriver on Android. Added a test (testAndroidGetWindowSize) to run_py_tests.py to test this functionality, which should be the same as running a script to get window.innerWidth / window.innerHeight. Bug: chromedriver:1005 Change-Id: Ib30b84e657ef9fb2ab1b5e7a5f5dd9cf452ae98f Reviewed-on: https://chromium-review.googlesource.com/1121335 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#572328}
-
Chris Harrelson authored
This (a) avoids extra cost in copy constructors for HitTestResult (which happen often in PaintLayer::HitTestLayer), and (b) is cleaner because the hit testing code on the layout tree doesn't ever call GetHitTestLocation. This improves performance due to fewer copies happening when we need to create temporary outputs. Bug:831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d0716fd74b566d3c18646a8c685d184e49dd7d4 Reviewed-on: https://chromium-review.googlesource.com/1111472Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572327}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3bc977a42022..d000b0a32ee7 git log 3bc977a42022..d000b0a32ee7 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 jonasolsson@webrtc.org Move RTC_CHECK_OP error message construction out of header file. 2018-07-03 sprang@webrtc.org Add sprang@ as owner for simulcast.cc/h 2018-07-03 mbonadei@webrtc.org Remove usage of //build/config/clang:extra_warnings. Created with: gclient setdep -r src/third_party/webrtc@d000b0a32ee7 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf645797aedd60ee259ec9629b9159c58060dd81 Reviewed-on: https://chromium-review.googlesource.com/1124900Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572326}
-
Jun Choi authored
Add 'Time out' sheet model to show when Web Authentication request times-out due to inactivity or error. Bug: 849323 Change-Id: Ifda965c3120d4fbd28f46a4f62e88200f316ca0f Reviewed-on: https://chromium-review.googlesource.com/1105284 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572325}
-
Amirhossein Simjour authored
DismissHandler is set in VrShellImpl to make it possible to close the dialog when native sends the request. Bug: 843325 Change-Id: I2e83840a77fa47cab0275a1710591bae23627b96 Reviewed-on: https://chromium-review.googlesource.com/1125085Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#572324}
-
Klaus Weidner authored
The current implementation had an invalid DCHECK_EQ, there's a valid flow where is_webvr_frame could be true while ShouldDrawWebVr was false. Remove the invalid check and update the comment with a more accurate lifecycle description. Change-Id: I4eb1c7496972334c4d3b8e42fb3ffb352c0ed236 Reviewed-on: https://chromium-review.googlesource.com/1124994Reviewed-by:
-
Amy Qiu authored
As part of refreshing page sets, the new linkedin page requires logging in before viewing profiles. Create a linkedin login helper and update the credentials.json file. Bug: 852530 Change-Id: Ibce40dc6cf0c3d09f4fed5cd8f34f0d7cf14d8e4 Reviewed-on: https://chromium-review.googlesource.com/1099728 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#572322}
-
Theresa authored
BUG=844570 Change-Id: I43a3d38a97718309fc781a09609641c9b3bc72d5 Reviewed-on: https://chromium-review.googlesource.com/1125081Reviewed-by:
-
Chris Lu authored
- Makes ClearBrowsingDataTableViewController conform to ClearBrowsingDataConsumer. - Mark methods related to IsNewClearBrowsingDataUIEnabled and show other forms of browsing history dialog in ClearBrowsingDataConsumer as optional Change-Id: I24f8d1a259537ddf962383fa17079beaa16e0132 Reviewed-on: https://chromium-review.googlesource.com/1123652 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#572320}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/583859d7395c..03abd2c8f358 $ git log 583859d73..03abd2c8f --date=short --no-merges --format='%ad %ae %s' 2018-07-02 marpan vp9: Adjust segment weight for cyclic refresh. 2018-07-01 marpan vp9: Fix to screen content artifact for real-time. 2018-06-29 marpan vp9: Reset params for cyclic refresh on slide change 2018-06-28 jianj vp9: copy source on sync frame in denoiser. 2018-06-29 marpan vp9: Reduce quality artifact for real-time scene-content. 2018-06-24 huisu Add partition breakout models for 720p resolution 2018-06-20 jingning Exploit the spatial variance in temporal dependency model 2018-06-28 jingning Refactor to use unified multiplier for partition search 2018-06-28 marpan vp9-svc: Adjust threshold for early exit on golden 2018-06-28 jingning Skip temporal dependency build when the speed feature is off 2018-06-28 johannkoenig libyuv: disable AVX512 in clang 2018-06-28 jingning Avoid operation on INT64_MAX value 2018-06-26 paulwilkins Enhanced partition experiment. 2018-06-27 marpan vp9-svc: Set avg_frame_low_motion for lower layers. 2018-06-27 marpan vp9-svc: Fix to early golden exit nonrd-pickmode 2018-06-20 luc Add Speed Tests to Trans32x32Test 2018-06-27 lu_zero Support Power8/Power9 tuning 2018-06-26 luc [VSX] Replace vec_pack and vec_perm with single vec_perm 2018-06-20 luc VSX Version of fdct32x32_rd 2018-06-26 slavarnway BUG FIX: Initialize AverageTestBase members (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Bug: b/110978869,b/110977202 Change-Id: I4ddb56a6b6eb7f9d74e1d8b009e0e228a8d0cd7c Reviewed-on: https://chromium-review.googlesource.com/1123408Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#572319}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f46241c6c03..ce6b2fbbac20 git log 9f46241c6c03..ce6b2fbbac20 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 charliea@chromium.org Remove BattOr support from Telemetry Created with: gclient setdep -r src/third_party/catapult@ce6b2fbbac20 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:859514 TBR=sullivan@chromium.org Change-Id: Iab7c470fa766f99277ff2b867dbfa6160c0983cd Reviewed-on: https://chromium-review.googlesource.com/1124901Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572318}
-
Ian Vollick authored
This reverts commit 0e9a15da. Reason for revert: smoothing was simply scaling. Original change's description: > [vr] Tune scroll event stream > > This change applies three heuristics to make trackpad scrolling feel > smoother. We increase the frequency at which we submit scroll events to > the platform, we also decrease the scroll scale factor (to make the > scrolls less jumpy), and we do some simple filtering of our scroll > values. > > I pair-programmed much of this change with asimjour@ and he wrote the > initial code to interpolate events in the android ui gesture target. > > Bug: 859075 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I2fe42940214d01d99618ddacd182f202ff271dad > Reviewed-on: https://chromium-review.googlesource.com/1120425 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571535} TBR=vollick@chromium.org,mthiesse@chromium.org,asimjour@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859075 Change-Id: I6c82a12e0ba687e43c169206ad9b85d82f08570c Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1124999Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#572317}
-
Timothy Gu authored
Bug: 859691 Change-Id: I9f1fbb3dac9b794dcf1f069447096c8559e03d5b Reviewed-on: https://chromium-review.googlesource.com/1123202 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#572316}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d77e0ed72f73..1c14ae2fbe1a git log d77e0ed72f73..1c14ae2fbe1a --date=short --no-merges --format='%ad %ae %s' 2018-07-03 tsepez@chromium.org Avoid explicit allocs in fxbarcode matrix classes. Created with: gclient setdep -r src/third_party/pdfium@1c14ae2fbe1a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I04fe123ce81583953e62bb2532b1d81d3179c18f Reviewed-on: https://chromium-review.googlesource.com/1124650Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572315}
-
Lu Chen authored
Retrieve site engagement score from site engagement service. Bug: 850624 Change-Id: I4c894981210e5026aa9de7432231a803cd71c01e Reviewed-on: https://chromium-review.googlesource.com/1115580 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#572314}
-
Boris Sazonov authored
This CL updates titles and summaries for non-personalized services in UnifiedConsent Settings. It also adds an entry for url-keyed anonymized data collection to this screen. Bug: 814728 Change-Id: Ia83af10f57c7652cc7f4b58d9d9908be0b7e94cd Reviewed-on: https://chromium-review.googlesource.com/1124457Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#572313}
-
mrefaat authored
_openedApplicationURL is a set that is used by inserting the URL for external apps that was launched on it. Then in HandleError if the error was policy interruption for a URL inserted on the set ignore it. The problem with that logic is HandleError is never called for requests rejected by DecidePolicyForNavigationAction which is the place that Chromium reject/allow app launches. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc2535af2fef6ade9fdf28350c55336f8dbf51c1 Reviewed-on: https://chromium-review.googlesource.com/1124971Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#572312}
-
Tom Anderson authored
This is a followup to: https://chromium.googlesource.com/chromium/src.git/+/270b2bfa01f4eadfe6f25673767a3357158e0ef9 BUG=856607 R=sadrul CC=fbeaufort Change-Id: If06c971a309b4630e44184f7a08bb156b620c7ec Reviewed-on: https://chromium-review.googlesource.com/1123367 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#572311}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/94d57c477fe1..34aa059c1502 git log 94d57c477fe1..34aa059c1502 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 ethannicholas@google.com Revert "Remove setting/use of GrPixelConfig in GrBackendTex/RT ctors." 2018-07-03 ruiqimao@google.com added skeletal animation support to GPU backend 2018-07-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 92da844eb754..2b06054dd41f (1 commits) 2018-07-03 brianosman@google.com Replace isGammaCorrect with isLinearlyBlended 2018-07-03 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 9d19e2abf000..678e47d97bc5 (1 commits) 2018-07-03 jcgregorio@google.com Add cloudbuild.yaml file for continous builds of fiddler and skia-release. 2018-07-03 robertphillips@google.com Fix empty stroked oval handling in GrRenderTargetContext::drawOval 2018-07-03 egdaniel@google.com Remove setting/use of GrPixelConfig in GrBackendTex/RT ctors. Created with: gclient setdep -r src/third_party/skia@34aa059c1502 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I75f76fa6db466cd549625022947802cfd60381b1 Reviewed-on: https://chromium-review.googlesource.com/1124649Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572310}
-
Ryan Hansberry authored
This issue manifested as all new account creations on Chrome OS crashing. It was caused by the local device metadata being returned by DeviceSyncClient not yet being initialized. DeviceSyncClient now internally keeps track of whether it is "ready", that is, whether its local device metadata and synced devices are available yet. Only once it has loaded both sets of data will it mark itself as "ready", and inform clients appropriately. This change also ensures that DeviceSyncClient's Observer callbacks, OnEnrollmentFinished() and OnNewDevicesSynced(), are not called until DeviceSyncClient is ready. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 856406 Change-Id: Idb6fdf123d4d90883f67bb1e88a617004926207e Reviewed-on: https://chromium-review.googlesource.com/1121351Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#572309}
-
Alexei Filippov authored
Change-Id: I0a07c50c28c4719a18f01305511d63574094f604 Reviewed-on: https://chromium-review.googlesource.com/1115818 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#572308}
-
Michael van Ouwerkerk authored
Bug: 853791 Change-Id: I3349c450d8b285bcfdea69e6342350941d121353 Reviewed-on: https://chromium-review.googlesource.com/1120503 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#572307}
-
Daniel Bratell authored
It's currently easy to use an IntRect when a FloatRect is needed since there is an implicit (lossy) conversion from IntRect to FloatRect. This patch changes some code to remove some unnecessary conversions between the types. (A float can store all integers up to, but not including, 16,777,217 so it the conversion is most of the time non-lossy) R=fs@opera.com, pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I324b79c3d78d387574f47a4bda8f7dc7bdad567b Reviewed-on: https://chromium-review.googlesource.com/1124682Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ied1a11b41e14dcc6ce3e64b13889525287c4a6cd Reviewed-on: https://chromium-review.googlesource.com/1124979Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572305}
-
Takumi Fujimoto authored
Clicking on the Cast button when there are no sinks causes a crash. This CL disables the button when the dialog goes from having sinks to empty. Bug: 857224 Change-Id: I8040aef278d28fbc6e6b03c04e9ff9103156ea44 Reviewed-on: https://chromium-review.googlesource.com/1119531Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#572304}
-
Leonard Grey authored
Also removes the explicit focus ring layout since ImageButton::Layout takes care of this. Bug: 854934 Change-Id: Ib49442d1db95577d9e4f7d0497e1b3bd50bf2cbc Reviewed-on: https://chromium-review.googlesource.com/1124765Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#572303}
-
Xianzhu Wang authored
This reverts commit e71a3846. Reason for revert: Caused performance regressions because changed paint properties are not cleared changed flags. Original change's description: > [PE] Don't call PaintController::FinishCycle() if not repainted > > This is mainly a performance optimization because we don't need > FinishCycle() if PaintController has nothing changed. > > By the way it can also avoid the immediate bad effect (but not the > root cause) of bug 859294. > > Bug: 859294 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iad3e14ee303c08185922d3d6e495c3b25ead5434 > Reviewed-on: https://chromium-review.googlesource.com/1121783 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571803} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859294, 859885 Change-Id: I2a4d2a7d09cc3bf5edfbf0c6dee275581030c2c9 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1124701Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572302}
-
Lei Zhang authored
It is only used in the ProfileInfoCache sub-class. Change-Id: Iba2c64e99821866d2ec3072d0b0ef412a1353e01 Reviewed-on: https://chromium-review.googlesource.com/1124107Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#572301}
-
Pavel Feldman authored
Change-Id: I916652f378d2d43cb89c1aa546108d4bc38d8746 Reviewed-on: https://chromium-review.googlesource.com/1121420 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#572300}
-
Reza.Zakerinasab authored
The flakiness cannot be reproduced and suspected to be a result of recent changes in Skia color management code. Removing timeout tag for the tests and monitoring the bots to see if the flakiness returns. TBR=fserb@chromium.org Bug: 851746 Change-Id: Ie9f3e650140be4b9f27e9e7963ead014cee2bf49 Reviewed-on: https://chromium-review.googlesource.com/1124986Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572299}
-
spqchan authored
TBR=carlosk@chromium.org Bug: 859681 Change-Id: Ic06fbd6b18c570e210ecd5e2e7bd8aa3802fc5cb Reviewed-on: https://chromium-review.googlesource.com/1123319 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572298}
-
Simeon Anfinrud authored
This method was only used in one place, and was the only user of first() and changes(). unique() can be confusing because its scope exits before it gets new data, so it only happens to work when we don't care about deactivations. While these methods seemed like a good idea at the time, the possibility of Observable implementations that have multiple simultaneous activations make these methods tough to define. In the meantime, duplicate-filtering can be done with Controllers, which now have that built-in to set(). Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I86f542bbcdcb1a643400715733ecdaae438915ba Reviewed-on: https://chromium-review.googlesource.com/1119192Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572297}
-
Jun Choi authored
Implement GetAssertion operation for CTAP2 software key. The implement GetAssertionOperation does not support multiple accounts per device and never returns UserEntity as a response. Bug: 829413 Change-Id: I58a43a032fc520494ea8fdbfb1c64959a04c6b82 Reviewed-on: https://chromium-review.googlesource.com/1117369 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#572296}
-
Christian Fremerey authored
There is an incompatibility in the serialization of shared memory handles between the Mojo libraries used in Chromium vs. the older ones used in ChromiumOS. As a workaround, this CL allows clients of the video capture service to ask it to use raw file descriptors for sharing shared memory handles instead. Note, this is only supported on platforms that use file descriptors for base::SharedMemoryHandle, i.e. Posix platforms. Design Doc: https://docs.google.com/document/d/1cmtWA8yua5sqjZC0tswVUZwJeQR-KSZBr3Mj1jUagKk/edit?usp=sharing Bug: 847598 Change-Id: Ie269231b98149cbbc104ea62c1ff522c665cf187 Reviewed-on: https://chromium-review.googlesource.com/1043646 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572295}
-
Charlie Harrison authored
This mode was added as a way to hedge our feature against failing to launch metadata on the SafeBrowsing API side. This feature has been launched for a while and the parameter did not end up being used, so just remove it and associated tests. Bug: None Change-Id: Ib2e7d633da2d98478cee17dc3cdffe4e0b998d1b Reviewed-on: https://chromium-review.googlesource.com/1124763Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#572294}
-
