GitLab

This is a test-only change. See crbug.com/1132828 for the rationale.

Bug: 1132828
Change-Id: I8226bdd79012e1fb2cbe85d7a8c188846ace091a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584204
Commit-Queue: Leon Scroggins <scroggo@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Cr-Commit-Position: refs/heads/master@{#837153}

Using wpt-import in Chromium f42fa3f3.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel
Change-Id: Ifa51c453dbac05f89829caa8ec2f1c180057b59d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592135Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837152}

BUG=783819

Change-Id: I45975dff6acc8a753aec5ac20ad658c96ad5e24c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587459
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837151}

This CL converts three base::Bind to base::BindOnce in this file.
The function that takes the callback is already expecting a
OnceCallback, so converting to base::BindOnce seems to be the right
choice.

Bug: 1152278
Change-Id: I0ed76be834d516ccdcb20200b30f172fa41f385a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592012Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837150}

Bug: 1000989
Change-Id: Ifd726a85b530c9dbb31e5bbe7ff4c3b4f64f6094
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589456
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837149}

This CL converts base::Bind to base::BindOnce in this file. The
function is already expecting a OnceCallback so using BindOnce is
the right choice.

Bug: 1152278
Change-Id: I168b2049878b43cef21065a5bf6825ddfa64e68b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593469Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837148}

Chrome can be started with the 2 following events:
+ Open the sign-in upgrade promo
+ Open an URL (from an external app)

The opening the URL interrupts the sign-in promo, while its view
controller is not fully presented yet.

This patch prevent from the coordinator from dismissing its view
controller before it is fully on the screen.

Fixed: 1126170
Change-Id: I03287c9f830f650c10aa2476d6d693af3783c553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593107
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837147}

Wire NetworkIsolationKey through DomainReliabilityContext.

This is the interesting CL of the bunch. To keep things simple, it keeps
all pending beacons in a single list with a maximum size, even with
different NetworkIsolationKeys. To upload a report, it selects all
beacon with the same Key as the first (oldest) beacon and creates a
report using them. On successful upload, it will remove just those
beacons, and try to upload again (with backoff), if any beacons are
left.

This CL also adds some eviction tests, and removes some incorrect
eviction DCHECKs, which assumed that all beacons currently being
uploaded could not be evicted. That may be unlikely, but there's
nothing from preventing it from actually happening, and it may
be more likely once only beacons with a matching NIK are uploaded
each time.

Bug: 1138994
Change-Id: I37d97b679cc0309c5e128c239585555ab097369b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587669
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837146}

This CL converts the base::Bind to base::BindOnce in that file. It
is a code health CL, no behaviour change is expected.

Bug: 1152278
Change-Id: I5524c86ea0e9a58c2beb87c224d0d220630dead1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593747Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837145}

This reverts commit 0f312f10.

Reason for revert: Downstream fix has rolled

Original change's description:
> Keeping CastOptionsProvider to avoid crash.
>
> Bug: 1157603
> Change-Id: I04bf94d2e2d758cd871d5328513de135c2e155de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585843
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Commit-Queue: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836743}

TBR=mfoltz@chromium.org,mlamouri@chromium.org,zqzhang@chromium.org,tguilbert@chromium.org,smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I725e928b3d5bce99df9a587e014e1ceb07f04892
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1157603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593452Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837144}

[CodeHealth] Convert c/b/ui/views/extensions and bookmark from base::Bind and base::Callback to Once/Repeating

Bug: 1152282
Change-Id: I9b557a75a039844183ee49eae868036fa1cfa072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592248Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837143}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6df594ecc557..a885fded8b30

2020-12-15 pmalani@chromium.org usergroup_baseline: Add user typecd_ec to cros_ec-access
2020-12-15 chrome-bot@chromium.org Update config settings by config-updater.
2020-12-15 saklein@chromium.org portage_testables: Fix DEPEND/RDEPEND quoting.
2020-12-15 saklein@chromium.org portage_testables: Add Package.package_info.
2020-12-15 mmortensen@google.com BundleDebugSymbols: Initial api/controller implementation and test.
2020-12-15 chrome-bot@chromium.org Update config settings by config-updater.
2020-12-15 saklein@chromium.org Build API: Prevent entering the chroot for mock/validate calls.
2020-12-15 saklein@chromium.org lib/depgraph: Add functions to generate some common depgraphs
2020-12-15 vapier@chromium.org gs: ls/acl/rm: extend to support multiple paths
2020-12-14 sfrolov@google.com cros_sdk: Make fstrim run in background
2020-12-14 benreich@chromium.org uprev_lib: Avoid committing Manifest if package does not have one
2020-12-14 chrome-bot@chromium.org Update config settings by config-updater.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I1ccd48753a9918630a14089f8fef0f710e576231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593668
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837142}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012150600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Jd9IBDXrEmKkgb_A4oF9p3iMEi3gg3iptnwf_dbG_RgC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: Ia2da8ce09acf58e915e7b910c949cd77dca285e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593669Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837141}

When an HTMLImageElement's 'src' is set to the empty string, the state
of the image request will be 'broken', and thus the promise should be
rejected with an InvalidStateError exception per the rules at [1].

Move the intrinsic size check below the image existence check, and use
a more direct method of getting at the size (no need to go through the
BitmapImageSource interface when we're already fiddling with internals).

Also add a check for IsLoaded() to better match the spec wording
'fully decodable'.

[1] https://wicg.github.io/shape-detection-api/#image-sources-for-detection

Bug: 789511
Change-Id: I69ac4a9081cfff7f9c7c8f7edf39667e3dd1eb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587165Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#837140}

It was missed at https://crrev.com/c/2584603

Bug: 1155269
Change-Id: I7e0ac2e75210d909cba3905b2fae1aa39dbeeb4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592997
Auto-Submit: Andrey Logvin <landrey@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837139}

This CL adds a flag which will allow the website to request the
'elevated' It2Me host (with the UiAccess manifest value) is used
instead of the base It2Me host which does not have access to
elevated windows.  The flag is overridden by the Chrome policy so
if a network admin has specified that they do not want to allow
elevated remote support hosts, this new flag is ignored.

Change-Id: Ic84968f432db6ab041a5b4afdc38a2ac7be27a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586967
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837138}

When session restore rebuilds the session restore commands, it was
losing the workspace because it wasn't adding the workspace command to
the list of rebuilt commands. This is most noticeable if you have a lot
of windows open on different workspaces/virtual desktops.

This CL also makes BrowserDesktopWindowTreeHostWin update the workspace
on ::Show, if the workspace isn't set. This makes opening a new browser
window immediately update the workspace, so it will be restored
on session restore without the user having to focus the window.

Bug: 1150225
Change-Id: I38ab861147041f4557e5ae8b62ec0c04763f1f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585990
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837137}

This change crrev.com/c/2380329 added an index to the interface name,
following this now-deleted comment:

  // Interfaces with more than one IPv6 address will yield multiple
  // NetworkInterface objects, with friendly names to distinguish the
  // different IPs (e.g. "wlan" with three IPv6 IPs yields wlan-0,
  // wlan-1, wlan-2).

This comment was incorrectly describing the previous behavior, and
clients relied on `interface_name` not including an index.

Bug: b/171599542
Bug: fuchsia:21155
Change-Id: Ied6972f15546a8f022f486e8c049bdf1dfb1e819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586317
Commit-Queue: Peter Johnston <peterjohnston@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837136}

This reverts commit 06e0fcb1.

Reason for revert: No longer necessary.

Original change's description:
> Android: Fix cronet proguard failure when enable_chrome_android_internal=true
>
> Tested that all targets now build via:
> autoninja -C out/Release $(build/android/list_java_targets.py --proguard-enabled)
>
> Bug: 1155547
> Change-Id: Ie32d62e108778c219a190e363be9c82b747a2a02
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574597
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Paul Jensen <pauljensen@chromium.org>
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833824}

TBR=pauljensen@chromium.org,agrieve@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1155547
Change-Id: I0361ac731d01e97012e21547201969cb3a492cd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593769Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837135}

FilePersistedTabDataStorageTest: 6744 ms -> 2003 ms (70% improvement)
PersistedTabDataTest: 1621 ms -> 178 ms (89% improvement)

Bug: 1158487
Change-Id: Ibe1c998aa4269955582c4a3d0548f61f5e939e33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590344Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837134}

Bug: 1158461
Change-Id: Ifcf9beca09381e26f866f57c4be6a22225b2cccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590710Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837133}

This is a reland of 1208732e

Original change's description:
> Remove unneeded CursorLoaderWin::SetPlatformWindow calls
>
> SetCursorNative is only called from WindowTreeHost::SetCursor, which
> guarantees that the platform cursor has been set.
>
> Bug: 1097556
> Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#810120}

Bug: 1097556
Change-Id: I89b742a80ddd9fee7a77b5af1bee07b58c18f39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445550Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#837132}

Replace deprecated DISALLOW_COPY_AND_ASSIGN macro with deleted copy
constructor and assignment operator on the base class.

Change-Id: Id6ce85518a1db717784a9a6d5f38ea2f191a1d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590691Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837131}

Shows setup for Family Link users on tablet and clamshell if the device
supports PIN for login. Does not change the behavior for other users.

Bug: 1156890
Test: PinForLoginSetupScreenTest
Change-Id: I2e1f8a29ae6fa2739ee57ade6f1351d46254da48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580402Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837130}

This will also allow converting the remaining providers in //clank.
Moving providers to the base module gives more time for the chrome split
preload to work, see http://crrev.com/c/2577546 for more info.

Note I removed the onCreate method from ChromeBrowserProvider, because
it just calls ensureNativeSideInitialized(). Every method which uses
native already calls canHandleContentProviderApiCall() which internally
will call ensureNativeSideInitialized(), so it seems unnecessary to call
from onCreate. This simplifies things a bit.

Review from Patchset 1 on for better diffs, Patchset 1 just moves
ChromeBrowserProvider.java to ChromeBrowserProviderImpl.java.

Bug: 1150600
Change-Id: I98134425b32173211293a4306f7e962934ed47c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591879
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837129}

The comment referenced a function that no longer exists. Fix it.

Change-Id: Id4b9b1107a07c14bc6e0a7d7283ed0aa67f72557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590405
Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#837128}

Add webapps:: namespace to InstallableAmbientInfoBar code, since it will
soon be moved to //components/webapps.

Change banners:: namespace to webapps::, since a lot of that code will
soon be moved to //components/webapps.

Bug: 1147276,1147268,1151772
Change-Id: I089cbffb789993095e90ce6ceb7c84e0419a0e50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586961Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837127}

Bug: 1152282
Change-Id: I05adec0b83f58387694b0443e8bdfc9a1d4ecfa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592007Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837126}

This CL moves AccountPickerDelegate to signin.ui target.

Bug: 1158335
Change-Id: Ibd61670d9ef1ac098b3ba826b9239ece9dd2c283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592994Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837125}

This CL prepares the profile picker to work with the force signin
policy. The list of changes:

- Propagate IsSigninRequired() value from ProfileAttributesEntry to the
  WebUI
- Modify the profile card to display "Sign in [lock]" prompt on profiles
  that require sign-in
- Remove asserts checking that the force signin policy is disabled
- Add native handlers for launching a locked profile and creating a new
  profile when the force signin policy is enabled

Screenshot:
https://drive.google.com/file/d/1Y03Kpe_4CoO5DWLbJ79Fu5j-hjjz0xzz/view?usp=sharing

Bug: 1156096
Change-Id: I8aa315c4459ecf3e9d0faed331a3590aa92a0169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584002
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837124}

Bug: 1151292
Change-Id: I385d767ae4aee2160f85904afa5bac1da1c7923a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593607Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#837123}

The crash in vkGetPhysicalDeviceProperties2() which is supported
by Vulkan 1.1.0. The Vulkan loader may support 1.1.0, but the
device may not support 1.1.0, so we need check device API version
before calling it.

Bug: 1158768
Change-Id: Ib306feda2c4b790ef06e5802e4777744bf1c4892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593548
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837122}

Bug: 1156663
Change-Id: I0ca8c2a2882c627780f94dae09b0e19a65bd04a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591708Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837121}

Bug: 1156668
Change-Id: I5ab27202a535c829304291ac53dc9545eeb292da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588909
Commit-Queue: Ossama Mahmoud <osamafathy@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837120}

ChromeDriver python expecting pid in constructor

Bug: chromedriver:3681
Change-Id: Icb1e56720ca3c8231442628254f965d675df1696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592807Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#837119}

Currently, it creates a copy of the map, which means no metrics should be recorded.

Change-Id: I8d00d464e448fa364cfd47dd8657b3c4f650fff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590384
Auto-Submit: Alex Turner <alexmt@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837118}

My intention is to merge this to 88.

This adds the following changes to cct:
1. context menu when in incognito mode no longer shows
   'open in chrome'. As the app menu explicitly doesn't show 'open in
   chrome' I'm assuming it's an over site that 'open in chrome' is
   shown in the context menu. If this isn't an over site, I can hide
   this behind the flag I previously added.
2. Makes it possible for first parties to use this regardless of the
   feature state if an extra is present. Reason for this is I plan to
   merge this to 88, in which the feature is disabled.
3. Makes it possible for colors to come from the intent. This is only
   enabled if an extra is present in the bundle and restricted to first
   parties.
4. Makes it possible for not show the incognito icon. This is only
   enabled if an extra is present in the bundle and restricted to first
   parties.

BUG=1157916
TEST=Various tests in CustomTabActivityIncognitoTest

Change-Id: I812f46e935dcae01b8d161893059ecf81c146522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582643
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837117}

The current PolicyWatcher exposes a set of 'current' policies which
is actually the default policies with overrides from any platform
policy which is actually set.  This works fine for driving behavior
but in some cases we actually want to know whether a policy value
we receive is the 'default' or if an admin has set it explicitly.

To allow this, the PolicyWatcher will now store the set of platform
policies on the machine and provide it on request.  I plan to use
this for logging (to get an idea of policy usage and popularity)
and for cases where we want to provide a flag from the website to
the NMH but also want admins to override the value if needed.

Since the PolicyWatcher provides the platform policies now, I renamed
GetCurrentPolicies() to GetEffectivePolicies() as I think that name
reflects the fact that it is a merged set of policies.

Change-Id: Id2fd578ac42d925922e8beb5f028374d7bcdcbf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587614Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837116}

This is a reland of b5ab6427

Seems this CL shouldn't be the cause for the test failure that the
reverted CL is referring to.

Based on https://ci.chromium.org/p/chromium/builders/ci/android-asan,
the android_sync_integration_tests also failed before (#9128). It also
succeeded (#9148) after the recent mass failures (#9146), and the
successful build occurred without the revert. Besides, this CL simply
renamed a struct field / some APIs. Any potential errors should be
caught by the compiler.


Original change's description:
> Rename publicly_routable field in the history APIs to floc_allowed
>
> What: Rename publicly_routable field in the history APIs to
> floc_allowed. The database schema is left unchanged to save the
> migration cost. Updated the comment for VisitRow::floc_allowed.
>
> Why: This bit is expected to be used only for floc. We've decided to
> incorporate another opt-out status, and may introduce more status in
> the future. Therefore it makes sense to rename to floc_allowed.
>
> Bug: 1157761
> Change-Id: I9aecb50287e7953754eb05aa2d7993a6092639e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586232
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836815}

Bug: 1157761
Change-Id: I4d9329f953f3ee4d3707c2a4e06e27a8542c2bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592194Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837115}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012150600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hggko_uXuyxm_pLSASRkHELwYPxwaBF969K75Dw8z_MC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/138543581,b/138961540,b/161823671,b/169023690,b/174201860,b/174536568,b/175517195,b/175636714,b/175638149
Tbr: media-app@grotations.appspotmail.com
Change-Id: I22450ce53bfefbd560ed610a48ec42cab73a4ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593422Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#837114}