- 22 Jul, 2016 40 commits
-
-
msramek authored
Revert of Support early associated interface binding on ChannelMojo (patchset #7 id:120001 of https://codereview.chromium.org/2163633003/ ) Reason for revert: Probable cause of failures on Mac ASan. See crbug.com/630564 for more details. Original issue's description: > Support early associated interface binding on ChannelMojo > > Changes the associated bindings implementation for ChannelMojo > such that remote interfaces can be acquired immediately upon > ChannelMojo construction rather than having to wait for connection > on the IO thread. > > Simplifies the Channel bootstrapping process, removing a round-trip > Init message (and in fact the entire IPC::mojom::Boostrap interface) > since there's no need to actually exchange associated interface handles > over the pipe. Instead both sides can assume the other will use a fixed, > reserved endpoint ID for their IPC::mojom::Channel interface. > > This also removes the restriction that associated interfaces must be > added to a Channel after Init. Instead the same constraints apply as > with AddFilter: an associated interface, like a filter, may be added > at any time as long as either Init hasn't been called OR the remote > process hasn't been launched. > > The result of this CL is that any place it's safe to AddFilter, > it's also safe to AddAssociatedInterface; and any place it's safe to > Send, it's also safe to GetRemoteAssociatedInterface and begin using > any such remote interface immediately. > > Remote interface requests as well as all messages to remote interfaces > retain FIFO with respect to any Send calls on the same thread. Local > interface request dispatch as well as all messages on locally bound > associated interfaces retain FIFO with respect to any OnMessageReceived > calls on the same thread. > > BUG=612500,619202 > > Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091 > Committed: https://crrev.com/508da24622f957a01b076ccd058bfdccc79068a4 > Cr-Original-Commit-Position: refs/heads/master@{#406720} > Cr-Commit-Position: refs/heads/master@{#407050} TBR=yzshen@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612500,619202 Review-Url: https://codereview.chromium.org/2173753002 Cr-Commit-Position: refs/heads/master@{#407120}
-
ivoc authored
Also adds a timeout to the test, to prevent an infinite loop when no file is produced, or the filename is different than expected. BUG=webrtc:4741 Review-Url: https://codereview.chromium.org/2131133002 Cr-Commit-Position: refs/heads/master@{#407119}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/482fb9de..1a2021bc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2176583002 Cr-Commit-Position: refs/heads/master@{#407118}
-
bugsnash authored
https://codereview.chromium.org/2053273002/ Review-Url: https://codereview.chromium.org/2175603002 Cr-Commit-Position: refs/heads/master@{#407117}
-
ehmaldonado authored
This is to make peerconnection-call.html and webrtc_browsertest.cc more readable BUG=6135 Review-Url: https://codereview.chromium.org/2167133002 Cr-Commit-Position: refs/heads/master@{#407116}
-
bugsnash authored
Review-Url: https://codereview.chromium.org/2171173002 Cr-Commit-Position: refs/heads/master@{#407115}
-
karandeepb authored
Crash reports beginning from Chrome V48 suggest that CreateUTIFromExtension may return nil. This causes a crash when the uti string is added to the NSMutableSet which holds the uti strings corresponding to the extension dropdown. This CL does a nil check before adding the string to the set, which should prevent the crash. BUG=630101 Review-Url: https://codereview.chromium.org/2164223003 Cr-Commit-Position: refs/heads/master@{#407114}
-
msramek authored
This reverts commit ea728cb1. Reason for revert: Broken Linux ChromiumOS Tests. TBR=bmcquade@chromium.org,shivanisha@chromium.org,isherman@chromium.org BUG=630549 Review-Url: https://codereview.chromium.org/2172183002 Cr-Commit-Position: refs/heads/master@{#407113}
-
kojii authored
W3C discussion[1] resolved to allow observing the style attribute. CEReactions are added to CSSStyleDeclaration interface[2]. Ported from a canceled patch for Custom Elements V0[3]. [1] https://github.com/w3c/webcomponents/issues/521 [2] https://drafts.csswg.org/cssom/#cssstyledeclaration [3] https://codereview.chromium.org/1446933002 BUG=594918 Review-Url: https://codereview.chromium.org/2166213002 Cr-Commit-Position: refs/heads/master@{#407112}
-
yoichio authored
Rename and sort variables, Extract function body to receive and return Position. TEST=No change in behavior. Review-Url: https://codereview.chromium.org/2177433002 Cr-Commit-Position: refs/heads/master@{#407111}
-
bzanotti authored
BUG=627675,627872 Review-Url: https://codereview.chromium.org/2159393003 Cr-Commit-Position: refs/heads/master@{#407110}
-
yukishiino authored
createClosure() is abused in ScriptPromise{,Resolver}Test, so, simply removes it. BUG=626266 Review-Url: https://codereview.chromium.org/2144413004 Cr-Commit-Position: refs/heads/master@{#407109}
-
hayato authored
HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this) unconditionally. Since Blink does not support "slots in a flat tree", we should return early here for a slot element. BUG=627385 Review-Url: https://codereview.chromium.org/2172133002 Cr-Commit-Position: refs/heads/master@{#407108}
-
jkrcal authored
The call to base::LinearHistogram::FactoryGet may simply look wrong without the explanation. Review-Url: https://codereview.chromium.org/2169863003 Cr-Commit-Position: refs/heads/master@{#407107}
-
machenbach authored
Remove chromium defaults for v8_optimized_debug and v8_use_external_startup_data. This is not needed after v8 provides these defaults: https://codereview.chromium.org/2025803003/ https://codereview.chromium.org/2024833002/ It also interferes if somebody tries to override the gn args with a different value. BUG=chromium:616034 TBR=alokp@chromium.org, brettw@chromium.org Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce Review-Url: https://codereview.chromium.org/2058033002 Cr-Original-Commit-Position: refs/heads/master@{#406067} Cr-Commit-Position: refs/heads/master@{#407106}
-
tkent authored
-webkit-appearance:menulist, which is the default appearance of menulist SELECT, uses fixed font sizes, auto height, and the fixed font family. Ignoring such style was not good for platform-predictability. After this CL, -webkit-appearance:menulist automatically fallbacks to -webkit-appearnce:menulist-button by font-size, height, font-family CSS properties. This CL also changes the default rendering of <input type=color list> because it uses -webkit-appearance:menulist with a fixed height. The new rendering is better because its height is same as the default rendering of <input type=color>. BUG=104922 Review-Url: https://codereview.chromium.org/2171133003 Cr-Commit-Position: refs/heads/master@{#407105}
-
hayato authored
This DCHECK just rephrases the result of the previous line. BUG=630141 Review-Url: https://codereview.chromium.org/2174693002 Cr-Commit-Position: refs/heads/master@{#407104}
-
yamaguchi authored
.detail-checkmark creates a new containing block by position:absolute so that it is always clickable, but the thumbnail icons should not do that. BUG=630236 Review-Url: https://codereview.chromium.org/2166353002 Cr-Commit-Position: refs/heads/master@{#407103}
-
sdefresne authored
Allow to specify dependencies that are only used by the create_bundle target when using ios_app_bundle or ios_framework_bundle templates to increase parallelism. BUG=629867 Review-Url: https://codereview.chromium.org/2169973002 Cr-Commit-Position: refs/heads/master@{#407102}
-
lizeb authored
When a Custom Tabs client dies, the Android framework sends a notification to an IBinder.DeathRecipient. This is relayed by CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this method is called from a different thread than the UI thread, then this triggers a native crash. Avoid that crash by making sure that mClientManger#cleanupSession() (and then CustomTabsConnection#cancelPrerender()) is called from the UI thread. Also add a non-regression test. BUG=623128 Review-Url: https://codereview.chromium.org/2158843003 Cr-Commit-Position: refs/heads/master@{#407101}
-
yoichio authored
global functions. Make Node::isContentEditable and Node::isRichEditable global functions. This CL also re-introduce HTMLElement::isContentEditable because it is a web-exposed IDL attribute. This is a preparation to move these functions from core/dom to core/editing/ TEST=No change in behavior Review-Url: https://codereview.chromium.org/2121313003 Cr-Commit-Position: refs/heads/master@{#407100}
-
yosin authored
This patch converts "editing/deleting/delete-ws-fixup-00[1234].html" to use w3c test harness and consolidates into "delete_ws_fixup.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2174683002 Cr-Commit-Position: refs/heads/master@{#407099}
-
yosin authored
This patch converts "editing/deleting/delete-trailing-ws-00[12].html" to use w3c test harness and consolidates into "delete_trailing_ws.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2174673002 Cr-Commit-Position: refs/heads/master@{#407098}
-
yosin authored
This patch converts "editing/deleting/delete-to-select-table.html" to use w3c test harness and consolidates into "delete_tab.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2169323002 Cr-Commit-Position: refs/heads/master@{#407097}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bc62d66..482fb9de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2169353002 Cr-Commit-Position: refs/heads/master@{#407096}
-
sdefresne authored
Keep the name of the target generating the executable in ios_app_bundle template the same whether the final binary is a fat or thin binary. BUG=629867 Review-Url: https://codereview.chromium.org/2167933003 Cr-Commit-Position: refs/heads/master@{#407095}
-
vasilii authored
BUG=629459 Review-Url: https://codereview.chromium.org/2166823004 Cr-Commit-Position: refs/heads/master@{#407094}
-
sdefresne authored
The XCTest support (used for EarlGrey tests) requires linking against XCTest.framework whose location is relative to sdk-platform-path, so propagate via ios_sdk_platform_path variable in gn. BUG=629867 Review-Url: https://codereview.chromium.org/2168873003 Cr-Commit-Position: refs/heads/master@{#407093}
-
groby authored
Clarify function call parameter. BUG=none R=esprehn@chromium.org Review-Url: https://codereview.chromium.org/2145613002 Cr-Commit-Position: refs/heads/master@{#407092}
-
joone.hur authored
Here is a DOM state when we only add a blockquote. <div contenteditable><blockquote>|<br></blockquote></div> After indenting the blockquote, the change is as follows: <div contenteditable> <blockquote> <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"> <blockquote>|<br></blockquote> </blockquote> </blockquote> </div> There is an unnecessary blockquote so the result should be as follows: <div contenteditable> <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"> <blockquote>|<br></blockquote> </blockquote> </div> This CL removes the additional blockquote. BUG=625802 TEST=editing/execCommand/indent-empty-quote.html Review-Url: https://codereview.chromium.org/2175433002 Cr-Commit-Position: refs/heads/master@{#407091}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#407090}
-
foolip authored
Revert of Reland "Implement FullScreen using top layer." (patchset #13 id:260001 of https://codereview.chromium.org/2107233002/ ) Reason for revert: Multiple regressions around the fullscreen transition becoming visibly worse, as well as a suspected leak. BUG=628554,628605,628662,630191 Original issue's description: > Reland "Implement FullScreen using top layer." > > This reverts commit 2460a952. > > Notable changes on top of previous attempt: > > full-screen-iframe-ua-style.html is changed to use overflow property > instead, as position is no longer changed on ancestors. > > :root:-webkit-full-screen-ancestor { overflow: hidden !important; } is > retained, as the previous attempt regressed on Vimeo (crbug.com/543946) > and it's not clear yet how to handle this in the spec: > https://github.com/whatwg/fullscreen/issues/19 > > Make ::backdrop work for replaced content (video, iframe, etc.) by > changing StyleResolver::createPseudoElementIfNeeded to allow creating > the ::backdrop pseudo-element even if the parent doesn't support > children. With this change, full-screen-stacking-context.html was > simplified and full-screen-video-has-backdrop.html was > simplified+renamed. > > The will-change override is dropped, as full-screen-will-change.html > passes without it. > > BUG=240576, 543946 > > Committed: https://crrev.com/d666f503ae854fac360cc70da1f5971a6724546a > Cr-Commit-Position: refs/heads/master@{#405478} TBR=dsinclair@chromium.org,esprehn@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=240576, 543946 Review-Url: https://codereview.chromium.org/2168373002 Cr-Commit-Position: refs/heads/master@{#407089}
-
atotic authored
The plot thickens: This checkin introduces all the classes, and the links between them. The links are important for object lifetime management. Lifetime architecture is described at https://docs.google.com/document/d/1G4OmqqlFY3H3erQAUmteKES02-bIECikDjWBrDKH9PA/edit?usp=sharing BUG=612962 ResizeObserver: conecting Objects Review-Url: https://codereview.chromium.org/2161313002 Cr-Commit-Position: refs/heads/master@{#407088}
-
yosin authored
This patch converts "editing/deleting/delete-block-content-00[123].html" to use w3c test harness to simplify test files by consolidating them into "delete-block-content.html". Note: "delete-block-content-003.html" is identical to "delete-block-content-002.html" expect for 003.html has two DIV[id=root]. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2170273002 Cr-Commit-Position: refs/heads/master@{#407087}
-
yosin authored
This patch converts "editing/deleting/delete-contiguous-ws-001.html" to use w3c test harness to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2169263003 Cr-Commit-Position: refs/heads/master@{#407086}
-
yosin authored
This patch converts "editing/deleting/delete-tab-[1234].html" to use w3c test harness and consolidates into "delete_tab.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2172943002 Cr-Commit-Position: refs/heads/master@{#407085}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71da59b9..5bc62d66 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2176443003 Cr-Commit-Position: refs/heads/master@{#407084}
-
dcheng authored
BUG= Review-Url: https://codereview.chromium.org/2137863002 Cr-Commit-Position: refs/heads/master@{#407083}
-
sanjoy.pal authored
Specification: https://www.w3.org/TR/payment-request/#updatewith BUG=629462 Review-Url: https://codereview.chromium.org/2170783002 Cr-Commit-Position: refs/heads/master@{#407082}
-
yosin authored
This patch converts "editing/deleting/delete-and-undo.html" to use w3c test harness to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2164243002 Cr-Commit-Position: refs/heads/master@{#407081}
-