GitLab

Currently the last three parameters to UpdateSchedulingInfo are
actually return values.  This is hard to remember, so change
UpdateSchedulingInfo to return the three values as a tuple to make it
clear what its inputs and outputs are.

Bug: 878171
Test: all layout tests pass
Change-Id: I43cdcc4127d3890fe6b2f1107e0f7731bdcfc2e5
Reviewed-on: https://chromium-review.googlesource.com/1192351Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586806}

To allow media to eventually switch to sequences we should at
least fix our most commonly used primitive to work on sequences.

base::SequencedTaskRunnerHandle::Get() falls back to the threaded
version if a sequence is unavailable, so this is a no-op.

BUG=none
TEST=everything still passes.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7c9884d94633598a55d96a2ca1a23a8decca731e
Reviewed-on: https://chromium-review.googlesource.com/1192346
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586805}

Bug: 878315
Change-Id: I2ccae48290d4191efb5de6ea4ae4890a7a800fe0
Reviewed-on: https://chromium-review.googlesource.com/1194565Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586804}

Bug: 876352
Change-Id: I0f9d8c16390c0f79c972a63f178616ef5a8e5083
Reviewed-on: https://chromium-review.googlesource.com/1192409Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586803}

Saves traffic while capacity is limited.
Relevance also seems lower for those results vs text queries.

Bug: 876596
Change-Id: I15cb3a19673946b888d20658d223b6097a1fe49d
Reviewed-on: https://chromium-review.googlesource.com/1185496
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586802}

Google-internal design doc:
https://docs.google.com/document/d/1X6Xoz9hl3qoAj3EhAKcvZ6hWLVcY_QpQgmUexpgDHKA/edit?usp=sharing

Keep prefs that should be persisted across runs in a JsonPrefStore, and
other prefs in an InMemoryPrefStore. Use SegregatedPrefStore to dispatch
individual prefs to one or the other, based on a whitelist of persisted
prefs. The whitelist is currently empty; prefs will be added as features
require them.

Also keep pref_registry in a scoped_refptr, rather than a raw pointer,
for safety.

BUG=866722

Change-Id: I55c819b14f130849b2066321fa4042bb0bd2b5ea
Reviewed-on: https://chromium-review.googlesource.com/1189043Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586801}

Currently, the controls on the Picture-in-Picture window are shown while
the window is being resized or dragged. The scaling of the controls is
not very smooth while the window is resized.

The controls cannot be interacted with during the resize and dragging
actions. They also slightly obscure the video, especially the play/pause
icon. Removing the controls will allow the user to view the final video
size and position.

The controls are shown again when the user hovers over / interacts with
the window.

Bug: 877987
Change-Id: Ic50b2a330a811540914d9675b068cc561a652bbd
Reviewed-on: https://chromium-review.googlesource.com/1191026Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586800}

https://webrtc.googlesource.com/src.git/+log/a911eaf79bce..d941c09bc032


git log a911eaf79bce..d941c09bc032 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 nisse@webrtc.org Delete unimplemented methods from the NetEq interface.
2018-08-28 phoglund@google.com Revert "Roll chromium_revision ca3a5e1c..076bef0a (585726:586605)"
2018-08-28 titovartem@webrtc.org Revert "Rename VideoQualityTestFixtureInterface::Params.pipe into config."
2018-08-28 phoglund@webrtc.org Roll chromium_revision ca3a5e1c..076bef0a (585726:586605)


Created with:
  gclient setdep -r src/third_party/webrtc@d941c09bc032

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I007bd8043b68f75c35a2a954fda47c53f43fb0bc
Reviewed-on: https://chromium-review.googlesource.com/1194266Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586799}

Crashing the network service just after completing a network request
can corrupt the cache.

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/1193967,
where I accidentally only disabled one of the two tests that crash the
network service and expect an on-disk cache cache to work aftwards.

Also do some cleanup to the earlier fix (Renable the other test when
the network service is crash but there's no on disk cache, remove
dead code)

Bug: 878346
Change-Id: I7f483443aec4b0e60abd344676d4d197344b1b7f
Reviewed-on: https://chromium-review.googlesource.com/1194466Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586798}

Makes the Enterprise Reporting policies from a previous CL [1]
effective. They now really control what gets reported and what doesn't,
instead of just serving as placeholders.

[1] https://chromium-review.googlesource.com/1187066

Bug: 877120
Change-Id: I5098e55ce337fd3e8a5a56fc98bdc08d105b6a86
Reviewed-on: https://chromium-review.googlesource.com/1190542
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586797}

Incorrectly deleted as part of http://crrev.com/c/1153969

Bug: 754341
Change-Id: I7f7fc998246a4ed1fd0b41c5168d37ff641105f9
Reviewed-on: https://chromium-review.googlesource.com/1192410Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586796}

Adds several utility functions for accessing the accessibility tree,
annotated with Switch Access predicates.

Bug: None
Change-Id: I48e5785c9ed7fa28a3ed396f493f0639e3fec340
Reviewed-on: https://chromium-review.googlesource.com/1188889
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586795}

This is no longer allowed in the WebAssembly spec, see
https://webassembly.github.io/spec/web-api/index.html#serialization

Bug: chromium:877286
Change-Id: I11f64cf8537eb893fc037e411f4eba80af8d946b
Reviewed-on: https://chromium-review.googlesource.com/1192337Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586794}

Consolidated the selected and hovered tabs into the same list. This list
is then sorted based on their hover-animation state, selected state, and
if the mouse is hovering the tab. This eliminated the second hovered_tabs
list and hovered_tab variable.

All 5 states are now managed together and painted in the following order:
 o Unselected with hover animating
 o Unselected with mouse hovered
 o Selected with no hover animations
 o Selected with hover animating
 o Selected with mouse hovered

The unselected with no hover animations tabs are painted in the first pass
and are not in this consolidated list.

Bug: 876595
Change-Id: Ib77a7161485a08321f0f27e06f162263eaa891f0
Reviewed-on: https://chromium-review.googlesource.com/1188433
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586793}

Bug: 875986
Change-Id: I99721c6555f6595bdc70088d0d0590523eef9f6e
Reviewed-on: https://chromium-review.googlesource.com/1188967Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586792}

Bug:

LayoutBlock::LayoutPositionedObject had a static position check whether
child reflow was necessary:
  if (.... ||
       (!IsLayoutNGBlockFlow() &&
        NeedsLayoutDueToStaticPosition(positioned_object))))
    layout_scope.SetChildNeedsLayout(positioned_object);
This check would skip reflow for all NGBlockFlow children.
This is incorrect. If child abspos layout was initiated by Legacy,
we should check static position.

Fix:
There was no way to tell in current code whether child abspos layout
was initiated by legacy.
Added a flag is_legacy_initiated_out_of_flow_layout_.
Flag was added to LayoutBlock per ikilpatrick recommendation.
Flag is set to true in LayoutNGBlockFlow::UpdateOutOfFlowBlockLayout
Flag is set to false in NGOutOfFlowLayout.

With this fix, checkboxes on code review page are correct.

Bug: 863865
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ifc55ac03b76dd1aa2113181681bca1b5a2832fb2
Reviewed-on: https://chromium-review.googlesource.com/1190723
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586791}

My first CL into Autofill iOS automation - continuing off noyau@'s
work by expanding the capabilities of the automation suite to match work
done on other platforms. Previously, only the "click" action was
implemented in iOS, and this adds the "waitFor" action, which waits
until all associated Javascript assertions are true before continuing
with the test script.

This is meant to be a fairly 1:1 port of the equivalent actions
(composed of TestRecipeReplayer::ExecuteWaitForStateAction,
WaitForStateChange, and AllAssertionsPassed) here:
https://chromium.googlesource.com/chromium/src/+/831f175d0cafe05c00306104bd86dfb4c00921da/chrome/browser/autofill/captured_sites_test_utils.cc#477

Next, I plan on adding the "autofill" action.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaea2e2ecd68eb29755fb4a8be6736bdaea64dcfb
Reviewed-on: https://chromium-review.googlesource.com/1185920Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586790}

Previous divider implementation looked thicker than the standard ones
(see the bug for screenshots). This CL fixes the issue by using
listDivider theme attribute instead of explicitly specifying divider
size and color. This CL also introduces a couple of textApperance styles
to overcome presubmit errors.

Bug: 877482
Change-Id: Iab448228ca34cd1d6fd443768fe009b14d7f9e3e
Reviewed-on: https://chromium-review.googlesource.com/1191703
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586789}

This CL runs clang-format on
chrome/utility/importer/ie_importer_win.cc, to separate the
behaviour-affecting changes of https://crrev.com/c/1174711 from style
changes enforced by presubmit checks.

This CL does not introduce any functional changes.

Bug: 456119
Change-Id: I27a52f047c95a16648c550c045a2699fa1b40c61
Reviewed-on: https://chromium-review.googlesource.com/1193223
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586788}

This reverts commit af0b9e0e.

Reason for revert: the original CL was for diagnostic purposes and is not needed anymore.

Original change's description:
> Check DrawQuad is given a valid pointer to SharedQuadState
> 
> Bug: 852294
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: Iea27ee973f337f833b31a8c18e002b2772f7bacb
> Reviewed-on: https://chromium-review.googlesource.com/1133579
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Commit-Queue: Saman Sami <samans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574366}

TBR=fsamuel@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 852294
Change-Id: I2001b68cc4b2a685517c5149302e6e8aacd081eb
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1194248Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586787}

Page color overlays are used for extension "deemphasized" effects. These
were integrated outside the blink lifecycle update but they can be moved
entirely into blink now. This patch moves the page color overlay from
WebViewImpl to Page and puts the update and paint calls in the blink
document lifecycle.

Bug: 870422
Change-Id: I92586ebeca29be24dfe35e033ca4099852d93ce4
Reviewed-on: https://chromium-review.googlesource.com/1192120Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586786}

Bug: b/78190629
Test: Manual Test
Change-Id: Ia24c946348544f3ebe4a9edc17972895fbc0df60
Reviewed-on: https://chromium-review.googlesource.com/1189709Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586785}

A few more changes, following up to the previous commit which added the WebGPU command buffer.

Bug: 868192
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iade27669c2bdebb598463b579a8dfaa6b91fbb9b
Reviewed-on: https://chromium-review.googlesource.com/1192411Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586784}

Records the number of resource loading tasks split by net priority. Recorded
each time a resource's request priority changes.

Bug: 870349
Change-Id: Idef96f2e9e0a08045387b8bf78874727b2deeb91
Reviewed-on: https://chromium-review.googlesource.com/1185596Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586783}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/a1750dbc79a8..9977619490e1

$ git log a1750dbc7..997761949 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 thakis Move src.git/build/secondary/third_party/libjpeg_turbo in-tree.
2017-07-26 agable Upload libjpeg_turbo reviews to Gerrit by default

Created with:
  roll-dep src/third_party/libjpeg_turbo

Also remove now-unused build/secondary/third_party/libjpeg_turbo/BUILD.gn

Bug: none
Change-Id: I688b3c5f6d0250ba9f568203169d9bb504c49dd9
Reviewed-on: https://chromium-review.googlesource.com/1194482Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586782}

Previously, offline content suggestions would show on
any net error page. Now they only show on the dino page, as intended.
As a beneficial side-effect, the error strings (available on page load) will
indicate whether offline content may be inserted to the page later. This is
important for implementing the final UI because, for instance, we need to hide
error help suggestions to make room for content.

I moved the feature flag from browser/ to chrome/common so that it is accessible
from the error page code.

This code was previously reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1185282
and needed move to another issue for an OOO reviewer.

Bug: 852872
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I86392d2b10d1f243525f043e0627b04f41f83b96
Reviewed-on: https://chromium-review.googlesource.com/1194245Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#586781}

Bug: 877948, 656015
Change-Id: Ifc19e9a8566094adccf39ef953d909e7b5218dd8
Reviewed-on: https://chromium-review.googlesource.com/1190023Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586780}

This is a follow up to r586485.

Bug: 877697
Change-Id: Ie4cbcf90d3fd626ffe8d66832535ab8a0a9b227c
TBR: trivial
Reviewed-on: https://chromium-review.googlesource.com/1192698Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586779}

This reverts commit 8f6992ac.

Reason for revert: Broke Build
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/87180

Original change's description:
> Add VulkanSurface::SetSize() to implement resize.
> 
> This method will recreate VulkanSwapChain in VulkanSurface with the new size.
> This CL also adds a new param old_swap_chain for VulkanSwapChain::Initialize(),
> so we can create a SwapChain correctly.
> 
> Bug: 866914
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I2042f389c69a591a325f7b530fff1e554cca5e66
> Reviewed-on: https://chromium-review.googlesource.com/1184977
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: Victor Miura <vmiura@chromium.org>
> Reviewed-by: Michael Spang <spang@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586776}

TBR=penghuang@chromium.org,rjkroege@chromium.org,spang@chromium.org,ccameron@chromium.org,vmiura@chromium.org

Change-Id: I0d502444e96f68341f35f405d1cb027b21404ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866914
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1194664Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586778}

- Make fling from top and inside snapping area have different velocity
  thresholds.
- Update the value of velocity threshold, the old value is too small.

Bug: None
Change-Id: I44493c061640ed7a0c163b42e3a686c237de0d84
Reviewed-on: https://chromium-review.googlesource.com/1192700
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586777}

This method will recreate VulkanSwapChain in VulkanSurface with the new size.
This CL also adds a new param old_swap_chain for VulkanSwapChain::Initialize(),
so we can create a SwapChain correctly.

Bug: 866914
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2042f389c69a591a325f7b530fff1e554cca5e66
Reviewed-on: https://chromium-review.googlesource.com/1184977Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586776}

We haven't been DEPS'ing in third_party/nss for a long time, so having
the build file there is misleading. Since it uses pkg-config, put it
in build/config/linux, where most other pkg-config-using system dependencies
live.

TBR=stevenjb

Bug: none
Change-Id: Iaa32ba43898303a5072edb2b183beb89a220d78a
Reviewed-on: https://chromium-review.googlesource.com/1193965
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586775}

This reverts commit 45116fe1.

Reason for revert: Does not pass in official builds:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/91358

Original change's description:
> [NTP] Test EmbeddedSearch APIs for custom backgrounds
> 
> Check that the embeddedsearch APIs for custom background correctly
> update the ThemeBackgroundInfo when called.
> 
> Bug: 857256
> Change-Id: I7c71ddbbdc30fa9fbcf4a2afc8387affcc39693c
> Reviewed-on: https://chromium-review.googlesource.com/1189082
> Reviewed-by: Kristi Park <kristipark@chromium.org>
> Commit-Queue: Kyle Milka <kmilka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586394}

TBR=kristipark@chromium.org,kmilka@chromium.org

Change-Id: I756c849a01dfdda6f1c8074a21e0613fc0062fdc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857256
Reviewed-on: https://chromium-review.googlesource.com/1194571Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586774}

Use ".any.js" tests [1] rather than redundant files for window and
worker variations, and increase coverage where window-only tests
existed. Also use ".worker.js" and ".window.js" to eliminate some
boilerplate. The one manual test is left untouched for ease of
running... manually.

[1] https://web-platform-tests.org/writing-tests/testharness.html

Change-Id: I7be790e0134854c804dbf82072589f07fa6e0bfb
Reviewed-on: https://chromium-review.googlesource.com/1194324Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586773}

This change exposes the AtkText interface on all accessibility elements
and uses the, now shared, ComputeHypertext in order to compute composite
text for elements that have multiple children. Once we start exposing
the hypertext interface, we can start testing the embedding of objects
into the hypertext itself. The plan is also to eventually expose the
interface on objects that need it.

Unfortunately, since hypertext computation is now triggered by the
content code, we must move the existing AtkText unit test to content as
well alongside the new one.

Bug: 866337
Change-Id: I8cc738dd0e14cf95ecdffa2370d242fb447aa9b6
Reviewed-on: https://chromium-review.googlesource.com/1190782
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586772}

Updated filter file from jamescook@

Also adds PictureInPictureWindowControllerBrowserTest\
.OpenInFrameWithDevToolsDoesNotCrash to blacklist to fix failure on FYI bot.

Bug: 874090
Change-Id: I737511e2cb0214a586326ac68889e71ced9e79cf
Reviewed-on: https://chromium-review.googlesource.com/1192334
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586771}

This is a follow-up to r583089 as it was pointed out that the original
patch did not handle connection errors caused by a network service
process restart. In this case we can simply try to reinstall the cookie
change listener.

Bug: 792663
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5ef4b038b942a47c8aa1f8cc485327ba14f2fa28
Reviewed-on: https://chromium-review.googlesource.com/1192022
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586770}

In places where dependency on the constants defined in
widevine_cdm_common.h is needed, we should include widevine_cdm_common.h
directly, instead of depending on the include of widevine_cdm_version.h.

This also clears the way for us to remove the include of
widevine_cdm_common.h in widevine_cdm_version.h, and potentially the
removal of widevine_cdm_version.h altogether in the future.

Bug: 349182
Test: No functionality change
Change-Id: I49a8d6bc976272ca6730e5f7ec4a52aa46c4a456
Reviewed-on: https://chromium-review.googlesource.com/1192350Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586769}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/component_updater.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=laforge@chromium.org

Bug: 874080
Change-Id: If7aa633ca41f4bdf0836c2b25977b3cc0df9607a
Reviewed-on: https://chromium-review.googlesource.com/1191100Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586768}

(1) HostVerifierImpl::IsHostVerified() returned true if the device had
    previously been verified but was pending removal. If a device is
    pending removal, the user has explicitly requested that it be
    removed as the host device, so it should not be considered verified.
(2) RemoteDeviceCache::SetRemoteDevices() skipped overwriting device
    metadata if that data was not newer than the previously-stored data.
    However, there is currently a bug on the CryptAuth back-end which
    does not update the device metadata update time when a feature has
    been changed from supported to enabled or vice versa. Thus, this
    check has been temporarily removed until the back-end bug has been
    fixed.

Bug: 870069, 824568
Change-Id: Ie748e5d662a9ea00cf1b5e6a42fc8354c986d61e
Reviewed-on: https://chromium-review.googlesource.com/1192417Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586767}