- 17 Dec, 2019 40 commits
-
-
Mario Sanchez Prada authored
This CL migrates the code using the unsafe static_cast to using the new mechanism to downcast to subclasses of WebUIController, implemented in crrev.com/c/1959199. Bug: 1006361, 1002647 Change-Id: I72797397f0427450b988897335c43903a96dc80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962253Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#725455}
-
Alexandre Courbot authored
Now that all the Fourcc producers return only valid instances, we can remove the invalid Fourcc constructor as well as the invalid state itself. Bug: 1031082 BUG=b:143498574 Test: Chromium builds for arm-generic and Eve. Change-Id: Ic603fbe3e8e50a2d88eeaf851261d26021a1358c Change-Id: If3960b8f56269109a15e2f82f39cf456b5b61528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961303 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#725454}
-
Alexandre Courbot authored
ToVaFourCC() is not guaranteed to return a valid value for any of the Fourccs we recognize, so make it return an Optional in case the conversion cannot be performed to force the user to check the returned value. BUG=1031082 BUG=b:143498574 TEST=Chrome compiles on Eve. Change-Id: I6910fccc871bb3baf86ca8ed1431419cfbc7743b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957200Reviewed-by:
-
Kent Tamura authored
- Update comments - Remove unnecessary code - No 4th argument - No need to unlink the original generated header because it must have been renamed to foo.h. - We don't need to try *.cpp.h and *.hpp because now we require Bison 3.4 or later. - Rename variables for better readability This CL has no behavior changes. Change-Id: I4f825a3ea5cf006d60c6c765c33a6de3d579f4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971300Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#725452}
-
Jan Scheffler authored
This cl updates the testresults for crrev.com/c/1959000. Tbr: yanngguo@chromium.org Bug: chromium:1026879 Change-Id: Ieee4172ea5a9485dc0f20c6daaf4b7a378a7984e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967237 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#725451}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/304bb2fe9236..bd963dc11651 git log 304bb2fe9236..bd963dc11651 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 eseckler@google.com Merge "build/logging: Disable info logs in chromium" Created with: gclient setdep -r src/third_party/perfetto@bd963dc11651 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I31dd23914c3ed634f316af79c7704385e7534edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725450}
-
Kent Tamura authored
If an implementation applies Unicode careless comparison incorrectly, 's' can be matched to U+017F. Bug: 627682 Change-Id: I9dd26abea13d06a2067e834a902aea76b3421c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971185Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#725449}
-
Hitoshi Yoshida authored
Also updates some BUILD.gn files to stop the current IDL compiler generate code of dictionaries, if |use_idl_compiler_v2_for_dictionary| is set true in gn.args. Bug: 839389 Change-Id: I69bd10cf4e7f57cd1d9873c4b2202a917ed67ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969318 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#725448}
-
Kent Tamura authored
Make it match to Blink Python style. - Rename variables - Wrap the top-level code with main() function This CL has no behavior changes. Change-Id: If7f7fdba757e03b71b3d7c386de6771ad98fb3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971293 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45a70dc772a6..ba22253ee917 git log 45a70dc772a6..ba22253ee917 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 dberris@chromium.org Reduce calls to Change.FromDict(...) Created with: gclient setdep -r src/third_party/catapult@ba22253ee917 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034373 Tbr: rmhasan@google.com Change-Id: I3985c2ade3f91635254a640cd1bfa767c2bda31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971252Reviewed-by:
-
Ken Rockot authored
Fixed: 1007751 Change-Id: I9d0d2ddea7c44ca218652d0417c1019ae8db51d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970576Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#725445}
-
Kent Tamura authored
In order to follow Blink coding style as much as possible, - Rename token types from UPPER_SNAKE_CASE to kCamelCase - Rename %parse-param from 'parser' to 'parser_'. It becomes a data member of the generated YyParser class. This CL has no behavior changes. Change-Id: Iaedbfdf68346b8a0b96960a72e689340ed22dfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971187Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1032899 Test: covered by unittest Change-Id: Ie96d7ba7237aa466a1f3b9039240b24f9f07f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961578 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#725443}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.66-1575889638-benchmark-80.0.3987.5-r1 to 80-3987.0-1576496920-benchmark-80.0.3987.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0234f9aa4ebee78d41925538d9a32d3f65e6e501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971256Reviewed-by:
-
Jiewei Qian authored
This relands https://crrev.com/c/1955247. Some refactors in origin CL breaks official build tests, they are deferred to https://crbug.com/1034361. Original change's description: > Revert "system-web-apps: add support to pass launch_files to running Apps" > > This reverts commit 42bdc71e. > > Reason for revert: https://crbug.com/1034456 (All/SharedPWATest.MixedContentInPWA/1 failing on linux-chromeos-chrome bot) > > Original change's description: > > system-web-apps: add support to pass launch_files to running Apps > > > > - Clean up ShowApplicationWindow logic, split it into sub functions. > > - Remove SetInitialFocus, which is no longer necessary. > > - Remove extra HostedAppBrowserController::SetAppPrefsForWebContents > > during app launch. HostedAppBrowserController already does this. > > - Set launch files before showing the window. > > > > Fixed: 1023742 > > Change-Id: I074a917bb0ed557d1a967a04cb3042c9ee29113b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955247 > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#725054} > > TBR=msw@chromium.org,ericwilligers@chromium.org,ortuno@chromium.org,joelhockey@chromium.org,qjw@chromium.org > > Change-Id: Ic5e4c4afec085827e7ac879bd1f67f84e100be4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969341 > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Commit-Queue: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725069} TBR=msw@chromium.org,ericwilligers@chromium.org,ortuno@chromium.org,joelhockey@chromium.org,hendrich@chromium.org,qjw@chromium.org Change-Id: I1753cb42ff8b47d4862cffa7677784df1b8fb88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971046 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#725441}
-
Nate Fischer authored
This creates AwStabilityMetricsProvider, which listens to content layer notifications to implement some stability metrics. This is a subset of what ChromeStabilityMetricsProvider does at the moment. This now implements: * system_profile.stability.launch_count (all that was necessary was to persist a pref) * system_profile.stability.page_load_count * system_profile.stability.renderer_hang_count * system_profile.stability.renderer_launch_count Other stability fields will be implemented in a follow-up change. Fixed: 994834 Bug: 994839 Test: run_android_webview_unittests --gtest_filter=AwStabilityMetricsProviderTest.* Test: Manual - verify fields with AndroidX demo app Change-Id: Ibf199889b2caf138c62a6aee71749a3cefbbb625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966697Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#725440}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3945.66-1575891900-benchmark-80.0.3987.5-r1 to 80-3987.0-1576497572-benchmark-80.0.3987.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If1ffa0bb8535f66e40feb09f74997acb87888782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971253Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6153165d78f2..fdb2b7d53038 git log 6153165d78f2..fdb2b7d53038 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 herb@google.com Add more thread annotations to SkStrike 2019-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d1860ea17e8e..5407aaa089ac (11 commits) Created with: gclient setdep -r src/third_party/skia@fdb2b7d53038 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I3e2869d32502c01df2b38462dd112b4fef6a27de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971250Reviewed-by:
-
Alan Cutter authored
ShowPWAInstallBubble() was assuming the browser for the WebContents had a PWA install icon when this is not always the case. Bug: 1033608 Change-Id: I29026b6cacbfc6f73a84e62935f395df11eacbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970306 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#725437}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/408a0c7a..29760046 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icee17c1aad134f9565b3e66c27dbc1bc3c217413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970148Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725436}
-
Fergus Dall authored
memlog_browsertest.cc includes //chrome/common/chrome_switches.h which depends on a generated //chrome/common/buildflags.h, but does not specify this dependency in its BUILD.gn. Because of this, the build will sometimes fail, depending on the order objects are built in. TBR=ajwong@chromium.org TBR=alph@chromium.org TBR=erikchen@chromium.org Bug: 952918 Change-Id: I3d9e80b9e32fe32f008299b047f5ada815d51f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971183Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#725435}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_party/blink/renderer/core/layout only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - CustomScrollbar::CreateCustomScrollbar Bug: 939691 Change-Id: I8d36d02e45569591cf40aaa90b8206090b704b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971032Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#725434}
-
Fergus Dall authored
TBR=layout-dev@chromium.org Bug: 1034839 Change-Id: I4213c437d76e9868f50b1525a6d2ac7b6d1d6456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971176Reviewed-by:
-
Timothy Loh authored
Change-Id: I951eec1d645a17278742386e58a24bd4883daf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971182Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#725432}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I8e40c2f97ac725ff1db8e3ee50e0ca62a3877d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970143 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 6606 Change-Id: I023f300ac8055bd5e9c37efbb7a10fef5dcf1f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970071 Commit-Queue: Rob Buis <rbuis@igalia.com> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#725430}
-
Maggie Chen authored
This is ported from V1 for Linux only. Don't crash the GPU processor if Chrome is not on the TTY of our host X11 server. It's expected to be slow. Bug: 949839 Change-Id: I497582c48e8b0d1d9f648ed4abd04882170738d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969775 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#725429}
-
Ted Meyer authored
Change-Id: I8452be4bc6ab0fe28246cd4dd3560491f017dd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971070 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#725428}
-
Kent Tamura authored
This is a reland of 982f6f23 The difference from the original CL: - xml/BUILD.gn: Fix gcc build Original change's description: > xpath_grammar.y: Switch to C++ parser > > We used non-standard alloca() in Bison-generated C parser because the > semantic union object contains raw pointers of Oilpan objects and they > need to be on stack. > > We'd like to avoid non-standard alloca(), and would like to manage > lifetime of union member objects correctly. So, we switch to > Bison-generated C++ parser with 'variant' semantic object. It allocates > the stack of semantic objects in the normal heap, and correctly > construct and destruct each member objects. We can use WTF::String and > blink::Persistent as members without any hacks. > > * rule_bison.py > Replace xpath_grammar_generated.hh with xpath_grammar_generated.h on > preprocessor directives such as #include and #line. > > * xml/BUILD.gn > Move xpath_grammar_generated.* and xpath_parser.cc to a separated > target, and it disables chromium-style clang plugin. > chromium-style plugin produces errors on xpath_grammar_generated.h. > > * xml/xpath_grammar.y > Switch to C++ parser. > Switch to 'variant' from 'union'. > Add missing |$$ = $1|. > Remove unnecessary DeleteString() calls. > > * xml/xpath_parser.cc > Adopt to the Bison-generated C++ parser. > Remove unused |strings_| code. > > * audit_non_blink_usage.py > Allow xpathyy:: namespace in core/xml/. > > > Change-Id: I1b4f3a224dca058bee83518573d1482259f221bf > Bug: 1032320 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961464 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725348} Tbr: dcheng@chromium.org Bug: 1032320 Change-Id: Id0e4983308b78bce1e8ba597460df2fc9d4bc869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971171Reviewed-by:
-
Fergus Dall authored
TBR=xr-dev@chromium.org Bug: 1034841 Change-Id: I2c9f3af01bb2bf7a58710dc25a6cd819cc3a8fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971180Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d78a9b45b9e5..6153165d78f2 git log d78a9b45b9e5..6153165d78f2 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b1568f29..98b390c9 (401 commits) Created with: gclient setdep -r src/third_party/skia@6153165d78f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ibd1655ceb9228d39f029792bdb0d5ab2a1e0cf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971210Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e45b256a. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 0f40bb89 "Enable the CSS image-orientation always" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I1eb01132cd58b23cd8810ecd60fa7e552a1aa450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970147Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725424}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/75d4d0376360..45a70dc772a6 git log 75d4d0376360..45a70dc772a6 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 dberris@chromium.org Always provide an array of result_values Created with: gclient setdep -r src/third_party/catapult@45a70dc772a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1034786 Tbr: rmhasan@google.com Change-Id: I5b49451c7352bffa7a6b8f044ca095837111087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971211Reviewed-by:
-
Navid Zolghadr authored
Make NGLayoutResult to use passkey pattern and move the private constructors to public and remove friend keywords. Change-Id: I206aa5889481e05355bf81bc965449294b0de475 Bug: 1030176, 939691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971036Reviewed-by:
-
Jon Mann authored
This is a more robust method of re-applying focus to an iron-list after the underlying data changes. The current method breaks during oobe and updates the list more often than needed. Bug: 1031994, 1032265 Change-Id: Ibc115fa099f80c1da0fd872f00a84472b9ff8c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966581 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#725421}
-
Jon Mann authored
Previously, focus would jump to the first element when the underlying data was updated. Bug: 1030825 Change-Id: I78ae75f3230e3b09c0d286677cbfbbbf6ed8bab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954273 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
-
Ana Salazar authored
Add metrics for hotseat transitions in the in-app shelf, i.e. hiding or extending the hotseat. We only had metrics for transitions from the in-app shelf to the show launcher, so we extended the TransitionAnimationMetricsRocorder to also include the transitions within the in-app shelf as a separate category. Bug: 10221769 Change-Id: Ib55692f412410b59ce9f626ce2424ece003184d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963102Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#725419}
-
Ricky Liang authored
Move switches::kVideoCaptureUseGpuMemoryBuffer from //media/base:base to a simple component //media/capture:capture_switches. The switch is needed by multiple components and //media/base:base causes dependency loop. Bug: 982201 Change-Id: I5351f3e30f6672f53268366e67c640a0e05094f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967094 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#725418}
-
Victor Costan authored
The enum's values are persisted to disk. Make the values explicit, and add a comment warning against deleting / renumbering values. Change-Id: I10761ecd987e23f38302e201ad0345dccb05866e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969246 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#725417}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_party/blink/renderer/modules/webusb only when it meets the policy of removing Create() so that we support only one of Create() methods or public constructors in a class. Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below Create() functions, - USBDevice::Create - USB::Create - USBDevice::Create Bug: 939691 Change-Id: I3a1965c3d108422f1d09a9c5c80e93476e71bad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965746 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#725416}
-
