- 29 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/018f5f6dccd6..67e1cf4b1d81 2020-10-28 johnstiles@google.com Replace pooling mechanism with GrMemoryPool. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I715b329f5f37b80043394b1e82535c8fb45707d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822002}
-
Shakti Sahu authored
This CL contains a few UX polish 1 - Bottom margin between IPH card and the next cards on NTP 2 - Loading screen - Added Loading... text 3 - Used TextButton style for buttons in the player Bug: None Change-Id: I9f38ea1dc154332fafbfd5643448a2c15a15f646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506511Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822001}
-
Shannon Chen authored
Making the vertical line and horizontal line sweep across the screen. Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: I80278b756d92b085f4b6074a0443c07487066875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490274 Commit-Queue: Shannon Chen <shannc@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822000}
-
David Black authored
Previously we removed all holding space item views when closing the holding space tray bubble. This was due to lifecycle concerns since it is possible for holding space item views to outlive their delegate due to the holding space bubble widget being asynchronously destroyed. Removing child views during a destruction sequence can have unintended side effects as it can trigger re-layout, as was the case in this crash. This CL removes the logic which removed child views when closing the bubble widget as item views only interact with the delegate in response to UI events which should not occur when the widget is being closed. Bug: 1143426 Change-Id: Ie0548401b8672c2c0c3b571e45c80900edd53b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506513Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#821999}
-
Xing Liu authored
Delete metric Download.ParallelDownload.CreationEvent. Bug: 1142493 Change-Id: Id2fbf8c447afaa45c3bc3db3e9e42c78518d41fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500449Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821998}
-
Patti authored
This reverts commit 85415a2c. Reason for revert: Suspected for tree closing compile error described in crbug.com/1143504 - optimize_webui.py failures. Original change's description: > OS Settings: Autogenerate grd files > > Bug: 1132403 > Change-Id: Ief77c7d304940fa9eec0c553d91674c0806cb790 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493991 > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821744} TBR=khorimoto@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: I6aed7b6ca7003e5baf616520bf901ced8bd527a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403, 1143504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505699 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#821997}
-
Patti authored
This reverts commit b9c180c8. Reason for revert: Merge conflicts with actual revert for tree closing compile error described at crbug.com/1143504 - reverting both patches to be safe. Original change's description: > OS Settings: Move grit() target to settings/chromeos > > Followup from > https://chromium-review.googlesource.com/c/chromium/src/+/2493991 > > Bug: 1132403 > Change-Id: Idc2d9473feef2ad9746473a6bd8724a2f15616ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505955 > Reviewed-by: dpapad <dpapad@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821810} TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: I71d85c4595988a1b93aabf0ebe59e32e61c4c6fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403, 1143504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505356Reviewed-by:
-
Sammie Quon authored
This was left behind since the algorithm was changing during feature implementation, but now the core of the feature has been committed this can be addressed. Test: none Bug: 1111445 Change-Id: I0927ca46ffa8378a8d837cc32045d7c0b98e3167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493722 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#821995}
-
Jason Lin authored
Previously, we do some initialization in PluginVmManagerImpl when the primary profile is prepared. The initialization steps are: 1) reset some permissions stored as prefs 2) kill plugin vm dispatcher if chrome has crashed When a user with custom flags signs in, Chrome restarts itself, which causes the initialization steps to be run twice, which is unnecessary. What's worse, the first time they are run they don't "see" the custom flags, but we will soon need to make step 1 to be conditioned by a custom flag. Doing the initialization when the primary session is started solves these problems. Bug: b/167491603 Test: manually test that the initialization steps are still working Change-Id: I91dbb002e1f9c24ea4cb090a89e8241716a358e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503758Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I865d374b380b6c1bd5dc60380cb56a7ddb6bae16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506371Reviewed-by:
-
Mark Mentovai authored
Disk images produced with this compression can only be created and mounted on macOS 10.15 (“Catalina”) and later. This may be useful in the near term for things shipped to arm64 users, as the baseline OS for mac-arm64 is macOS 11.0 (“Big Sur”). This also adds ULFO (lzfse/lzvn) support to pkg-dmg, but that’s not interesting and I doubt we’ll ever use it. Bug: 1130557 Change-Id: I1ba54b8fcc0a69d8770af98a364123b64e24423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505683Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821992}
-
Jimmy Gong authored
Bug: 1106937 Fixed: 1141604 Test: chromeos_components_unittests Change-Id: I033f8685061d9e5f2cfc30218786abcf89723f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503895 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821991}
-
Liquan (Max) Gu authored
Before the CL, ChromePaymentRequestFactory.sObserver was used before assigned in production code. To fix it, this CL null-check the observer, suffix it with "ForTest", and annotate it with @Nullable. This CL also add unit-tests for ChromePaymentRequestFactory which is able to capture this crash. Bug: 1143141 Binary-Size: Recovering after the wrong reduction of crrev.com/c/2499323 Change-Id: I6947fcee22d07c7641c9d22bb63defb1306c9079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504283Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821990}
-
Jan Wilken Dörrie authored
This change fixes up the GstaticFetchHttpResponseCode and GstaticFetchResult histograms in PasswordManager.WellKnownChangePassword to use `enum` instead of `units`. R=chromium-metrics-reviews@google.com Bug: 927473 Change-Id: I23e8838e065dd21bc433747f64a54d2a85da6f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485229 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821989}
-
Olivier Li authored
This is a change in preparation of logging hang count histograms per thread type. Bug: 1135528 Change-Id: I96dc1e114ac170f5ff9a32eedd57dd19ea97b152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505451 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#821988}
-
Ewann authored
This CL postpones the expiration of a year. Bug: 1140087 Change-Id: I58bccf3917e9e6edd3effc629918fcee44c643b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502336 Auto-Submit: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
Moe Ahmadi authored
Allows using NTP features in MostVisitedSites and related services in components/ Fixed: 1143475 Change-Id: I673bed5c25651acca3ef7c44512567599bb6b9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504639 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821986}
-
Sujie Zhu authored
Remove server nickname metrics logging since the feature is fully enabled and we don't need to maintain metrics for analysis post launch. Bug: 1059087 Change-Id: I07a6b8a0fc277bcf7634a26842930ed0d5978316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495794 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#821985}
-
Alexander Timin authored
Add //ui/base/mojom as a dependency for //third_party/blink/public/mojom:mojom_core as LocalMainFrameHost depends on ui.mojom.WindowOpenDisposition as it's a parameter for LocalMainFrameHost::ShowCreatedWindow. TBR=danakj@chromium.org R=oksamyt@chromium.org Change-Id: Iaed399ab440c17d4607b778fab7b65fec296a676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506173 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#821984}
-
Alexandre Courbot authored
The video decoder factory object needs to know the size of MediaLog in order to be instantiated. Include the header containing its definition so users don't have to do it. BUG=None TEST=Chromium builds. Change-Id: Idce313f58565f0b71788453d443910b5cc0a3647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503912 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821983}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/c23a5652bda1..5ede1190cf97 2020-10-28 dsinclair@chromium.org [hlsl-writer] Add read-only storage buffers. 2020-10-28 dsinclair@chromium.org [msl-writer] Add read-only storage buffers. 2020-10-28 dsinclair@chromium.org Rename unwrap helpers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: I0dbdb182204bef385aca6dd4f69fb268776188c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506456Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603884477-73d70e68a4c2b6db53055c0ce78d0123cab0e9a7.profdata to chrome-mac-master-1603907949-48bee2a7f2855ac438725bf6194390f836d0af96.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8d645b079a2fc5b35efdc1a251f568be35420c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506258Reviewed-by:
-
Chait Pinnamaneni authored
Original PR which disabled layout test: https://chromium-review.googlesource.com/c/chromium/src/+/2463929 Explainer for this feature is https://docs.google.com/document/d/14qJ1rZyMtnIa8hPJc1V8DJRxk4lVI3hlWYGvBDICog0/edit?ts=5f7c13ce Bug: 1137050 Change-Id: I2adec2db2a536af6ffa5e1b8daab7ab0344ba1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504690 Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#821980}
-
James Cook authored
Measure how long it takes from before the binary is launched until the lacros binary replies with the AshChromeService mojo interface. This is a reasonable approximation of the time until ash can start communicating with lacros. This will help determine if the performance in the field matches what we see in internal benchmarks and tracing. Bug: 1137977 Change-Id: I88210545615076a90c74d2a3f4fabf6383f20926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500959 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821979}
-
Joe DeBlasio authored
Bug: 1076617 Change-Id: I5d818d4db60fad9e4cdc8e862d82a5bff6372560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505583 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Yu Su authored
Currently Cronet disables 0-RTT features for all POST requests, as they are not considered idempotent. But for Youtube /videoplayback request, we are POSTing client abr state information. We want to create an option in Cronet UrlRequestParams to specify enabling 0-RTT when creating idempotent requests. This cl only makes it available for iOS. Enabling 0-RTT for idempotent request in Android interface will be implemented in the next cl, since it requires a different env. Change-Id: Id2f1aa1fd89c654d6a374cb70566c6c72e18233e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497468Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#821977}
-
Brandon Wylie authored
Currently the post-layout translation is taken into account for both focused and unfocused states. This should only be applied when focused because that's the only time the url bar is translated post-layout. Bug: 1135898 Change-Id: Ie805e6d638c0c9c86e08c1ca6e5dfc8d08451aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458888 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#821976}
-
Julie Jeongeun Kim authored
As blink::mojom::ResourceType is deprecated[1], this CL removes |type| from WebRequestInfoInitParams and WebRequestInfo. Instead, they use |web_request_type| converted using ToWebRequestResourceType(). [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I1d06f264c78ec3f3da171ab7899b1e225768f891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426064 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821975}
-
Ryan Sturm authored
When the --enable-search-prefetch-service flag is passed into Chrome, various conditions should be modified to be easier to test behavior locally. Change-Id: Ic78f795c923f9fd6c4a5c178c3517980db0077dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505742Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821974}
-
Matt Falkenhagen authored
Most of the code was already written assuming not in content namespace, so just remove it. Change-Id: I7b637c8b372da83ce16be85eac0a238f15b6568b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479882Reviewed-by:
-
David Tseng authored
Value changes (either previously or in its new value in text field changed) events were never used to process output for content editables nor text areas. Doing so will at least be more costly if not cause unwanted output. Fixed: 1143161, 1143157 AX-Relnotes: n/a R=dmazzoni@chromium.org, nektar@chromium.org Change-Id: I3e7414b9df3853d6e86409db7bc398fb8a8f80d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506469Reviewed-by:
-
Hitoshi Yoshida authored
navigation/post-frames-goback1.html expects to call a function when it navigates back from resources/go-back.html. However, if we enable same-site backward/forward cache, we don't handle onload event and the function isn't called again. This CL fixed the test to work as expected. Bug: 1136383 Change-Id: Ibfac773230fcadd52cbeacfa399c4b55425afb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503911Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#821971}
-
wutao authored
This patch extracts the ambient view ids from assistant view ids and adds DCHECK in test for better debugging. Bug: b/171901133 Test: Add DCHECK Change-Id: I4ba1d4d37c543773fa18f10168d4906ca53c56d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506398Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#821970}
-
Ian Vollick authored
This reverts commit 1c5d9e6d. Reason for revert: appears to be causing flake. Reverting to check. Original change's description: > Add activation-related trace events > > Adds trace events to HTMLPortalElement::activate, > RFHI::OnPortalActivated and PortalHost::OnPortalActivate. > In order to correlate the flow events, a trace id > is plumbed through activation flow. > > Bug: 1137916 > Change-Id: I8841dff33bfeaf91adc58722311672db8aa59210 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439016 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821749} TBR=vollick@chromium.org,dcheng@chromium.org,altimin@chromium.org,adithyas@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org Change-Id: Ibaffedf5a48ad74f55ab54003dd2fa22e9123338 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506559Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#821969}
-
Alex Turner authored
base::Bind, base::Callback and base::Closure are deprecated and should be replaced with the more explicit base::Bind{Once,Repeating}, base::{Once,Repeating}Callback and base::{Once,Repeating}Closure. This cl converts most uses, but ClientReportPhishingRequestCallback is left for a follow-up cl. This is due to non-trivial required test changes. The follow-up should also remove the directory from the legacy exception list in PRESUBMIT.py. Bug: 1141564 Change-Id: I89504921c1a590872d1883e0173c238ca587b204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493044Reviewed-by:Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#821968}
-
Hidehiko Abe authored
Currently, system time is used in WaylandTest. However, it turns out that, in order to fix other test (key repeating tests), we need precise control of timing. This CL switches the timer as its preparation. The actual fix of key repeating tests will follow. Note that key repeating tests are not working as intended, and even with this CL they are not fixed yet. However, they pass now at least, and this CL should not make regressions which could cause of blocking CQ/CI. Bug: 1141473 Test: Ran ozone_unittests locally. Change-Id: Ifdc2768561e373c9170385a1aee43dae424c7b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503996Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821967}
-
Erik Chen authored
This CL implements GetCertificates, GenerateKey, ImportCertificate and RemoveCertificate extension APIs for Lacros. Most of the CL is generic plumbing. One decision in this CL is to pass certificates as byte arrays between Lacros to Ash. Another approach would have been to use network.mojom.X509Certificate. This structure just serializes the leaf certificate, along with any intermediates. This would risk Mojo errors whenever the net::X509Certificate parser changes. Instead this CL uses byte strings in the mojom interface. Ash parses and serializes net::X509Certificates, and Lacros passes the byte strings directly to the extension. Note the enterprise.platformKeys API does not take or return intermediate certificates, so the mojom interface only sends the leaf. Another decision in this CL is to use a string param |named_curve| in KeystoreECDSAParams. platform_keys_service_nss.cc only supports one curve: P-256. However, all the plumbing in both lacros and ash assumes that there's a string parameter to the GenerateKey() plumbing. It would be possible to parse and error check in Lacros, send as an enum, and then convert the enum in ash back into a string. This adds plumbing for no perceivable benefit since platform_keys_service_nss also performs the same parsing and error checking. This CL adds basic integration tests that confirm that the IPC is working appropriately. Additional work is necessary to flush out the full integration testing surface. Change-Id: Ia91f20ca2adc6e04ca14509b8e1a8185aeb98d69 Bug: 1127505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488755Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821966}
-
Jared Saul authored
Code was previously removed, but apparently the flag-metadata entry should be removed too, otherwise it'll keep nagging. :) Fixed: 1143336 Change-Id: I90d0efca147a9221dfc05f132cd696c4457a43dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505947Reviewed-by:
-
Aaron Krajeski authored
First step on the way of getting non-affine transforms into canvas2D. Right now this is a no-op. Trying to keep the CLs small. CanvasRenderingContext2DState now stores a TransformationMatrix, which is a generic 4x4 matrix instead of an AffineTransform, which is one of those 2x3s used to encode 2D rotation/skew and a translation in the 3rd column. For operations that require an affine transform, there's an explicit GetAffineTransform method that constructs one. Also, CanvasRenderingContext2DState->Transform() has become CanvasRenderingContext2DState->GetTransform() on juanmihd@s sage advice, which is the bulk of this change. Bug: 1140535 Change-Id: I5630e48747dcfc7b7b27f25f1dc1a7cdd8860408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490821Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#821964}
-
Nate Chapin authored
Change-Id: I518b2781541cfa169cdb1b6c4b5dea729c0a796b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493087 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821963}
-
