Commits · 5514928db622ba5eba249127115cef28e961eb48 · eriksson monteiro / tangled

18 Jul, 2014 40 commits

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284189 0039d316-1c4b-4281-b951-d872f2087c98

5514928d

revert Skia back to before XP bots started failing · 8a1795a8

scottmg@chromium.org authored Jul 18, 2014

speculative revert to try to resolve XP bot binaries not launching.

R=dpranke@chromium.org
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/407623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284188 0039d316-1c4b-4281-b951-d872f2087c98

8a1795a8

Revert of [Telemetry] Fix a flake in android browser finder.... · 70fcbab8

tonyg@chromium.org authored Jul 18, 2014

Revert of [Telemetry] Fix a flake in android browser finder. (https://codereview.chromium.org/394423002/)

Reason for revert:
BUG=395228

Original issue's description:
> [Telemetry] Fix a flake in android browser finder.
> 
> Traceback (most recent call last):
>   File "tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper
>     func(*args, **kwargs)
>   File "/b/build/slave/Android_Tests/build/src/tools/perf/benchmarks/benchmark_unittest.py", line 51, in BenchmarkSmokeTest
>     self.assertEqual(0, SinglePageBenchmark().Run(options),
>   File "tools/perf/../telemetry/telemetry/benchmark.py", line 84, in Run
>     results = page_runner.Run(test, ps, expectations, args)
>   File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 346, in Run
>     possible_browser = browser_finder.FindBrowser(finder_options)
>   File "tools/perf/../telemetry/telemetry/decorators.py", line 26, in Cacher
>     cache[key] = obj(*args, **kwargs)
>   File "tools/perf/../telemetry/telemetry/core/browser_finder.py", line 73, in FindBrowser
>     curr_browsers = finder.FindAllAvailableBrowsers(options)
>   File "tools/perf/../telemetry/telemetry/core/backends/chrome/android_browser_finder.py", line 214, in FindAllAvailableBrowsers
>     pids  = [p.pid for p in psutil.process_iter() if 'adb' in p.name]
>   File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 161, in name
>     cmdline = self.cmdline
>   File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 188, in cmdline
>     return self._platform_impl.get_process_cmdline()
>   File "/usr/lib/python2.7/dist-packages/psutil/_pslinux.py", line 327, in wrapper
>     raise NoSuchProcess(self.pid, self._process_name)
> NoSuchProcess: process no longer exists (pid=13764)
> 
> Observed here:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14626/steps/telemetry_perf_unittests/logs/stdio
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284144

TBR=dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/407633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284187 0039d316-1c4b-4281-b951-d872f2087c98

70fcbab8

Fix infinite loop around FocusManager.onDocumentFocus_() when getFocusParent()... · 70ff25dc

alekseys@chromium.org authored Jul 18, 2014

Fix infinite loop around FocusManager.onDocumentFocus_() when getFocusParent() returns document.body (encountered the problem trying to add FocusManager to Print Preview).

BUG=276784

Review URL: https://codereview.chromium.org/398243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284186 0039d316-1c4b-4281-b951-d872f2087c98

70ff25dc

Update .DEPS.git · 054550b8

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284185 0039d316-1c4b-4281-b951-d872f2087c98

054550b8

Blink roll 178434:178453 · 8dc2e09d

blink-deps-roller@chromium.org authored Jul 18, 2014

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178435:178453&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/406593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284184 0039d316-1c4b-4281-b951-d872f2087c98

8dc2e09d

Added frequency stats and c-state residency to CrOS power monitor. · dcf3f642

tmandel@chromium.org authored Jul 18, 2014

BUG=336561

Review URL: https://codereview.chromium.org/352583007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284183 0039d316-1c4b-4281-b951-d872f2087c98

dcf3f642

Apps&Extensions for supervised users: Cleanup · bddf240a

treib@chromium.org authored Jul 18, 2014

Remove an obsolete "already loaded" check.
Allow all component locations, not just Manifest::COMPONENT.

BUG=none

Review URL: https://codereview.chromium.org/404773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284182 0039d316-1c4b-4281-b951-d872f2087c98

bddf240a

Add adb version check to adb_remote_setup.sh. · 65a0687a

newt@chromium.org authored Jul 18, 2014

This ensures that the local and remote versions of adb are the same,
since using different versions of adb will probably result in protocol
errors.

NOTRY=true

Review URL: https://codereview.chromium.org/395393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284181 0039d316-1c4b-4281-b951-d872f2087c98

65a0687a

Video Player: Add a message which is shown on casting · 94bd40d9

yoshiki@chromium.org authored Jul 18, 2014

This patch shows a message like "Playing on xxxx", andd adds the dummy video element which will be used to control the casting video.

BUG=305511
TEST=none

Review URL: https://codereview.chromium.org/397813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284180 0039d316-1c4b-4281-b951-d872f2087c98

94bd40d9

IndexedDB: Fix coding style issues c/o cpplint.py · f3c1e7f6

jsbell@chromium.org authored Jul 18, 2014

Most of these are non-const refs that should be pointers.

BUG=381456
TBR=dgrogan@chromium.org

Review URL: https://codereview.chromium.org/405433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284179 0039d316-1c4b-4281-b951-d872f2087c98

f3c1e7f6

Add initial components unit tests to GN build. · 0260b7a9

brettw@chromium.org authored Jul 18, 2014

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/398423007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284178 0039d316-1c4b-4281-b951-d872f2087c98

0260b7a9

Make NativeViewHostAura clipping window non-focusable. · e8e29424

calamity@chromium.org authored Jul 18, 2014

This CL fixes an issue where the clipping window would get a focus event
when the SadTab was displayed causing the focus to be set to nothing,
disabling all keyboard shortcuts.

This is fixed by making the clipping window nonfocusable.

BUG=393119

Review URL: https://codereview.chromium.org/397493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284177 0039d316-1c4b-4281-b951-d872f2087c98

e8e29424

[Ozone-DRI] Migrate cursor to using ScanoutBuffer · b794b3fa

dnicoara@chromium.org authored Jul 18, 2014

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/407603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284176 0039d316-1c4b-4281-b951-d872f2087c98

b794b3fa

Disable PrerenderOmniboxBrowserTest.PrerenderOmniboxCancel · 6627e73f

waffles@chromium.org authored Jul 18, 2014

TBR=gavinp
BUG=395152

Review URL: https://codereview.chromium.org/406603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284175 0039d316-1c4b-4281-b951-d872f2087c98

6627e73f

Revert of [DevTools] Move DevToolsWindow testing code to a separate class.... · a9cc57a8

gab@chromium.org authored Jul 18, 2014

Revert of [DevTools] Move DevToolsWindow testing code to a separate class. (https://codereview.chromium.org/395783002/)

Reason for revert:
Mac 10.7 has become flaky for ViewIDTest.Basic (http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%282%29?numbuilds=100) and this CL is suspected as it touches this exact test.

Example crash stack trace below:

BrowserTestBase signal handler received SIGTERM. Backtrace:
0   browser_tests                       0x0132e9ba base::debug::StackTrace::StackTrace() + 26
1   browser_tests                       0x04e5ecb8 _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 72
2   libsystem_c.dylib                   0x9090259b _sigtramp + 43
3   ???                                 0xffffffff 0x0 + 4294967295
4   browser_tests                       0x01328f56 base::AtExitManager::RegisterCallback(void (*)(void*), void*) + 102
5   browser_tests                       0x02614bb4 Singleton\u003Ccc::TaskRunnerPairs, DefaultSingletonTraits\u003Ccc::TaskRunnerPairs>, cc::TaskRunnerPairs>::get() + 276
6   browser_tests                       0x026141e7 cc::BlockingTaskRunner::current() + 23
7   browser_tests                       0x02614762 cc::BlockingTaskRunner::CapturePostTasks::CapturePostTasks() + 18
8   browser_tests                       0x026404eb cc::SingleThreadProxy::Stop() + 59
9   browser_tests                       0x02619e04 cc::LayerTreeHost::~LayerTreeHost() + 132
10  browser_tests                       0x0261a2c1 cc::LayerTreeHost::~LayerTreeHost() + 17
11  browser_tests                       0x04011e94 ui::Compositor::~Compositor() + 148
12  browser_tests                       0x040120c1 ui::Compositor::~Compositor() + 17
13  browser_tests                       0x03fa8dfd -[BrowserCompositorViewCocoa .cxx_destruct] + 173
14  libobjc.A.dylib                     0x995863bf object_cxxDestructFromClass + 104
15  libobjc.A.dylib                     0x99583204 objc_destructInstance + 40
16  browser_tests                       0x021dd2c2 (anonymous namespace)::ZombieDealloc(objc_object*, objc_selector*) + 98
17  AppKit                              0x96b68b39 -[NSResponder dealloc] + 156
18  AppKit                              0x96b66fee -[NSView dealloc] + 74
19  libobjc.A.dylib                     0x9958254e _objc_rootRelease + 47
20  browser_tests                       0x03fa7f16 base::LazyInstance\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa>, base::DefaultLazyInstanceTraits\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa> > >::OnExit(void*) + 38
21  browser_tests                       0x013291e2 base::internal::Invoker\u003C1, base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid (*)(void*)>, void ()(void*), void ()(void*)>, void ()(void*)>::Run(base::internal::BindStateBase*) + 18
22  browser_tests                       0x01328e27 base::AtExitManager::ProcessCallbacksNow() + 119
23  browser_tests                       0x01328ec2 base::AtExitManager::~AtExitManager() + 34
24  browser_tests                       0x013bbb20 base::TestSuite::~TestSuite() + 48
25  browser_tests                       0x00b5f783 ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) + 51
26  browser_tests                       0x012fd642 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 34
27  browser_tests                       0x04e97e42 content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 738
28  browser_tests                       0x012fd5f3 LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) + 67
29  browser_tests                       0x00b5f73d main + 77
30  browser_tests                       0x00039635 start + 53
31  ???                                 0x0000000b 0x0 + 11

Original issue's description:
> [DevTools] Move DevToolsWindow testing code to a separate class.
> 
> This change:
> - allows for proper docking testing (including toolbox);
> - removes all test friends from DevToolsWindow;
> - unifies testing approach to use load callback instead of notifications;
> - adds simple toolbox tests.
> 
> BUG=393566
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284050

TBR=pfeldman@chromium.org,lushnikov@chromium.org,sky@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393566

Review URL: https://codereview.chromium.org/403833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284174 0039d316-1c4b-4281-b951-d872f2087c98

a9cc57a8

Update .DEPS.git · 197c92cc

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284173 0039d316-1c4b-4281-b951-d872f2087c98

197c92cc

Roll pdfium. This brings in: · b0c19d04

thakis@chromium.org authored Jul 18, 2014

6256a14  Fix pdfium building issue on VS2010
5eb9f7b  pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac.
a9c29e0  Fix garbled text when loading linearized pdf document
c7cd3c8  Fix building pdfium for x64 with ninja under windows.
3fb18f4  Hook up the default v8::Platform implementation to pdfium

BUG=260112, 249006, 275281, 354966, 365302, 236952
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/398273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284172 0039d316-1c4b-4281-b951-d872f2087c98

b0c19d04

Fixes for wifi side of GCD prototype · 16ee2632

noamsml@chromium.org authored Jul 18, 2014

1.  Moved actual device indicator to config.json
2.  Wireless interface now part of config.json
3.  LED path now part of config.json
4.  udhcpd config now generated by script

This should make the script a fair bit more robust and allow it to work on any
machine.

In addition, updated the SSID to the new format.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/405483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284171 0039d316-1c4b-4281-b951-d872f2087c98

16ee2632

Adding a router class to handle messages that expect responses. · acc18a83

qsr@chromium.org authored Jul 18, 2014

This also introduce the notion of message header to allow routing.

R=rmcilroy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767

Review URL: https://codereview.chromium.org/371603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284170 0039d316-1c4b-4281-b951-d872f2087c98

acc18a83

[Password Generation] Trigger confirmation bubble when a password is saved · d07e19ac

gcasto@chromium.org authored Jul 18, 2014

BUG=318977

Review URL: https://codereview.chromium.org/399573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284169 0039d316-1c4b-4281-b951-d872f2087c98

d07e19ac

Update .DEPS.git · 6db3d352

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284168 0039d316-1c4b-4281-b951-d872f2087c98

6db3d352

Roll ICU to icu52 · 9ba3fbcd

jshin@chromium.org authored Jul 18, 2014

The ICU update does the following among other things:
  - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
    encoding spec.
  - Add CP866
  - Add far better/more extensive support for plural, format, etc
  - Numerous locale data update
  - Khmer/Lao line/word-breaking support
  - More compact Chinese/Japanese dictionary (now a part of the upstream
    instead of our local patch)
  - Better plural support that we plan to use right away.

- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
  a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
     remove JIS X 212 code points from the round-trip test
  b. l10n_util_unittests: Display names for zh-*.
  c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
  d. Update Expected results in file_manager_browsertest/test_util.js
     (see http://crbug.com/383930)
- Update SpellcheckerWordIterator
  a. Add U+0027 back to MidNumLet
  b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
     word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
  has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
  dictionary any more. It's now a part of ICU

Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.

2.  http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.


BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
     browser_tests (encoding related, Iden*verifyGet*),
     unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
     layout tests (encoding, date/calendar, line breaking, and others),
     build 'base_i18n_nacl', GN build bots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111

R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org

Review URL: https://codereview.chromium.org/265613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284167 0039d316-1c4b-4281-b951-d872f2087c98

9ba3fbcd

ui/gfx: optimize UnPreMultiply operation by checking alpha value · bb9e9d43

hyunki.baik@samsung.com authored Jul 18, 2014

Don't need to do Un-premultiplying operation,
if alpha value equals to 0 or 255.

BUG=none
Test(DONE)=gfx_unittests --gtest_filter="ColorAnalysisTest*"

Review URL: https://codereview.chromium.org/399053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284166 0039d316-1c4b-4281-b951-d872f2087c98

bb9e9d43

Currently, bionic only build a subset of the examples. This changes turns on... · 7539b931

noelallen@chromium.org authored Jul 18, 2014

Currently, bionic only build a subset of the examples. This changes turns on all the examples and tests compiling those examples.

BUG=344574
R=sbc@chromium.org, binji@chromium.org

Review URL: https://codereview.chromium.org/339393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284165 0039d316-1c4b-4281-b951-d872f2087c98

7539b931

Don't drop all children when changing Android root layer. · 25950ad2

aelias@chromium.org authored Jul 18, 2014

Unlike when this method was originally written, there can now be a
second child, a readback layer.  If the root layer happens to change
while a readback is active, it will never complete, hanging the
rendering.

NOTRY=true
BUG=386337

Review URL: https://codereview.chromium.org/407433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284164 0039d316-1c4b-4281-b951-d872f2087c98

25950ad2

Update .DEPS.git · d690b7d3

chrome-admin@google.com authored Jul 18, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284163 0039d316-1c4b-4281-b951-d872f2087c98

d690b7d3

Skia roll 19eb3b2:63f413c · 7d6b2952

skia-deps-roller@chromium.org authored Jul 18, 2014

https://skia.googlesource.com/skia/+log/19eb3b2f0aa6dce5c0335230a8930e90733e5d5d..63f413ce94358e3e76dca66218c7da20fec18569

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/401713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284162 0039d316-1c4b-4281-b951-d872f2087c98

7d6b2952

Split IndexedDBFactory into virtual base + impl. · 8f4c9206

jsbell@chromium.org authored Jul 18, 2014

This change makes IndexedDBFactory a virtual base class, and what was
IndexedDBFactory is now IndexedDBFactoryImpl. This change will allow tests
to create proper mock factories and not require them to instantiate the
"real" factory (which often doesn't work) in the test. It will also take us
one step closer to eliminating special cases in IDB's other classes where
having a factory is optional (because tests don't create them).

BUG=393974
R=ericu@chromium.org, jochen@chromium.org, jsbell@chromium.org, michaeln@chromium.org

Review URL: https://codereview.chromium.org/313883003

Patch from cmumford@chromium.org <cmumford@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284161 0039d316-1c4b-4281-b951-d872f2087c98

8f4c9206

Docserver: Add TODO for implementing scheduled availability at the object level · 15cc6f4a

ahernandez.miralles@gmail.com authored Jul 18, 2014

NOTRY=True

Review URL: https://codereview.chromium.org/407613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284160 0039d316-1c4b-4281-b951-d872f2087c98

15cc6f4a

sync: Support non-blocking initial sync in proto · 955a206f

rlarocque@chromium.org authored Jul 18, 2014

Adds support for non-blocking initial sync to the sync protocol.  This
allows some types to request an initial sync without having the
scheduler enter configure mode.  The protocol changes are necessary to
keep the server informed that the request is due to an initial sync
request.

The remainder of the changes in this CL were required to plumb
information about the cause of the sync cycle through the SyncScheduler.
This CL also includes some new tests.

At the moment, there are no types in use that support this feature.
This CL will not affect behavior in any way.

BUG=351005

Review URL: https://codereview.chromium.org/387983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284159 0039d316-1c4b-4281-b951-d872f2087c98

955a206f

Drop time from media::{Audio,Video}Renderer::StartPlayingFrom(). · 08602875

scherkus@chromium.org authored Jul 18, 2014

In preparation for migrating to TimeSource, StartPlayingFrom() is
renamed to StartPlaying() with renderers expected to fetch the current
time instead of being provided the time.

AudioRenderer::SetMediaTime() is temporarily added until we can migrate
the interface to being based on TimeSource.

BUG=370634
R=xhwang@chromium.org

Review URL: https://codereview.chromium.org/400853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284155 0039d316-1c4b-4281-b951-d872f2087c98

08602875

[Android] Fix PEN event values · df34bc78

changwan@chromium.org authored Jul 18, 2014

BUG=384803
NOTRY=true

Review URL: https://codereview.chromium.org/397873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284152 0039d316-1c4b-4281-b951-d872f2087c98

df34bc78

re-enable startup benchmarks on Android · 7b87e407

pasko@chromium.org authored Jul 18, 2014

(trybots are probably useless anyway)

Review URL: https://codereview.chromium.org/399053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284151 0039d316-1c4b-4281-b951-d872f2087c98

7b87e407

[Telemetry] Fix a flake in android browser finder. · 8f36d53c

tonyg@chromium.org authored Jul 18, 2014

Traceback (most recent call last):
File "tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper
func(*args, **kwargs)
File "/b/build/slave/Android_Tests/build/src/tools/perf/benchmarks/benchmark_unittest.py", line 51, in BenchmarkSmokeTest
self.assertEqual(0, SinglePageBenchmark().Run(options),
File "tools/perf/../telemetry/telemetry/benchmark.py", line 84, in Run
results = page_runner.Run(test, ps, expectations, args)
File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 346, in Run
possible_browser = browser_finder.FindBrowser(finder_options)
File "tools/perf/../telemetry/telemetry/decorators.py", line 26, in Cacher
cache[key] = obj(*args, **kwargs)
File "tools/perf/../telemetry/telemetry/core/browser_finder.py", line 73, in FindBrowser
curr_browsers = finder.FindAllAvailableBrowsers(options)
File "tools/perf/../telemetry/telemetry/core/backends/chrome/android_browser_finder.py", line 214, in FindAllAvailableBrowsers
pids = [p.pid for p in psutil.process_iter() if 'adb' in p.name]
File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 161, in name
cmdline = self.cmdline
File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 188, in cmdline
return self._platform_impl.get_process_cmdline()
File "/usr/lib/python2.7/dist-packages/psutil/_pslinux.py", line 327, in wrapper
raise NoSuchProcess(self.pid, self._process_name)
NoSuchProcess: process no longer exists (pid=13764)

Observed here:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14626/steps/telemetry_perf_unittests/logs/stdio

BUG=

Review URL: https://codereview.chromium.org/394423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284144 0039d316-1c4b-4281-b951-d872f2087c98

8f36d53c

Remove ericu from WATCHLISTS, upon request · 55a62256

jsbell@chromium.org authored Jul 18, 2014

NOTRY=true
TBR=ericu@chromium.org

Review URL: https://codereview.chromium.org/406643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284143 0039d316-1c4b-4281-b951-d872f2087c98

55a62256

ash: Fix a few leaks in the network list. · 4b6d62b6

sadrul@chromium.org authored Jul 18, 2014

View::RemoveChildView() does not delete the child view. So make sure they
are destroyed correctly.

BUG=none
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/400983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284140 0039d316-1c4b-4281-b951-d872f2087c98

4b6d62b6

Hide the insertion handle when performing a Cut · f2c05bd0

sayan.nayak@samsung.com authored Jul 18, 2014

Make behavior uniform with other apps on Android,
where after a Cut from an editable field, the 
insertion handle is hidden and only the cursor
remains visible.
https://codereview.chromium.org/394953005/

BUG:394781

Review URL: https://codereview.chromium.org/399613008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284138 0039d316-1c4b-4281-b951-d872f2087c98

f2c05bd0

Hook up symbol files to the Windows GN build. · 8d94c765

brettw@chromium.org authored Jul 18, 2014

Previously the GN Windows build specified the symbol file $pdbfile but this variable was never defined, so the command like would just say "/Fd" and the default one would be used.

This patch defines some per-target variables in the ninja file for the toolchain to use. The Windows toolchain uses these to construct C- and C++-specific pdb files (the MS tools can't share between these two) for the current target.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/406453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284137 0039d316-1c4b-4281-b951-d872f2087c98

8d94c765

Mark WebFont.Resource.* histograms as obsolete · 6dbfee52

ksakamoto@chromium.org authored Jul 18, 2014

No longer tracked after Blink r162391.

BUG=246492
NOTRY=true

Review URL: https://codereview.chromium.org/400913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284136 0039d316-1c4b-4281-b951-d872f2087c98

6dbfee52