- 05 Sep, 2018 40 commits
-
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/58e53ea82f25..b27d084b0112 git log 58e53ea82f25..b27d084b0112 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 dj2@everburning.com Revert "BUILD.gn: Make a better interface with dependents. (#1875)" (#1876) 2018-09-05 corentin@wallez.net BUILD.gn: Make a better interface with dependents. (#1875) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b27d084b0112 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I75d27e2add9990ccd3c6fc80fe40b28cf6297e8a Reviewed-on: https://chromium-review.googlesource.com/1208070Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588983}
-
Xida Chen authored
This CL adds temporary fix in TouchActionFilter to prevent crash. We'd likely need to merge this back to 70 for the next Android dev release. Bug: 869375, 880018 Change-Id: I087f39f64ba31dc4b5f8edfd2f6b0b0ae28da76d Reviewed-on: https://chromium-review.googlesource.com/1207094Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#588982}
-
Alex Leung authored
Bug=b:111935545 Change-Id: I991b5161d14aadae59576dbab231631364b47f8b Reviewed-on: https://chromium-review.googlesource.com/1187681 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#588981}
-
Robert Phillips authored
This change lets Chrome see the bug fix from the Skia CL: https://skia-review.googlesource.com/c/skia/+/12733 (Fix srcBounds computation in SkMatrixConvolutionImageFilter) which fixed some matrix image filter problems when tiling (i.e., the edges would become darker bc some input pixels needed for filtering were being discard) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9fca093a223104b85847b0b3a3c0a6a29871d5ba Reviewed-on: https://chromium-review.googlesource.com/1131554Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#588980}
-
James Wallace-Lee authored
Fixes a crash from HitTestSync caused by writing to nullptr. Bug: 880801 Change-Id: Icc01027f6aa2fb60956bdc1ecafb96048680e895 Reviewed-on: https://chromium-review.googlesource.com/1208190 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588979}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6438547360b..7b9e6b164953 git log e6438547360b..7b9e6b164953 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7b9e6b164953 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iafa02f9c25b5b42807d15c14e321d86968643cf1 Reviewed-on: https://chromium-review.googlesource.com/1208291Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588978}
-
David Black authored
When launching Assistant via the stylus we should use the correct corner radius. Bug: b:114055376 Change-Id: I6ecc2ceb757175b5d92feae9f816f45e9ef8ba06 Reviewed-on: https://chromium-review.googlesource.com/1207654Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#588977}
-
Tommy C. Li authored
This CL removes the Java implementation of Query in Omnibox, and makes Chrome for Android use the native C++ implementation. This native C++ implementation will be shared with Desktop. Bug: 874592 Change-Id: Idfe296090c43d5d3aefe4ce166a4f8859d5699f1 Reviewed-on: https://chromium-review.googlesource.com/1204413Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#588976}
-
Jordy Greenblatt authored
The placeholders were complete dummy links before this CL. Although the info page for the Better Together (a.k.a. MultiDevice) suite is not yet fully build, we are filling it in the like we plan to use for eve in the meantime. Bug: 853321 Change-Id: I9bcfc4693455b3d7083cc6f3bb4ff4474c787bfb Reviewed-on: https://chromium-review.googlesource.com/1208350Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#588975}
-
Alexandr Ilin authored
This CL removes the deprecated chrome_browser_net::Predictor class. This code isn't executed since M68 and was kept as a backup for the LoadingPredictor experiment. Bug: 875238 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I50e1fc48739bc73e23f396cfd60e61532812e16c Reviewed-on: https://chromium-review.googlesource.com/1179884Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588974}
-
Jordy Greenblatt authored
The mocks now require that the Settings UI page when there is there is no response from the server has a disabled "Verify" button instead of the old active "Retry" button. Here are screenshots for this CL deployed: Waiting for verification: http://screen/E19zdKcijRN Waiting for server: http://screen/SSkhb7tzDkb Bug: 870127 Change-Id: If529edc1b6756de4fa6ecc5f5c8d0346e551a926 Reviewed-on: https://chromium-review.googlesource.com/1205596Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#588973}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/424621e3129f..cc5f350ab9c8 git log 424621e3129f..cc5f350ab9c8 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 rharrison@chromium.org Update libpng from 1.6.22 -> 1.6.34 Created with: gclient setdep -r src/third_party/pdfium@cc5f350ab9c8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I301ac78d336512a0c519a62cb641d4aede07218f Reviewed-on: https://chromium-review.googlesource.com/1208072Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588972}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/74b1c01cdd1d..29a4a684af25 git log 74b1c01cdd1d..29a4a684af25 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 caryclark@skia.org makeSurface defaults to raster 2018-09-05 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 80e0493eab5f..8a251fa55434 (1 commits) 2018-09-05 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0466301999..750e508722a9 (1 commits) 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-05 brianosman@google.com Add error handling logic to viewer's GLX context creation 2018-09-05 reed@google.com Deliberately call typefaceproc only once per face in pictures 2018-09-05 brianosman@google.com Replace SkColor with SkColor4f in layer draw looper 2018-09-05 robertphillips@google.com Begin centralizing opList DAG 2018-09-05 brianosman@google.com Enforce range in SkPaint::setAlpha 2018-09-05 mtklein@google.com clean up S16CPU 2018-09-05 caryclark@skia.org add color4f to docs 2018-09-05 stephana@google.com Refresh gcloud asset to include BigTable emulator 2018-09-05 halcanary@google.com SkPDF: use more vector<>, more sk_sp<>, cleanup. 2018-09-05 bungeman@google.com Make Slide::getDimensions pure virtual. 2018-09-05 mtklein@google.com more skcolorspace cleanup 2018-09-05 brianosman@google.com Reland "Switch SkPaint's color to SkColor4f" 2018-09-05 brianosman@google.com Fix typo in viewer docs Created with: gclient setdep -r src/third_party/skia@29a4a684af25 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Id31024f6e8ea648890f62562c1365630ad68189a Reviewed-on: https://chromium-review.googlesource.com/1207160Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588971}
-
Oksana Zhuravlova authored
This change implements the controller management logic in DeviceMotionEventPump and removes the dependency on PlatformEventDispatcher. Bug: 873761 Change-Id: I520987c38877f0adfc4cbbce75bff2a36e5b47fe Reviewed-on: https://chromium-review.googlesource.com/1187517Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#588970}
-
David Black authored
The layer to which our web contents is drawn is not masked by the layer which applies corner clipping logic in Assistant UI. To fix this, I've added a distinct clipping layer mask that enforces our desired corner radius. See bug for before/after. Bug: b:113903157 Change-Id: If19ff4d6836cedf8b8ec6d0e9fef5616d5392b1d Reviewed-on: https://chromium-review.googlesource.com/1205195 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#588969}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb4cfa21. With Chromium commits locally applied on WPT: b691cab2 "Implement script and style attr/elem CSP directives" bde179ef "Revert "Implement script and style attr/elem CSP directives"" 77fb9999 "Reland "Implement script and style attr/elem CSP directives"" 51b234e2 "Set longer timeout to all tests in wpt/editing/run/" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24123 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I7dbea3ca564ef9fd0aa925c5df0b5dc51570b2bc Reviewed-on: https://chromium-review.googlesource.com/1207214 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588968}
-
Misha Efimov authored
This is a reland of 4327cf6c Original change's description: > [Cronet] Provide bidirectional stream support from native CronetEngine. > > Bug: 874542 > Change-Id: I8414e75049ee219f1c7491caf91f6282c42f23dd > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester > Reviewed-on: https://chromium-review.googlesource.com/1178666 > Commit-Queue: Misha Efimov <mef@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588541} Bug: 874542 Change-Id: I1380e751fa00fae546c563d72da829b089458fe5 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/1207613Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#588967}
-
nednguyen authored
Update MILO entry of linux-builder-perf and remove the legacy 'Linux Builder Perf' config in mb_config.pyl Bug: 828467 Change-Id: I93df365ccf16e9668fd7fd07b79bbff8646311c9 Reviewed-on: https://chromium-review.googlesource.com/1206930Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#588966}
-
Oksana Zhuravlova authored
This change updates the service_manager::Instance code to reference its options_.can_connect_to_other_services_as_any_user value instead of "service_manager:user_id" in the "required" section of its interface provider specs. Tests and existing manifests were updated accordingly. Bug: 866967 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7c6529ef8e6cb8267710dc96ee009bec4c7f352a Reviewed-on: https://chromium-review.googlesource.com/1203714 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#588965}
-
Tim Zheng authored
The 2 policies added are an user policy UserCrostiniEnabled and a device policy UnaffiliatedCrostiniAllowed. This CL adds their definitions and the related pref and setting name respectively. BUG=chromium:879737 TEST=Unit tests. Change-Id: I0b213251e47eec1d7b8ecceb63b8bf779c3f283e Reviewed-on: https://chromium-review.googlesource.com/1200524Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588964}
-
Mirko Bonadei authored
WebRTC still supports GCC, this CL makes sure /wd4267 is only applied to MSVC. Since there is no -Wshorten-64-to-32 in GCC, nothing gets suppressed in that case. Bug: 588506 Change-Id: I0b7477ec26123437f4e2274e0cc9d92738b0b066 Reviewed-on: https://chromium-review.googlesource.com/1205394Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#588963}
-
Owen Min authored
The DM token directory should be created only when writing token. Reading the token should not create any directory or file. Bug: 880870 Tbr: pastarmovj Change-Id: I6917092a494c6b99508ef6279639ff75906f2175 Reviewed-on: https://chromium-review.googlesource.com/1207218 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#588962}
-
Alexei Svitkine authored
Previously, it would do this only for non-official builds. Now, we check both. Bug: 880853 Change-Id: I0f37a32ede20cdcb7379a748341203eab7028cf1 Reviewed-on: https://chromium-review.googlesource.com/1207211Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#588961}
-
Ted Choc authored
See discussion here: https://groups.google.com/a/chromium.org/forum/#!topic/java/10-nLjh4Rtg BUG= Change-Id: Ib2007de8f88edfb08f808eb5f01005cbe975e12b Reviewed-on: https://chromium-review.googlesource.com/1207653Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#588960}
-
Ian Kilpatrick authored
Fixes percentage sized floats which were previously not using the correct percentage resolution size. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie57909b7f452f5d59b8dfe2f899bedf253ab90ac Reviewed-on: https://chromium-review.googlesource.com/1205200 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#588959}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/797fd93eccde..8a49a283b96c git log 797fd93eccde..8a49a283b96c --date=short --no-merges --format='%ad %ae %s' 2018-09-05 bmgordon@chromium.org chromeos_config: Make grunt-pi-pfq builder non-experimental Created with: gclient setdep -r src/third_party/chromite@8a49a283b96c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1adc4164209d2148e03f4955c94a1e5c5a1a1bf9 Reviewed-on: https://chromium-review.googlesource.com/1207159Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588958}
-
Min Chen authored
|force_clamshell_power_button_| is not needed after this cl https://chromium-review.googlesource.com/c/chromium/src/+/1053565 Bug: None Change-Id: Ie54f4bef235ab5f537849c70be40582a1c9f647c Reviewed-on: https://chromium-review.googlesource.com/1207893Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#588957}
-
Ryan Sturm authored
This adds a document URL HTTP/HTTPS check in the renderer (anchor_element_metrics) for OnClick. This check already happens in OnLoad and on the browser side, and due to the browser side check being a fast fail, this causes a crash if the user is on a data:// page with an https:// anchor element. Bug: 879999 Change-Id: Iec3de21649d8f4f2d81a4c9c9e23cfe02fbbc9d7 Reviewed-on: https://chromium-review.googlesource.com/1204830Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#588956}
-
Khushal authored
AVDASurfaceBundle sends redundant position updates to the AndroidOverlay which results in an unnecessary re-layout of the chrome window for every frame. This change fixes it in the AVDASurfaceBundle to avoid redundant IPCs to the browser processes. And also in DialogOverlayCore to avoid any client-side errors from regressing this in the future. R=liberato@chromium.org BUG: 880691 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I17d9264c6d117ed5fc4d1012321cbd66c5cf60d4 Reviewed-on: https://chromium-review.googlesource.com/1205599 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#588955}
-
Christian Fremerey authored
This is a fix for bug 880249. Bug: 880249 Change-Id: I176f925cbddfff9b2fdd6127216bbdcce85cb4c4 Reviewed-on: https://chromium-review.googlesource.com/1207093 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#588954}
-
Karan Bhatia authored
Currently when a user grants access to the current page using the extension action context menu, we run the blocked actions. But the extension may have blocked actions which can't be run at this stage. Prompt the user to refresh the page in this case, and grant permissions once the user accepts the refresh bubble. BUG=876791 Change-Id: I2516fe40050110ee2844670489796b421ad4fdb9 Reviewed-on: https://chromium-review.googlesource.com/1196225 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#588953}
-
Etienne Bergeron authored
This is a reland of 0ea3570a Original change's description: > Add a sampling profiler to chrome tracing. > > This CL is plumbing the base::StackProfiling to allow collecting > stack sample at a low rate on the browser process. > An event is triggered to the trace with the collected stackframe. > > The goal of this code is to get low-rate stack samples in the field > for the slow-report to help the investigation of stalled tasks. > > > This is a variant of: > https://chromium-review.googlesource.com/c/chromium/src/+/1188502 > > R=ssid@chromium.org, oysteine@chromium.org > > Change-Id: I150c17df51914f4535d4e7d6ec086a2e13c17cff > Reviewed-on: https://chromium-review.googlesource.com/1191745 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588554} Change-Id: If50c39644d0563d169281169e57839e2d223754d Reviewed-on: https://chromium-review.googlesource.com/1205573Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#588952}
-
Mathieu Perreault authored
A previous change misplaced the code to remove all information in addresses. It is now moved to after GetDetectedValues is computed. Bug: 878416 Change-Id: I15fd8d8c97d2a051aab9313be98fff5a840fcbd9 Reviewed-on: https://chromium-review.googlesource.com/1207193Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#588951}
-
Philipp Hancke authored
uses Math.floor() to round bits per second as fractions of a bit are not very meaningful Bug: 678292 Change-Id: I8b8f5cb9b4a88729d64fb37d8d05145b8330d421 Reviewed-on: https://chromium-review.googlesource.com/1207950 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588950}
-
Roger McFarlane authored
Bug: 806987 Change-Id: I73c8428395fc6905636587d5143a79bfff97c65c Reviewed-on: https://chromium-review.googlesource.com/1135752Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#588949}
-
Rune Lillesveen authored
Things like the isConnected() flag was not updated for these elements when removed. Bug: 868810 Change-Id: I53aecf996c3d45253ab9929aa94cf29fd0c4ff6f Reviewed-on: https://chromium-review.googlesource.com/1202063Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#588948}
-
Derek Cheng authored
The availability caching will now be checked when a new sink query is added. Before that, it is only checked during Refresh() (user gesture) and when sink is added. This prevents a request from being re-sent if a query was removed and re-added while the sink is still on the list. In addition, the cache rule now applies when a sink is added or updated. This means a request will be re-sent (subject to timing threshold) if its cached availability is kUnavailable. Note the rule to always use cache if the availability value is kAvailable hasn't changed. An app is considered to be available until it is offline, at which point the cache value will be invalidated. Bug: 809249 Change-Id: Iadcee4953b51464211c3ee91777683a640f1291a Reviewed-on: https://chromium-review.googlesource.com/1173477 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#588947}
-
Xing Liu authored
This CL implements the functionality to extract one encoded video key frame in utility process with ffmpeg for video thumbnail retrieval. The decoding will be done in later CLs with MojoVideoDecoder. TBR=dtrainor@chromium.org Bug: 826021 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia36ffe5ab4bb6fc32e55f1de089f07046e72a1bd Reviewed-on: https://chromium-review.googlesource.com/1145780 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#588946}
-
Takumi Fujimoto authored
Record MediaRouter.Icon.Click.Location whenever the Cast trusted area icon is clicked. When a media route is created, call the callback to record MediaRouter.Source.CastingSource before calling other callbacks, so that the MediaRouterUIBase doesn't get destroyed before we get to record. Bug: 880624 Change-Id: Ic242cb7621886035f07f8edd96ca55b0d7b7a0a8 Reviewed-on: https://chromium-review.googlesource.com/1205992 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588945}
-
Theresa authored
Nokia devices crash when trying to set to set the status bar color in bookmarks, history, and downloads. Disable status bar theming for now. BUG=880694 Change-Id: I48ae7ec0d7aa5059d70eb5a99b23e84d8263dcd0 Reviewed-on: https://chromium-review.googlesource.com/1207310Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#588944}
-