GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c44ff58..c0363f0

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/615763003

Cr-Commit-Position: refs/heads/master@{#297358}

Move all white-listed input method indicator text from InputMethodUtil to manifests of IME extensions.

BUG=232260
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/608183002

Cr-Commit-Position: refs/heads/master@{#297357}

Fixes a potential crash if an app gets duplicated in the app list, and
the user tries to drop it onto itself. (There is no known way to repro
this currently, but there was recently; see http://crbug.com/415530.)
That situation will now result in a very descriptive DCHECK, rather than
a confusing low-level CHECK fail.

AppListModel::MergeItems:
- returns "" instead of crashing if the source and target IDs are equal.
- returns "" instead of crashing if the target ID is inside a folder (no
  longer needs to explicitly CHECK whether it is in a folder.)

Added plenty of new tests for the various corner cases in
AppListModel::MergeItems which would have caught these crashes.

AppsGridView::MoveItemToFolder:
- DCHECKs for a NULL result of GetViewAtSlotOnCurrentPage.
- DCHECKs that you aren't dropping an item onto itself (this should
  never happen).

BUG=417482

Review URL: https://codereview.chromium.org/600393002

Cr-Commit-Position: refs/heads/master@{#297356}

It's empty, except for a DEPS file.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/606403004

Cr-Commit-Position: refs/heads/master@{#297355}

BUG=418014
TEST=manually
1. Open Files.app. Put a file name "test.txt" under /Downloads.
2. Start dragging the file, and drop to the blank area of the same
   directory (/Downloads).
3. Confirm to not start move operation.

Review URL: https://codereview.chromium.org/609223002

Cr-Commit-Position: refs/heads/master@{#297354}

The type causes an exception and it prevent the app from running
progressCenter.removePanel.

So the disposed ProgressCenterPanel remains in the ProgressCenter and it causes
another bug.

BUG=418517
TEST=repo steps of the bug.

Review URL: https://codereview.chromium.org/618563002

Cr-Commit-Position: refs/heads/master@{#297353}

BUG=407997
TEST=N/A

Review URL: https://codereview.chromium.org/604193002

Cr-Commit-Position: refs/heads/master@{#297352}

These translations were accidentally missed.

BUG=414468
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/612553003

Cr-Commit-Position: refs/heads/master@{#297351}

BUG=416665

Review URL: https://codereview.chromium.org/603243005

Cr-Commit-Position: refs/heads/master@{#297350}

I profiled Bookmark Sync association code on a Windows workstation with about 16K folders and bookmarks. This was for the scenario when bookmarks had been already synced and and BookmarkModelAssociator::BuildAssociations needed to match sync data to the already existing bookmark model.

While it was fairly fast in absolute terms (less than 1 sec on my rather powerful workstation), I verified that 59% of samples for the UI thread were in BookmarkModelAssociator::BuildAssociations.

The top 3 functions called from BuildAssociations and their costs in terms of UI thread sample counts are:

browser_sync::BookmarkNodeFinder::FindBookmarkNode	- 20.7%
browser_sync::BookmarkChangeProcessor::UpdateBookmarkWithSyncData	- 14.6%
browser_sync::BookmarkNodeFinder::BookmarkNodeFinder - 13.9%

Altogether BookmarkNodeFinder was responsible for almost 35% of all UI thread samples.
Furthermore UTF16ToUTF8 function alone was responsible for 24% of UI thread samples.

The reason UTF16ToUTF8 is so expensive is because it is used in custom comparator used with multiset which is a part of BookmarkNodeFinder implementation.
Each bookmark node gets added and searched to BookmarkNodeFinder once.
Altogether that results in approx 2*2*(N*logN/2) calls of UTF16ToUTF8 (and
also N calls of UTF8ToUTF16). Each conversion involves an allocation.
On a mobile platform the relative cost of this should be even higher because
memory tends to be slower and CPU caches smaller.

The fix replaces multiset with a hash_multimap where the key is the converted
bookmark title. Therefore UTF16ToUTF8 ends up being called only once for each node and due to different lookup (by title vs. by node) UTF8ToUTF16 calls are eliminated.
Also hashing should work more efficiently for long bookmark/folder titles than the binary search.

Measurement showed that improved combined cost of BookmarkNodeFinder::BookmarkNodeFinder and BookmarkNodeFinder::FindBookmarkNode - close to 5x. And the overall cost of bookmark association - improved by 1.5-2x (when measured on my windows dev workstation).

There is also an opportunity to optimize UpdateBookmarkWithSyncData which blindly applies data even when it guaranteed to be exactly the same, but I didn't touch it in this change.

BUG=238621

Review URL: https://codereview.chromium.org/603153005

Cr-Commit-Position: refs/heads/master@{#297349}

If someone wants to disable a page, the right way to
do it is comment out the "self.AddPage(...)" in page_set.__init__().

BUG=

Review URL: https://codereview.chromium.org/616693002

Cr-Commit-Position: refs/heads/master@{#297348}

BUG=None
R=cmasone@chromium.org, fukino@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/607413005

Cr-Commit-Position: refs/heads/master@{#297347}

PrintingControllerTest was faking being in org.chromium.printing package.
Move to org.chromium.chrome.browser.printing package where it actually lives.

BUG=None

Review URL: https://codereview.chromium.org/618553002

Cr-Commit-Position: refs/heads/master@{#297346}

Several spurious NotifyObserver calls have been removed, in addition to
removing the configuration retry code (which was not doing anything anymore).

BUG=418140

Review URL: https://codereview.chromium.org/612573005

Cr-Commit-Position: refs/heads/master@{#297345}

BUG=393873
R=estade@chromium.org

Review URL: https://codereview.chromium.org/617673002

Cr-Commit-Position: refs/heads/master@{#297344}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b4e21e6..c44ff58

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/613843005

Cr-Commit-Position: refs/heads/master@{#297343}

This reverts commit 20d99284. {#297319}

BUG=418816
R=cpu@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/616533004

Cr-Commit-Position: refs/heads/master@{#297342}

Almost every views::View* in this class is actually an AppListItemView*,
and we are now specific about that. Also made a few explicit
PulsingBlockViews. This removes a mess of static_casts throughout the
file, and makes the interface to many methods type-safe and explicit.

Review URL: https://codereview.chromium.org/599933004

Cr-Commit-Position: refs/heads/master@{#297341}

format int32.

BUG=

Review URL: https://codereview.chromium.org/600143002

Cr-Commit-Position: refs/heads/master@{#297340}

Refactor FakeAttachmentStore into AttachmentStoreProxy and
InMemoryAttachmentStore backend. Break AttachmentStore interface into
AttachmentStoreBase (common interface for backends) and AttachmentStore
(referenced by datatype and AttachmentService).

BUG=
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/601553004

Cr-Commit-Position: refs/heads/master@{#297339}

Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.)

To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink.

BUG=411026
TEST=None. I cannot reproduce the crash.

Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf
Cr-Commit-Position: refs/heads/master@{#296697}

Review URL: https://codereview.chromium.org/583043005

Cr-Commit-Position: refs/heads/master@{#297338}

Followup to https://codereview.chromium.org/602013002/, which fixes a bug with empty window shapes not being handled properly on CrOS.

BUG=417014

Review URL: https://codereview.chromium.org/607623002

Cr-Commit-Position: refs/heads/master@{#297337}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/613053002

Cr-Commit-Position: refs/heads/master@{#297336}

There are a number of static downcasts in ShelfView that are *probably*
correct, but there is no clear proof that they are casting to the
correct type. This patch adds explicit CHECKs before every static_cast
to ensure that we are not casting from an incompatible dynamic type.

drag_view_ now has type ShelfButton*, so it is downcast on assignment,
rather than on many of its uses.

BUG=418460

Review URL: https://codereview.chromium.org/614653002

Cr-Commit-Position: refs/heads/master@{#297335}

BUG=417835

Review URL: https://codereview.chromium.org/610673002

Cr-Commit-Position: refs/heads/master@{#297334}

R=tbreisacher@chromium.org, vitalyp@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/613763005

Cr-Commit-Position: refs/heads/master@{#297333}

Increase device orientation event frequency to 60 Hz to match requestAnimationFrame rate on most hardware. Change constants to microseconds for increased precision.

BUG=413327

Review URL: https://codereview.chromium.org/604483003

Cr-Commit-Position: refs/heads/master@{#297332}

BUG=401365

Review URL: https://codereview.chromium.org/508823009

Cr-Commit-Position: refs/heads/master@{#297331}

This copies the logic from tools/build/scripts/slave/runtest.py in swarming.

I changed test_env.py so that it sets CHROME_DEVEL_SANDBOX to be an empty string, instead of unsetting it. The latter doesn't work as Chrome triggers checks in content/browser/browser_main_loop.cc. This is what runtest.py does.

BUG=414808,336218

Review URL: https://codereview.chromium.org/605063004

Cr-Commit-Position: refs/heads/master@{#297330}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/612243002

Cr-Commit-Position: refs/heads/master@{#297329}

Define ViewMsg_ColorProfile IPC message and plumb it into renderer
RenderWidget::SetDeviceColorProfile(). The browser uses the IPC to
set the renderers screen color profile.

Note SetDeviceColorProfile is overridden by RenderViewImpl, so the
IPC message data is handled there - it calls the base RenderWidget
SetDeviceColorProfile, which detects if the color profile changed,
and stores it in the RenderWidget if so.

If there was a change, the RenderViewImpl informs its webview() so
the Page contained therein can update / repaint all color profiled
elements on the Page.

For a diagram of the IPC and procedure call proceedings, including
layout test support (added in issue 369787), see:

  https://crbug.com/368663#c14

Not used as yet: the IPC from the browser-side will be added later
(need to resolve issue 338130, issue 357443 first), so this change
is again just plumbing.

CQ_EXTRA_TRYBOTS=tryserver.blink:mac_blink_rel,mac_blink_dbg
BUG=368663

Review URL: https://codereview.chromium.org/601273002

Cr-Commit-Position: refs/heads/master@{#297328}

This is a simpler fix than https://codereview.chromium.org/595213005/.
I would like to make a more robust fix (and added a TODO), but this
should address the crash bug for 38 and 39 while allowing us to
investigate a better solution for 40.

BUG=417633

Review URL: https://codereview.chromium.org/614793003

Cr-Commit-Position: refs/heads/master@{#297327}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ed24ca8..b4e21e6

TBR=zmo@chromium.org,eustas@chromium.org

Review URL: https://codereview.chromium.org/607673003

Cr-Commit-Position: refs/heads/master@{#297326}

BrowserActionView::~BrowserActionView deletes ExtensionActionViewController,
which calls CleanupPopup, which resets a MenuButton::PressedLock, which was
already deleted. Fix the order of destruction.

BUG=418737

Review URL: https://codereview.chromium.org/615543006

Cr-Commit-Position: refs/heads/master@{#297325}

Restore Pepper printing support even without full printing.
If was guarded to work in full printing for Android, because Android
did not implemented that functionality. Proper guard should allow
even non-full printing, because code is usefull to print PDF.

Removed printing to DC code, related code already deleted from Chrome.

BUG=170859, 417967

Review URL: https://codereview.chromium.org/599633007

Cr-Commit-Position: refs/heads/master@{#297324}

BUG=416691

Review URL: https://codereview.chromium.org/612983004

Cr-Commit-Position: refs/heads/master@{#297323}

Missed from https://codereview.chromium.org/454623002

Review URL: https://codereview.chromium.org/618453003

Cr-Commit-Position: refs/heads/master@{#297322}

ShelfViewTest.AppListButtonTouchFeedback and ShelfViewTest.AppListButtonTouchFeedbackCancellation are both failing on Valgrind after the refactor of the feedback switch. The tests does not have a memory failure, the test cases are failing now.

Disabling the tests until they can be fixed.

This is a follow up to: https://codereview.chromium.org/580903003/

TBR=skuhne@chromium.org
BUG=398398

Review URL: https://codereview.chromium.org/616703002

Cr-Commit-Position: refs/heads/master@{#297321}

These values should be filled in as specified by the MSDN documentation for the function: http://msdn.microsoft.com/en-us/library/windows/desktop/dd162611(v=vs.85).aspx

BUG=418684
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/613033002

Cr-Commit-Position: refs/heads/master@{#297320}

To be merged on 2171.

BUG=418816
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/616713002

Cr-Commit-Position: refs/heads/master@{#297319}