GitLab

The interface RenderWidgetHostNSViewLocalClient provides a set of helper
functions that add functionality to a RenderWidgetHostNSViewClient.
These functions may be implemented directly using that Client, or using
a side-channel.

The naming of this class is very confusing as we add the ability to have
local (in-process) and remote (out-of-process) clients. To this end,
rename this to a name that more closely mirrors the names in ui/views
and doesn't these naming ambiguities.

Move the ForwardingLocalClient from render_widget_host_view_cocoa.mm
over to a new render_widget_host_ns_view_client_helper.mm. Change
the instance which is created as a dummy pipe to always be identified
as a dummy pipe.

Bug: 821651
Change-Id: I1dd130ddbed46d4854a065fa3d629b7f9833824c
Reviewed-on: https://chromium-review.googlesource.com/1239641Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593601}

Bug: 884062
Change-Id: I584dda328551a10db2100d493e802f42da83c1e5
Reviewed-on: https://chromium-review.googlesource.com/1237262
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593600}

When CalculateKMeanColorOfBitmap was called with a desired (sample) height larger than the size of the raw image to sample, it would only initialize the buffer up to the number of pixels in the image (appropriately), but this would result in the buffer containing uninitialized memory at the end.  Changed the function to clamp the input height to the height of the image.  Also simplified the control button background sampling logic in BrowserThemePack to only crop the image when sampling (instead of trying to tile it).

Bug: 883588
Change-Id: Ief3a27d63bac7e54757c3d3c4dad47d73aa980d9
Reviewed-on: https://chromium-review.googlesource.com/1228126
Commit-Queue: Ryan Meier <rameier@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593599}

Also when a fallback exists but has a different FrameSinkId or embed token
than the primary, don't use the fallback because the resulting range in
the new view will not cover any surface with the FrameSinkId or embed
token of the old view's primary.

Bug: 857575,870456
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia4736f354160dfd510793bf35ae4292c276bf115
Reviewed-on: https://chromium-review.googlesource.com/1236456Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593598}

Bug: 825947
Change-Id: Id03b7c06a7173afb7b15e64eb91974735a979c0d
Reviewed-on: https://chromium-review.googlesource.com/1240514Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593597}

ColorSyncDeviceCopyDeviceInfo sometimes returns nil. The GPU test framework
should gracefully handle this failure.

Bug: 888035
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6374f2ef01e6272a7220a030e1e0ff5ecdaa80b9
Reviewed-on: https://chromium-review.googlesource.com/1238780Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593596}

In the associated bug, we decline to restore the anchor after the initial
restoration, which causes us to fall back to using the saved scroll offset.
This clears the anchor, causing the anchor to get re-restored on subsequent
layouts. This feedback loop causes flickering.

To avoid this, we early return true from RestoreScrollAnchor when there's an
existing anchor. This prevents us from falling back to using the saved pixel
offset.

Bug:884139

Change-Id: I22f17e1f73a7604eb7b99df9291f2f37b2ea9229
Reviewed-on: https://chromium-review.googlesource.com/1231831Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593595}

Bug: b/112748586
Test: none

Change-Id: If42ab10a110e563c88cd24551a76d7806d5603c1
Reviewed-on: https://chromium-review.googlesource.com/1232956Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593594}

USER_BLOCKING is too high for this task as it doesn't affect UI.
This CL lowers the task priority to BEST_EFFORT.

Bug: 888276
Change-Id: I5d2a45915dfb82206e2880e58d1c4ec593ef09ca
Reviewed-on: https://chromium-review.googlesource.com/1239162
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593593}

This reverts commit f7623733.

Reason for revert: causes DCHECK failures in external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled.html

Original change's description:
> Workaround for nested remove for datalists.
> 
> Nested removes confuses the style traversal roots. Make this a general
> workaround for UA shadow removals.
> 
> Bug: 888236, 888448
> Change-Id: Ia0165e7478c96282900a8191eeac18ae34586a2c
> Reviewed-on: https://chromium-review.googlesource.com/1238728
> Reviewed-by: Anders Ruud <andruud@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593510}

TBR=futhark@chromium.org,andruud@chromium.org

Change-Id: I843b4cc5d9be74fea13ff43305b0093fd64dcae3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 888236, 888448, 888618
Reviewed-on: https://chromium-review.googlesource.com/1240505Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593592}

Flag for the new feature that allows user to add custom search engines in
settings.

Bug: 433824
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If3b91e276b752b546013644119a5560f0a486314
Reviewed-on: https://chromium-review.googlesource.com/1236314
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593591}

The minimized windows are now stacked underneath non-minimized windows.
Minimized windows now animate back when uncessfully swipe to close.

Test: manual
Bug: 886392, 886390
Change-Id: I520a9cfc642e5f417af6755b783b831098430ce8
Reviewed-on: https://chromium-review.googlesource.com/1238782
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593590}

There are some cases that though the validity map
on the server side has not changed, we need to update
the validity states of the profiles. This is when the
profiles are updated. Thus, we need to turn on the
flag for profile_validities_need_update in case they
have changed.

Change-Id: I87f7d6f6df914b98ffb9ef744ff055c0b4c92f3c
Reviewed-on: https://chromium-review.googlesource.com/1239436Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593589}

Currently this is only allowed for renderer and gpu process. This CL
also allows it for utility process.

Also pass logging switches to the UtilityProcessHost. These switches
are already passed in ServiceUtilityProcessHost. Both are using
kUtilityProcess process type.

Bug: 888088
Change-Id: Ic26b9c9e6ce0c9024fb3ca4c8d352c5a283bef81
Reviewed-on: https://chromium-review.googlesource.com/1239172Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593588}

https://skia.googlesource.com/skia.git/+log/a9adb6f03525..4fb073ac7328


git log a9adb6f03525..4fb073ac7328 --date=short --no-merges --format='%ad %ae %s'
2018-09-24 mtklein@google.com use __builtin_debugtrap() in sk_abort_no_print() where possible
2018-09-24 mtklein@google.com make only valid SkRRects in FuzzPath
2018-09-24 kjlubick@google.com Remove coverage bots
2018-09-24 mtklein@google.com Reland "focus exported color apis"


Created with:
  gclient setdep -r src/third_party/skia@4fb073ac7328

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:888381
TBR=bsalomon@chromium.org

Change-Id: I9f3de224dfaf69b7693e936acd43d9f192a44ff3
Reviewed-on: https://chromium-review.googlesource.com/1240476Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593587}

Bug: 832676
Change-Id: I25fa2e314592f392a716bcb3b5dd3836bfb878cc
Reviewed-on: https://chromium-review.googlesource.com/1239636
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593586}

When the user disables the unified consent toggle in settings,
a metric is recorded.
This metric is added to UnifiedConsent.RevokeReason.

Bug: 868892
Change-Id: Iff196b3428b130ea4b3d71a50c2b861f5da48966
Reviewed-on: https://chromium-review.googlesource.com/1240278Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593585}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2c8e12da..d786acd3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If21a1481d1c94548968e357b1c8294f5acc96212
Reviewed-on: https://chromium-review.googlesource.com/1240493Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593584}

Change-Id: I69b90b0ff716c3b506f699fcec6fed9ab32f351c
Reviewed-on: https://chromium-review.googlesource.com/1239994Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593583}

These two tests were disabled due to assertion failures on Cocoa
call stack. By porting fullscreen code to Views, we no longer call into
such functions. With some minor improvement -- adding initial preference
setup, the tests should pass.

BUG=823490

Change-Id: I9b3c7838d1502c52a2da8cbc4a954ae9f8e71da7
Reviewed-on: https://chromium-review.googlesource.com/1239356Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593582}

This CL changes the default parameters for password generation so that we don't
need a configuration on the server unless anything changes. It also removes the
PasswordGenerationRequirements feature which was only implemented as an early
kill switch in case of crashes and is not necessary anymore.
PasswordGenerationRequirementsDomainOverrides remains as a feature that is
enabled by default in case some distribution wants to disable this feature that
talks to Google.

Bug: 846694
Change-Id: I32bd06ef908f16c189cd0fa2a376d490c6fe20d0
Reviewed-on: https://chromium-review.googlesource.com/1233740Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593581}

Before launching V2 viz hit testing, we need to verify the correctness.
This patch forces V2 to do slow path async hit testing and compare the
results.

If there is no reported mismatched results, it will be safe to launch
V2 viz hit testing.

Bug: 823888
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I060b9626e6e59cc12ae2b476425cef715475e40d
Reviewed-on: https://chromium-review.googlesource.com/1157227
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593580}

Implementation CL:
https://chromium-review.googlesource.com/c/aosp/platform/system/connectivity/shill/+/1220430

BUG=chromium:729335
TEST=none

Change-Id: I00fe89328d9ec0f910b354733fb1914838c5d75c
Reviewed-on: https://chromium-review.googlesource.com/1234696
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593579}

Bug: 881445
Change-Id: I745c35e6f3ba0dba1804ee5787a6dc811fb123db
Reviewed-on: https://chromium-review.googlesource.com/1238794
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593578}

Bug: 884711
Change-Id: Ice9b8c2d260a98f5612884a19abca85d200e5ee4
Reviewed-on: https://chromium-review.googlesource.com/1240354Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593577}

Spec: https://w3c.github.io/reporting/#generate-test-report-command

Change-Id: Ia6932007db49eb11c005752b8eace6d7f1267e4f
Reviewed-on: https://chromium-review.googlesource.com/1221694Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593576}

The hooks are currently required by the jank calculator. They will eventually be
the mechanism that the browser task scheduler hooks into native events.

Bug: 859155
Change-Id: I4b633c7b350c673c7b59cdcfe3a115ae74e5bacb
Reviewed-on: https://chromium-review.googlesource.com/1238777Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593575}

This reverts commit 33d3164a.

Reason for revert: Breaks NVDA / JAWS

Original change's description:
> Ensure Windows accessibility is enabled properly.
> 
> http://crrev.com/c/1192062 made it so that we don't enable accessibility
> as often. The idea was to only enable accessibility if we get a call to
> IAccessible2, or to both get_accName and a response to our alert message
> on a honeypot window.
> 
> However, this only worked if we constructed at least one
> BrowserAccessibilityManager. In cases where the external client
> never explored and discovered a BrowserAccessibilityManager, the
> IAccessible2UsageObserver wasn't registered yet.
> 
> As a fix, move the IAccessible2UsageObserver code to part of
> BrowserAccessibilityStateImpl.
> 
> Bug: 878072
> Change-Id: Iadcbd032fa1d6f635bbb99c1e130d384efe0d9b1
> Reviewed-on: https://chromium-review.googlesource.com/1234267
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593233}

TBR=dmazzoni@chromium.org,aleventhal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 878072
Change-Id: I482cb7e3fa19f5f6357c4bc28f44cb20272142cd
Reviewed-on: https://chromium-review.googlesource.com/1240473Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593574}

Automatically continue from welcome to network screen when hands-off
enrollment is in progress.

This fixes the regression introduced by split of welcome screen into
welcome and network screen:
https://chromium-review.googlesource.com/c/chromium/src/+/1139586

Bug: 886919
Test: HandsOffEnrollmentTest + manually
Change-Id: I9f5fe438c5dd7284973e76728c4204b4cad2ea52
Reviewed-on: https://chromium-review.googlesource.com/1236662Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593573}

The previous code in VisualOffsetFromPaintOffsetRoot() converting the result
into scrolling contents space used ScrolledContentOffset which mismatched
the new ScrollTranslation which also includes scroll origin. Now use
ScrollTranslation instead.

Also removed the wrong remedy about scroll origin in one of the callers.

Bug: 887423
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9a72ed6ddc066c5b4c9970037ed4c4287c5a2f0f
Reviewed-on: https://chromium-review.googlesource.com/1239170
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593572}

Change-Id: I586fbd98fbf5529d7144513f75fa470d1accd0e8
Reviewed-on: https://chromium-review.googlesource.com/1236462Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593571}

This is set for ~3% of PageVisits.

Bug: 638198
Change-Id: Ib6c3d10565f2776aadbabea1a2d4d1363f2a6f9d
Reviewed-on: https://chromium-review.googlesource.com/1240166Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593570}

Adds the new two line suggestion display experiment argument for
credit card and profile autofill drop downs. This new experiment
argument will allow autofill drop downs to show two lines worth of
information for autofill suggestions as well as a leading icon
for the given suggestion (if any).

Bug: 870342
Change-Id: Iaa303bafea5fe09f81538d452e2f6871c0d4282a

Screenshots (Googlers-only): https://drive.google.com/drive/folders/1XDzDE9GiOt4bAG_kDXZDaiJbbBvuTwPX?usp=sharing

Change-Id: Iaa303bafea5fe09f81538d452e2f6871c0d4282a
Reviewed-on: https://chromium-review.googlesource.com/1234968
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593569}

Bug: 867106
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I931d15446e55a2f68b673d71525a805914bad422
Reviewed-on: https://chromium-review.googlesource.com/1239369
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593568}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: Ibc83b79270a95040405b7ff1a5bd0628fe287068
Reviewed-on: https://chromium-review.googlesource.com/1240170Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593567}

Use Network Quality Tracker (NQT) in network metrics provider
instead of the network quality estimator (NQE).

NQT works when network servicification is enabled or disabled.
NQE works only when network servicification is disabled.

Note that NQT is to be used on UI thread, while NQE was on
IO thread, which makes the code a bit simpler.

Change-Id: If95a8882d578ef6d00ea1a51e4bc5a861b3a47a2
Bug: 882482
Reviewed-on: https://chromium-review.googlesource.com/1215371Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593566}

TBR=smaier@chromium.org (mechanical refactor)

Bug: 825947
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I378c64c40f3c7ce9522f3d8f534eaee88225880b
Reviewed-on: https://chromium-review.googlesource.com/1231989
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593565}

Bug: 832676
Change-Id: I844589ee9726882c5a19b4d7e0ffd2543118d6a4
Reviewed-on: https://chromium-review.googlesource.com/1240167Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593564}

Bug: 832676
Change-Id: If8b70eefc57a17b734c33a953b3c06a1a0dc2bd2
Reviewed-on: https://chromium-review.googlesource.com/1240165
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593563}

NOTRY:true

Bug: 887512
Change-Id: Ie4aab44d8eb186b9aff35036aa5317c6f79fc643
Reviewed-on: https://chromium-review.googlesource.com/1236714
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593562}