- 11 Dec, 2018 40 commits
-
-
Steven Valdez authored
Also fixes the ssl-version-max commandline flag. Change-Id: If7c22b7df0d8e37575481be9deb6e707650e3e37 Reviewed-on: https://chromium-review.googlesource.com/c/1330075Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615695}
-
Tommy Martino authored
Bug: 914065 Change-Id: I9e030c1086428566692a6db7400f822018f653c0 Reviewed-on: https://chromium-review.googlesource.com/c/1372555 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615694}
-
Pavel Feldman authored
Bug: 717195 Change-Id: I0360d0dea935d2da11179dd7380f36bf52b85ced Reviewed-on: https://chromium-review.googlesource.com/c/1370862 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#615693}
-
Stuart Langley authored
1/ Fix up the FileManagerRootType enums to reflexct the values sent. 2/ Add back the deprecated "ADD_NEW_SERVICES_MENU" so that the enums have a consistent value. Note that there will be a time period where the accounting is incorrect for roots > 15. 3/ Add expiry to all FileBrowser metrics, M79 which is the last release of 2019. 4/ Mark as obsolete FileBrowser.CloudImport.UserAction which does not appear to exist anymore. Bug: 849156 Change-Id: If7eea77f079cb6ca24ab9a744924899e2404df3b Reviewed-on: https://chromium-review.googlesource.com/c/1370156Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615692}
-
Stephen Martinis authored
This was removed in https://crrev.com/c/1361804. I missed this reference though. Bug: 718157 Change-Id: Idbddfec89d5c143c494df1f5572cb82f631baf62 Reviewed-on: https://chromium-review.googlesource.com/c/1371192Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615691}
-
Dana Fried authored
Does not currently affect the test, but the minimum size reported by the toolbar is incorrect (see issue #842239). If the display is small and the minimum window width grows at all, the target point for the drag operation ends up still in the first (and focused) window, so the test fails. This change forces the endpoint of the drag onto the second window, and raises an error if it cannot do so. Bug: 898632 Change-Id: If4ee828e3309de247b1940a6b7f8ea98cffd5063 Reviewed-on: https://chromium-review.googlesource.com/c/1372711Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615690}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12659a46b9d9..5beabfe91862 git log 12659a46b9d9..5beabfe91862 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d2791c205bca..09056de49d52 (1 commits) 2018-12-11 michaelludwig@google.com Update 405 vk blacklist 2018-12-11 bsalomon@google.com Revert "Move some Gr headers from include/gpu to include/private and src/gpu." 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a233ceaecd85..d2791c205bca (1 commits) Created with: gclient setdep -r src/third_party/skia@5beabfe91862 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I1b5e3ddc0842924bfbc2da32384ebd504879d2a7 Reviewed-on: https://chromium-review.googlesource.com/c/1372469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615689}
-
Lakshmi Kumar Dabbiru authored
Had interacted is being logged just when prompt is shown. Introduced shown boolean to denote that and fixed logging for had_user_interacted. Bug: 848955 Change-Id: Ib3d17ab567b88c7ebda2dbe08cb3e46cf0807924 Reviewed-on: https://chromium-review.googlesource.com/c/1372281 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#615688}
-
Giovanni Ortuño Urquidi authored
Four small changes: 1. Make a js_library that depends on the //services/device/public/mojom:mojom_externs_js_library. This unearthens a bunch of problems. 2. Add externs for nested enum in interfaces and in structs. 3. Refactor externs type generator to correctly generate externs for nested enums, structs, and unions. 4. Changed the generated externs to not generate "mojo.internal.AssociatedInterfaceProxy" and "mojo.internal.AssociatedInterfaceRequest" since they are not fully supported by the lite bindings yet. Change-Id: Ife282be5e2b5dde5fc17a345c138981812a617d8 Reviewed-on: https://chromium-review.googlesource.com/c/1369560 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615687}
-
Darwin Huang authored
Bug: 896479 Change-Id: I95b4c57b2643883f2ea7f0ebbea4f50d7bc7111a Reviewed-on: https://chromium-review.googlesource.com/c/1371016Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615686}
-
Tommy Steimel authored
This CL adds a Windows implementation of a global MediaKeysListener. This implementation uses a KeyboardHook to receive media key events. Bug: 902379 Change-Id: Ieb4003292e2a0622e500b83c1d8b298129e1f1fe Reviewed-on: https://chromium-review.googlesource.com/c/1362197Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615685}
-
Wei Li authored
The distance calculation was broken due to pinned element and hovered element used different coordinates. r91bef92b also fixed this issue. This CL refactored the function name to make the coordinates used clearer, and also added unit test to prevent future breakage. BUG=899001 Change-Id: Ic1e2e577eb085a82f5ea32f608312335d6befd42 Reviewed-on: https://chromium-review.googlesource.com/c/1372551Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#615684}
-
Etienne Pierre-Doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 766678 Change-Id: Ifef9e8ac9c9893f4e11e20dc8221578971904b6f Reviewed-on: https://chromium-review.googlesource.com/c/1325194 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615683}
-
Jacob Dufault authored
Bug: 912234 Change-Id: I1f1e0a22c0866ecca1c988695b6651851120fe4d Reviewed-on: https://chromium-review.googlesource.com/c/1372528Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#615682}
-
David Grogan authored
This includes column containers, ortho children, and non-horizontal writing modes. This is a reland after the original[1] triggered an underlying crash issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1332247 Bug: 845235, 909021 Change-Id: I0d29126d5d4c2f203deecb03ee23480d46b447ef Reviewed-on: https://chromium-review.googlesource.com/c/1371196Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615681}
-
James Darpinian authored
As requested in the review of https://crrev.com/c/1336753. After https://crbug.com/913996 is fixed we can remove outstanding_result_pointer_ entirely when DCHECKs are disabled. It also turns out that we can't use the string argument to ASSERT_DEATH to detect a CHECK message in a test because the message strings are stripped in official builds. Bug: 905890, 913421, 913996 Change-Id: Ia7df19057564ef7a4bbbab9ba36f583c6e6bca0f Reviewed-on: https://chromium-review.googlesource.com/c/1370484 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615680}
-
Robert Ma authored
This file does not seem to exist any more and new builds should always have chromium_revision in their JSON results. Bug: 811976 Change-Id: If8c9a2d1d9a2e18f5171947990bf404aedc41b67 Reviewed-on: https://chromium-review.googlesource.com/c/1371072 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615679}
-
Dan Sanders authored
The issue mentioned in this TODO was already completed in the associated bug. Bug: 869660 Change-Id: I57f35558770a0c56441a899371eff5d723d76a26 Reviewed-on: https://chromium-review.googlesource.com/c/1371076Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615678}
-
David Tseng authored
This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura. Highlights: - removes usage of hard-coded desktop tree id in automation api (native and js bindings) - makes all known tree managers implement AXHostDelegate TBR=servolk@chromium.org Bug: 888152 Test: existing browser_tests (Automation Api tests, ChromeVox tests). Change-Id: I86a211d7588d280223c6dbacda0f0f1ad056a4fa Reviewed-on: https://chromium-review.googlesource.com/c/1361650 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615677}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11ba6a8ca5be..a039a0255e18 Created with: gclient setdep -r src-internal@a039a0255e18 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:914014 TBR=mmoss@chromium.org Change-Id: I6d593dd2e9f3c7fd2f8f3eda2e8d56e44d88ffaf Reviewed-on: https://chromium-review.googlesource.com/c/1372467Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615676}
-
Bruno Santos authored
Screen will appear when user is re-authenticating after a supervision transition occurs, if ARC++ was enabled when that happened. Screen will remain visible until transition finishes or times out, in which case it will clean up all ARC++ data. Bug: 903851 Change-Id: Ia960355930fba05dd6ffd07b23693690c77b28b1 Reviewed-on: https://chromium-review.googlesource.com/c/1340891 Commit-Queue: Bruno Santos <brunoad@google.com> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615675}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af97be96b474..4998533202d9 git log af97be96b474..4998533202d9 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 eseckler@google.com Merge "trace buffer: Fix some issues with reordered / missing chunks." 2018-12-11 fmayer@google.com Merge "profiling: Do not scan /proc if no cmdlines given." Created with: gclient setdep -r src/third_party/perfetto@4998533202d9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4a33a5a754a06bff5cf9c16c33f4d1c78207e29b Reviewed-on: https://chromium-review.googlesource.com/c/1372652Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615674}
-
Eric Karl authored
Enable this feature by default as we prepare to roll to launch. Change-Id: I80bc0a1be124a2ae3cae9637de55cda5ef5e9203 Reviewed-on: https://chromium-review.googlesource.com/c/1366866Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615673}
-
Lucas Furukawa Gadani authored
Bug: 865565 Change-Id: Ie76202a74a8d9a31884a04de88c99395800d6b5a Reviewed-on: https://chromium-review.googlesource.com/c/1372274Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615672}
-
Xiaohui Chen authored
We are checking locales in |IsAssistantAllowedForProfile|. Bug: None Test: None Change-Id: I2c6e5cfdbc8f23c48b646d89c92e0ed9aa2f8899 Reviewed-on: https://chromium-review.googlesource.com/c/1371817Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615671}
-
bsheedy authored
Disables failing WebXR tests that are causing CQ issues. Will be re-enabled once the root cause is found and fixed. TBR=billorr@chromium.org Bug: 913161 Change-Id: If50af30cc9e24ce917989a0b0ac210254ce503bb Reviewed-on: https://chromium-review.googlesource.com/c/1372540Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615670}
-
danakj authored
WebViewClient and WebWidgetClient no longer inherit each other, do the same with these test overrides. WebViewHelper takes a TestWebViewClient and if null makes one itself. Similarly TestWebViewClient takes a TestWebWidgetClient, and if null makes one itself. Then WebViewHelper gets the WebWidgetClient from the WebViewClient, avoiding us having 2 channels for this object through WebViewHelper. R=dcheng@chromium.org Change-Id: If9ba127bafc19a8a881c971aefdb25c201656d51 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1370720Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615669}
-
John Budorick authored
Also fix bucket ordering after yesterday's prefix removal. Change-Id: Ic17c93305993be7506dd6decfc75ec04854ee7b9 Reviewed-on: https://chromium-review.googlesource.com/c/1372649Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615668}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8435aca79e4d..7814fa265093 git log 8435aca79e4d..7814fa265093 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 pasko@chromium.org devil: docs: clarify what devil is Created with: gclient setdep -r src/third_party/catapult@7814fa265093 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibaaf4529ba327e65f46f9dcb2e317e4ff35ca352 Reviewed-on: https://chromium-review.googlesource.com/c/1372668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615667}
-
Xi Han authored
ServicificationBackgroundServiceTest. Add a check to make sure the background tasks are running in ServiceManager only mode and the full browser doesn't start. Otherwise, if the test falls back to start the full browser, it won't be able to detect any failure that happens only in the ServiceManager mode. To do this, we plumb the startup result from the native to Java via the callback when ServiceManager started. The callback will tells Java if the full browser is starting. Bug: 904549 Change-Id: I39d39166269fa0fcebf54b9d8ece3b6c761a223a Reviewed-on: https://chromium-review.googlesource.com/c/1363369 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615666}
-
manuk authored
For matches with long text, the regex filtering algorithm's performance becomes problematic. For matches of about 350 characters, occasional lag becomes noticeable as you type the filter text. For matches of about 500 characters, the page approaches unusable when trying to filter. When the match text being filtered is longer than 200 characters, we truncate it to 100 characters and `console.warn` a message. Bug: 891303 Change-Id: I79d9ce5eb17b479ddb0584aa0ac2e461938e8dac Reviewed-on: https://chromium-review.googlesource.com/c/1372308 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#615665}
-
Katie D authored
This continues the refactor of Tts from chrome/ into content/. Bug: 517317 Change-Id: Ib607ef45f2486f20e5bd8d986baaf6176194ce07 Reviewed-on: https://chromium-review.googlesource.com/c/1366788 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#615664}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6a4a425f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I9bcd31d88878d09d15812b4f2014772a5453c97f Reviewed-on: https://chromium-review.googlesource.com/c/1372311Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615663}
-
Dana Fried authored
Bug: 913274 Change-Id: I8ca09d553d4cce55887604f07300aa0685a7f498 Reviewed-on: https://chromium-review.googlesource.com/c/1372309Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615662}
-
Matthew Mourgos authored
Bug: 912198 Change-Id: I9011485d088c1c08c11597543cb36bcb66766ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1364331Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615661}
-
manuk authored
Additionally, typically the inline text is a suffix of the fill text; e.g. typing 'g', may result in the inline text 'oogle.com' and fill text 'google.com'. To conserve space and mimick how the actual omnibox displays the inline and fill texts, we display the inline text only once, and format it (1px border & bold font) to distinguish it from the fill text; e.g. g|oogle.com|. In the yet-unencountered case where the inline text is not a suffix of the fill text, we display both adjacent. Bug: 891303 Change-Id: I8096eca7b14d84be0941ae19c5a076cbc782218c Reviewed-on: https://chromium-review.googlesource.com/c/1372231Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615660}
-
David Lu authored
Bug: 896461 Change-Id: Ie34adadd37e87630816d5a776429c06e7d1ec204 Reviewed-on: https://chromium-review.googlesource.com/c/1370203Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: David Lu <davidluphd@google.com> Cr-Commit-Position: refs/heads/master@{#615659}
-
Justin Donnelly authored
Also fix an issue with the score boosting. Bug: 913299 Change-Id: Ia44b6e8658a37a75a1f64776306d764dc73d25ae Reviewed-on: https://chromium-review.googlesource.com/c/1370394Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#615658}
-
Justin DeWitt authored
This is a one-off solution just for Explore Sites. It does the following: * Changes the job ID for ExploreSitesBackgroundTask 100->101 * Deprecates job ID 100 * Cancels any tasks with job ID 100 when they are executed by JobScheduler * Forces ProGuard to keep the ExploreSitesBackgroundTask class name without obfuscation. Bug: 908476 Change-Id: Ib769e6678a82771a68dec86c04a73621f21fa9e1 Reviewed-on: https://chromium-review.googlesource.com/c/1370318 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#615657}
-
danakj authored
Have ChromeClient go directly to WebWidgetClient instead of through the WebFrameWidget. The WebFrameWidgetImpl would go either to the compositor (which always exists) or to WebWidgetClient. The latter path was dead. Similar in WebViewImpl. Then when ChromeClient (via plumbing..) would ping the compositor, it would callback to RenderWidget to say RequestScheduleAnimation() for single-thread-no-scheduler tests. This would redirect to WebWidgetClient (empty for RenderWidget) in order to pick up test overrides. Instead, ChromeClient goes to WebWidetClient which is RenderWidget (or test overrides). RenderWidget goes to the compositor. Then we don't need the callback from the compositor anymore, so remove it and change tests to watch ScheduleAnimation() as needed directly instead. WebLayerTreeView also has an equivalent of ScheduleAnimation() which would get to the test harness by round-tripping through cc. Instead of re-routing it, remove that API and have callers go through the WebWidgetClient to ScheduleAnimation(). R=dcheng@chromium.org TBR=dcheng for components/ Change-Id: I3c1a5a4c2c6dfc8008067891531b35e5d845b4ba Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1369032 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615656}
-