- 03 Jan, 2020 40 commits
-
-
Alison Maher authored
This change is a follow-up to the intrinsicSizes implementation based on feedback in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1949536 The main changes are as follows: 1. Pass in the correct information to CalculateChildPercentageBlockSizeForMinMax(). 2. Subtract out border_scrollbar_padding_ instead of border_padding_ from the intrinsic sizes if in legacy layout. Bug: 726125 Change-Id: I430a029ef76f7326a3224593c4c9bac18c0e94d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980895 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#728232}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4cbf1de4ac07..ccd45a5efe06 git log 4cbf1de4ac07..ccd45a5efe06 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ab3cf9c7bd22..605b00d7728f (1 commits) 2020-01-03 brianosman@google.com Tweak the CanvasKit interface to SkRuntimeEffect 2020-01-03 mtklein@google.com one more flourish 2020-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cbbfa2f28a0e..1fdf6ca5141d (1 commits) 2020-01-03 mtklein@google.com ultimate retry for image shader cleanup 2020-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 81693dc9..a12a9d87 (186 commits) Created with: gclient setdep -r src/third_party/skia@ccd45a5efe06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I53c5370ac0cad09185c34432b0b4d7b0a278bacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728231}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e198b494fa086f68300bf6d0ad8418dc733eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986849Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728230}
-
Antonio Gomes authored
... instead of a dummy empty function on anonymous namespace. BUG=787254 R=haraken@chromium.org Change-Id: I39beabcbe99175a895522c7cca1e16d4c4aa0424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986132Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728229}
-
Tomasz Wiszkowski authored
This change allows all suggestions to benefit from Spannable container that introduces .equals for Spannables. Bug: 982818 Change-Id: Ia31d7baf2fb4a97556090867b1f29e9f8fb1547b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968115Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728228}
-
Antonio Gomes authored
... to use of the corresponding WTF counter part bind functionality. BUG=787254 R=haraken@chromium.org Change-Id: Icdd46e7cbe5da49110fe9fe9cbba911a6a56f396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984504Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728227}
-
Evan Stade authored
Bug: none Change-Id: I0f8e0c81f64f0c340b95374296d85800c4197c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986236Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#728226}
-
Regan Hsu authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1967803, while learn more links were being swapped out with settings-localized-link elements, "nearbyPrintersListDescription" was incorrectly used for the link-url attribute when "printingCUPSPrintLearnMoreUrl" should have been instead. This CL corrects that mistake. Fixed: 1038646 Change-Id: If35351143c81c17e2bcaec0268281a41d9fcf576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985137Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728225}
-
Antonio Gomes authored
... now that it is out of the Blink API layer. This is a follow up of crrev.com/c/1976214 BUG=919392, 704136 R=haraken@chromium.org Change-Id: I43a004e6c6eb170f95eca3704f4cb52efb142fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984503 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#728224}
-
Eric Seckler authored
Previously, we already didn't emit the category or event name for end events that were split off from complete events. In preparation to the switch to the client libary, stop emitting them for explicit end events, too. Trace processor will match the begin/end pairs and emit the matched begin event's category and name when converting to JSON. Also stop emitting names of nestable async events (categories are still required as they are included in event ID matching [1]). [1] https://cs.chromium.org/chromium/src/third_party/perfetto/src/trace_processor/importers/proto/track_event_parser.cc?bpv=0&bpt=1&l=394 Bug: 928738 Change-Id: I80810ac555355270297f09804343107bed2bbbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983174Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#728223}
-
Nicolás Peña Moreno authored
Currently, idlharness fails because attribution is not frozen in the toJSON output. This CL fixes that by calling FreezeV8Object on the object. In addition to this, we remove the loop and produce interface objects instead of JSON objects per the algorithm in https://heycam.github.io/webidl/#es-default-tojson. Change-Id: Idc4e2adb1c8bfedc296817d1ca259b2ab90fdb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986015 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728222}
-
Evan Stade authored
This change makes it easier to construct IconDescription by adding default values to three out of four constructor params. No functional change is intended, although on SK_ColorBLACK is changed to gfx::kPlaceholderColor. This should not matter because all the icons it applies to have hard-coded colors for every individual path (verified manually). Bug: none Change-Id: Ieed356656b2e1f346cbecd76a4d230a445873e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985124 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728221}
-
David Bokan authored
It looks like this crashes because of a null outer viewport scroll node. That should never happen here because we have an inner viewport scroll node. There's a few ways this could be going wrong: - A ScrollNode is marked as the inner scroll node even though it wasn't registered as one in viewport_property_ids_ - The ScrollNode doesn't exist in the property tree even though it was registered. - We're getting this bad combination from Blink. I've turned a few DCHECKs into release CHECKs to narrow down which of these it might be. Bug: 1037759 Change-Id: I972582da6e18725557859063da0889d465063c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981268 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728220}
-
Abhijeet Kandalkar authored
The goal of this CL is to use new downcast helper and remove DEFINE_COMPOSITOR_KEYFRAME_VALUE_TYPE_CASTS from t_p/b/r/c/animation to adopt new downcast helpers. This CL removes DEFINE_COMPOSITOR_KEYFRAME_VALUE_TYPE_CASTS for below classes. - CompositorKeyframeColor, - CompositorKeyframeDouble, - CompositorKeyframeFilterOperations, - CompositorKeyframeTransform Bug: 891908 Change-Id: I2b34d477f21cb0aa016f78f7d7292c55809abaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983680Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#728219}
-
Philip Rogers authored
This patch removes two redundant paint test configurations: INSTANTIATE_SCROLL_HIT_TEST_SUITE_P INSTANTIATE_LAYER_LIST_TEST_SUITE_P These were used for the rollouts of PaintNonFastScrollableRegions [1] and BlinkGenPropertyTrees [2]. [1] https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw [2] https://docs.google.com/document/d/17GKr2uIH2O5GthdTyvJpv1qZjoHYoLgrzvCkbCHoID4 Change-Id: I4cb416b0acf296daa74c8ed526e1aa5a066fee32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986776Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728218}
-
Yao Xiao authored
Cross-origin redirect downloads from <a download> was disallowed http://crrev.com/c/1627209 as it was a way to circumvent the multiple download protection. It seems to be an overkill as it breaks the single download case. Later changes happened in the DownloadRequestLimiter around the use of "initiator origin" (http://crrev.com/c/1657031) further strengthened the protection, so even without the previous fix, this type of download will still be prevented because the initial <a download> request and the redirected download both have the same initiator origin. This CL: 1) Removes the FromDownloadCrossOriginRedirect() check in IsNavigationRestricted() that was introduced in previous fix. 2) Plumbs through |from_download_cross_origin_redirect| to CanDownloadImpl() and when it encounters such download, always allow it. Bug: 1025149 Change-Id: Iaefc42838c30ce0dbc2f372e6e105a9d49b30cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978817 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#728217}
-
Alex Turner authored
Adds PageLoad.Cpu.TotalUsage and PageLoad.PaintTiming.NavigationToFirstContentfulPaint, which are both high-level metrics that allow us to track the impact of (ads and other) scripts on page load performance. Bug: 1036160 Change-Id: I530481cd5023d159624defb7e9ccf992945d0b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977957 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#728216}
-
Toni Barzic authored
When deciding final hotseat position, give the last drag velocity precedence over last hotseat position, so short upward flings (which are not long enough to move hotseat up by half of its length) still move the hotseat to the extended state. This was previously flipped in CL:1870051 because last_drag_velocity_ had upward value while dragging down to the bezel - the likely cause of this issue is last_drag_velocity_ not being reset when completing drag handling, so in cases where drag handling does not encounter ET_SCROLL_FLING_START (which might happen if drag exits the screen bounds), last_drag_velocity_ from the previous drag would be used. The described issue is fixed as part of this cl. BUG=1035024 Change-Id: I246121d84820fd3c633753b1d4d01dad0e323ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983268Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#728215}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/df344bb8dec4..0f14db22decb git log df344bb8dec4..0f14db22decb --date=short --first-parent --format='%ad %ae %s' 2020-01-03 peah@webrtc.org Reduce for reallocations the pre-amplifier and high-pass filter Created with: gclient setdep -r src/third_party/webrtc@0f14db22decb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I09615b84d6a88b6da1c3158156902f5217f15d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728214}
-
Oleh Lamzin authored
Keep the same function order in .cc as in .h for WilcoDtcSupportdBridge. Bug: none Test: run existing unittests Change-Id: I7ff0c026821de7021e00b3cda4f38e99bb843407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985946Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#728213}
-
Oleh Lamzin authored
Move WilcoDtcSupportdBridge::HandleEvent function to private section. Bug:none Test:existing unittests Change-Id: I13982544accd0c924900941ecca6f83dc414e349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985987Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#728212}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7ac038f302f2..4cbf1de4ac07 git log 7ac038f302f2..4cbf1de4ac07 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 benjaminwagner@google.com [infra] Use POSIX paths for Docker containers Created with: gclient setdep -r src/third_party/skia@4cbf1de4ac07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ie327f886bd0db74c7d727e24df27c0177387b694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728211}
-
Antonio Gomes authored
This CL migrates WebMediaTrackConstraintSet away from both std::string and std::vector, in favor of their WTF counterparts. Next, the class itself will be renamed from WebMediaTrackConstraintSet to MediaTrackConstraintSetPlatform (since MediaTrackConstraintSet exists). BUG=923394 R=guidou@chromium.org, haraken@chromium.org Change-Id: I310362d7b8cc2694f34b23724b022f68458808e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728210}
-
kylechar authored
This CL starts to remove code in content/browser/renderer_host/ that existed to receive CompositorFrames and submit them to the display compositor running on the browser UI thread. The VizDisplayCompositor feature has launched so this code is no longer used. This CL is a first pass to delete code that doesn't have require significant changes to tests. TBR=sky@chromium.org Bug: 759653, 812322, 1038683 Change-Id: I7bf29f57e7418eb8d3a16b86169f2b30bb9fbf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978997Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#728209}
-
Robbie Gibson authored
I ran the test multiple times locally and wasn't able to reproduce the flakiness. However, the error is the same as that observed if you remove the viewport tag from |LoadHtml| and the same as the issue described in that comment. I tried adding in the -webkit-text-size-adjust flag in hopes that the two methods together will prevent flakiness. Fixed: 1038529 Change-Id: I742005ec22618566c6279d89fe9d1d7ca47c2867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983171Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#728208}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/76bd0f030f3c..71b51fa69ee9 git log 76bd0f030f3c..71b51fa69ee9 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 nator@chromium.org [PeriodicBackgroundSync] Remove DevTools experiment Created with: gclient setdep -r src/third_party/devtools-frontend/src@71b51fa69ee9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1038678 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc53ab7ee73d62e4760d97c7b23c4780f07f844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728207}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7af927e60755..15e191fdcca2 git log 7af927e60755..15e191fdcca2 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 moragues@google.com mushu: add board 2020-01-03 tcwang@google.com afdo: Replacing the email of old sheriff rotation to new one Created with: gclient setdep -r src/third_party/chromite@15e191fdcca2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Iaabc23c4513a2d715b8e9808b2dca07a51f2ee3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728206}
-
Dave Tapuska authored
Since the class is no longer memcopied between processes we can use virtuals. - Add virtual destructor - Add pure virtual cloning - Remove memset - Remove size attribute BUG=836826 Change-Id: I92f7c1394009223d0e7970929ae5cdfc4bec2b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972167 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728205}
-
Koji Ishii authored
Following bot results are included. 775 777 779 780 781 782 783 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 808 809 810 811 813 814 815 816 817 818 819 820 821 33 lines were removed and 17 lines were deflaked by consecutive results since 788. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I0b739907c03c41eb7e5b021b5adf26a1fb31faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983105Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728204}
-
Dave Tapuska authored
- Define ScrollDirection in mojom. - Move bubble scroll methods into LocalFrameHost and RemoteFrame interfaces BUG=1008432 Change-Id: Ib8cda8a7c403cc483d4c718521f87f5f46642b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955858Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728203}
-
Ian Barkley-Yeung authored
c2978022d178 Update comment to match current state of MemorySnapshotGeneric 558b7ea43ff5 Pass --always_allow_feedback during integration tests Bug: chromium:1037656 Change-Id: I3c95e30aa585cf6782b6c66c0ce8bc3e063d1ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985123 Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#728202}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/873610ca688a..df344bb8dec4 git log 873610ca688a..df344bb8dec4 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d4992c6f..9427b393 (728071:728171) Created with: gclient setdep -r src/third_party/webrtc@df344bb8dec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I25b62fd3fade9341ecf6f20d859b358982e777b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728201}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ee635638fc1..7ac038f302f2 git log 4ee635638fc1..7ac038f302f2 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 benjaminwagner@google.com Move Android GPU ASAN jobs to NVIDIA_Shield. 2020-01-02 herb@google.com Document fBrokenRun in VertexRegenerator. 2020-01-02 benjaminwagner@google.com Add xSAN jobs for Vulkan 2020-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 25234a0a9c2c..ab3cf9c7bd22 (1 commits) 2020-01-02 mtklein@google.com add some useful Debug/ASAN bots 2020-01-02 mtklein@google.com build libjpeg-turbo with -DUSE_CLZ_INTRINSIC 2020-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ec78f685becd..25234a0a9c2c (1 commits) 2020-01-02 brianosman@google.com Move SkRuntimeEffect.h to include/effects 2020-01-02 brianosman@google.com Fix asserts in SkRuntimeEffect color filter benchmarks 2020-01-02 benjaminwagner@google.com Enable Vulkan Debug layers 2020-01-02 mtklein@google.com reland "clarify that there's no kMedium here" 2020-01-02 mtklein@google.com Reland "pass more information to shaders" Created with: gclient setdep -r src/third_party/skia@7ac038f302f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I1cb50634a21f5102bf17de08cc21c345607fdcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728200}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f7810a6a39e..114e7ffbe641 Created with: gclient setdep -r src-internal@114e7ffbe641 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic013fb7ac0aed5da8250c1aa37450c91641a4f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986772Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728199}
-
Olivier Robin authored
Bug: 1037681 Change-Id: I118bc49076c2ab9e658d60fc926781923166f18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986077 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#728198}
-
Michael Lippautz authored
This change enables detailed class names for debugging when the marking verifier is enabled. Change-Id: I2d0c8e3587a28768eeb8bad5cc4f5de85c81e578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986785Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#728197}
-
Peter Marshall authored
This test registered a callback that was an async function, but the caller doesn't await the result. This means that we re-entered the callback and modified the global counter, which was not expected. Update the test to de-register the callback before awaiting the stopTracking call, even though we still have an async function where it doesn't belong, this could at least stop the flakiness. Bug: 824904 Change-Id: Ib32eabdefb409f082dcb1f99db5f1d527fff88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986080 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#728196}
-
Francois Beaufort authored
Bug: 1038778 Change-Id: I0ebc318354a8b2f2101e2a9097dd4511f28c3deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986069 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#728195}
-
Balazs Engedy authored
The tests used to work with a global singleton CrowdDenyPreloadData instance. This is wrong semantically, and had also been leading to use-after-frees because this global instance used to a reference to a ThreadPool instance that would be created (and destroyed) with the first ever test case run. Bug: 1038902 Change-Id: Ie6e560de3a779e7d9621bbe5a53587a76a019826 TBR: andypaicu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983176Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728194}
-
Yi Gu authored
The test was flaky on Mac 10.13 due to Timeout rather than Failure. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=virtual/threaded/fast/scroll-snap/snap-to-area-with-fractional-offset.html Bug: 1036054 Change-Id: I497b3bb58fc15fd29be0608f6be3326dd7085e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986767Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728193}
-