GitLab

CHROMEOS macro is defined in third_party/webrtc.
This CL replaces it with more appropriate macro.

Bug: None
Change-Id: Ia62a2a1e4b129f7aef7aadb2e7d8158ff06b22f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022045Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735660}

CL:1549297 adds scrolling to the top level menus hanging off a menu
button. The calculation for limiting the height of the menu allowed the
menu to sit inside the viewport with a large number of pixels gap
resulting in a scroll-bar and scrollable region when the menu could
fit inside the viewport without scrolling.

Changes the calculation of positioning the top level menu so that more
vertical space is used - limiting the height to 2 pixels less than the
viewport. The 2 pixel gap at the bottom of the menu serves as a visual
indicator for the user so they can see the menu ends there, rather than
it appearing to be clipped.

Bug: 1040058
Tests: browser_tests --gtest_filter="FileManagerJsTest.MultiMenu"
Change-Id: Idb7d1199095d5d5e7482cc5b8eaa228439202bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018364Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735659}

CHROMEOS macro is defined in third_party/webrtc.
This CL replaces it with more appropriate macro.

Bug: None
Change-Id: I7c5c5928424c026b1fb679814617c1134c0d5537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022584Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735658}

CHROMEOS macro is defined in third_party/webrtc.
This CL replaces it with more appropriate macro.

Bug: None
Change-Id: I38fd9e830b8d4b9a6585f7b554377e364daf50e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022024Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735657}

9df6272 Move buffer and buffer_pos down (#125)
43c6826 Fix strtod.cc undefined constants (#123)
1dce44c Add full license to test .cc files missing it. (#121)
8857767 Add wasm32 as supported platform (#120)
a54561b Pseiderer/add nios2 and xtensa 001 (#119)
5cc233e Add support for microblaze.
4a51e73 Add support for e2k architecture. (#118)
7da5db9 Add min exponent width option in double-to-string conversion (#116)

Bug: 977230
Change-Id: I89fbe9295172df16ae2668b750aeac6293e7b361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023865Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735656}

CHROMEOS macro is defined in third_party/webrtc.
This CL replaces it with more appropriate macro.

Bug: None
Change-Id: I440c0cf528ebb2c9ca3549a23e180026a2fc8a9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021787Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Hiroki Sato <hirokisato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735655}

Queries the CookieManager for each URL and doesn't prefetch if there
are any cookies for that page.

Bug: 1023485
Change-Id: Idff1feb22a03a5d30c13556d27cd4ffdd867fd05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020754Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735654}

These are no longer used as partial raster has shipped and is not being
tuned.

Bug: 1030142, 1021382, 997971, 991053
Change-Id: I6b5e8a28259e98a82ac2a51baed168fb70e724cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020528
Commit-Queue: Eric Karl <ericrk@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735653}

This CL adds support for, but never triggers, two kinds of mixed content
download warnings that show up in the download shelf. Neither is used
yet. These supplement the existing silent blocking.

The warnings look like this:
- https://drive.google.com/file/d/1HKKrRv4uScGsVv_l8J9huZLnHWp-j_t6/view
- https://drive.google.com/file/d/1TgSTEFh1n0gWn1CpJnqkP4imhtkk20gd/view

This CL also adds support for these warnings in the chrome://downloads
UI. There it re-uses the "dangerous" download warning without any
modifications beyond a custom string.

All MIX-DL blocking logic is guarded by a flag, but even when that flag
is enabled, this change is not triggered and is thus not visible.
Subsequent CLs will:
 - trigger these warnings when appropriate,
 - finish the UI for Android, and
 - add proper testing.

This is part of go/downloads-as-mixed-content

Bug: 960819
Change-Id: Id69adca8f5b7ae9acab9384435bb84257acaa9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984470Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735652}

This reverts commit da0bf646.

Reason for revert: Breaks the downstream clank build

Original change's description:
> Rename CopylessPaste to DocumentMetadata to reuse the class for other purposes
> 
> Bug: 1044244
> Change-Id: I7af8208b8c5a25f247b09cc0cbe55d44934f1d2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020604
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Sam Bowen <sgbowen@google.com>
> Cr-Commit-Position: refs/heads/master@{#735612}

TBR=dcheng@chromium.org,haraken@chromium.org,beccahughes@chromium.org,sgbowen@google.com

Change-Id: I0cdec26603543fe5f50140c7e8bee9988229e36d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1044244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024073Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735651}

These histograms are still used to track common ad sizes, and size of
small tracking iframes that are used for advertising purposes.

Bug: 1034591,1034590,1034589
Change-Id: I8cb1c32e62119f28ee2653d3124555f9a2e9eeeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022260Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735650}

Bug: 1042807
Change-Id: I9f8554970d5344bf9c90ced78aa925e8fa77282b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023276Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735649}

This will prevent crashes in cases where the current blocking page
reference has been released. Underlying issue will be fixed in a
follow-up CL.

Bug: 1044768,1045038
Change-Id: Ieda79f321a3f933369a74e539267ead95106d6e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015669Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735648}

Reduces use of margins and calc in the checkup banner.
Checkup banner image and text overlap when the screen width is 930px.
Issue: https://screenshot.googleplex.com/0r8JXYYOOvY

1 column: https://screenshot.googleplex.com/qTuVDG6rcBb
2 column: https://screenshot.googleplex.com/QRm4c4XjF0u

Bug: 1019296
Change-Id: Iee4071726c78871f2ddf79ec619231473d71a2b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995922Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735647}

Using wpt-import in Chromium 46a3fc7d.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I60a54be1205e40db6f45e1a4214eeaca03a6f149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023967Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735646}

So long for now, Chromium!  I hope we meet again :).

R=dpapad@chromium.org
BUG=letting me touch the code

Change-Id: I28b1c05fe6ab51558f51e59c17803b4581759480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014144Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735645}

This cl adds padding in supervised user error page.

Bug: 1045152
Change-Id: Ic0e06df7b53dabf178b67b592526b2ec3cc84307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023196Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735644}

The design doc for the experiment is at
go/e14s-assistive-personal-info-exp
Though the experiment is not approved yet. I think it better to add a
flag first and try implementation behind it.

Test: Tested with emulator on Linux
Bug: 1042084
Change-Id: I623edcca0a1c43d5e52cb4d6c96cb25581168369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018342Reviewed-by: Keith Lee <keithlee@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735643}

Doing this mostly to make it clear what to expect from a page which
kills the renderer but also to make clear exactly what counts as
finished.

Change-Id: I881723a2cf5061de6f807919fda30e43dfff6ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014627Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735642}

Bug: 1043490
Change-Id: I189949505f56b21f6a362d41f6319bb8da58c654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023226
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735641}

https://crrev.com/c/1500020 made this test parameterized but did not
add INSTANTIATE_TEST_SUITE_P(MHTMLGenerationSitePerProcessTest).
Googletest warns about this in its console output but doesn't fail.

I've filed https://crbug.com/1045846 to try prevent this happening in
future, as I almost did something similar.

Change-Id: I6b08f79e007612f3c58c54b8554401f48bf48a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022564Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735640}

Adds a new Feature ContextualSearchTranslations that does inline
partial translation using CoCa to get a translation during the
Resolve request.

This adds a flag to chrome://flags and will send an integration
code to the server to allow Translate card responses.

The server is all set up for this already, except that it switches the
positions of the translation and the original text from what we're used
to on our team.

TODO: unit tests.

BUG=952401

Change-Id: Ia22b5bba4a6c98a3d8717decf99a20c9698a3038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018485Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735639}

This reverts commit c5dca82e.

Reason for revert: https://crbug.com/1046058

Original change's description:
> Roll src/third_party/SPIRV-Tools/src b97057e7f747..1b3441036a8f (6 commits)
>
> https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b97057e7f747..1b3441036a8f
>
> git log b97057e7f747..1b3441036a8f --date=short --first-parent --format='%ad %ae %s'
> 2020-01-24 syoussefi@google.com Fix chromium build (#3152)
> 2020-01-24 dneto@google.com Clarify mapping of target env to SPIR-V version (#3150)
> 2020-01-24 greg@lunarg.com Use dummy switch instead of dummy loop in MergeReturn pass. (#3151)
> 2020-01-23 alanbaker@google.com Fix structured exit validation (#3141)
> 2020-01-23 dneto@google.com Add spvParseVulkanEnv (#3142)
> 2020-01-23 jaebaek@google.com Handle conflict between debug info and existing validation rule (#3104)
>
> Created with:
>   gclient setdep -r src/third_party/SPIRV-Tools/src@1b3441036a8f
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
> Please CC radial-bots+chrome-roll@google.com,timvp@google.com,syoussefi@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
> Bug: None
> Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,syoussefi@google.com
> Change-Id: If9579d754397acc9c4402bc11ddfb346732a823a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021434
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#735222}

TBR=timvp@google.com,syoussefi@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com,radial-bots+chrome-roll@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Bug: chromium:1046058
Change-Id: I46e1d36ab9209c7ce12b1169bccb6d2c72435ba4
Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023990Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735638}

Bug: None
Change-Id: I53f5ffc3ae7a314bf799cc243ab491aa535cff2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023475
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735637}

Renamed the study to match the respective finch config.

Change-Id: Ie1fefeb62e5c6cb451bb0863fa204bec91833caf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019023
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735636}

Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`.

This increases the clang version from 10 to 11.

Bug: 1030664
Change-Id: I8b7ad7f85895abda80e45860ab7e0215e6740d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020894
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735635}

Bug: 1022143
Change-Id: I0b381df87615afae66fa65e832eaa28f2796c452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023667
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735634}

Refactor EndBatchReadAccess() to remove the entry for the current
context correctly for all the cases even though there are no registered
backings in the current context.

Bug: 1045677,1045127,1045242
Change-Id: I1a8081193900ec5d7f8955bdbd00eff96ccef68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023289
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735633}

Dragging a tab group around acts the same as dragging a tab. The
dragged tab group takes the index of the tab or group it is being
dragged over.

Bug: 1027373
Change-Id: Ie70883a16330e09732e1bad02e2112d2511cb51e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018499
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735632}

This change adds the origin_trial_feature_name entry and adds a test
for the expected interfaces.

Change-Id: Idd79b99fc61e9eee925732745be2bcd8c35afe92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019330Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735631}

BUG=1038487

Change-Id: I86f44dac59451af54966304d55f827e6f23d9de8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021790Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735630}

Reporters should not be advanced to Active stage prior to Submit.
Currently the reporter in BeginImpl and BeginMain will be move to
Activate stage in case of ImplFinish and BeginMainAbort.
This might result in losing the previous reporter in Active stage which
might be needed for submit.

Bug: none
Change-Id: I90b7161f8daebb8884ce23b4fc4cc9d593dea09d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993743Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735629}

This is to avoid the spinner that shows while the Get Help app loads.
See context in https://crbug.com/1026620#c48.

Bug: b/145710734
Change-Id: Ifb24fdc6242ea9ac52ba6129ba14ffda641997f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016523
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735628}

Bug: 1045980
Change-Id: I3eed762b79c3bdda55271a1b5716277a3ba32336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023675Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735627}

I verified on the Harmony stickersheet that these are intended to be supported
styles.  Losing them was a regression in r716332.

Bug: 1042809
Change-Id: I3e1ab146fbfb6d4702afb77963a026316a1cce39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024107Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735626}

For the workflow where you drag from one overview grid and drop into
another, the present CL expands a unit test to explicitly check that the
destination grid is arranged in MRU order, although if it were not then
the stacking order would also be wrong and the test would fail anyway.

Bug: None
Change-Id: I15baba6a9812db409b1c8897155290cdf7cd3c4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023345Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735625}

Clearing the BinaryUploadServices is missing from

the associated Profile after the profile has been destroyed during
shutdown.

ServicesManagerDesktop: :ShutdownServices which can cause accesses to
Change-Id: Id4c0862dcae5d0772cd44ca43c3ec71ede95a864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024030
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735624}

Roll airmont AFDO profile from 81-4025.0-1579516880-benchmark-81.0.4019.0-r1 to 81-4028.0-1580123479-benchmark-81.0.4019.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I915a2dd0760123e4f9ef6433fd2c7642b03eeaf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735623}

- We prefer to have no periods for UX single sentences

Bug: 1015628
Change-Id: I6fc71162830b9a05349614d5ff84dabf6e4304f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022900Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735622}

Addressed two deprecated methods in SuggestionDrawableState.

Some polish around the switch to generics to ensure we don't lose
generic types through the various call stacks.

Some small javadoc/other cleanups too (to get rid of the underlying
in my IDE).

BUG=982818

Change-Id: I8bd90bd73a7fa826f2f2bf5dc2eb94dd2f5d0e3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023198Reviewed-by: Ender <ender@google.com>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735621}