GitLab

Since the feature is already launched and we do not need to monitor
performance impact any more, let's remove intervention related metrics.

Bug: 578029
Change-Id: I11f682d3bfcfe5f2bd5ec8d27c355635568489d5
Reviewed-on: https://chromium-review.googlesource.com/722820Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510058}

It seems they were used to make sure users are aware of that the
contents in the String argument must be "output of KURL::GetString()
called on a valid KURL object, or indiscernible from such" as noted in
the comment.

However, these methods are actually performing validation and there's
no fast path assuming the input is valid.

Considering the value of the annotation and additional character typing
in coding, I'd like to propose removal of it.

The constructor invocation in WorkletModuleResponsesMapTest.cpp that is
taking String() (i.e. null String) is replaced with KURL() invocation.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I40f433e6c1472fba559af9b87ea12cff06d21045
Reviewed-on: https://chromium-review.googlesource.com/718236
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510057}

This reverts commit 38636aa2.

Reason for revert: downstream failure: unable to find chromium-debug.keystore (internal bug: http://crbug.com/776328)

Original change's description:
> Android: Remove last remnants of ANT
> 
> It had a good run.
> 
> Bug: 375324
> Change-Id: I1db1d501f58d3d3ac8731bc36e8ca550da24adf9
> Reviewed-on: https://chromium-review.googlesource.com/722521
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509785}

TBR=thakis@chromium.org,agrieve@chromium.org

Change-Id: I7323c95dcdd47145166d6bbd61345cc17db2e7d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 375324
Reviewed-on: https://chromium-review.googlesource.com/727902Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510056}

Currently the RequestGlobalDump has an ambiguous dual semantic: return results
or add to the trace. For historical reasons both semantics have been collapsed 
in the same function, but this is now getting too hairy, making the codebase hard
to reason about, and caused some bugs.

Splitting the functions names as they clearly achieve two different functions
with different outcomes, specifically:
When adding the dump to the trace, clients don't care about the returned
object (which also happens to be empty). Likewise when returning the dump
(e.g. for SUMMARY_ONLY) the clients don't care about the dump_guid.

Bug: 775039
Change-Id: Ia0861bcd20775802813a35f5a138fa022521f416
Reviewed-on: https://chromium-review.googlesource.com/721540
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510055}

Steps to replicate:
1. Build clang-tidy and clang-apply-replacements as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
2. Build blink in out/gn.
3. Generate the compilation database:
  tools/clang/scripts/generate_compdb.py -p out/gn > compile_commands.json
4. Run clang-tidy and apply replacements:
  cd out/gn && PATH_TO_RUN_CLANG_TIDY/run-clang-tidy.py -p ../../ -clang-tidy-binary PATH_TO_CLANG_TIDY_BINARY -clang-apply-replacements-binary PATH_TO_CLANG_APPLY_REPLACEMENTS_BINARY -checks=-*,hicpp-use-nullptr -fix -j 8 third_party/WebKit

BUG=403854

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4e8f3f82bdfcda6afb89755a20c78cc4cb7aa571
Reviewed-on: https://chromium-review.googlesource.com/720361
Commit-Queue: Ivan Kotenkov <kotenkov@yandex-team.ru>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510054}

When a pushed suggestion is received, ignore it if it exists in
one of the following
- Currently shown articles.
- Dismissed articles (was already implemented before this CL).
- Archived articles (i.e. possibly shown on previously opened NTPs).

Bug: 774122
Change-Id: I46076e432b1ecd12c47e550a5faea7c0c36d6432
Reviewed-on: https://chromium-review.googlesource.com/713495
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510053}

Gaia started sending the auth code in the same response as the Gaia cookies.
The auth code is now send in the following responses:
* For the regular sign-in case, the auth code and the cookies are sent in an
XHR response.
* For sign-up and when JS is disabled, the auth code and the cookies are sent
in main frame response.

This CL ensures that the DICE header is parsed on all Gaia responses (so far
XHR were ignored). This allows Chrome to correctly extract the auth code from
XHR responses, adapting the DICE sign-in flow to the new Gaia behavior.
  
Note: This flow is also used for DICE fixing auth errors that is already rolling
out in M62.

Bug: 775856
Change-Id: I9d19e44f0d5c8d81e5af399649507f6b23af46d3
Reviewed-on: https://chromium-review.googlesource.com/725382Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510052}

This reverts commit db2ec9ce.

Reason for revert: I reverted the wrong patch, sorry for the mess. It should have been the reland patch, https://chromium-review.googlesource.com/727122

Original change's description:
> Revert "Fire focus if needed in automation api"
> 
> This reverts commit 9af30c03.
> 
> Reason for revert: breaks Linux ChromiumOS Tests.
> 
> Bug: 776308
> 
> Original change's description:
> > Fire focus if needed in automation api
> > 
> > Bug: 773866
> > 
> > Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> > Reviewed-on: https://chromium-review.googlesource.com/723606
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#509911}
> 
> TBR=dmazzoni@chromium.org,dtseng@chromium.org
> 
> Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 773866
> Reviewed-on: https://chromium-review.googlesource.com/727982
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510044}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,mastiz@chromium.org

Change-Id: Iaa74032a25ec60545cf7be951b0dd0c7cf731afb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 776308, 773866
Reviewed-on: https://chromium-review.googlesource.com/727901Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510051}

Network Traffic Annotation Auditor switches current directory to source
before calling 'tools/clang/scripts/run_tool.py' as the script expects
to be run from there.

Bug: 656607
Bug: 690323
Change-Id: I5eeb872281b6966a341d159260c6037cba73aa99
Reviewed-on: https://chromium-review.googlesource.com/727881Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510050}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/037f9b80bbd8..c3d1208d5c69

$ git log 037f9b80b..c3d1208d5 --date=short --no-merges --format='%ad %ae %s'
2017-10-19 machenbach Revert "bot_update recipe: Upload source manifest"

Created with:
  roll-dep src/third_party/depot_tools


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=phajdan.jr@chromium.org

Change-Id: Idfba621d88ef838f1a38ed63a6e8205df3517d00
Reviewed-on: https://chromium-review.googlesource.com/727531Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510049}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f2f56bff..17c3128d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Iacf8b82efa88231884a4b6736e6fccf90c297f1c
Reviewed-on: https://chromium-review.googlesource.com/727941Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510048}

Goal is to match recent changes in third_party/webrtc/modules/audio_device/include/audio_device.h
where two unused APIs have been removed. This CL ensures that these methods are removed in Chrome
as well so I can then delete the signatures totally in third party (WebRTC).

Similar changes have been done in https://chromium-review.googlesource.com/c/chromium/src/+/657399

TBR=sergeyu

Bug: webrtc:7306
Change-Id: Ie63ca4db09911601b1cc606c9b5bd47b59add612
Reviewed-on: https://chromium-review.googlesource.com/725737
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510047}

https://skia.googlesource.com/skia.git/+log/7ce549f32ec2..6fb802e2b2e3

$ git log 7ce549f32..6fb802e2b --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I0e7dbf4b15f80c107def6082618345dfebfa5eee
Reviewed-on: https://chromium-review.googlesource.com/727534Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510046}

https://chromium.googlesource.com/catapult.git/+log/a25d87f24cc6..b9501ea73c6c

$ git log a25d87f24..b9501ea73 --date=short --no-merges --format='%ad %ae %s'
2017-10-18 benjhayden Add isReferenceBuild diagnostic.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia0496871f7ef7bace5393da7f113abf46adcbcaf
Reviewed-on: https://chromium-review.googlesource.com/726754
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510045}

This reverts commit 9af30c03.

Reason for revert: breaks Linux ChromiumOS Tests.

Bug: 776308

Original change's description:
> Fire focus if needed in automation api
> 
> Bug: 773866
> 
> Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509911}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773866
Reviewed-on: https://chromium-review.googlesource.com/727982Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510044}

R=dcheng@chromium.org

Bug: 772386
Change-Id: Ic352ad8d20838eab6e759f3a53f1d56d7bfb76b7
Reviewed-on: https://chromium-review.googlesource.com/720374Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510043}

There were three different DependentIOBuffer classes, three similar
kBufferSize constants, two similar InitializeResourceBufferConstants
functions and two identical GetNumericArg functions.

Besides being potentially confusing, it causes clashes in jumbo
build experiments (chromium unity build system in development).

This patch moves around GetNumericArg (to merge the two copies) and
InitializeResourceBufferConstants (to make them not clash).
It renames the DependentIOBuffer classes which are deceptively
similar as well as the kBufferSize contstants and some other
variables that were not actually constants.

Bug: 746953
Change-Id: Id7cfa4baac0aa67a7b086896701aeab931e23a96
Reviewed-on: https://chromium-review.googlesource.com/723302Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#510042}

This reverts commit 885d259d.

Reason for revert: Need to test new sound card config on win bots.

Original change's description:
> Disables WebRtcAudioQualityBrowserTest on Windows
> 
> TBR=phoglund
> 
> Bug: webrtc:677256
> Change-Id: I84a0fdf08a25204231ee1869918ecbffc8bdca9d
> Reviewed-on: https://chromium-review.googlesource.com/677458
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Commit-Queue: Henrik Andreasson <henrika@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503516}

TBR=phoglund@chromium.org,henrika@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 677256,737090
Change-Id: Ie41beeec00b3e3fbc7702ba6c7fd8a754c567e18
Reviewed-on: https://chromium-review.googlesource.com/727919Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510041}

https://skia.googlesource.com/skia.git/+log/95c5e3392f3a..7ce549f32ec2

$ git log 95c5e3392..7ce549f32 --date=short --no-merges --format='%ad %ae %s'
2017-10-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 082e70060..6dee4d8c1 (1 commit)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ie475ccf71d28e6456355d00730515800592662b1
Reviewed-on: https://chromium-review.googlesource.com/727701Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510040}

Bug: 631937
Change-Id: I1b0396f0dc757d9f445909ce244a6f72e1983b49
Reviewed-on: https://chromium-review.googlesource.com/700443Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510039}

This CL enables swarming for all builders using GOMA_TESTS in chromium_fyi.py
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Bug: 776264
Change-Id: I4c31bc7f47788186629d661b34bb16e82e4cfe0b
Reviewed-on: https://chromium-review.googlesource.com/727679Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#510038}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/43e99bf7..f2f56bff

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Iab2f48e478c57bf6775b9bc91a6ed893e2f59bbe
Reviewed-on: https://chromium-review.googlesource.com/727625Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510037}

BUG=739343, 775825

Change-Id: Ib0f997a0228fcf02b117d769644a31cd4b3352d0
Reviewed-on: https://chromium-review.googlesource.com/725342Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510036}

Historically, the Oilpan macros for Trace() methods were defined using
macros, since there were two different types of Visitors. The macros can
conditionally include virtual as well: however, this makes it harder to
enable the chrome clang plugin checks around usage of virtual, override,
and final. While it's possible to adjust the plugin heuristics to
account for these macros, the macro definitions are simple enough that
they are no longer needed. Replacement was automated using perl regex to
expand the macros. Manual fixes were required for:

  Source/core/dom/NthIndexCache.h
  Source/core/html/canvas/CanvasRenderingContext.h
  Source/modules/canvas2d/CanvasRenderingContext2D.h
  Source/modules/media_controls/elements/MediaControlDivElement.h
  Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
  Source/modules/vr/VRDisplayCapabilities.h
  Source/modules/vr/VREyeParameters.h
  Source/modules/vr/VRFrameData.h
  Source/modules/vr/VRStageParameters.h

Bug: 775741
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5901e047eb0f08050a00b8faab7ea731e7447db2
Reviewed-on: https://chromium-review.googlesource.com/726978
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510035}

Bug: 583291
Change-Id: I62f45a36db59b118a5f7a571252c4a4a705355b8
Reviewed-on: https://chromium-review.googlesource.com/725723Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510034}

These tests should have been re-enabled in 96a257b8, but weren't.
Do it for realz.

Bug: 570423
Change-Id: I3e2aa6e230af3412b854c2d2cb1a2dba03ced338
Reviewed-on: https://chromium-review.googlesource.com/725816Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510033}

I'm leaving Opera Software today.

TBR=eae@chromium.org
NOTRY=true

Change-Id: Id9e11f73d3a3cbc0f2a772f93945cff21e742933
Reviewed-on: https://chromium-review.googlesource.com/727981Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#510032}

When using network persistence and save a file that is not safe to save
with the desired name on the filesystem, devtools will now encode parts
that are deemed 'unsafe' to save on filesystem.

Example: 'con' and 'nul' are not allowed on windows. '?' also not
allowed on windows.

R=lushnikov,pfeldman
BUG=760316

Change-Id: I29bd227fc3f7f5f10a6b80ed45d21b6a7a6d34a2
Reviewed-on: https://chromium-review.googlesource.com/727195
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510031}

In e.g. some headless environments, we care about deterministic
rendering results. As the new content rendering timeout can affect page
rendering, we'd like a way to disable it.

This patch adds a command line switch to that effect.

Change-Id: Ib0c09aa57df82665ffb4f1290c8ad5d2761aa7bf
Bug: 776292
Reviewed-on: https://chromium-review.googlesource.com/725324
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510030}

This is basically same as https://chromium-review.googlesource.com/c/chromium/src/+/647050.
This CL tries to reland the change after rebasing.

This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is
recorded when a Document object survives 5, 10, 20 or 50 garbage
collections after detached. If a document outlives such long time, the
document might be leaked. The UKM would be very useful to know where such
leaky documents exist and to fix them.

Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing

Bug: 757374
Change-Id: I1f64d2a9260d898c386bb948dd25a1c5586f8eb7
Reviewed-on: https://chromium-review.googlesource.com/722301
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510029}

When we want to return an empty WebString, just explicitly return a
WebString() instead of going through the

    const char* -> WTF::String::FromUTF8 -> WTF::String -> WebString

path to achieve the same thing.

Bug: 736308
Change-Id: If3c9a45b3cac140a1a2d9d48c2b68558d09f106a
Reviewed-on: https://chromium-review.googlesource.com/726085Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#510028}

Bug: none
Change-Id: Id75500ca8b83d211e2b5c3a786e92f030791aedc
Reviewed-on: https://chromium-review.googlesource.com/726855Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510027}

Instead, fake implementation is added into FakeLorgnetteManagerClient,
and it replaces MockLorgnetteManagerClient in unittests.

BUG=223061
TEST=Ran trybot.

Change-Id: I6d9cde402dda453e5b5bdc59c26c384dea6bfd90
Reviewed-on: https://chromium-review.googlesource.com/726039Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510026}

The following tests relied on a callback occurring within a 2 second
window
while an animation was in progress. We now allow 10 seconds.

animations/3d/matrix-transform-type-animation.html
animations/3d/transform-perspective.html
animations/cascade-important-keyframe-properties.html
animations/cascade-important.html

BUG=248938

Change-Id: If33bae00d4da904a5520c83cc85f314e6f7f400b
Reviewed-on: https://chromium-review.googlesource.com/722824Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510025}

All targets that need earl_grey are supposed to depend on
//ios/third_party/earl_grey:earl_grey+link, and those who depend on
//ios/third_party/earl_grey should not compile because
//ios/third_party/earl_grey doesn't have the corresponding header
search path cflags included in its public_configs, dependents don't
know where to find the generated EarlGrey.framework.

However, current code compiles because earl_grey depends on
ochamcrest+link, so dependents of earl_grey knows where to find
Ochamcrest.framework, and coincidentally, EarlGrey.framework and
Ochamcrest.framework are generated in the same directory, thus,
dependents indirectly knows where to find EarlGrey.framework.

This CL converts //ios/third_party/earl_grey to
//ios/third_party/earl_grey:earl_grey+link whereever possible, and will
have a follow up CL to generate EarlGrey.framework and
Ochamcrest.framework in different directories so that the above
mentioned error can be caught at compile time.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibec2be796aff27011689f0e342be4ec050819c39
Reviewed-on: https://chromium-review.googlesource.com/727189Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510024}

Support Active Directory policy in PreSigninPolicyFetcher:
Don't require a policy verification key for Active Directory.
Active Directory provided policy is not signed with any
verification key.

BUG=772372
TEST=unit_tests --gtest_filter=PreSigninPolicyFetcherTest*

Change-Id: I671713f890d1de0444f3fd462de061d8f18e373c
Reviewed-on: https://chromium-review.googlesource.com/707240
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510023}

https://chromium.googlesource.com/catapult.git/+log/2bc7fe7bc1e6..a25d87f24cc6

$ git log 2bc7fe7bc..a25d87f24 --date=short --no-merges --format='%ad %ae %s'
2017-10-17 benjhayden Split vulcanizing histograms_viewer.html from rendering Histograms in an HTML viewer.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id357cec400a91619e4d3cd5d6d2eb09ea9953a9d
Reviewed-on: https://chromium-review.googlesource.com/727720
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510022}

Change-Id: Ie9d4285be4f7bb9e436847ea42779e1828de8540
Reviewed-on: https://chromium-review.googlesource.com/727485Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510021}

This patch implements LocalVisualRectIgnoringVisibility() for
LayoutInline and LayoutText, that are used by PaintInvalidator.

This patch is still at the early iteration in a few ways:
1. Other similar functions (e.g., LocalSelectionRect()) are not
   implemented.
2. The inline fragment iterator is supposed to be useful for
   several other purposes. Making it more generic and applicable
   for other purposes is planned after we collect how we use it.
3. Adds ~20 new failures, part because CurrentFragment() is not
   available in some cases, part because overflow logic isn't
   complete yet. I'll look into these failures in following patches.

Bug: 636993, 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I55c607a40fcf705c46162577fd9a1255f3048da7
Reviewed-on: https://chromium-review.googlesource.com/718637
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510020}

TBR=kochi

Bug: 742715
Change-Id: I1bc4e37d5d1e707276f38bc11dfae2fe93c2d260
Reviewed-on: https://chromium-review.googlesource.com/727389Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510019}