GitLab

Review URL: http://codereview.chromium.org/115834

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17033 0039d316-1c4b-4281-b951-d872f2087c98

This regressed recently during porting. When
comparing to see who is registered we need to 
be comparing against a class that implements
FocusChangeListener (and registers as such
with AddFocusChangeListener). In this case,
host_ does not implement that interface and 
doesn't register as a listener, so it will 
never be registered. We should be comparing
using 'this', not 'host_'.

I've fixed this and added a browser_test to 
catch this in the future.

BUG=12729
TEST=Open Find, press Esc, press Esc again 
and the Find box should not briefly appear
and hide again. Also, make sure Esc works 
to cancel navigations.

Review URL: http://codereview.chromium.org/115832

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17032 0039d316-1c4b-4281-b951-d872f2087c98

Fork breakpad's dump_syms and related code. Generate XOR of first page of memory instead of MD5 of text section.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113893

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17031 0039d316-1c4b-4281-b951-d872f2087c98

The crash server requires an MDRawSystemInfo stream in order to process the
file, although it actually only needs a single value in it.

Additionally, it needs a PDB7 structure for each module, so we remove those
modules which probably aren't shared libraries and XOR the first page of data
to get a signature for them. The previous code opened the file and MD5 summed
the text segment. However, we can't know if the shared library is still linked
on disk, nor if the whole text segment is mapped in memory. Thus, we only
assume that a single page is mapped.

dump_syms will need to be forked and updated to match the signature scheme used
in this patch.

http://codereview.chromium.org/113875


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17030 0039d316-1c4b-4281-b951-d872f2087c98

easier for callers. Also gets bookmark menu button to compile.

I'm also removing a function I just added to gtk_util as it's not
needed. GTK offers gtk_widget_get_toplevel which does what I need.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115831

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17029 0039d316-1c4b-4281-b951-d872f2087c98

system's thumbnail storage.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/12725

TEST=repro test mentioned in http://code.google.com/p/chromium/issues/detail?id=12725#c4

Review URL: http://codereview.chromium.org/113922

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17027 0039d316-1c4b-4281-b951-d872f2087c98

"""
Fixed StatusBubbleViews::AvoidMouse() to support the mirrored UI (RTL) mode.

BUG=12148
TEST=Start chromium with --lang=he. Hover a mouse cursor on a link in the bottom
right corner, verify that the status bubble appears to the left. Verify that the
status bubble appears in a normal (right) position for all other links.
"""

Original review URL:
http://codereview.chromium.org/115461


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17026 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/6590
TEST=Cause the download shelf to appear by initiating a download.  Hover
over a link in the extreme lower left corner of the browser window.  The
status bubble should avoid your mouse by moving to the right, instead of
moving down and obscuring the download shelf.


Review URL: http://codereview.chromium.org/113671

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12653

Review URL: http://codereview.chromium.org/115829

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17024 0039d316-1c4b-4281-b951-d872f2087c98

* activex_test_control.dll
* browser_tests.dll
* browser_tests.exe
* memory_watcher.dll
* rlz.dll
* security_tests.dll
* test_chrome_plugin.dll
* themes/default.dll
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113915

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98

make chrome app depend on pdfsqueeze
add a rule to run pdfs through pdfsqueeze

BUG=7654
TEST=pdf files in resources should be smaller now.
Review URL: http://codereview.chromium.org/113911

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17022 0039d316-1c4b-4281-b951-d872f2087c98

The problem was related to an infobar (the default browser one) showing.
When the tab is closed, InfoBarClosed is called on the infobar delegates, triggering a delete of the delegate. Then a notification that the tab is destroyed is sent, causing the tab contents to layout its infobars accessing the deleted delegates.

BUG=12668
TEST=All UI tests should pass (especially the LoginPromptTest ones).
     Make IE your default browser, start Chrome. The default browser infobar should show. Close the tab.

Review URL: http://codereview.chromium.org/113906

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/113921

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113919

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115826

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17018 0039d316-1c4b-4281-b951-d872f2087c98

add methods in bookmark model to get/set this preference.

Review URL: http://codereview.chromium.org/113882

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17017 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/113890

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115825

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17014 0039d316-1c4b-4281-b951-d872f2087c98

Open a new tab page rather than the homepage if startup is set to "open the following" with a blank list.  Patch by Yuzo Fujishima (see http://codereview.chromium.org/113444 ), r=beng.

BUG=6901

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17013 0039d316-1c4b-4281-b951-d872f2087c98

Don't lose omnibox edits when dragging tabs out.  Patch by Yuzo Fujishima (see http://codereview.chromium.org/115558 ), r=beng.

BUG=10632

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17012 0039d316-1c4b-4281-b951-d872f2087c98

Move the "breakpad_linux*" files to the "browser" target rather than "app",
since they're needed by "render_crash_handler_host_linux*" which is in
"browser". This fixes link errors in unit_tests, which incorporates "browser"
but wasn't getting the definitions in these files.

This is a revised version of r16954 which avoids the scons "multiple inclusion" errors in the non-official build.

Review URL: http://codereview.chromium.org/115823


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17011 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/115824

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17010 0039d316-1c4b-4281-b951-d872f2087c98

when there are browsers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113912

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17009 0039d316-1c4b-4281-b951-d872f2087c98

Binary files for themes+extensions change - these are in a separate change so they can be committed ahead of the other CL so that the try server can work.

The modified file removes one item from the manifest that wasn't being used.

TBR=aa,erikkay

Review URL: http://codereview.chromium.org/113918

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/113917

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11380

TEST=Start chrome with empty resolv.conf, fix resolv.conf; chrome should
be able to resolve sites.

Review URL: http://codereview.chromium.org/113904
Patch from Craig Schlenter <craig.schlenter@gmail.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17005 0039d316-1c4b-4281-b951-d872f2087c98

We specifically detect this case, close the channel and return an error.
This CL also silences error messages that where previously printed to the console in this situation.

BUG=12734

Review URL: http://codereview.chromium.org/113913

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115821

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17003 0039d316-1c4b-4281-b951-d872f2087c98

namespace change to window_sizer_mac which I noticed when doing a previous
change.
Review URL: http://codereview.chromium.org/113910

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17002 0039d316-1c4b-4281-b951-d872f2087c98

or not. If not valid, just pass white to ThemeEngine.

This change was motivated by the issue
http://code.google.com/p/chromium/issues/detail?id=2756, but it has been
resolved by only the upstream change
https://bugs.webkit.org/show_bug.cgi?id=25742.

However, this verification code is still useful.

BUG=2756
Checked in for tyoshino@google.com
Original review: http://codereview.chromium.org/113165

Review URL: http://codereview.chromium.org/113907

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=9936
TEST=Download a .svgz file to local disk, then attempt to view it. Please make sure it didn't get decompressed during the download.
Review URL: http://codereview.chromium.org/99109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17000 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/115768
	
TBR=tyoshino
Review URL: http://codereview.chromium.org/115822

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16999 0039d316-1c4b-4281-b951-d872f2087c98

Add app_locale_settings and app_strings to all the locale dlls.

BUG=12309

Review URL: http://codereview.chromium.org/115820


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115813

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16997 0039d316-1c4b-4281-b951-d872f2087c98

ExternalTabContainer should subclass WidgetWin rather than Widget and ATL CWindowImpl. This makes it much easier to extend the API of Widget.

Cleans up ExternalTabContainer to better match chrome style.

BUG=none
TEST=run ui tests, verify ExternalTabContainer tests pass.
Review URL: http://codereview.chromium.org/113892

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=7697
TEST=Open RTL Chrome (--lang=he), load ynet.co.il, load mako.co.il, open new tab page.  Observe that ellipsis is placed correctly at the end of the page titles for aforementioned sites and that the underline is under the whole title and not just under the ellipsis.

Review URL: http://codereview.chromium.org/112025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

TEST=With an empty history, open a new tab. The NTP should not show the link
to "Remove thumbnails". Browse 3 different sites and open a new tab again. The
link "Remove thumbnails" should now be visible.


Review URL: http://codereview.chromium.org/115787

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/115811

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16992 0039d316-1c4b-4281-b951-d872f2087c98