- 06 Aug, 2019 40 commits
-
-
Josh Nohle authored
Add an abstract class (and a fake implementation) for providing an Instance ID for use with CryptAuth v2, and also for providing Instance ID tokens for each CryptAuth v2 project: Enrollment and DeviceSync. The implementation will follow in another CL. Bug: 951969, 990430 Change-Id: I6fd3280bf5a12114a92059a8a84bd0d1749c627b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737951 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684479}
-
Josh Nohle authored
In a rollback-rollforward scenario, it is possible that the persisted v1 and v2 user key pairs can differ when the v2 enrollment manager is created. To get in that state, consider the following: - the device enrolls with v2, creating a user key pair, - Enrollment v2 is rolled back, - the device enrolls with Enrollment v1, creating a new user key pair - Enrollment v2 is rolled forward. Because an existing v1-enrolled key is always preferred (for continuity reasons), the v2 key will be overwritten by the v1 key on start-up. However, the v2 scheduler does not necessarily know to re-enroll (now with the v1 key) since it still considers the v2 enrollment before the rollback the last successful enrollment. Therefore, the v2 enrollment manager needs to force a v2 re-enrollment. Bug: 899080 Change-Id: I1d5c9511996210a1852efc1da842370d291898e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686774 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Hesen Zhang authored
- Rework on adding strings for helpful/unhelpful buttons. - No need to create new grd file. https://chromium-review.googlesource.com/c/chromium/src/+/1735525 Bug: 988117 Change-Id: Icfa104bbf176f2c9164200879393e8e8963881b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739153Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#684477}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/ad3443c93121..734d60f63cfa git log ad3443c93121..734d60f63cfa --date=short --no-merges --format='%ad %ae %s' 2019-08-06 wl@gnu.org Another minor documentation improvement. Created with: gclient setdep -r src/third_party/freetype/src@734d60f63cfa The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Ic36090542a9ffefec75b8c38d49ef455fd2dee04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#684476}
-
Eric Seckler authored
This reverts commit 5915dae5. Reason for revert: crbug.com/991282 Original change's description: > Roll src/third_party/perfetto b9d6775dfb5f..600679a1c326 (21 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/b9d6775dfb5f..600679a1c326 > > git log b9d6775dfb5f..600679a1c326 --date=short --no-merges --format='%ad %ae %s' > 2019-08-06 khokhlov@google.com Maintain compatibility with both jsoncpp versions > 2019-08-05 rsavitski@google.com Merge "traced_probes ftrace: cap the per-cpu pages read per drain period" > 2019-08-05 ilkos@google.com Merge "Combine heap profiler stats" > 2019-08-05 fmayer@google.com Merge "Move profile.packet to perfetto.third_party package." > 2019-08-05 treehugger-gerrit@google.com Merge "UI: Fixed timeline scrubbing" > 2019-08-05 treehugger-gerrit@google.com Merge "Improve extension for perfetto trace recording." > 2019-08-05 hjd@google.com Merge "Update rollup config to remove warning" > 2019-08-05 hjd@google.com Make bad config the right amount of bad > 2019-08-05 hjd@google.com Merge "Add bad config to test/config" > 2019-08-05 fmayer@google.com Merge "Add //src/base to dep for pprofbuilder." > 2019-08-05 fmayer@google.com Merge changes Iff458990,If7f8d5f2,Ia79e6e0b > 2019-08-05 ilkos@google.com Add pid to the frame stats metric > 2019-08-05 taylori@google.com Merge "perfetto-ui: Only quantize tracks with too much data" > 2019-08-05 ilkos@google.com Merge "Enhance heap profiler metrics" > 2019-08-02 hjd@google.com Merge "perfetto-ui: Fix ui" > 2019-08-02 treehugger-gerrit@google.com Merge "no-stall mode: Track stats about packet loss" > 2019-08-02 treehugger-gerrit@google.com Merge "client api: Don't hang if a not-yet-started session is stopped" > 2019-08-02 fmayer@google.com Merge "Use ProfiledFrameSymbols for symbolization." > 2019-08-02 treehugger-gerrit@google.com Merge "processor: Export LegacyEvent raw events as JSON" > 2019-08-02 taylori@google.com Merge "perfetto-ui: Fix tslint errors" > 2019-08-02 treehugger-gerrit@google.com Merge "perfetto-ui: Make 'm' timespan select work on all selections" > > Created with: > gclient setdep -r src/third_party/perfetto@600679a1c326 > > The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > TBR=perfetto-bugs@google.com > > Bug: chromium:b/133745684 > Change-Id: I81653eaafcaf2aad1da8bec5e8d9cbae305ef704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738431 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#684343} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I22cca0b5f81dbd5ac7d477fbc05f78692bae95f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:b/133745684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739930 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#684475}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bdb0919dcc6a..c853bf2867b9 git log bdb0919dcc6a..c853bf2867b9 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 mtklein@google.com build programs lazily in SkVMBlitter 2019-08-06 egdaniel@google.com Update some gpu caps isFormatRenderable calls. 2019-08-06 halcanary@google.com experimental/editor: interface no longer uses stringslice Created with: gclient setdep -r src/third_party/skia@c853bf2867b9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: Idd45ce3c6b5bccee6ec6cadc57a0ceb8df33d6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739000Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5f95c03ada3..3ff0e5dfaf1a git log c5f95c03ada3..3ff0e5dfaf1a --date=short --no-merges --format='%ad %ae %s' 2019-08-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-06 ehmaldonado@chromium.org Reland "depot_tools: Move six to depot_tools' .vpython" Created with: gclient setdep -r src/third_party/depot_tools@3ff0e5dfaf1a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I4f8c461fd8bd148e5fd08edd5fa96c7114b71b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738322Reviewed-by:
-
Peter Boström authored
Let's put FlexLayout's SetIgnoreDefaultMainAxisMargins through some real-world usage. Bug: chromium:943702 Change-Id: I21fb28d21494f9df0045ac9e31ed2fd26875bdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739648 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#684472}
-
Lan Wei authored
When I merged and rename the flags to update hover for layout change and scroll, I did not change the flag in Rename a flag in layout test update_hover_after_layout_change.html, it should be updateHoverAtBeginFrame. Bug: 877132 Change-Id: I2032283cc4bb36a17c0e805dacc35367ee630877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738668Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#684471}
-
Sebastien Marchand authored
This code isn't used and we don't intend to use this as is anyway, remove the code as it's not expected to be used. Bug: 755840 Change-Id: I1f7822492abc2b00d799758d3417990320626067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733506Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#684470}
-
Dan Sanders authored
This histogram measures watch time in MediaPlayer, categorized as non-HLS, HLS audio-only, or HLS video. Each entry is 1s of playback, and entries are created on a timer whenever playback is ongoing. This UMA is expected to be relatively short-lived, as it is intended as a verification of the existing Media.WatchTime metric (UMA and UKM). The primary difference is that Media.WatchTime does not specifically separate HLS watch time. Bug: 985144 Change-Id: I0a07427df746556703bb550b249683404bce0dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726740 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#684469}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I7066971f181c889e02aef13c865be51855ec63eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738437 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#684468}
-
Joshua Bell authored
A pair of histograms tracked the type of key used for object stores and indexes. This was added to gather data on usage, since not all browser engines supported array-type keys, and developers of those engines wondered how heavily used they were. Those engines are no longer in development, so it's moot. mojom changes are comments-only, so TBRing TBR=tsepez@chromium.org Bug: 974968, 975991 Change-Id: I0f4ef81a9839d530059b432d0fd82b12004d3aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733851 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#684467}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=battre@chromium.org Bug: 968047 Change-Id: Ic0cc4bde7101b3fe4b00454c64a63897d93d9f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739830 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#684466}
-
Josh Nohle authored
Also updated result codes. Bug: 951969 Change-Id: I872c02203ce80688bd8f9916d4d909a00e34e122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731871Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 990853, 802836 Change-Id: I7aeba7f34ae3257a8c0d7900a4f266f872273304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739646 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#684464}
-
Harsh Patel authored
Added flag for aapt2 link to generate proguard conditional keep rules. Bug: 682786 Change-Id: I11e7afd5b540bcc6bc0f4bf54a8bd20c750fb0a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723796 Commit-Queue: Harsh Patel <harshpa@google.com> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#684463}
-
Nektarios Paisios authored
A few text marker attributes are still missing from our Mac implementation. This patch adds the missing attributes for paragraph and caret browsing. This patch also declares any missing attributes for text markers in the form of constants, instead of using text strings. This is the full set of text marker attributes supported by Safari. R=aleventhal@chromium.org Bug: 990931 Change-Id: I9839f2f1f419c14b7730573ac1f7c1f3306f36c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732692 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#684462}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=nharper@chromium.org Bug: 968047 Change-Id: Ie94b75f8055d40ca1225b1da7154e8f86a4b1350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738596 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#684461}
-
Dave Tapuska authored
WebView and extensions allow frame lookup across browsing instances. We wish to enforce Same Agent restrictions in bindings but for these cases we cannot. This change adds the ability to mark frames as having CrossBrowsingInstanceFrameLookup. A folloup change will add a SECURITY_CHECK to the bindings interface for this. BUG=970360 Change-Id: I76334a82644161f7b44b07a32847514bf20acecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708752Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#684460}
-
Eric Willigers authored
The following properties accept either a number or a percentage: - fill-opacity - flood-opacity - opacity - shape-image-threshold - stop-opacity - stroke-opacity Each property serializes as a number. Spec: https://drafts.csswg.org/css-color/#typedef-alpha-value Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/SdPIaBdhzAQ/f26Mp_3REAAJ Credit to hanlee.dev@gmail.com for uploading a patch. Bug: 907787 Change-Id: Ie297d7225becafde73449c35bcb719c4847c87d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734753 Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#684459}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=peter@chromium.org Bug: 968047 Change-Id: I4e4e63b3ac7944977f2ac01725f153b97d008616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739807 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#684458}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c9edc556eae1..db9976265161 git log c9edc556eae1..db9976265161 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 thestig@chromium.org Remove code that checks GetSystemHandler() return value. 2019-08-06 tsepez@chromium.org Deduplicate pointers to widgets in pwl. 2019-08-06 thestig@chromium.org Simplify code in CPWL_EditCtrl::SetCursor(). Created with: gclient setdep -r src/third_party/pdfium@db9976265161 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ibb6eff26cfcd25d8de279af96cb540ac271532fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738651Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7cbee84610a8..63c38e21dae6 git log 7cbee84610a8..63c38e21dae6 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 srte@webrtc.org Fix for incorrect transport sequence number config for audio in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@63c38e21dae6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I59b8b2b0c4659b657b152e4fa448b7fd09aacdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738321Reviewed-by:
-
Yue Li authored
Merge the current Assistant prefs controller logic into the AssistantStateBase. Will also merge the logic of VoiceInteractionController into this controller in the next change. Bug: b/110211045 Test: Run existing tests Change-Id: I1d3a8388fd66217baad44d7c7043ffd75830e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727733 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684455}
-
Yue Li authored
Check if Assistant is disabled by admin policy at Service startup. Bug: b/138589497, 982286 Change-Id: I3efe448f95bc8cc8059885db23fb004de5b3af89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734742 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#684454}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=oysteine@chromium.org Bug: 968047 Change-Id: Ibc31dc65ba9108247d7e6780d5f815827f4a3354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739814 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684453}
-
Matt Menke authored
Currently, they do the same thing for numeric IPs (modulo a DCHECK that the IP is valid in HostStringIsLocalhost()), but I don't think we want the two methods to have potentially divergent concept of loopback IPs if, for instance, we add IPv6-mapped IPv4 loopback addresses. Bug: None Change-Id: Ia193c2dff08f90bf62847a89fb6b31f130f75fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739482Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#684452}
-
Josh Nohle authored
CryptAuth v2 Enrollment and v2 DeviceSync are separate Cloud/Pantheon/Firebase projects that need separate authorization to send push notifications to the client. The authorized entity values here identify the v2 Enrollment and v2 DeviceSync Cloud/Pantheon/Firebase projects. While the user's Instance ID can be used across multiple CryptAuth projects, the Instance ID *tokens* are project specific. The authorized entity values are needed to generate Instance ID tokens. These tokens are unique and immutable identifiers of the client's authorization of the project to send the client push notifications. Bug: 951969, 990430 Change-Id: Iad38286357f71054530a9afc05c5dc2382edcbae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735472 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
This change adds DCHECKs to AXNode::*Unignored* traversal methods to guarantee they are not accessed in the middle of a tree update, which can cause subtle bugs if the previously unignored parent becomes ignored during the update. --- Problem : AXTree notifies AXTreeObservers of node and subtree changes in the middle of a tree update, which means observers may be seeing a tree state that's incomplete. This can lead to subtle bugs when observers access nodes in the AXTree other than the node being updated. e.g. |GetUnignoredParent| may be invalid during a notification, but correct afterwards. Proposed solution : Separate notifications from updates in AXTree::Unserialize. This requires the following steps : 1. Record all operations that would be performed on the tree. 2. Fire all on destroy and OnNodeDataWillChange callbacks. 3. Apply all update operations. 4. Fire all created and node data changed callbacks. For additional context, see these comments by Nektarios and Dominic : https://chromium-review.googlesource.com/c/chromium/src/+/1650222/20#message-ffe9bf96b616a915bebf2e69d7803bcae6a18b24 https://chromium-review.googlesource.com/c/chromium/src/+/1535171/69#message-7b62970b193439a1878d7339cdc94d2556d0a416 I plan to submit approximately 3 CLs to resolve this : 1. Handle Pre/Post Tree changes (create node / destroy subtree) 2. Handle Pre/Post Node data changes (attributes will / have changes) 3. Add DCHECKs to AXNode::*Unignored* accessors, along with any remaining work required to do so, to help harden these paths. Bug: 974444 Change-Id: I40ce8a29b7faf2f1eeea513c37a19320062783f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710052 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#684450}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=simonhatch@chromium.org Bug: 968047 Change-Id: I90e2499257ebe0b5914568b3f496d32c48b4f6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739806 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#684449}
-
Jacob DeWitt authored
Change-Id: I158bbc20c0b0eea748d1200b4709d48d1355fe80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739667Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#684448}
-
Robert Ma authored
Currently blocking the importer. Example: https://test-results.appspot.com/data/layout_results/linux-rel/159555/not_site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html No-Try because the change hasn't landed in Chromium yet. TBR=flackr No-Try: True Bug: 991295 Change-Id: I599bd336d45df0ca928711657cb81cb838713990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738335Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#684447}
-
Jacob DeWitt authored
The mapping is defined by the spec at: https://immersive-web.github.io/webxr/#xr-standard-gamepad-mapping Now, only a primary trigger is required for a controller to claim xr-standard mapping, and the order of some of the buttons has changed. Centralize the logic of how to order buttons + input axes, as well as where/when to add placeholder values in the XRStandardGamepadBuilder class. Bug: 979246 Change-Id: Iefb116ea603c0a7237575d189686fd2daee9de90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728345 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684446}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=battre@chromium.org Bug: 968047 Change-Id: I034c246f7d4dbfb87ad12731f35e47e8710ddd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738600 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: -
Mustafa Emre Acer authored
Change-Id: I9a6c3772e33e67cfe99f2d20da97c0f52aaa8fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739543Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#684444}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I011ff9c037debc4092850caff94f52f4d7667ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733610Reviewed-by:
-
Brian Sheedy authored
Increases the swarming expiration and overall builder execution timeout for Win10 FYI x64 Release (Intel UHD 630) since only having one device is causing shard timeouts on heavily sharded tests and the builder is getting dangerously close to its current 6 hour timeout. Bug: 986939 Change-Id: I30f01c869b405cea3aae0e11b09f0d81769d62e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739590 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684442}
-
K Moon authored
Due to the loose, asynchronous coupling between the C++ and JavaScript portions of the layout code, we need to pass certain layout "options" (such as the default page orientation) back and forth by value. As a result, it makes sense to have a separate Options class to hold these settings, which then can be used to recalculate the layout. The expected layout lifecycle eventually should look like this: 1. Update desired layout options one or more times. 2. Estimate layout size with new layout options. 3. Send options and estimated size to JavaScript. 4. Receive updated options from JavaScript. 5. Apply final options to current layout. 6. Repaint using updated layout. As a side effect of this change, I added the desired_layout_options_ field to PDFiumEngine. This new field holds the mutable state about page orientation that was split off into DocumentLayout::Options. Miscellaneous changes: * Revised some of the API comments for DocumentLayout * Eliminated need for unsigned math by replacing -1 with +3 (mod 4) * DocumentLayout no longer needs to be copyable, so it isn't Bug: 885110 Change-Id: I89714c4c2cba6c0ab354c0696ec3943327c979d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733795 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684441}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I859a008b9a68313d3d0479225d20b2b23acf4de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738667 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#684440}
-
