- 18 Sep, 2019 40 commits
-
-
danakj authored
This reverts commit 6876fb4f. Reason for revert: Breaks layout tests even though they passed in the CQ??? Linux: animations/animationworklet/worklet-animation-responsive-to-zoom.html svg/as-image/img-zoom-svg-stylesheet.html fast/media/mq-width-pagezoom.html Windows: animations/responsive/zoom-responsive-translate-animation.html fast/media/mq-resolution-pagezoom.html fast/backgrounds/tiny-tile-zoomed.html animations/animationworklet/worklet-animation-responsive-to-zoom.html svg/as-image/img-zoom-svg-stylesheet.html fast/media/mq-resolution-pagezoom.html Original change's description: > Move page zoom level responsibility into RenderViewImpl. > > Page zoom level is a page/view concept, but the code to manage it is > currently in RenderFrameImpl, though only run when it is the root frame. > > This doesn't dramatically change ownership of responsibility but moves > the code up into RenderViewImpl. RenderWidget still goes through > RenderFrameImpl (though more explicitly) to set the zoom level on the > RenderView. And RenderWidget takes responsibility for closing the page > popup instead of having multiple "set page zoom" methods on > RenderViewImpl. > > This uncovered some spooky action-at-a-distance and makes it more > explicit and documented, though no less unfortunate. A local root > LocalFrame does not initialize with the correct page zoom value because > it has no parent to read it from. We (accidentally?) worked around that > by setting the RenderView's page zoom to its current value when > navigating a (new) LocalFrame, which would call into blink's WebView > and walk through the entire frame tree setting the value on everything, > eventually also on the new LocalFrame. > > Now on navigation, for a local root, we call RenderWidget's > UpdateWebViewWithDeviceScaleFactor() which does the same thing by > re-setting the WebView's page zoom factor. This was done when making > a new main frame in multiple places (RenderView and RenderFrame both > called it in the same CreateFrame() callstack). Now it is consolidated > to a single place on navigation for the main frame and child frames > giving them more consistent behaviour, and going explicitly through > this method that should go away if things were well designed, rather > than re-setting the RenderView to its own value. > > Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered > throughout RenderViewImpl and RenderFrameImpl. What we need is for > 1) The Page to be updated with PreferCompositingToLCDText when the > device scale factor changes. > 2) The WebView to be updated when the device scale factor changes. > 3) The LocalFrame of a local root needs its page zoom set by poking > the WebViewImpl to walk through all frames and set it. > > R=erikchen@chromium.org > > Bug: 419087 > Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697687} R=avi@chromium.org, dcheng@chromium.org, erikchen@chromium.org TBR=danakj@chromium.org Change-Id: I3177d7f7a601b6692fd931623ca749bacce051c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811937Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697766}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8391bac5c6f0..17a3a0bda946 git log 8391bac5c6f0..17a3a0bda946 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 robertphillips@google.com Last tranche of new SkColorTypes 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@17a3a0bda946 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Iea704ae2d3de29ea0b31724aa46d7a2e1bacb421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697765}
-
Wei-Yin Chen (陳威尹) authored
In incognito tabs, stop reporting page visits to Firebase. Also move the reporting to didFirstVisuallyNonEmptyPaint(), which is closer to when the user perceives a page to be visited. Also skip creating the observer altogether on low-end devices as an optimization. Bug: 1004003 Change-Id: I592521ab9ce5894df48f7994de30a255d9280f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805297Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697764}
-
danakj authored
Instead of signaling if the frame is a local root by sending a routing id or not, and then based on that reading the VisualProperties or not, make the whole widget_params structure optional, and only send it when the frame is a local root. Then the VisualProperties are not included in the IPC at all for non-local roots, nor a routing id. This is a followup for https://chromium-review.googlesource.com/c/chromium/src/+/1797385 R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I49b735ec081aae6c4511a475535ce337ce2a5394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809988 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697763}
-
Fernando Serboncini authored
Bug: 988125 Change-Id: I989a74f5b30ccf9d9d4b5d3d00fdd56131dd5df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801226 Auto-Submit: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697762}
-
K Moon authored
The set_size() method is used externally only for testing at this point, and provides a dangerous API for violating layout invariants. Remove this API now to avoid having to modify it in a later change to add dirty tracking to DocumentLayout. Bug: 885110 Change-Id: Idb03aaad86131b625589ac07c48c9284caaf0919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810237 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697761}
-
Dana Fried authored
(dfried@ was original author of this file.) Change-Id: Iadb874be902c430b0a4494a33137d3265ad92a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810194Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#697760}
-
Xiaoqian Dai authored
In tablet mode, when doing a tab dragging, the dragged window's size is 1/4 of the work area's size. It worked well for big screens, but on smaller screens, the size might be smaller than the window's minimum size. We should take the minimum size into consideration as well. Bug: 1002728 Change-Id: I6a834150015890f7e9eb949b8d724c064474a84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799693 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697759}
-
Robbie McElrath authored
This cuts a dependency from aw.ui.util to aw.services. Test: ninja -C out/aw system_webview_apk Bug: 934152 Change-Id: Ibdf189e79ef71f948591fe14a0de7316d76da27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794027Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#697758}
-
Justin Cohen authored
kRestoreNavigationTime was a timer created by WKBasedNavigationManagerImpl::Restore and stopped when session restoration begins navigating to its final URL. Unfortunately, WKBasedNavigationManagerImpl::Restore is called for every restored WebState on startup. Actual network access doesn't happen until a tab is selected. That means if you have 10 tabs, background/kill/restore, navigate a bit, and then change tabs, that second tab will have had a timer running since the app started. Instead, start kRestoreNavigationTime when ios/web begins loading the restore page, and finish the timer when ios/web begins loading the real page. This should more correctly tell how much time SlimNav restoration adds. Bug: 1005044 Change-Id: I35fee36bb50ec627d7455d6215669a92a2b4bc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808355 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697757}
-
Xianzhu Wang authored
Split layer_tree_host_common.h/cc into several parts: - ScrollAndScaleSet => scroll_and_scale_set.h/cc (new files) - CalculateLayerJitter() => LayerImpl::CalculateJitter() - CalculateDrawProperties(LayerImpl*,...) => draw_property_utils.h/cc - CalculateDrawPropertiesForTesting() => Combined into UpdateDrawProperties() in layer_test_common.h/cc - GetPropertyTrees() => property_tree_test_utils.h/cc Split layer_tree_host_common_unittest.cc into two parts: - property_tree_builder_unittest.cc for tests testing PropertyTreeBuilder - draw_properties_unittest.cc for the rest. TBR= # tiny passive changes in components/viz and content/renderer Bug: 994361 Change-Id: Ic6011c5849f5fded5e91eb2d0f592edc939b5ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808797Reviewed-by:Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697756}
-
danakj authored
Stop relying on the RenderWidget holding all the VisualProperties state and constructing a VisualProperties in order for web tests to toggle auto resize on the widget/view. R=avi@chromium.org Bug: 419087 Change-Id: I1a20c1ead527489ed0075907a45b70812b63f84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811430Reviewed-by:
-
Sammie Quon authored
Slow scrolling was not working properly because of an optimization I tried to add to not process scroll events that barely change the grid but it was dropping too many events resulting in small scrolls not eventually scrolling the grid at all. Fix a bug with fling and add a test for it. Fling was not working, due to a bug where the grid wouldn't shift until the API returned no offset, in which it would not shift anyways. Test: Added test Bug: 978112 Change-Id: Ib9544706975aa7adfa5163c07eb835c1b06708e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802957 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#697754}
-
Lucas Gadani authored
Per RFC7230 section 3.2.2, multiple headers can be combined with a comma. Bug: 759184 Change-Id: I024e0fcd03ca723a8ea6c89cc4090a143dccbe00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809336 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697753}
-
Jan Krcal authored
This CL adapts the guest mode avatar to an updated design. Bug: 967317 Change-Id: Iccfd4c665238fe5731c52126a4c914c736d3ece0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810979 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#697752}
-
kylechar authored
This CL enables SkiaRenderer to use Windows DC layer overlays. The operation is essentially the same as GLRenderer with some minor differences. The list of DCLayerOverlay candidates is plumbed to the GPU thread via ScheduleGpuTask() instead of over command buffer. Also instead of providing a GL texture ID a gpu::Mailbox is provided. DCLayerOverlayProcessor::ProcessForUnderlay() is modified to set to SharedQuadState::are_contents_opaque true for the replacement SolidColorDrawQuad. SkiaRenderer needs to draw the replacement quad with SkBlendMode::kSrc but setting the blend mode to kSrc isn't supported by GLRenderer. SkiaRenderer uses the |are_contents_opaque| to change the blend mode at draw time while GLRenderer ignores it. SkiaOutputSurface::SkiaSwapBuffers() is also modified to optionally return a SyncToken. This SyncToken can be used to return overlay resources after swap buffers completes on the GPU thread. This should work for all overlay paths except macOS. Bug: 1003040 Change-Id: I9ff3ff55cde1aabfae8200fc2dfcc416c15d0005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796626Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697751}
-
Antonio Gomes authored
... off of content::RenderThreadImpl. This CL changes the ownership of blink::PeerConnectionDependencyFactory as per section 5.1.1 in the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ Quoting the document: " PeerConnectionDependencyFactory is currently owned by RenderThreadImpl in content, which makes it a single object per renderer process. This ownership must be moved to a suitable place in Blink. A possibility is to keep it as a global object (using DEFINE_STATIC_LOCAL). The disadvantage of this approach is that PCDF would never be destroyed, whereas it is currently destroyed by the RenderThreadImpl destructor, but this is acceptable. " This move will allow a set of blink::Platform methods to be removed (follow up CL). BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie79f13cfd90c56fcbed50142802b0fcda480c43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807657 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#697750}
-
Jamie Madill authored
This will allow moving the SwiftShader Vulkan module to the root out folder. This in turn will enable more easily running TSAN and ASAN testers. Bug: angleproject:3876 Bug: angleproject:3912 Bug: b/140251624 Change-Id: I3ed8598ca396a445f46d5cddc4d19f997f4e61f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811317Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#697749}
-
rbpotter authored
- Autogenerate Polymer 3 version of managed-footnote and tests - Add to demo page - Add new build targets and browser test files as needed since this is the first CrComponent to be ported. - Also adding a way for the TestDataSource to serve an empty version of strings.m.js, for tests that need to override values in loadTimeData Bug: 965770 Change-Id: Id8ce7b102c8cb86d84e606a6bc9046cecd6f284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809747Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697748}
-
Sadrul Habib Chowdhury authored
Stop reporting the throughput metrics for the UI compositor, since it is currently bundled with the throughput metrics for the renderer. We could report these separately, but it's not clear that these would be used for monitoring the UI performance. BUG=1005226 Change-Id: Ia1572010737a66ecba114cfbb96239f822c1ea92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810014Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#697747}
-
Vikas Soni authored
glCopyTexImage2D was causing crash in arm gpu driver for webview. This CL adds a gpu driver bug workaround to do texture to texture copy via drawing to the destination texture instead of doing glCopyTexImage2D. This workaround is applicable on android devices with Mali-T8* gpu. Bug: 991869 Change-Id: I56a011e1a1c21df763fd397467ec0888c4bdfb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803695 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697746}
-
Brandon Wylie authored
The issue here was that StatusMediator#updateLocationBarIcon is called before the state for the dse icon is setup in StatusMediator#updateSearchEngineStatusIcon. This results the google icon being inadvertently downloaded and used instead of the large google g. I added a flag to ensure that setup completes before attempting to show a dse icon. Bug: 1001659 Change-Id: I3b2c32c9710d81ccc6e4d498fb58a0e7ab0ae3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808188 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#697745}
-
Bruce Dawson authored
Thread names are great in general. They are specifically good when doing multi-process debugging because the names of the main threads are the best clue as to which process is which. The crashpad handler threads were notably missing names in a recent debugging session. This fixes that. This is being done in Windows specific Chromium code because that is where the benefit is greatest and because crashpad doesn't have a function to set thread names. Bug: 1004991 Change-Id: Id7163852c3a609856fc50b30932a313e3dd34a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808450Reviewed-by:
-
Lucas Furukawa Gadani authored
This is a reland of cd4d366b Original change's description: > Convert SimpleURLLoader to use mojom types. > > This CL Converts the SimpleURLLoader to use the mojom URLResponseHead > struct instead of the native ResourceResponseHead struct. > > Change-Id: I016b0731930b4589ba6169aa2e24ad45dc6675cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790273 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Charles . <charleszhao@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697317} Change-Id: I51e7519f8ec48ee625ab9eed03b4829d7993e511 Tbr: kinuko@chromium.org, avi@chromium.org, khorimoto@chromium.org, sorin@chromium.org, charleszhao@chromium.org, bsazonov@chromium.org, hashimoto@chromium.org, rkaplow@chromium.org, tbansal@chromium.org, hajimehoshi@chromium.org, mmenke@chromium.org, danyao@chromium.org, dtrainor@chromium.org, zmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811199Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697743}
-
Sam Maier authored
Bug: 998231, 999186 Change-Id: If26cb58677341158e76bc2998bc24104db5fbbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803732 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#697742}
-
Juanmi Huertas authored
We only have to disable deferral when it is enable to avoid issues with stack or with performance having to recreate resources and play the matrix transformations all over again. Bug: 1003124, 1001142, 997735 Change-Id: Ib5b60c89b1218dd50c0b97914c08ca921683435a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808276Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#697741}
-
Will Cassella authored
ScriptPromiseResolver has logic in its destructor to ensure that you've either resolved or rejected its promise (or not accessed the promise at all), to catch abandoned promise issues. This technically wasn't an issue for us because we were rejecting the promise via ExceptionState, but since we access the ScriptPromiseResolver's promise it thinks it was abandoned.
😢 Bug: 1003617 Change-Id: I276fde6ca0e2877cdc4793cb1674bca0821ca2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809598 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#697740}
-
Sean Gilhuly authored
Following crrev.com/c/1677233 |content_layer_| is always created in the constructor of DelegatedFrameHostAndroid. Checks to its existence will always be true, so remove them. Bug: 978640 Change-Id: I328519e7bbebb8b053af5f13eafca4cb2581c716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810013Reviewed-by:
-
liberato@chromium.org authored
When VideoFrameFactoryImpl started initializing the CodecImage itself rather than delegating to the SharedImageVideoProvider, the YCbCrInfo for Vulkan wasn't being set; the provider asked the (now uninitialized) CodecImage. This CL makes VideoFrameFactoryImpl cache the YCbCr info itself, using an extra thread hop to the gpu main thread. It does this just for the first few frames, until it receives the YCbCr info once. Then, it re-uses it for all subsequent frames. Change-Id: Ie167b4435b3ece6ec71dfd2f1a36250e7bc4d781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797107Reviewed-by:
Vikas Soni <vikassoni@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#697738}
-
Scott Violet authored
Prior to this patch WebLayer.init() must be called before super.onCreate() (from FragmentActivity), otherwise we hit NPEs. Two changes are necessary to get this working: . Remove call to ApplicationStatus.initialize(). . Supply false to ActivityWindowAndroid so that it doesn't listen to the activity. BUG=none TEST=none Change-Id: I24a80de016b9a8433f883f9d9e9a5c12808abc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810252Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697737}
-
Ivana Zuzic authored
PasswordUpdateDelegate has a new method for saving password changes. It will be used through the PasswordEditing Bridge in the future to save changes made in PasswordEntryEditor. Both PasswordManagerPresenter and the PasswordUpdateDelegate use the editing method from the newly created password_utils file. Bug: 377410 Change-Id: I1ee09fba8f815db99370c30d3c84acf32d1bdb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787507 Commit-Queue: Ivana Zuzic <izuzic@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697736}
-
Tina Wang authored
- Rename the DeviceIconType attributes. - Remove default case of CreateDeviceIcon because of using desktop icon by default. Bug: 1003812 Change-Id: Ie1e1a9cc9ef397769c8b37d25b867dfd1018cf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802500 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
-
James Cook authored
Follow up for comments in: https://chromium-review.googlesource.com/c/chromium/src/+/1807777 If every settings-subpage is inside a settings-section, then we can clean up the while() loop a bit. Also added a test that an associated control gets a search bubble highlight, which is one of the side effects of this function. Bug: 1003970 Test: browser_tests Change-Id: Ib2509dc5e3ffff075e46c1e61823fdf67229ddea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808423 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697734}
-
Mandy Chen authored
Wrap a user facing string in ls so it's localizable. Bug: 941561 Change-Id: If4285af49d7fd3ca8b2b7c2a447c35900e9efae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793748 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697733}
-
Aidan Beggs authored
This CL updates the URL only for Android to no longer use an answer ID. P-links allow easier tracking and prevent us from deprecating a link that's still used in-product. Bug: 703445 Change-Id: I2bb405e99ef230229a38aab8fa01ae3e5995486d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810840Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Aidan Beggs <beggs@google.com> Cr-Commit-Position: refs/heads/master@{#697732}
-
Tomasz Śniatowski authored
Don't add a string to a list, as that creates a broken depfile with "deps" of single-character paths. Also while there make the depfile preserve the relative path passed in -- use abspath when it's needed instead of ahead of time. Change-Id: Ib61efc68dfc9ecfaac7f3dcb6007bafb9fb8af67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811252Reviewed-by:
-
chrome://flagsPeng Huang authored
Change-Id: Ieff9d96ceb1dc1af2e93b4e9cacd90a02c0b9ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802389 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697730}
-
David Tseng authored
Bug: 990425 Change-Id: I70006053906de020ae8e0ca7f5fda70285e5aeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810254 Commit-Queue: David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/122f4535b1be..4599045c795c git log 122f4535b1be..4599045c795c --date=short --no-merges --format='%ad %ae %s' 2019-09-18 yshaul@google.com afdo: Add pupr chrome-profiles handler 2019-09-18 yshaul@google.com Preserve ebuild position and quotes during uprev 2019-09-18 yshaul@google.com Add multiversion support to packages api 2019-09-18 dburger@chromium.org Remove test config override for betty-nyc-arc-release. Created with: gclient setdep -r src/third_party/chromite@4599045c795c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6272f711bb83f5812b7190cc4911ba0b04074331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810246Reviewed-by:
-
Abigail Klein authored
Convert the arguments passed to accessibility_ui.cc functions into a dictionary rather than a long list. Since the number of arguments passed to accessibility_ui.cc is expected to grow, this will keep the argument list easier to understand. Bug: 785493 Change-Id: I089e0e6621f57b9b453f650da6c2c9b14386a687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802198Reviewed-by:
-
