- 26 Aug, 2020 40 commits
-
-
Hodol Han authored
Remove STGMEDIUM* usages, make StorageDataInfo constructor private, and provide a factory method of StorageDataInfo. There is no explainable reason to use STGMEDIUM pointer. In current implementation it seems to be used to test validity of STGMEDIUM, but we still can verify whether STGMEDIUM is valid or not by TYMED_NULL. We assume StorageDataInfo owns that STGMEDIUM, but it still can be copied and used elsewhere. A factory method called TakeStorageMedium takes and nullifies STGMEDIUM to prevent the problem. Change-Id: I3ea7e22d4363cc2ce6e3838433f249f7486d1129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329204Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#801704}
-
Alex Rudenko authored
The set of CSS Grid settings has changed so we add a new histogram to track the new set of settings. The previously used histogram becomes obsolete. Frontend CL: https://crrev.com/c/2366793 Bug: 1109177 Change-Id: I391595622ef99c7e2e6be554f2141acc4e44d752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367833 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801703}
-
Fredrik Söderqvist authored
This interface has a single user and is overridden by a single subclass (SVGImage), so it seems more pertinent to just implement this using other existing building blocks. Change-Id: I241c382c71052821e59280cd4cee10d2deef33dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372285 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#801702}
-
K. Moon authored
Adds a chrome_pdf::UrlLoader class that abstracts pp::URLLoader. This is currently a very thin abstraction that almost exactly duplicates the pp::URLLoader API, in order to minimize changes at call sites. At this point, the biggest change is that UrlLoader uses scoped_refptr for reference counting, rather than pp::Resource. In the future, this will allow a Pepper-free implementation of UrlLoader that doesn't rely on Pepper's resource management. More minor changes to the API include using base::span<char> instead of void* and size_t for passing buffers, and using ResultCallback instead of pp::CompletionCallback. This change also cleans up some IWYU issues in url_loader_wrapper_impl.cc. Bug: 1099022 Change-Id: Ia8764603c791942f8839d376e4866366a04f002e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376510Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#801701}
-
Kunihiko Sakamoto authored
And run wbn-subresource-(third-party-}origin-trial.https.html under it. This allows us to enable SubresourceWebBundles by default for web tests. Bug: 1082020 Change-Id: I8359cdb7359a77371e0c73f6cf69f129ef5d2fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377665Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801700}
-
Giovanni Ortuño Urquidi authored
https://crrev.com/c/2360089 added a "IsOffTheRecord" check to fix a crash in incognito. Unfortunally that introduced a new crash for Guest sessions. IsOffTheRecord() returns true for both incognito and guest session profile, which caused guest session to try to use the original login profile which leads to a crash. This fixes the issue by excluding guest sessions and only getting the original profile for incognito mode. Bug: 1121553 Change-Id: Iface9c78a56de1c44295d503e7090a64cdb471ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377187Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#801699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13e23939fb1a..346ebfc47a54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: hayato@google.com Change-Id: I281e139d842360c6a3d5a083fa3580e18806e651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377508Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801698}
-
Hirokazu Honda authored
AcceleratedVideoEncoder implemented in VaapiVideoEncodeAccelerator returns one-time Picture on GetPicture(). In other words, different Picture instances returns every GetPicture(). This behavior likely leads to a bug. In fact, vp9 metadata is not filled because it attaches the metadata in the returned Picture and refers to it later but the pictures are different. This CL fixes the interface so that it will always returns the same instance. Bug: 1030199 Test: tast run webrtc.* on atlas Test: video_encode_accelerator_tests on atlas Change-Id: I5ec1cb17e032566ed082469331f89a380d86148f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371085 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#801697}
-
Minggang Wang authored
This patch removes EnableReducedReferrerGranularity from WebRuntimeFeatures, because features::kReducedReferrerGranularity is available in Blink now. Bug: 860403 Change-Id: If7da017b49bf86c2a539e07ac03a0735658f6a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358992 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#801696}
-
Luciano Pacheco authored
Remove JS code, CSS style and images used by non-native controls. Native controls have been enabled by default for a few milestones (since M73) crbug.com/909963#c7 This CL dead code since the feature flag has been removed: CL:2018089. Tested manually opening one video as well multiple videos and switching between them. Bug: 909963 Change-Id: I3478fb03cb33acff2d58e527af48a31879c37c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362171Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#801695}
-
David Roger authored
This prevents Chrome from shutting down while the profile picker is displayed. Fixed: 1119369 Change-Id: I1d9df7c66c360dd29984876382b116d5732cb132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375350Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801694}
-
Gauthier Ambard authored
This CL hides the NTP avatar when the user isn't signed in. Fixed: 1115654 Change-Id: Idfcdadddbfb2ccd81000833d561aca46ac8074cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375247 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#801693}
-
Maksim Sisov authored
This is a reland of f985905e. This change broke our headless build: ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. assert(ozone_platform_x11) ^----- See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. "//ui/events/platform/x11",. Fix: Don't include x11 build for headless case. Original change's description: > X11 and Ozone: enable use_x11 and use_ozone > > This is the final change that enables use_x11 > and use_ozone for Linux builds and (as it was > before) excludes X11 for chromeos, chromecast, > lacros. > > in order to run ozone/X11/wayland, one must pass > —enable-features=UseOzonePlatform > —ozone-platform=x11 or wayland. otherwise, > non-ozone/X11 is used. > > it’s also possible to completely disable X11 > so that clients, who need that kind of build can > continue to have that. > > Bug: 1085700 > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801523} Bug: 1085700 Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#801692}
-
John Palmer authored
Bug: b/166339813 Change-Id: Icf220bf8446cc9e6c761607dd99a9b918e4909fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377526 Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#801691}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 877c823f. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-cascade NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I8dd7c6e2f7cc059a192d609db9cee4eb2d3813b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377425Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801690}
-
Fredrik Söderqvist authored
We can use a wrapping SVGImageForContainer instead, and then call AsSkBitmapForCurrentFrame() as in the BitmapImage case. Drop unnecessary null-checks for |image| (it is dereferenced already, and cannot be null because of ImageResourceContent::GetImage). Bug: 1121177 Change-Id: I1f327bdca72b6ba60ae30413607246226c4c7e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375171Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#801689}
-
Austin Tankiang authored
Bug: 1007662 Change-Id: I31c5de09e2e0e18daf316b519a86cdabdb50be11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375005Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#801688}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I04675627db6b86f4ff2db08a977cfd25ea33bd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377149Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801687}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c02c934afa7..a139788b4c78 2020-08-25 mtklein@google.com add arm64e slice to arm64 iOS builds 2020-08-25 johnstiles@google.com Fix early-return misdetection in the inliner. 2020-08-25 mtklein@google.com remove __ARM_FEATURE_CRC32 workaround 2020-08-25 reed@google.com use pathbuilder 2020-08-25 johnstiles@google.com Add unit test for return statements wrapped in a block. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ifc32c64780c5e456a4fcdccf86c01db51faaed42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801686}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59230836579a..a095d432e768 2020-08-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0d713c93..44a1544c (801321:801457) 2020-08-25 ricebin@google.com expose MediaProjection 2020-08-25 hbos@webrtc.org Fix OperationsChainTest.OnChainEmptyCallback flake. 2020-08-25 eshr@google.com [Adaptation] Remove resource adaptation queue 2020-08-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ba69b98d..0d713c93 (801212:801321) 2020-08-25 hbos@webrtc.org [Perfect Negotiation] Fire onnegotiationneeded when chain is empty. 2020-08-25 perkj@webrtc.org Ensure RtcEventLogEncoderNewFormat::EncodeRemoteEstimate handles infite If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1060083 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6e1e35bd5faf8e8b36c55fbdb160e4d529204d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376427Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801685}
-
Peter Marshall authored
Change-Id: I482ddc9931d7fac057769be9c1bddbfcdd5ba430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360072Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#801684}
-
Austin Tankiang authored
Extract out the callbacks from CreateResponderAuthMessageContext and ValidateInitiatorAuthMessageContext structs to avoid making those structs move only. Bug: 1007662 Change-Id: I8ae410e796c21ff0d137eae3e0bab486b286ae1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374928Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#801683}
-
tby authored
This is part of a chain of CLs to simplify how we rank search results. This removes an unused parameter of search provider groups - the boost - that increases result scores by a fixed amount. This used to be used to order the UI containers for apps and non-apps, but now just makes the scores hard to compare. Bug: 1028447 Change-Id: I407ca422b645069f4460db15d6bac42c44e4a745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374936Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#801682}
-
Joel Hockey authored
Some VMs such as PluginVM do not always send an AppListUpdate when they start, so it is better to always query when an icon is fetched and we don't have it. Bug: b/166150220 Change-Id: I5979d4f36986b46e86d846ff40fc61a5101d1bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377170Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#801681}
-
Minggang Wang authored
As blink::GetDefaultNetReferrerPolicy() becomes available inside Blink, we could leverage it directly. This patch makes ReferrerPolicyResolveDefault() to call blink::GetDefaultNetReferrerPolicy() and merge the method into ReferrerUtils. Bug: 860403 Change-Id: I7c00bcdfb22a6461f81ca32bcc08ede2e5405815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353888 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#801680}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dff2104727dc..c6aa15118046 2020-08-25 sokcevic@google.com Warn only if non-inclusive term is used If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098560 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Ic81f5e44e77b87e8ad613d6e963b6dbbe099c93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801679}
-
Austin Tankiang authored
Extract out the callback from the ValidateResponderAuthMessageContext struct to avoid making the struct move only. Bug: 1007662 Change-Id: I5e5edccaabc2e7047e83ae6af963467ab6c5c4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374927Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#801678}
-
Devlin Cronin authored
The json_schema_compiler can treat dependencies as "hard" or "soft". Hard dependencies require a #include in the API's .h file, and are needed for e.g. types that aren't wrapped in a pointers. Soft dependencies can have a forward include. Since enums are never wrapped in pointers (they instead use a _NONE value to signify absence), they always need to generate hard dependencies. Bug: 1119660 Change-Id: Id30ca82ce4a84838518129eef39fa540574b8ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366560Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801677}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/30f6538a..1dec2f31 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2a81746e3cc445d692d3ffa05f5b29850afcc460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376605Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801676}
-
Josh Nohle authored
Splits the single contact manager observer method into three: 1) A notification when the list of selected contacts changes, along with whether contacts were added and/or removed from the list. 2) A notification when contacts are downloaded, including the list of downloaded contacts along with the list of selected contact IDs. 3) A notification when contacts are uploaded, including an indication of whether or not contacts have changed since the previous upload. These methods better align with the contact manager implementation in the child CL https://crrev.com/c/2307477. Bug: b/154863722 Change-Id: Iadf71c27febfeb66707844aef64660214eae2e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370922Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#801675}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d19c08c9ed8d..3c2454b82c05 2020-08-26 timvp@google.com Vulkan: Only count descriptor set resources once 2020-08-26 m.maiya@samsung.com Vulkan: Reserve memory for ResourceUseList::mResourceUses 2020-08-26 lehoangq@gmail.com Metal: Use compute to generate 3D texture's mipmap. 2020-08-26 jmadill@chromium.org Vulkan: Fix dirty state in XFB emulation on EndXFB. 2020-08-25 jmadill@chromium.org Revert "Work around dEQP KHR-GLES31 bug with tess/geom support." 2020-08-25 timvp@google.com Vulkan: Convert ProgramExecutableVk::mDescriptorSets to std::array 2020-08-25 jmadill@chromium.org Allow rendering to unused levels of bound Textures. 2020-08-25 ianelliott@google.com Vulkan: restore mContentDefined at endRP() 2020-08-25 syoussefi@chromium.org Vulkan: Generate perf warnings on suboptimal paths If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: CQTest: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/* Change-Id: Idf4ee37805ad5c53f525a03b6ae98d2e6dab04e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801674}
-
Arthur Wang authored
Some linux version might not like the '#' in the file name, replace it with well supported characters. Run this on arm64-rel CQ bot and it works. Bug: 1096656 Change-Id: Id589214dd473315b85698fcc60677f3d94772cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373042 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#801673}
-
Michael Bai authored
Currently the triggering of ContentCapture is unpredictable, it is hard for us to get the unbiased result for the UserActivatedDelay experiment. This patch adds an ExperimentContentCaptureConsumer which triggers the ContentCapture independently and is enabled by default. The allow list check is moved to consumer if the experiment is enabled. As ContentCapture is potentially used for all Android versions, we plan to run the experiment for all of them. This mechanism will also be used for future experiments. This patch hasn't supported multiple consumers yet. Test: Added new tests and pass the existing tests Bug: 1114819, 1119663 Change-Id: I72e0b991767329caec37080caae2d5c2a9068eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368104 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801672}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ff77947e7ecc..7023f47299aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3f726eeaf2d9f0838d4f42a8d36d0406366e04e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375723Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801671}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib3c7710366228777cdc14f17e10dfa6e61e92b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801670}
-
Zhenyao Mo authored
BUG=1117185 TEST=added tests R=sunnyps@chromium.org Change-Id: I88464603eff831c991100ca7ee37cc7c555bb553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368487 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#801669}
-
Marc Treib authored
After crrev.com/c/2374512, the reason for its flakiness should be gone. Bug: 1043899 Change-Id: Id33e945b5bd7eae3412146d008d9c344e039e987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375369Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#801668}
-
Austin Tankiang authored
Bug: 1007662 Change-Id: I8296336c501cdb4a4634d0c78545af123ef3d6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374910Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#801667}
-
tby authored
As part of fixing the omnibox/launcher_search_provider file duplication issue, we're going to increase the maximum number of file search results that can be shown to the user. Bug: 1053637 Change-Id: Idf8126ab2eb648cb5d7b393bcff451e6f6c958b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376785Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#801666}
-
Tal Pressman authored
Add a pointer to the AgentSchedulingGroupHost in RenderWidgetHost, and route some initial calls through it instead of the RenderProcessHost. This is needed since in the future all widget-specific communication will be done directly at the agent scheduling group level, and not the process level. Bug: 1111231 Change-Id: I65bf4769bd9572046316a9f569651bcaf8e462aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358943 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#801665}
-