- 03 Jun, 2020 40 commits
-
-
Aaron Leventhal authored
Avoid unnecessary processor usage for blinking caret, as accessibility children changed events are not needed. The caret is an ignored object, meaning that it is not even exposed as a child. These extra events are especially prevalent when the JAWS screen reader is running, because it increases the caret blink rate in order to track it better in legacy apps. Bug: None Change-Id: I83b20883dca9f73c5f529f23e5b99195bb0982a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225621 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774608}
-
Alex Rudenko authored
Inspector resources have been moved to DevTools[1]. This CL integrates all inspector resources with the inspector overlay agent. [1] https://crrev.com/c/2226560 Bug: 1078267 Change-Id: Ia0f8df3181bfc428df1e3222de070aa814523ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228551Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774607}
-
Andrei Salavei authored
Make |chromeos::AccountManager| instance available from |IdentityManager| class interface for tests. Bug: 1068240 Change-Id: I9d66c4bddd2df105e4aa0cd42699474e99a6837b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214383 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#774606}
-
Lukasz Krakowiak authored
Add test cases to fulfill expectations from ticket: * LookupDefaultInputDeviceWithProperGroupId * LookupDefaultOutputDeviceWithProperGroupId R=olka@chromium.org Bug: 764291 Change-Id: Ie1586febb83802df5a836d98c8a65d1bec643dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199062Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#774605}
-
David Bokan authored
This CL updates expectations for tests in layer_tree_host_unittest_scroll to pass when the scroll unification flag is turned on. We also run each LayerTreeHostTest with both states of the flag. Due to the use of macros, using a parameterized test is difficult so we do this manually inside the macro definition. These changes are mostly straightforward updates to expectations returned from ScrollBegin. Additionally, we replace instances of TryScroll with ScrollBegin as the former will go away after unification and we shouldn't be directly calling this internal method anyway. Its only external callers were these tests so this method is also made private. LayerTreeHostScrollTestScrollZeroMaxScrollOffset gets some significant changes to the test structure. This multi-step test was posting a SetNeedsCommit to the main thread which causes a main frame; the test step was implicitly tracked in the frame number. By updating to use ScrollBegin/ScrollEnd, the test became racy (under TSan) because ScrollEnd calls SetNeedsCommit as well and can in some cases synchronously post a task to the main thread. This meant that in some cases we might post two MBF which can commit before the first is drawn. The issue is solved by manually tracking the step and requesting the commit from the main frame. NonScrollingNonFastScrollableRegion also required a fix; it mixed up the container and scrollable bounds on the scrolling node so that the node wasn't actually scrollable. The test passed without unification because we fallback to the viewport node when we can't scroll any other node; the test wasn't checking which node is scrolling, only that one was. The fallback doesn't work in unification because we (correctly) expect that all scrolls will chain up through the viewport node. In this case, the test also didn't correctly parent the scroll node so this is fixed as well by making the layers parent from the outer viewport scroll layer. Bug: 1086625 Change-Id: I3c0c6b5f9e976c038f537fe50e1861b12d51acf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223088Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774604}
-
Jonathan Ross authored
http/tests/loading/bad-server-subframe.html began being flaky after being re-enabled in: https://chromium-review.googlesource.com/c/chromium/src/+/2219088 I'm marking it flaky on Mac TBR=danakj@chromium.org TEST=http/tests/loading/bad-server-subframe.html Bug:1088441 Change-Id: If61b47f0588aeaa01caf6f60cb437a7fda79a138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228979Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774603}
-
Liviu Rau authored
Bug: chromium:1086891 Change-Id: Ieaccbe5ba6a7d7d59e547696ba936803ad009016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216654 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#774602}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6a8b828fd50..fb005807e661 2020-06-03 patrick.brosset@microsoft.com Introducing a general UI interaction test for the Network panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66028b2ae609b74d75373c9d9bc4ff944be02d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228906Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774601}
-
Thiemo Nagel authored
MediaCanPlayTypeTest.CodecSupportTest_HLS MediaCanPlayTypeTest.CodecSupportTest_Mp4aVariants MediaCanPlayTypeTest.CodecSupportTest_Mpeg2Ts MediaCanPlayTypeTest.CodecSupportTest_mp3 MediaCanPlayTypeTest.CodecSupportTest_mp4 MediaCanPlayTypeTest.CodecSupportTest_ogg MediaCanPlayTypeTest.CodecSupportTest_wav MediaCanPlayTypeTest.CodecSupportTest_webm TBR=dalecurtis Bug: 1090770 Change-Id: I4c811e1b64c2693b8eceed9d9b477cc987a49d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228314Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774600}
-
arthursonzogni authored
Add some basic WPT tests about the COOP access reporting feature. No web browsers actually implement this. As a result, chrome do not pass them yet. The tests aren't complete yet, they will evolve along the specification and the implementations. Bug: 922191 Change-Id: I9aa03e727252086eb64c0110afc9b5885b66802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225757 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774599}
-
Ambre Williams authored
This adds the -funwind-tables flag when compiling libunwind. This allows unwinding past, eg. _Unwind_RaiseException. The upstream cmake build adds it when it is supported, and generation of unwind tables is already done for all the libunwind C++ code since it compiles with exceptions enabled. Also pass -fexceptions to the C code on Fuchsia only to work around https://bugs.llvm.org/show_bug.cgi?id=45875. Bug: 1078588 Change-Id: Id821f143c12e7e1e376eea534be52c6cd8504465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218273 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774598}
-
Aga Wronska authored
Bug: 1088897, 1088895 Change-Id: I2432a76053f8514880e46ae333f7d8e3f515bd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228111 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774597}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icf51a51b1cda01f4286a9012a6f4e76cfdef2269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228978Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774596}
-
Morten Stenshorne authored
NGBlockBreakToken::HasSeenAllChildren() is currently not used in inline formatting contexts (so doing it wrong currently doesn't cause any damage), but this is likely to change. formatting contexts. Remove that method, and call NextChild() for real instead, and provide an inline break token when appropriate. NGBlockChildIterator: :IsAtEnd() would just always return true in inline Change-Id: I87bf5178588682cfaa8219dce0d90b472d097b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220047Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#774595}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8278fd0af106..9221f239a587 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090683 Tbr: tnagel@google.com Change-Id: I49edf5eb12c5e9e1925da140139c4e8f12c5208a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228899Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774594}
-
Katie D authored
Bug: 1088521 Change-Id: I532457433acadf2e7d7de98ca36b461efca3bf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226927 Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#774593}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/43ccfecdb768..fae05624ec66 2020-06-03 tommi@webrtc.org Deprecate the static RtpRtcp::Create() method. 2020-06-03 kwiberg@webrtc.org C++ style: We don't allow designated initializers 2020-06-03 hbos@webrtc.org [Adaptation] Move Resource to api/ folder. 2020-06-03 stha09@googlemail.com IWYU: size_t is defined in stddef.h 2020-06-03 hbos@webrtc.org [Adaptation] Remove Resource::UsageState() and ClearUsageState(). 2020-06-03 titovartem@google.com Add list of participants to the start method of video analyzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iac10b44895d6286ac9d6f4d2ab4c916c11165d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228905Reviewed-by:
-
Annie Sullivan authored
Refactor test to focus on subframe; print window width/height. Bug: 943668 Change-Id: I28f9c66350f709fa792b242334d117255c36dc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227184Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#774591}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/086a04058cba..78eb17fc53a8 2020-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 515b4041cc32 to d43f5107400d (1 revision) 2020-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 2bc4fcd9eba5 to 322784a873be (1 revision) 2020-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 11dd7183c4d2 to 3ad285a60d82 (15 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I58e17858c8bf30e5af9eb9d6f9cf909f3b56c508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228902Reviewed-by:
-
Victor Hugo Vianna Silva authored
It seems over time, different features added to passwords settings ended up implementing the check of whether there are saved passwords resulting in hasSome_, hasStoredPasswords_ and hasPasswords_ (e.g. crrev.com/c/1047867, crrev.com/2107524). This CL summarizes these in a single hasSavedPasswords_ property, reflecting the name of the corresponding array. The same is done for the array of exceptions. The motivations here are: a) Keep simplifying the PasswordsSection code; b) Avoid the use of hasStoredPasswords_ in setSavedPasswordsListener, allowing to extract that code into a new behavior in the next CL. Bug: None Change-Id: Ib39c29f3cc5fd90bde3313971eb95d17b3ed9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225905 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#774589}
-
Antonio Sartori authored
https://crrev.com/770126 introduced a regression in memory usage. I think this regression was due to storing the whole redirect chain of a ResourceRequestHead alongside with it. Although this seemed like a clean idea from the code point of view, this causes heap allocation for information which we do not really need. In this change I get rid of it and only store the first and previous urls in the ResourceRequestHead. Change-Id: I2ee5c122142d732d1496e6606615d83e028581f4 Bug: 1084972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214542 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#774588}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1150db5e1ce..93f1a38fb5b9 2020-06-03 kjlubick@google.com [canvaskit] Add flexibility to setColor API 2020-06-03 kjlubick@google.com [canvaskit] Change Malloc to return object instead of TypedArray If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I98e091e00156b148a67654a9b27fc2849a7f2724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228904Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 497ef2a5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2cbad6165a096562e1e51e037bbc6a9312df5fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228573Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774586}
-
Andrei Salavei authored
To make the IdentityManager's constructor easily extendable for different platforms, use a dedicated struct - |IdentityManager::InitParameters|. It helps in passing platform specific fields to IdentityManager, like |chromeos::AccountManager|. Bug: 1068240 Change-Id: I48eb10cb6f32c447692a9af045cfcedd66b4052d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212050 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I72b511a4b3ce9efb0c65036eee91c5c7e47ec188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228131Reviewed-by:
-
Viktor Semeniuk authored
This change adds BulkLeakCheckServiceInterface and TestBulkLeakCheckService which can be used by unit tests. Bug: 1087314 Change-Id: Ia7d80efe1b09a107c8cf1241f2b7fbd1a6a3de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218174 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Yunke Zhou authored
Bug: 1052281 Change-Id: Iaebf9fcb383de713f37ac7168e0bf20768a26044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225899 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f116b95..d77fdbe0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib15955733a87d1b61cf204cefa6f24fc9bd453b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228938Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774581}
-
Travis Skare authored
Reduces dialog width and space below download button to spec. Matches eligibility logic to send-tab-to-self (http-or-https) Matches focus hide/show to STTS. BUG=1077077,1082829 Change-Id: I0deee3f85d2ccc69190c2723e394584f8ee79588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218760Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#774580}
-
Caitlin Fischer authored
Bug: 1090424 Change-Id: I2c1fe5047360c23dbee12189e6411933ab4e9ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225847Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#774579}
-
Caitlin Fischer authored
This is accomplished by registering the FieldTrialsProvider last and by implementing FieldTrialsProvider::ProvideCurrentSessionData. This CL also adds a utility function to LogDecoder for decompressing data and parsing it to a proto. Bug: 1078795 Change-Id: Ic63afbc8fb3e92d6e98f80a3817bcfc3be1f2e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208293 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia673010c88e4a426db58be73456ab8b77bbde991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228901Reviewed-by:
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2215850 R=sigurds@chromium.org Bug: 1011811 Change-Id: I818c2e72be4151674a9bedf4d03935fec81296a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216251 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#774576}
-
Ravjit Singh Uppal authored
Bug: 1073883 Change-Id: I98964fe27b8a3f5bc247291e0b810e5e74c04a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224863 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774575}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: I31dc7b4a96759cf7203452e926df2d74e8860716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226854Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591156770-3a8b9ed3582dca859cc61c05847c60f8252d4d44.profdata to chrome-win32-master-1591170216-be28c2b4718a2f482f298b7a886d3f3e5fe30114.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I761c957b279738979103c8ebe3d7ce545fc3b76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228488Reviewed-by:
-
Victor Hugo Vianna Silva authored
The CL replaces the "These passwords were not commited" message in the bubble with a more informative one. The CL also changes the text on the cancel button from "Cancel" to "Discard". The strings are moved to a .grd file but are still kept as non-translateable, since they are not final. Screenshot of new bubble strings: https://screenshot.googleplex.com/fzW2r5fnawV Bug: 1060132 Change-Id: Ifc630eec1e2b23ee4d43305e316ce7c01606a390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228839Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#774572}
-
Hitoshi Yoshida authored
Bindings is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes the potential bug in Animatable.animate(). Bug: 839389 Change-Id: I305daff7130a2a26b5a7142f67fe7920910cead3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226483Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774571}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for project details. Bug: 1080832 Change-Id: I75a25ed0ff64561cb68555f5a6622cbb5b9d723a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228741 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1067228, 1073095 Change-Id: I00cc22cbc87eb2cc1641f2c40ab0630988c1f247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228610Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774569}
-
