- 07 Jul, 2017 40 commits
-
-
Fady Samuel authored
This CL moves: cc/resources/resource_format.h => components/viz/common/quads cc/resources/resoure_format_utils.{cc|h} => components/viz/common/resources cc/resources/platform_color* => components/viz/common/resources. This CL also moves out the functions in resource_format to resource_format_utils. The rest of the changes are just updating includes, namespaces and DEPS. TBR=piman@chromium.org, reveman@chromium.org, junov@chromium.org Bug: 722935 Change-Id: I4b861448df64f08733dac254525f1770336f9254 Reviewed-on: https://chromium-review.googlesource.com/563737 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#485089}
-
holte authored
BUG=739971,734091 Review-Url: https://codereview.chromium.org/2976453002 Cr-Commit-Position: refs/heads/master@{#485088}
-
smut authored
Bug: 738255 Change-Id: Ib00bbc4e7ca58868ed29dd72111042b29c74aa56 Reviewed-on: https://chromium-review.googlesource.com/562566Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#485087}
-
Alexei Filippov authored
Bug: 727780 Change-Id: I57046e86809b4f515b6856bf072c11cadd1bd45f Reviewed-on: https://chromium-review.googlesource.com/562976 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485086}
-
Alexei Filippov authored
It was caused by the stale timeToPixel ratio during zoom animation. Request the actual ratio from the chart viewport. Bug: 735584 Change-Id: I52a39c9377c9ae770a51e7f962426fc92dec8ec6 Reviewed-on: https://chromium-review.googlesource.com/562545Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#485085}
-
Jeff Carpenter authored
This is to verify recent changes to the exporter are functioning properly. Bug: 740176 Change-Id: I1fb68dafff0c3b760f3f50abe8300d3ead5124f4 Reviewed-on: https://chromium-review.googlesource.com/563958Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#485084}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/554098. This shouldn't change the behavior. Bug: 686281 Change-Id: Ia8ba4ac41aafc2851ba58389b4dd8d7d5910a226 Reviewed-on: https://chromium-review.googlesource.com/557381 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485083}
-
Sky Malice authored
Bug: 740221 Change-Id: I59bcfd1a9a6a27b00d41ba9fee65f24b7dd0fc73 Reviewed-on: https://chromium-review.googlesource.com/564177Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#485082}
-
Peter Beverloo authored
We added this check many years ago in response to a security issue where sender IDs weren't appropriately checked on the server. The check is the reason that extensions cannot use GCM Topic Messaging (because the `from` field for such messages is set to the topic, not the sender), and we may be missing out on unsubscription opportunities for Web Push too. The server-side issue has since been fixed, as confirmed by the GCM team. The check adds complexity and blocks a reasonably popular feature from being used by extensions, so let's just drop it. BUG= Change-Id: I1208548a583b97210628c5c72588587b2df48e72 Reviewed-on: https://chromium-review.googlesource.com/559145Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#485081}
-
Tommi authored
BUG=689520 Change-Id: Ida4b4b15a265d3a5bec6484d5dc4922df7f7334b Reviewed-on: https://chromium-review.googlesource.com/563359Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485080}
-
Alexei Filippov authored
Change-Id: I1b54003924e3c35c04fb9781820dced4830afde7 Reviewed-on: https://chromium-review.googlesource.com/545238 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485079}
-
hcarmona authored
BUG=737739 Review-Url: https://codereview.chromium.org/2965493003 Cr-Commit-Position: refs/heads/master@{#485078}
-
Bret Sepulveda authored
TBR=guidou@chromium.org Bug: 740251 Change-Id: I8bd65c5fdf55437778ee21ed4f98b74a60c11589 Reviewed-on: https://chromium-review.googlesource.com/563774Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485077}
-
Chris Harrelson authored
for the clip mask. The actual PaintLayer that the mask applies to may have a much smaller visual rect (or even empty), but nevertheless have a child which is not empty. If the visual rect were too small, some paint ops may not be rastered. Bug: 736661 Change-Id: Ib61766057e36f83cfab2be35d08c7773d2b676e1 Reviewed-on: https://chromium-review.googlesource.com/562614 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#485076}
-
Brett Wilson authored
This brings the first part of the .cc file in line with the header, as promised in the patch that ordered the header. Remove 2 obsolete items in the header that had no definition, and re-sort one thing added in the wrong place. TBR=pkasing@chromium.org Change-Id: I6427c182d11cd164d3a0ac42fc0280d8bd806730 Reviewed-on: https://chromium-review.googlesource.com/562646 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485075}
-
Bruce Dawson authored
pe_summarize.py is used to summarize the sizes of the sections in a PE file (a DLL or EXE). It can also summarize the differences between two PE files which is handy when investigating size regressions. The original version of this script assumed that section names matched exactly but this assumption does not always hold. This assumption breaks when comparing 32-bit PE files to their 64-bit counterparts, and it breaks if the size regression includes some new sections being added. So, this change updates the script to handle these mismatches, to increase flexibility and prevent confusion. I tested this change with the before/after versions of chrome_watcher.dll associated with crbug.com/717103. It listed all the changed sections and gave consistent total differences. BUG: 717103 Change-Id: I923e2655605333a72f0c9e3b9eecf6f7ec2a62d3 Reviewed-on: https://chromium-review.googlesource.com/563763Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#485074}
-
rdevlin.cronin authored
Setting the lastError property is implemented natively with native bindings, and the JS version should never be used. Don't load the lastError module when native bindings are enabled to enforce this. BUG=653596 Review-Url: https://codereview.chromium.org/2959583002 Cr-Commit-Position: refs/heads/master@{#485073}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ec045b431211..9b80ffc77b80 $ git log ec045b431..9b80ffc77 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 ethannicholas converted GrCircleBlurFragmentProcessor to sksl 2017-07-07 borenet Add infra OWNERS Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ib606ef3d5bd97425b622220520af5673b3efcb48 Reviewed-on: https://chromium-review.googlesource.com/563469Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485072}
-
Sorin Jianu authored
Also, make the clean up of stale jobs more aggressive. TBR=waffles Bug: 737730 Change-Id: I61bf9831aa5f753003c10ef50169a81a2545792a Reviewed-on: https://chromium-review.googlesource.com/563765 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485071}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1e3b1949cdcd..c2d9d2f7f16e $ git log 1e3b1949c..c2d9d2f7f --date=short --no-merges --format='%ad %ae %s' 2017-07-07 kraynov Android systrace: Process dump agent and importer scaffolding. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I69109dce7b4f7d91d0985d6511222796980aad7d Reviewed-on: https://chromium-review.googlesource.com/563646 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485070}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/554098. This shouldn't change the behavior. Bug: 686281 Change-Id: Ie5bc4d5f6974c00efa13899998c6b0b225fd941c Reviewed-on: https://chromium-review.googlesource.com/554119 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485069}
-
Nathan Bruer authored
Fixes a regression caused by: https://chromium-review.googlesource.com/c/526855/ SDK.TracingModel.reset() was removed in favor of destroy() and re-constructing it, but closure did not complain because of @unrestricted. This patch also will keep this from happening here by removing @unrestricted from classes in NetworkPanel.js. R=caseq BUG=736219 Change-Id: I4284602dbaca4af93e6645dd395ce4ebc51613ed Reviewed-on: https://chromium-review.googlesource.com/562299 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485068}
-
Reilly Grant authored
The blink::InterfaceProvider class is deprecated in favor of service_manager::InterfaceProvider. This patch makes LocalFrame::GetInterfaceProvider() a wrapper around LocalFrameClient::GetInterfaceProvider() instead and updates call callers. Bug: 726943 Change-Id: I1c1c59b62ecd824fe3bed31279b758ffed64ae85 Reviewed-on: https://chromium-review.googlesource.com/538911 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485067}
-
Ned Nguyen authored
Bug:728785 Change-Id: Ia7e9a7c1739be25c9f32ab88262b075d553ec535 After the fix to scrolling retry logic in https://chromium-review.googlesource.com/c/563340/, I can run this test multiple time on my Mac without flakes. So this is probably fixed. TBR=ulan@chromium.org, perezju@chromium.org Change-Id: Ia7e9a7c1739be25c9f32ab88262b075d553ec535 Reviewed-on: https://chromium-review.googlesource.com/563527Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#485066}
-
Hiroshige Hayashizaki authored
This CL introduces ExecuteScriptBlock() that is intended to directly corresponds to "execute a script block" in the HTML spec: https://html.spec.whatwg.org/#execute-the-script-block Upcoming CLs will replace ExecuteScript() calls with ExecuteScriptBlock() and make all script execution code paths call ExecuteScriptBlock(). This provides a spec-conformant single control point of script execution including load/error event dispatching, preparing for Issue 721914. This shouldn't change the behavior. Bug: 686281, 721914 Change-Id: Ia4d1d8a2db2b3d203db99b3a9e66be956ca9db74 Reviewed-on: https://chromium-review.googlesource.com/554098 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485065}
-
Vladimir Levin authored
This is a simple cleanup patch to remove unused fields. R=enne@chromium.org Change-Id: I023c86512541de6ed64e924904867b483d7ab268 Reviewed-on: https://chromium-review.googlesource.com/563512Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485064}
-
Daniele Castagna authored
Clean up GLRenderer::DrawTextureQuad declaration since it has no definition. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib43c5457d2769ede986bfe4c9c5ec20e2de7cf36 Reviewed-on: https://chromium-review.googlesource.com/560877Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#485063}
-
dtseng authored
In "braille mode", Docs re-exports the entire paragraph if you type. For a sample tree: text field (paragraph (static text (inline text box))) everything except for the text field gets destroyed. Thus, any client holding a reference to any node cannot use it in any logic. To work around this issue, add a new RecoveryStrategy class along with subclasses that implement specific recovery strategies. One such strategy is based on the tree path of the node and is useful here. When requested, the recovery can compute the recovered node for the invalidated node. In EditableLine, add a new member to track the line start container using a tree path recovery strategy. When determining whether two lines are equal, use the recovered node to decide if the two lines are the same along with the local start offset. TEST=type into Docs; verify character echo works. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2971913003 Cr-Commit-Position: refs/heads/master@{#485062}
-
Eric Roman authored
BUG=739896 Change-Id: Ia15bd6da393cbc4b0ad35ad727fa73bcd850b988 Reviewed-on: https://chromium-review.googlesource.com/562562Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485061}
-
lethalantidote authored
This CL creates the necessary interfaces to allow WebMediaPlayer have a SuraceLayer that is able to obtain SurfaceIds via The SurfaceLayerBridge. In this CL you will also find: - Renames CanvasSurfaceLayerBridge to SurfaceLayerBridge. - SurfaceLayerBridge now owns the WebLayer. - A WebSurfaceLayerBridge interface that allows the creation of SurfaceLayerBridge and the access of its WebLayer in media/blink. BUG=726619 Review-Url: https://codereview.chromium.org/2956713003 Cr-Commit-Position: refs/heads/master@{#485060}
-
Hiroshige Hayashizaki authored
This CL stops firing load events for inline module scripts controlled by ScriptRunner, by checking IsExternal() in Execute(). This CL doesn't affect classic scripts, because all classic scripts controlled by ScriptRunner are external scripts. Bug: 715369 Test: external/wpt/html/semantics/scripting-1/the-script-element/module/load-error-events-inline.html Change-Id: I1157b7e2d1f4f6e64077fde901cc6a6b95c102ae Reviewed-on: https://chromium-review.googlesource.com/557978 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485059}
-
Sergey Ulanov authored
Several simple fixes to make //gpu compile on Fuchsia: 1. Updated surface_handle.h to declare SurfaceHandle. 2. gpu/ipc/common/memory_stats.h updated to convert int32_t between ProcessId. 3. Updated eglplatform.h in third_party/khronos to define types for Fuchsia 4. Enabled use_egl in ui/gl Bug: 737802 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad46d340ebdd3916ac43a3528cdaa37c9641d2be Reviewed-on: https://chromium-review.googlesource.com/563764Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485058}
-
Dave Tapuska authored
The InputEvent struct traits currently convert from WebInputEvent<--mojo-->WebInputEvent. Eventually we will use the struct traits to convert ui::Event<--mojo-->WebInputEvent when we only use WebInputEvents inside the renderer. BUG=722928 Change-Id: I8653d74a0342da28c92ba2b31d5f98effbac54d1 Reviewed-on: https://chromium-review.googlesource.com/543197Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#485057}
-
Justin Donnelly authored
Bug: 732681 Change-Id: Ic51430e0acdc22acfc778158ee328f973e7f1c45 Reviewed-on: https://chromium-review.googlesource.com/559914Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#485056}
-
Bret Sepulveda authored
Test has been flaky in browser_side_navigation_browser_tests on the Win10 x64 builder. TBR=jialiul@chromium.org Bug: 736354 Change-Id: I0c08342b573df0b839e007b02d8d6509a831d20a Reviewed-on: https://chromium-review.googlesource.com/563770Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485055}
-
Yuki Awano authored
- third_party/minizip/src is checked out only on unix platform by gclient. Enable minizip_uncompress_fuzzer only on linux. BUG=739548 TEST=Able to build minizip_uncompress_fuzzer on linux. No build error on other platforms. Change-Id: If7dbd8415778648b3f3e06493127497788a0b004 Reviewed-on: https://chromium-review.googlesource.com/562937Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#485054}
-
Matthew Jones authored
WebContents::getUrl is considered obsolete. Each instance now uses either getVisibleUrl or getLastCommittedUrl depending on the context. The Java WebContents implementation of getUrl is removed with this change. BUG=237908 Change-Id: Icae13f41a1226d30ed712c513b2f58f95e80c91a Reviewed-on: https://chromium-review.googlesource.com/543561Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#485053}
-
Bret Sepulveda authored
This reverts commit 75bf6831. Reason for revert: Causing failures in services_unittests on Chrome OS builders. Sample failure: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/27980 Original change's description: > [GRC] Remove ambiguity from CoordinationUnitImpl property operations > > The following changes address ambiguity regarding the methods related > to the CoordinationUnitImpl property store: > > 1. Eliminate the mojom::Property struct > Previously, a mojom::Property struct was used to set properties > using the Mojo interface to a particular CoordinationUnit, while > a key-value approach was used locally. The latter is the preferred > approach, making the mojom::Property unnecessary. > > 2. Remove CoordinationUnitImpl::ClearProperty (for now) > A CoordinationUnitImpl::ClearProperty was added but never actually > used for anything. It has been removed for now as its use is > unclear. If a valid use case is found it can be added back. > > Bug: 691886 > Change-Id: I2d8fa1478c1bf784b29d9783fca2acddab25062b > Reviewed-on: https://chromium-review.googlesource.com/562917 > Reviewed-by: Zhen Wang <zhenw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Matthew Halpern <matthalp@google.com> > Cr-Commit-Position: refs/heads/master@{#484994} TBR=dcheng@chromium.org,zhenw@chromium.org,oysteine@chromium.org,lpy@chromium.org,matthalp@google.com Change-Id: Ic8f2ea1160f020aea7361cf553e709bee9ef599d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 691886 Reviewed-on: https://chromium-review.googlesource.com/564116Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485052}
-
aleventhal authored
More precise use of multiline state. It only needs to be exposed at the root of the editable area. ARIA should override native markup. Add lots of tests. BUG=730138 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2931893002 Cr-Commit-Position: refs/heads/master@{#485051}
-
tzik authored
This is a generated CL to rewrite base::Bind to base::BindOnce where the result of base::Bind is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); An explainer of OnceCallback is available here goo.gl/YZiUL1. The rewriting tool is in //tools/clang/base_bind_rewriters. To build and run locally, follow //docs/clang_tool_refactoring.md. This conversion makes almost no behavior change except that a bound objects are passed-by-move to the target function. Bug: 554299, 714018 Change-Id: I33da31a8980ecd54de8741a839c762f4bb6079ff Reviewed-on: https://chromium-review.googlesource.com/547697Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#485050}
-