GitLab

Example (new on top, old on bottom): http://imgur.com/a/vx7pW

BUG=99426

Review URL: https://chromiumcodereview.appspot.com/16019014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203052 0039d316-1c4b-4281-b951-d872f2087c98

The bugs fixed are:
- programs required for -o2 weren't checked for when using -o2
but were checked for lower -o levels.
- if no savings could be found the results printed at the end
were confusing and the script had a divide by zero error.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15970004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203051 0039d316-1c4b-4281-b951-d872f2087c98

This removes third_party/IconFamily from Chrome, which creates
questionable results when adding icon sizes < 128px. Since OSX 10.5, OSX
hasn't used indexed icons or alpha masks when a 32-bit icon is available
(see notes in OSServices.framework/IconStorage.h).

BUG=241304
TEST=Create an app shim and inspect Resources/app.icns using OSX Preview
-- ensure the icons are correct.
TBR=darin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15650005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203050 0039d316-1c4b-4281-b951-d872f2087c98

Fix some style nits while there.

TEST=Robot Unicorn Attack.
BUG=

Review URL: https://chromiumcodereview.appspot.com/15990006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203049 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242227
TEST=unittest

Review URL: https://chromiumcodereview.appspot.com/15862014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203048 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates content's references to the old location to
point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.

TBR=jamesr@chromium.org
BUG=239545

Review URL: https://chromiumcodereview.appspot.com/15822010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203047 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the heapchecker+components release build.

BUG=241938

Review URL: https://chromiumcodereview.appspot.com/15797009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203046 0039d316-1c4b-4281-b951-d872f2087c98

It makes the test more self-contained.

This patch converts only the tests not involving file deletion feed,
which is not supported yet in FakeDriveService.

BUG=244316

Review URL: https://chromiumcodereview.appspot.com/15741023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203045 0039d316-1c4b-4281-b951-d872f2087c98

Add per-dialog UseNewStyleForThisDialog() style control.
(by default this returns the static UseNewStyle() control)
Update DialogDelegate to respect this per-dialog control.

Have TaskManagerView always use the old style; cleanup.
See before/after pics at http://crbug.com/245000#c1

Do DialogClientView background init in ViewHierarchyChanged.
(check the dialog delegate instance for styling control)

BUG=245000,166075
TEST=The task manager always uses the old dialog style.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15731007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=mtomasz@chromium.org, hirono@chromium.org

Review URL: https://codereview.chromium.org/16216006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203043 0039d316-1c4b-4281-b951-d872f2087c98

The ui::CompositorTestSupport class existed to initialize WebKit since
ui::Compositor depends on cc which used to depend on WebKit being initialized
to function properly.  cc no longer has this requirement, so this class is
unnecessary.

R=piman, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202787

Review URL: https://chromiumcodereview.appspot.com/14744016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203042 0039d316-1c4b-4281-b951-d872f2087c98

This adds a task graph interface to the worker pool and
implements a simple queue instance of this interface for
use by the tile manager.

The task graph interface can be used describe more
complicated task dependencies in the future and
provides the immediate benefit of seamlessly being
able to cancel and re-prioritize tasks.

BUG=178974,244642
TEST=cc_unittests --gtest_filter=WorkerPoolTest.Dependencies

Review URL: https://chromiumcodereview.appspot.com/14689004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203041 0039d316-1c4b-4281-b951-d872f2087c98

FileSystem::GetFileByResourceId was converting resource ID to file path and then calling EnsureFileDownloaded.
Rename EnsureFileDownloaded to EnsureFileDownloadedByPath and add an additional version EnsureFlieDownloadedByResourceID
to avoid the unnecessary conversion from resource ID to file path.

BUG=244135
TEST=unit_tests
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/16190003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203040 0039d316-1c4b-4281-b951-d872f2087c98

that the Blink roll is sticking.

BUG=238484
R=abarth@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203039 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/15624003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203038 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the DOMActionType was being sent from the renderer to the browser ActivityLog as a string. It was then being turned into an enum. I've now moved it to its own proper field, and it's being marshaled across the renderer/browser boundary as an int that matches an enum instead of as a string.

R=mpcomplete@chromium.org
BUG=229703

Review URL: https://chromiumcodereview.appspot.com/15520002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242261

Review URL: https://chromiumcodereview.appspot.com/15359007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203036 0039d316-1c4b-4281-b951-d872f2087c98

Don't allow the the page to call setValue() if the omnibox doesn't have focus.
This breaks the "clearing out gray text" usecase (when the user clicks on
the suggestion corresponding to a gray-text completion), but we aren't
worried about it because we are aiming for a launch without any gray text.
We'll re-enable setValue() in the general case when we handle it properly.

Also disable the focus() API to prevent a trivial workaround (where the page
focuses the omnibox and then calls setValue).

BUG=229193

Review URL: https://chromiumcodereview.appspot.com/15001020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203035 0039d316-1c4b-4281-b951-d872f2087c98

Unreviewed gardening.

TBR=tomhudson@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/16123010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203030 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 4c237453.

As with the previous two rolls, this broke WebViewInteractiveTest.PopupPositioningMoved on the Mac.

TBR=tomhudson@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/15731010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203029 0039d316-1c4b-4281-b951-d872f2087c98

> Make the copy of GURL in src/url buildable as a component build. (try 2)
> 
> BUG=229660
> TBR=brettw
> 
> Review URL: https://chromiumcodereview.appspot.com/15805003

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/15848009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/15772012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229660
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/15805003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203025 0039d316-1c4b-4281-b951-d872f2087c98

R=mpcomplete@chromium.org
BUG=55316

Review URL: https://chromiumcodereview.appspot.com/15825008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203024 0039d316-1c4b-4281-b951-d872f2087c98

Swapping between BoxLayouts when the background toggles is confusing, and
requires us to also add and remove children in order to get the padding right.

Instead, just manually Layout(), which isn't hard, and allows us to create the
text label in the constructor and just toggle its visibility instead of actually
adding and removing it.

This CL contains a few minor changes:
* The label now obeys not only the passed-in font but also the color and
  y-position.
* The label is now ALIGN_LEFT, which probably doesn't matter with NO_ELIDE but
  is more logical in principle (since we think of the label as being pinned to
  the icon on its left side).
* The size calculations now cause the animation to smoothly grow from the size
  of the icon all the way out (and vice versa), rather than having the starting
  state of the animation be a jump (compared to the non-animating state) to
  immediately showing the background already expanded out to the margins around
  the icon.  This is almost imperceptible at full speed but makes the animation
  slightly smoother.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/16115010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203023 0039d316-1c4b-4281-b951-d872f2087c98

Fix the problem that the minimized docked panel is not unsqueezed back to its original size when the restore button is clicked

The fix is to make Panel::OnRestoreButtonClicked call Panel::OnTitlebarClicked such that the logic provided in OnTitlebarClicked can take effect

BUG=244781
TEST=Manual test by following repro steps as in the bug

Review URL: https://chromiumcodereview.appspot.com/15807006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203022 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=245043
TBR=ilevy@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16087007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203021 0039d316-1c4b-4281-b951-d872f2087c98

These headers have moved from Source/Platform/chromium/public to
public/platform. This CL updates src/webkit's references to the old location to
point to the new location. After this CL lands, I'll remove the forwarding
headers that are letting these references still work.

TBR=jamesr@chromium.org
BUG=239545

Review URL: https://chromiumcodereview.appspot.com/15937016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203020 0039d316-1c4b-4281-b951-d872f2087c98

Improve container detection testing by testing additional containers (new containers added https://codereview.chromium.org/16034004/). Also put back original reference URLs in source.

BUG=235108

Review URL: https://chromiumcodereview.appspot.com/15966005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203019 0039d316-1c4b-4281-b951-d872f2087c98

I find these function names confusing. I have to stop and read the code each
time I try to use them to figure out what they're going to do.

Part of the confusion is that ClampToMin sets the components to the _maximum_
of the two sizes/vectors. It's also not clear from the function name which of
the two objects is acting as the 'Min'. This is mitigated by the parameter names
and local variables passed to the function, but it would be nice if the name
of the function itself made this clear.

a.ClampToLowerBound(b) makes it clear both that b is acting as the lower bound
and how and when a is going to be altered.

Other names I've considered (for ClampToMin -- the suggestions for ClampToMax
are analagous):
  ClampIfSmallerThan(other)
  SetComponentsToMax(other)
  Union(other) (for sizes)

R=danakj,sky
BUG=None

Review URL: https://chromiumcodereview.appspot.com/14367021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203017 0039d316-1c4b-4281-b951-d872f2087c98

The following issues have been fixed:
1) If one or more panels in the stack are collapsed, the live preview is not shown correctly.
2) If the whole stack is minimized by the system, the live preview is not shown correctly.

BUG=177743
TEST=Manual tests by collapsing a panel or system-minimzing a stack and then hover over the taskbar icon

Review URL: https://chromiumcodereview.appspot.com/16035007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203016 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta@chromium.org
BUG=228833

Review URL: https://chromiumcodereview.appspot.com/15977002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242540

Review URL: https://chromiumcodereview.appspot.com/15675011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203013 0039d316-1c4b-4281-b951-d872f2087c98

Removal of this Flush is correlated with an increase in file
corruption on ChromeOS, so we're going to try and put it
back and see if our file corruption problems get better.

TBR=sky@chromium.org
BUG=chromium:236093
TEST=ran unit tests, ran on device.

Review URL: https://codereview.chromium.org/15937015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203012 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203010 0039d316-1c4b-4281-b951-d872f2087c98

per match pattern, by disallowing wildcard hosts and wildcard subdomains
of TLDs (com) and effective TLDs (appspot.com).

R=yoz@chromium.org
BUG=55316

Review URL: https://chromiumcodereview.appspot.com/15862011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203009 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151350:151373&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16171013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203008 0039d316-1c4b-4281-b951-d872f2087c98

verify-translations.py script is not longer necessary because
grit is now used to generate message.js files.

R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/15650018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=77656

Review URL: https://chromiumcodereview.appspot.com/16019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203006 0039d316-1c4b-4281-b951-d872f2087c98