- 18 Sep, 2018 40 commits
-
-
Mikel Astiz authored
After a long debugging session, we haven't yet found an explanation as per why the processor enters an inconsistent state, where apparently OnSyncStarting() is received twice without OnSyncStopping() in between. As a last resort to continue the investigation, we add even more CHECKs to understand which layer is violating the API contracts. Bug: 876490,885019 Change-Id: Ia15fa29d8bd128730bd79b4760ea233f09d9862e Reviewed-on: https://chromium-review.googlesource.com/1230733Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592041}
-
Jacobo Aragunde Pérez authored
Bug: 884306 Change-Id: Ibeff0b4c01007d9cfa0fbed3115a4acd5c3c8586 Reviewed-on: https://chromium-review.googlesource.com/1230019Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#592040}
-
Hans Wennborg authored
This is already inside an if (is_clang) scope. Bug: none Change-Id: I893f21598d4bc0e26c8d52fae44a48b6767f3eed Reviewed-on: https://chromium-review.googlesource.com/1230043 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592039}
-
Nicolas Ouellet-Payeur authored
Bug: 884221 Change-Id: Iaee4d979888e3bc5acf55f88c3618fd33810adf6 Reviewed-on: https://chromium-review.googlesource.com/1226025Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592038}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45b9bc919502..cc38544e3562 git log 45b9bc919502..cc38544e3562 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 pasko@chromium.org androidStartupMetric: remove request_start_time from comments Created with: gclient setdep -r src/third_party/catapult@cc38544e3562 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:883290 TBR=sullivan@chromium.org Change-Id: I237765b77a49da001cbb1ef19f147e4638f5f093 Reviewed-on: https://chromium-review.googlesource.com/1230320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592037}
-
Nicolas Ouellet-Payeur authored
Environment variables on the command-line (alternative browser path and parameters) are expanded before being passed to the external program. On Windows, this means strings like '%HOME%' are expanded. On Linux, this means strings like '$VAR' and '${VAR}' are expanded. Also, a '~' at the beginning of a command-line argument is expanded to the HOME environment variable. Bug: 882520 Change-Id: I9822b465999b3515d37e882f18a19df39b3e64d6 Reviewed-on: https://chromium-review.googlesource.com/1225854Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592036}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77304e28a65b..9a146dc589d8 git log 77304e28a65b..9a146dc589d8 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 hjd@google.com Merge "perfetto-ui: Add canned queries" Created with: gclient setdep -r src/third_party/perfetto@9a146dc589d8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8b1f1ea8d95bd19eb461c696f995a872f70a0b6b Reviewed-on: https://chromium-review.googlesource.com/1230321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592035}
-
Owen Min authored
Remove the directory when it's empty and there is no enrollment token. It only deletes $app_data_dir/Google/Chrome Cloud Enrollment/ It does NOT delete $app_data_dir/Google because it's used as default user data dir. Bug: 883869 Change-Id: Ie6071638fcc847dfe9d10e35884585b92b857d3e Reviewed-on: https://chromium-review.googlesource.com/1228946Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592034}
-
Reza.Zakerinasab authored
TBR=fserb@chromium.org Bug: 845556 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I623dad8aa5342ed2d6f1edd0f70ac3b41dbf84e1 Reviewed-on: https://chromium-review.googlesource.com/1228214Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592033}
-
Mugdha Lakhani authored
when: 1. recordsAvailable is false 2. the background fetch is incomplete. Bug: 882478 Change-Id: Id849a73370f8f07597039c3ccee5efce828fa452 Reviewed-on: https://chromium-review.googlesource.com/1226913Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592032}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I9db3182f9194360c8729e174a31ac77493f63f87 Reviewed-on: https://chromium-review.googlesource.com/1226023Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592031}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9b4845975ff..18b4479cee3f git log f9b4845975ff..18b4479cee3f --date=short --no-merges --format='%ad %ae %s' 2018-09-18 borenet@google.com gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator Created with: gclient setdep -r src/third_party/depot_tools@18b4479cee3f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6481d510a741df8843c64ab0b0f837f6cf96fd7a Reviewed-on: https://chromium-review.googlesource.com/1230315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592030}
-
Sean Gilhuly authored
The flag is not respected with OOP-D, so read the flag and send it to the GPU process. Bug: 841801 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I87644f9c10a04491289f9fe89b8cbbd9584bfb2a Reviewed-on: https://chromium-review.googlesource.com/1228497 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#592029}
-
Fredrik Söderquist authored
Intent-to-Ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/8B9FbeTBIK0/DNkC2pz-AAAJ Also removing the actual feature and corresponding check, because it's only used in a single spot, so if the feature should need to be unshipped it ought to be a fairly trivial revert. Bug: 707047, 880733 Change-Id: Ie854d7fd9f7a22e9c6144668a37f694dd1c508ee Reviewed-on: https://chromium-review.googlesource.com/1230018Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#592028}
-
Vladislav Kuzkokov authored
This doesn't look as weird as |false| for success and makes it consistent with |setLocalDestinationCapabilities|. Change-Id: I28dd85308bfe89d95aa90a68e6eacffa665e6c10 Reviewed-on: https://chromium-review.googlesource.com/1225766 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592027}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5f599e700e93..7f0a8877a213 git log 5f599e700e93..7f0a8877a213 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 stevenperron@google.com Move the registration of decorations. (#1895) 2018-09-18 stevenperron@google.com Add dummy loop in merge-return. (#1896) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7f0a8877a213 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4b2a99577848ab8fbab4258b7b6c14d18db683c7 Reviewed-on: https://chromium-review.googlesource.com/1230319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592026}
-
Ria Jiang authored
Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iebf99dde5bd1524779c417eb72dbe9e887e2457a Reviewed-on: https://chromium-review.googlesource.com/1228477Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592025}
-
Xi Han authored
TBR=jam@chromium.org Bug: 846846 Change-Id: I296abce1c525b642010268d48a50fd4b57573211 Reviewed-on: https://chromium-review.googlesource.com/1228475 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592024}
-
Mugdha Lakhani authored
from the WPT suite. This was added in response to an ongoing CL in the Fetch spec, which nobody is championing at present and isn't part of the spec. Here's the proposed spec change for reference: https://github.com/whatwg/fetch/pull/519/commits Bug: 884708 Change-Id: I185a876147ab7e02edd611840a237dce1cab750a Reviewed-on: https://chromium-review.googlesource.com/1228060Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592023}
-
Justin Cohen authored
Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If5a512f4acd9acfa9e606a119686040436436dfd Reviewed-on: https://chromium-review.googlesource.com/1228514Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592022}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96c8cc90..1bce3d27 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff0d9caa74a169c8822111d664585f89b608c858 Reviewed-on: https://chromium-review.googlesource.com/1230314Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592021}
-
Gyuyoung Kim authored
ApplyViewportDeltas and RecordWheelAndTouchScrollingCount have been using a raw pointer type for the argument. It would be good if we can use const T& for the arguments if possible. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibdcbc5cd3ebe95cce743b2ffcc84b7dc009a0044 Reviewed-on: https://chromium-review.googlesource.com/1227861Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#592020}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b98184a9ff69..77304e28a65b git log b98184a9ff69..77304e28a65b --date=short --no-merges --format='%ad %ae %s' 2018-09-18 primiano@google.com Fix GCC build Created with: gclient setdep -r src/third_party/perfetto@77304e28a65b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia5ccef74d2cd4c62e2550cfea40ff4f867587c02 Reviewed-on: https://chromium-review.googlesource.com/1230317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592019}
-
Stephane Zermatten authored
With this change, the controller will start a script automatically, without showing a chip first, if: - there is only one runnable script - that script is flagged with autostart=true by the server - no script has ever run - no tap was recorded Bug: 806868 Change-Id: Ia940af3308679b3c3a95837931081168f57ca16e Reviewed-on: https://chromium-review.googlesource.com/1226596 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592018}
-
Ramin Halavati authored
WebappSplashScreenTest#testThemeColorWhenNotSpecified and WebappSplashScreenThemeColorTest#testThemeColorWhenSpecified are disabled as they are consistently failing on Android CFI. Bug: 885100 Change-Id: I802c20afae567bf19e7d77f9892795ee1bfd6741 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1230044Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#592017}
-
Friedrich Horschig authored
This CL addresses a misconception in the calculation of the accessory sheet height: The difference of navigation bars wasn't due to the SDK version but due to the fact, that all my Lollipop emulators had virtual soft keys. We already have a function that calculates reliable window bottom insets which can be used as sheet height. This is used now as preferred option. Bug: 883084 Change-Id: I9dc3f4c9438788ec165544e397fa81e67e401d98 Reviewed-on: https://chromium-review.googlesource.com/1228155Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#592016}
-
Mark Cogan authored
This CL moves the shared tab switcher interfaces -- that is, the protocols defined in tab_switcher.h and the tab_switcher_mode utility -- into ui/main, in preparation for the removal of ui/tab_switcher. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7f22b0df03f3c75ba911fd9ec83469120186257c Reviewed-on: https://chromium-review.googlesource.com/1230020 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592015}
-
Gauthier Ambard authored
This CL changes the way the SideSwipe is checking if the touch location is inside the toolbar frame or not by passing it in the window coordinates instead of in the gesture's view coordinates. This starts creating an issue as the toolbar frame is now contained in a container, changing its frame's origin. Bug: 883694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaf42b36ce01c47addd87ae71772abff605e75a1c Reviewed-on: https://chromium-review.googlesource.com/1224387 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592014}
-
Rune Lillesveen authored
There was a copy-paste error which cleared the invalidation root twice instead. Since both marking and doing the actual rebuild of the layout tree happens inside UpdateStyle(), we should never be in the situation where we have a rebuild root when dom changes happen, so the clearing should strictly not be necessary. Add a DCHECK to detect if this ever happens. Bug: 868810 Change-Id: Ibcc9ec21e7a094295833ee442bd723000013b01e Reviewed-on: https://chromium-review.googlesource.com/1230040Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592013}
-
Yi Su authored
Current CopyImage only copies the image data to pasteboard. Image's url should also be copied, so that user can paste it to text field. Bug: 883674 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I30c9bd1018a5a2e4564b9bc7a40d69be325a4235 Reviewed-on: https://chromium-review.googlesource.com/1228061 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592012}
-
Ingvar Stepanyan authored
- ES6 `class` members are non-enumerable, so `for-in` iterated over an empty list, not stubbing anything. - When `window.InspectorFrontendHost` was missing, it was unnecessarily set to a new object twice. - Stub error was shown each time command was invoked; changed to showing it once for reduced noise in logs and simpler implementation. Change-Id: Ib0083737873a373220b3a5e1c0ea18b10482bc6c Reviewed-on: https://chromium-review.googlesource.com/1068915Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com> Cr-Commit-Position: refs/heads/master@{#592011}
-
Manuel Rego Casasnovas authored
This is a recent change by the CSSWG: https://github.com/w3c/csswg-drafts/issues/3020 The spec text (https://drafts.csswg.org/css-grid/#static-position): "The static position of an absolutely-positioned child of a grid container is determined as if it were the sole grid item in a grid area whose edges coincide with the content edges of the grid container." The patch is just a simple change in LayoutGrid::PrepareChildForPositionedLayout() to use border and padding. BUG=884956 TEST=external/wpt/css/css-grid/abspos/absolute-positioning-grid-container-parent-001.html Change-Id: I01a77dfe41abcfac00c6d45f517c6d216aaa8ff7 Reviewed-on: https://chromium-review.googlesource.com/1229893 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#592010}
-
Manuel Rego Casasnovas authored
Change-Id: I08b7aa662fc3dd767de0104c7e5f5ca0ca77619b Reviewed-on: https://chromium-review.googlesource.com/1230041Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#592009}
-
Arthur Sonzogni authored
It's no longer useful following the launch of PlzNavigate. Bug: 756751, 789577 Change-Id: If342a766d03a832f6c333eccec970b4506faa847 Reviewed-on: https://chromium-review.googlesource.com/1230054Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592008}
-
Thomas Tangl authored
The string from the second bullet on the sync confirmation dialog is changed from "Personalized Google services like Google Pay" to "More personal Google services, like better page suggestions". TBR=jochen@chromium.org Bug: 884746 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If17dd4edb4273b63c5b431c68a0c15a38a4f840e Reviewed-on: https://chromium-review.googlesource.com/1230015Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#592007}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates iOS' OmahaService and its respective unittests away from URLFetcher. BUG=879774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I60339c7599c6174951056c5a8b867aa6df1438da Reviewed-on: https://chromium-review.googlesource.com/1227191Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#592006}
-
Piotr Kalinowski authored
Auth cache uses URL's origin as a key, and non-standard URLs don't have it, so it only results in an attempt to use an invalid key, trigerring a DCHECK on the way, too. This can happen if page uses a data URL as a source for an HTML5 video. Bug: 882842 Change-Id: I0a1861d27152d4d84f3a7692fd94af6222ca027c Reviewed-on: https://chromium-review.googlesource.com/1219607Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Piotr Kalinowski <pkalinowski@opera.com> Cr-Commit-Position: refs/heads/master@{#592005}
-
Philip Jägenstedt authored
PaymentResponse was recently made to inherit from EventTarget: https://chromium-review.googlesource.com/c/chromium/src/+/1206750 At the time the webexposed tests were disabled, but now reenbled: https://chromium-review.googlesource.com/c/chromium/src/+/1223149 That CL update global-interface-listing-expected.txt for the change, but WebViewLayoutTest also need updating now. TBR=timvolodine@chromium.org Bug: 667069, 861704, 883914 Change-Id: I33ac483d8ee11747405505e3dcf1b7a48fbe1dfa Reviewed-on: https://chromium-review.googlesource.com/1227128 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#592004}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4b83349ad294..45b9bc919502 git log 4b83349ad294..45b9bc919502 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 anthonyalridge@google.com Clickable stack to go to metric. Created with: gclient setdep -r src/third_party/catapult@45b9bc919502 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I75ed029fbb65a7b13532663a72915f04497a9c8d Reviewed-on: https://chromium-review.googlesource.com/1230313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592003}
-
James MacLean authored
Revert "Tentatively re-enable SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe." This reverts commit 2affd10c. Reason for revert: The test is continuing to flake, so turning it off again on Win. Original change's description: > Tentatively re-enable SitePerProcessHitTestBrowserTest.CursorUpdateReceivedFromCrossSiteIframe. > > This CL tests if > https://chromium-review.googlesource.com/c/chromium/src/+/1228293 > has any effect on the flakiness of this test. > > Bug: 882458 > Change-Id: I0bd0503bd223fd4694f9e106882fcd68efeda85d > Reviewed-on: https://chromium-review.googlesource.com/1228513 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591892} TBR=kenrb@chromium.org,wjmaclean@chromium.org Change-Id: I651fb628162ec2bf301782d5cc61ad4af043fde4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882458 Reviewed-on: https://chromium-review.googlesource.com/1230433Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#592002}
-