- 31 Oct, 2019 40 commits
-
-
Hitoshi Yoshida authored
ActivilyLoggerTest creates some GC objects like DOMWrapperWorld which may be related to the global environment. Without running a GC after the test, these objects are kept alive and thus some statistics can show wrong values in the next test. e.g. DOMWrapperWorld::NonMainWorldsExistInMainThread() Bug: 1018970 Change-Id: Ib692c6593b121f187b6d70fa05a109135701b864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890373Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711133}
-
Adam Rice authored
This reverts commit 3bce0223. Reason for revert: This is no longer needed in ToT because it has already been merged and released for M77. Original change's description: > Disable WebSocket connection throttling in the network service > > Permit any number of connect requests to be pending in the network > service. > > Note that per-server WebSocket connection serialisation is still > applied, so this doesn't permit denial-of-service attacks against > servers. > > BUG=1006243 > > Change-Id: I31a10ec3384f32aa34ff0380f22738271bee0160 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829629 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701043} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006243 Change-Id: I195e463ab05461c8246be372378671c9b53a1c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880999Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#711132}
-
Tim Song authored
This CL also adds unit tests for the collapse/expand behaviour for the message center. TEST=manual + new unit tests BUG=1019405 Change-Id: I1189549e41e6f11f2d513c4d041de6e5ac108caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888187 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711131}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d4996c3785c..f6276f9ca394 Created with: gclient setdep -r src-internal@f6276f9ca394 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Idac35285153659e16b45c6ed9058cb19c9287a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711130}
-
Doug Turner authored
Bug: None Change-Id: Ibd6eee35a6d06083464ff9e76af779bf1871499c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874720Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711129}
-
John Abd-El-Malek authored
This is more aligned with Android style guide. Change-Id: I503748a796e2e5934e92d6ec9c6963907debabbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890824 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711128}
-
Xianzhu Wang authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1873504, we can put tests directly under a virtual directory, no longer needing the extra level of directory. TBR=wangxianzhu@chromium.org Bug: 1014162 Change-Id: I6aad51c4c508a50d274d35acdf9112cc9d809330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892094Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711127}
-
Alice Boxhall authored
TBR=ftang@chromium.org Bug: 1020034 Change-Id: If72015dc9ed501aebc92689d63b52856cbfdc8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890397Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711126}
-
Henrique Nakashima authored
Leaving the public API of SharedPreferencesManager intact for now, changes are broad and I don't want to mix them with this CL. Bug: 1017800 Change-Id: I658afd16cf56a5436193d5d307cc38c0964b79a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888388Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711125}
-
David Tseng authored
Change-Id: I46b9842698c02d40f48919514ab84b7f719cb994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881815 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711124}
-
Yuchen Liu authored
Bug: 825041 Test: CQ Change-Id: I64bedf18614a6a2c17e004a372123156290065b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887739 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#711123}
-
Alice Boxhall authored
This reverts commit 1a90cb5c. Reason for revert: This seems to have caused a failure on MSan: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898122667520416480/+/steps/unit_tests/0/logs/Deterministic_failure:_DownloadProtectionServiceTest.LargeFileBlockedByPreference__status_CRASH_/0 Original change's description: > Preserve original Safe Browsing verdict for download deep scanning. > > In cases where deep scanning fails, we currently supply a SAFE verdict. > If the original verdict from Safe Browsing was UNCOMMON, we will > therefore downgrade the warning. This CL preserves the original verdict > and returns it in cases where deep scanning fails. It also adds a test > implementation of the BinaryUploadService, for easier testing of code > using uploads. > > Fixed: 1017921 > Change-Id: I444b301c3fe75ebbe0561bc6b201945242f09dc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887736 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711049} TBR=bdea@chromium.org,drubery@chromium.org Change-Id: I2464508513e6728a8519a141e22d2ff226233733 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890399Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 19c668ff. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" f701be68 "[css-pseudo] Restrict the properties allowed in ::marker" 96a711f0 "CSS: Update min-width and min-height parsing WPTs" c47a6f0b "Use a transformed bounding box when hit testing transformed elements" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ifffb45b1403daec1c269eea8dd6bacc44782d33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892271Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711121}
-
David Tseng authored
Bug: 1005524 Change-Id: I690a7881c79c02ed44bdd370f661a72e752fe735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887590Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711120}
-
Tommy Steimel authored
This CL changes updates the ChromeOS Media Notification to hide the grey rectangle that surrounds the dismiss button. It is replaced by a circular background colored the same as the notification background. Bug: 1012740 Change-Id: Id8d0fefb63dbf75d5b8efd95e96cbd1a41fa3a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888273Reviewed-by:
-
rbpotter authored
Change the way style module JS files are autogenerated so that Polymer CSS build will correctly replace mixins. This is necessary for mixins to be correctly handled in optimized Web UI pages. Bug: 965770 Change-Id: I1de91006c4b0828a6371ef525c066293691e0e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892093 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711118}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I3a0f911c35ef6838f63a83f20410048d1cae6c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892451Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711117}
-
Peter Kasting authored
Bug: 1003612 Change-Id: I1ad31927926264069d8196de2c87ea23364da952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887666 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#711116}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5bd8cb74a659..32913c128aec git log 5bd8cb74a659..32913c128aec --date=short --no-merges --format='%ad %ae %s' 2019-10-31 qingsi@webrtc.org Removes the flakiness in PeerConnectionUsageHistogramTest. Created with: gclient setdep -r src/third_party/webrtc@32913c128aec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I22135ea3a7acfdcc8c5b3aa89253c29786262bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711115}
-
Will Harris authored
Filter crashes due to code integrity failure into their own histogram BrowserRenderProcessHost.ChildCodeIntegrityFailures. This histogram can be monitored independently of the usual crash metrics, meaning any non-CIG regressions are not missed. BUG=750886 Change-Id: I6913ca894d21e5f798e82fe8e6f216b2c46c8ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888738Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711114}
-
Robin Lewis authored
Also adds minimum supported version of Chrome for GCPW. Bug: 907493 Change-Id: Ie4d0e050050c0f807ec1725bf223df2a11a1e164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881474 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#711113}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for media::Renderer using PendingReceiver and SelfOwnedReceiverRef. Bug: 955171 Change-Id: Ibbd108219a3f3eac175e4122376f1a78ed976aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886070Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711112}
-
Jon Mann authored
Previously the configRequiresPassphrase_ value wasn't always updating when the security type changed, this resulted in the password field getting shown/hidden at incorrect times. Bug: 1019495 Change-Id: I127ad6bf57595afc1a244455a14386c00585eab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889470 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711111}
-
Sven Zheng authored
When tests run in parrallel, the dialog get randomly closed with reason lost focus. For bubble dialog, when they get deactivate they will close themselves: https://cs.chromium.org/chromium/src/ui/views/bubble/bubble_dialog_delegate_view.cc?l=237&rcl=c32f919eb9638bd8b1030a460c016c6b75a1c286 There's also test trying to tackle the problem: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc?l=345&rcl=2e48cb8072cdcf0a4da0c3e04e196a100838ebcc This cl will fix it by block close the dialog temporarily. Why it wasn't an issue when pixel test not enabled? It's because there's no wait/async in ShowAndVerifyUi(). But with pixeltest, there are several async calls and wait for callback, which give the browser chance to close the dialog. Eg the async in snapshot: https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_aura.cc?l=51&rcl=07fe9cc024d6c20514423412c9c3aead11d9767c When running in 36 launcher jobs, this issue contributes ~2% flakiness. I've also observed that in very rare cases, dialog can get closed with ESC pressed. But I didn't figure out which test mis-sending the ESC key press to the system. So the block close will block all reasons instead of lost focus only. Bug: 958242 Change-Id: I51037dd7070fc4c35195d0e07c408763906dcdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889949 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711110}
-
John Lee authored
- Track thumbnails only if they are currently in view or are just a standard finger swipe away. - Do not track thumbnails for pinned tabs. - Do not track thumbnails when the tab strip is closed. Note that this CL does not implement actually untracking thumbnails. It merely calls the method in the C++ side that will eventually do it. Bug: 1015132 Change-Id: I86f7a8ea284395fc97dfed60fbb0452a0dfaa8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885504 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a25f3386ca1a..69a6c2e64544 git log a25f3386ca1a..69a6c2e64544 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 pprabhu@chromium.org Stop running irrelevant pre-cq on LCQ Created with: gclient setdep -r src/third_party/chromite@69a6c2e64544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2832dbc1c24a1639a10f55e6156793b40ad86a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892099Reviewed-by:
-
Li, Hao authored
- Align VideoFrameMetadata structure following https://github.com/dalecurtis/video-animation-frame/blob/master/explainer.md - Rename WebGLVideoFrameInfo to WebGLVideoFrameMetadata - Add the definition for optional attributes Bug: 776222 Change-Id: Iee967cce45de0423e9ba327cdd462587e52aec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879998Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Hao Li <hao.x.li@intel.com> Cr-Commit-Position: refs/heads/master@{#711107}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I588967029bbfd17df5932ae8b7e8677bf64676bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892251Reviewed-by:
-
Shengsong Tan authored
autotest JS Some Tast Tests need to know the statement of ARC window caption, such as whether caption buttons enable or visible. But currently there isn't any function to get these information. This CL add caption information of arc window in GetAppWindowList. Bug: b/142446508 Bug: b/141978622 Test: tast -verbose run my_crbook arc.CompanionLibrary Change-Id: Ib9c0ebde1ec2304fd5cd9d77523207b64deb7767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883453 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711105}
-
Dirk Pranke authored
Two tests appear to have started becoming flak(ier) after r710862. TBR=aboxhall@chromium.org Bug: 10200183 Change-Id: I075bee4409114a46db3833f5c2cc5fef0ff72e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892292Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711104}
-
Michael Spang authored
This reverts commit 43dc520f. Reason for revert: Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1891457 Original change's description: > Revert "X11Window: Avoid size hack for tests" > > This reverts commit da320a9f. > > Reason for revert: Unfortunately this seems to be causing a CI failure: > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898137098615237856/+/steps/aura_unittests/0/logs/Deterministic_failure:_WindowTreeHostTest.DPIWindowSize__status_FAILURE_/0 > > Original change's description: > > X11Window: Avoid size hack for tests > > > > The default configuration of TestScreen is to create one display and one > > WindowTreeHost with the same size. > > > > X11 is now incompatible with this requirement as of b14e13fd ("Reland > > "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full""). > > > > Several aura tests are only passing currently due to another bug in > > DisplayList::UpdateDisplay, which prevents X11Window from > > seeing the current display size and enforcing the constraint. > > > > Other tests only work because TestScreen resizes the display to match > > the WindowTreeHost /after/ X11Window deletes the last row and column. > > i.e., X11Window tries to adjust the size to not match the display, > > and then TestScreen re-adjusts the display to match the window. This > > behavior is not convergent and causes small changes in initialization > > order to affect the dimensions of test windows. > > > > This hack should likely be removed altogether and the bug it's addressing > > fixed another way, but for now disable it in the test harness because it > > is blocking other changes such as a fix for the UpdateDisplay bug noted > > above. > > > > Bug: 1019015 > > > > Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294 > > Commit-Queue: Michael Spang <spang@chromium.org> > > Reviewed-by: Michael Spang <spang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710955} > > TBR=sky@chromium.org,spang@chromium.org,thomasanderson@chromium.org,msisov@igalia.com > > Change-Id: I1177d258e4957dc1f216e18c6df95067f7cbb0ed > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1019015 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890458 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711094} TBR=sky@chromium.org,spang@chromium.org,aboxhall@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I2caa075079f5f260c007cc553a94a77ab7bcd14e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892059Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711103}
-
Jimmy Gong authored
- Fixes a bug where some large error text would appear misplaced in both add and edit printer dialog. - Update browsertest to reflect this change. Bug: 1019432 Test: browsertests and end to end Change-Id: I24c2c96f4cf68c647a16d8cb69580cdf66ae43f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888950 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#711102}
-
rbpotter authored
Patch Polymer so that whitespace is always removed, since the legacyOptimizations flag does not seem to have this effect in Polymer 3. Bug: 965770 Change-Id: I050522e98cf3b8d606b964cd5def734e7cb0d16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891462 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
kylechar authored
Add a new scoped_refptr constructor for creating from nullptr. This is to better understand how many callers rely on the scoped_refptr(T*) constructor and what would need to be fixed for it to be made explicit. Also fix a few places where NULL is still being implicitly converted to scoped_refptr<T>. This causes a compilation error with the new constructor as NULL is defined as 0. TBR=marq@chromium.org Bug: 589048 Change-Id: I117703b4db3472e191bf64629ec7ac7966ba10d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876908 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#711100}
-
Hwanseung Lee authored
text_direction_ is not used anymore since the patch[1] merged. so get rid of text_direction_ variable. [1] https://codereview.chromium.org/1151263002 Bug: None Change-Id: I3745bed0c6ccb911e07d46d9dd7690d0e081b470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891815Reviewed-by:
-
Glen Robertson authored
Moves LoadWebAppAndCheckInstallability from being the only non-virtual method defined in the parent InstallManager class to exist alongside other similar methods in web_app_install_manager child class. This also allows it to use the web_app_install_task to run the async parts and use some shared machinery. This is a step towards unifying and de-duplicating various web app loading, checking, and installing steps. In prep for changing behaviour in http://crrev.com/c/1847609 Bug: 1007860 Change-Id: Ib18356719fc0f321cd6bd100d2ce6ec0a450ee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873817 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711098}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6d7ff710e36..6d4996c3785c Created with: gclient setdep -r src-internal@6d4996c3785c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ieb433af6461d33f2453b09bec0bab6a36949efe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892097Reviewed-by:
-
Vitaly Buka authored
This just enables the same flag as crrev.com/c/1795632 The following are still disabled: Windows: blocked by llvm roll, which will make clang-cl recognize -ftrivial-auto-var-init. Android: android-kitkat-arm-rel consistently fails a test. Clang shipped with XCode can be too old to support this flag. Bug: 977230 Change-Id: I622ba8fea93ed65cf8cb01fab26df0fb5f26f12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838383Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#711096}
-
Ben Pastene authored
A few of them have been consistently timing out. Looks like it's natural growth, so this increases their test shards. Note that linux-chromeos-dbg is CI-only, so the increase in bot usage should be minimal. Bug: 985588 Change-Id: I959507e5ba6892e56680bea707d5fd50b05850e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892071Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#711095}
-
Alice Boxhall authored
This reverts commit da320a9f. Reason for revert: Unfortunately this seems to be causing a CI failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898137098615237856/+/steps/aura_unittests/0/logs/Deterministic_failure:_WindowTreeHostTest.DPIWindowSize__status_FAILURE_/0 Original change's description: > X11Window: Avoid size hack for tests > > The default configuration of TestScreen is to create one display and one > WindowTreeHost with the same size. > > X11 is now incompatible with this requirement as of b14e13fd ("Reland > "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full""). > > Several aura tests are only passing currently due to another bug in > DisplayList::UpdateDisplay, which prevents X11Window from > seeing the current display size and enforcing the constraint. > > Other tests only work because TestScreen resizes the display to match > the WindowTreeHost /after/ X11Window deletes the last row and column. > i.e., X11Window tries to adjust the size to not match the display, > and then TestScreen re-adjusts the display to match the window. This > behavior is not convergent and causes small changes in initialization > order to affect the dimensions of test windows. > > This hack should likely be removed altogether and the bug it's addressing > fixed another way, but for now disable it in the test harness because it > is blocking other changes such as a fix for the UpdateDisplay bug noted > above. > > Bug: 1019015 > > Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710955} TBR=sky@chromium.org,spang@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I1177d258e4957dc1f216e18c6df95067f7cbb0ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890458Reviewed-by:
-
