GitLab

Bug: 990590
Change-Id: I3d5ac1e6317499f390ca1c81dc2f936d3f4a8dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737097Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684228}

Finch experiments have shown that most metrics have not diminished
because of the change from Sfntly to HarfBuzz. Instead, certain metrics,
like PrintPreview.PrintDocumentSize.HTML, have observed promising drops.

CL to define feature flag - [1]
CL to enable HarfBuzz Subsetter - [2]
CL to define finch config - [3]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1649070
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1659130
[3] cl/255041822

Bug: 931719
Change-Id: I7f656f71afe7414376e589453ce13832622274bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731731Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684227}

BUG=None
TEST=Compile.

Change-Id: I7db4fee7308aa5b90b5456bb68a2a7aee05497c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737067Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684226}

This is part of EG1 to EG2 migration, which involves moving
EarlGrey code from app-side helpers into test code.
EarlGrey2 has multiprocess architecture,
where Chrome Test and Chrome App are separate processes

Change-Id: I2468c4ff67829084ffc563822b8d53997367b9bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733036Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684225}

We'll eventually need to access this from the network stack in order to
decide whether to block requests. This patch just moves the value from
its existing home in Blink to a new abode in the network service. It's
mostly the result of the following command:

```
git gs IPAddressSpace -l | xargs -L1 sed -i '' \
  -e 's/third_party\/blink\/public\/mojom\/net\/ip_/services\/network\/public\/mojom\/ip_/g' \
  -e 's/\([ \(<{]\)mojom::IPAddressSpace/\1network::mojom::IPAddressSpace/g' \
  -e 's/blink::mojom::IPAddressSpace/network::mojom::IPAddressSpace/g' \
  -e 's/blink.mojom.IPAddressSpace/network.mojom.IPAddressSpace/g'
```

Reland of [1] which was reverted in [2].

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1718329
[2]: https://chromium-review.googlesource.com/c/chromium/src/+/1724149

TBR=kinuko@chromium.org

Bug: 986744
Change-Id: I8b14d528a6fe8746bcd6112ff5692e33215d3bf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735376
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684224}

This reverts commit 27296030.

Reason for revert: suspect this change caused video test fails on
the chromeos-kevin-rel bot.

https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/13464

Failing tests.

video.WebRTCDecodeAccelUsedVP8
video.PlayDecodeAccelUsedVP8
video.PlayDecodeAccelUsedVP9
video.PlayDecodeAccelUsedMSEVP8



Original change's description:
> media/mojo: Remove fallback of ChromeOS VideoDecoder.
> 
> We plan to enable new VideoDecoder implementation per board, instead
> of enable all boards at the same time. We won't enable boards that are
> not supported yet.
> This CL remove the fallback video decoder. Then we could catch any
> initialize or runtime failure of new VideoDecoder implementation.
> 
> BUG=chromium:984482
> TEST=open crosvideo.appspot.com on Kevin and Eve
> 
> Change-Id: I03026057b317ffde5436d8eb53c579ed18210bd8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734833
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684211}

TBR=sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org

Change-Id: Iec202f6c834aee136218c9b8964b77fc24874892
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:984482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736870Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684223}

MultiprocessTestClientLauncher.launchClient() is not supposed to be
called on the main thread; it causes hangs on older versions of
Android. assert that this invariant is true instead of failing by time
out.

Bug: 973167
Change-Id: I2fe475861d3d7331707820374a68198da4d34d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726640Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684222}

This reverts commit 3a99193d.

Reason for revert: 
This was already reverted at [1] and relanded with a fix at [2].
[1] https://chromium.googlesource.com/chromium/src/+/5bd3e578821d1daacdb92dd5180255a771bf6d6c
[2] https://chromium.googlesource.com/chromium/src/+/4f518dc059bb7e0167335a3bb01b47d01bd0da80

Original change's description:
> Revert "BundledExchangesParser: Update the bundle format [1/2]"
> 
> This reverts commit d8c863a6.
> 
> Reason for revert: 
> https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/24310
> 
> 
> https://luci-milo.appspot.com/p/chromium/builders/ci/Deterministic%20Linux/24310
> 
> Compile failure, List of errors:
> 
> ../../mojo/public/cpp/bindings/struct_ptr.h:56:18: error: no matching constructor for initialization of 'mojo::StructPtr<data_decoder::mojom::BundleMetadataParseError>::Struct' (aka 'data_decoder::mojom::BundleMetadataParseError')
> 
> 
> Original change's description:
> > BundledExchangesParser: Update the bundle format [1/2]
> > 
> > This updates BundledExchangesParser to parse the new bundle format [1].
> > 
> > Changes:
> > - Updated the magic header bytes [2]
> > - Version field is added (we use implementation-specific version string
> >   "b1\0\0", which matches gen-bundle's output [3])
> > - Fallback URL (== Primary URL) field is added
> > - ParseMetadata() returns error type ("format error" or "version error")
> >   and fallback URL if available
> > - Updated spec ref comments
> > 
> > The structure change of the index section is not reflected yet. It will
> > be updated in the next CL.
> > 
> > The test bundle file (hello.wbn) is generated with gen-bundle of
> > github.com/WICG/webpackage revision a3cef2c, which supports the new
> > bundle format except for the new index section structure.
> > 
> > [1] https://github.com/WICG/webpackage/pull/450
> > [2] https://github.com/WICG/webpackage/pull/454
> > [3] https://github.com/WICG/webpackage/pull/458
> > 
> > Bug: 969596
> > Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#684200}
> 
> TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org
> 
> Change-Id: I0e4c550179c4433022646f8ecc27cbdf4983ce87
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 969596
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738036
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684219}

TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,noel@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org

Change-Id: I27423f80338576b35506bb8f7e6010fc4c2d2ec7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 969596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735802Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684221}

android.nfc.tech.Ndef.getNdefMessage() may return null when the tag is
formatted but is empty, we need to handle the case well.
See
https://developer.android.com/reference/android/nfc/tech/Ndef.html#getNdefMessage().

BUG=520391

Change-Id: I49cdf40978ad837546dcb050ce8e7d2cac4662ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736167
Auto-Submit: Leon Han <leon.han@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#684220}

This reverts commit d8c863a6.

Reason for revert: 
https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/Deterministic%20Linux/builds/24310


https://luci-milo.appspot.com/p/chromium/builders/ci/Deterministic%20Linux/24310

Compile failure, List of errors:

../../mojo/public/cpp/bindings/struct_ptr.h:56:18: error: no matching constructor for initialization of 'mojo::StructPtr<data_decoder::mojom::BundleMetadataParseError>::Struct' (aka 'data_decoder::mojom::BundleMetadataParseError')


Original change's description:
> BundledExchangesParser: Update the bundle format [1/2]
> 
> This updates BundledExchangesParser to parse the new bundle format [1].
> 
> Changes:
> - Updated the magic header bytes [2]
> - Version field is added (we use implementation-specific version string
>   "b1\0\0", which matches gen-bundle's output [3])
> - Fallback URL (== Primary URL) field is added
> - ParseMetadata() returns error type ("format error" or "version error")
>   and fallback URL if available
> - Updated spec ref comments
> 
> The structure change of the index section is not reflected yet. It will
> be updated in the next CL.
> 
> The test bundle file (hello.wbn) is generated with gen-bundle of
> github.com/WICG/webpackage revision a3cef2c, which supports the new
> bundle format except for the new index section structure.
> 
> [1] https://github.com/WICG/webpackage/pull/450
> [2] https://github.com/WICG/webpackage/pull/454
> [3] https://github.com/WICG/webpackage/pull/458
> 
> Bug: 969596
> Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684200}

TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org

Change-Id: I0e4c550179c4433022646f8ecc27cbdf4983ce87
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 969596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738036Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684219}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org

Change-Id: I70ec64712d34500f3dc5d19c4892ac54a106d7de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738008Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684218}

When a navigation occurs, all OverlayRequests are cancelled, which
triggers the dismissal of any presented overlay UI.  The request queue
is empty at this point, so if the newly-loaded page attempts to present
a dialog on load, it's possible that OverlayPresenterImpl will try to
show this dialog before the cancelled dialog's UI is finished being
dismissed.  This CL adds a check to prevent attempting to present if
already presenting.  If a cancelled overlay is being dismissed, the new
request's UI will be presented upon the completion of the dismissal.

Bug: 990966
Change-Id: Iee7e735b53c9844666d6ea7cc48168513d768f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736182Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684217}

This is a reland of d8c863a6

PS1 is the original CL, PS2 is the fix for the new callsite of
BundleMetadataParseError::New() introduced by https://crrev.com/c/1732518.

Original change's description:
> BundledExchangesParser: Update the bundle format [1/2]
>
> This updates BundledExchangesParser to parse the new bundle format [1].
>
> Changes:
> - Updated the magic header bytes [2]
> - Version field is added (we use implementation-specific version string
>   "b1\0\0", which matches gen-bundle's output [3])
> - Fallback URL (== Primary URL) field is added
> - ParseMetadata() returns error type ("format error" or "version error")
>   and fallback URL if available
> - Updated spec ref comments
>
> The structure change of the index section is not reflected yet. It will
> be updated in the next CL.
>
> The test bundle file (hello.wbn) is generated with gen-bundle of
> github.com/WICG/webpackage revision a3cef2c, which supports the new
> bundle format except for the new index section structure.
>
> [1] https://github.com/WICG/webpackage/pull/450
> [2] https://github.com/WICG/webpackage/pull/454
> [3] https://github.com/WICG/webpackage/pull/458
>
> Bug: 969596
> Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684200}

Bug: 969596
Change-Id: I1d68a3cb2975fc7856449180517f67131d7b7817
Tbr: toyoshim@chromium.org
Tbr: kinuko@chromium.org
Tbr: rsesek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736907Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684216}

Instead, give it as an argument  of
mojom.WebSocketHandshakeClient.OnConnectionEstablished.

This is a follow up CL for
https://chromium-review.googlesource.com/c/chromium/src/+/1728917.
Passing the mojo::InterfaceRequest<WebSocketClient> at
OnConnectionEstablished is less error prone because

 1) It is unable to bind the implementation before that, and
 2) It is now clear that we should detect connection errors on
    |handshake_client| until the connection is established, and
    |client| after that.

Bug: 989406, 967524
Change-Id: Id9a7f184b678303d5b0ef8ad3b8637056a495933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728534
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#684215}

MessageLoopForIO will go away soon use ScopedTaskEnvironment instead.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=yhirano@chromium.org

Change-Id: I1d9a43a8101f9fdf6422532a77a3c3df288dadd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733612
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684214}

Used 'switch' statement instead of sequence of 'if' blocks.

Used destructuring assignments to shorten code.

Change-Id: I18d30b9d1a7db1eebac54a00c63535afc8b4c24b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731834
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684213}

https://chromium.googlesource.com/angle/angle.git/+log/7c8928d0a054..bf176a0d6db9

git log 7c8928d0a054..bf176a0d6db9 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 timvp@google.com Vulkan: Suppress KHR-GLES2 ASTC 3D Texture Tests

Created with:
  gclient setdep -r src/third_party/angle@bf176a0d6db9

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: I7742af3a90c08fd3f08ae515fa07b5cfce74b8b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684212}

We plan to enable new VideoDecoder implementation per board, instead
of enable all boards at the same time. We won't enable boards that are
not supported yet.
This CL remove the fallback video decoder. Then we could catch any
initialize or runtime failure of new VideoDecoder implementation.

BUG=chromium:984482
TEST=open crosvideo.appspot.com on Kevin and Eve

Change-Id: I03026057b317ffde5436d8eb53c579ed18210bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734833Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684211}

The required updater files are archived as an uncompressed LZMA archive
(similar to a tar file), which then is compressed using LZMA, and the
result of the compression is inserted as a binary resource into the
updater installer file.

updater.7z -> updater.packed.7z -> UpdaterSetup.exe

At the moment, the updater files are: updater.exe and uninstall.cmd.
However, in the debug component build, some other run time dependencies
are needed. The dependencies are collected at build time and archived
with the updater files.

The vast majority of this code has been lifted from
//chrome/installer/mini_installer. It is possible to further make the
code a shared library between the installer and updater projects.
This would be work for the future.


Bug: 989772
Change-Id: I9b84e8d1f4475b9977d5b7fd78f37272dd7c6212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730309
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684210}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/921f6a175146..36756e459041

git log 921f6a175146..36756e459041 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-08-05 vapier@chromium.org repo: pull in v1.13.4 changes

Created with:
  gclient setdep -r src/third_party/depot_tools@36756e459041

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Bug: None
Change-Id: I5889ff83f4ecb023cb8c8bf0ee7c5f52a527496b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737740Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684209}

This is a reland of a42acfa3

PS1 is the original CL, PS3 is the trivial fix of deleting a
stale #include.

Original change's description:
> Move file_util service off Service Manager
>
> Eliminates all Service Manager dependencies from
> //chrome/services/file_util/.
>
> Adds a LaunchFileUtilService() call to //chrome/browser/, which launches
> a dedicated service process for file utilities that can be controlled by
> the returned Mojo remote.
>
> Adapts client library call sites to use LaunchFileUtilService instead of
> a Connector.
>
> Bug: 977637
> Change-Id: Ie3e3a583fd00a6d9f77137d0febbccf6a086ff0f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732679
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#684140}

NOPRESUBMIT=true

Bug: 977637
Change-Id: If90c7cbbef6c144843a7964e5db5c5f8357f26bd
Tbr: sky@chromium.org
Tbr: dcheng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736115
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#684208}

This reverts commit d8c863a6.

Reason for revert: broke build, example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8905916412276160432/+/steps/compile__with_patch_/0/stdout

Original change's description:
> BundledExchangesParser: Update the bundle format [1/2]
> 
> This updates BundledExchangesParser to parse the new bundle format [1].
> 
> Changes:
> - Updated the magic header bytes [2]
> - Version field is added (we use implementation-specific version string
>   "b1\0\0", which matches gen-bundle's output [3])
> - Fallback URL (== Primary URL) field is added
> - ParseMetadata() returns error type ("format error" or "version error")
>   and fallback URL if available
> - Updated spec ref comments
> 
> The structure change of the index section is not reflected yet. It will
> be updated in the next CL.
> 
> The test bundle file (hello.wbn) is generated with gen-bundle of
> github.com/WICG/webpackage revision a3cef2c, which supports the new
> bundle format except for the new index section structure.
> 
> [1] https://github.com/WICG/webpackage/pull/450
> [2] https://github.com/WICG/webpackage/pull/454
> [3] https://github.com/WICG/webpackage/pull/458
> 
> Bug: 969596
> Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684200}

TBR=horo@chromium.org,kinuko@chromium.org,toyoshim@chromium.org,ksakamoto@chromium.org,rsesek@chromium.org

Change-Id: Ifce2b07c15a57a2030887cbfaad5853cbc5af992
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 969596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737883Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684207}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8be476e7a4e0..92d36fb5ab54

git log 8be476e7a4e0..92d36fb5ab54 --date=short --no-merges --format='%ad %ae %s'
2019-08-05 eashanbhatt@google.com device_unittest: Add device_unittest executable
2019-08-05 bhthompson@google.com Disable unittests on branch pre flight builders

Created with:
  gclient setdep -r src/third_party/chromite@92d36fb5ab54

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I900561a42dfe72c3011b76f87305875e7727290f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737734Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684206}

Updates the
1) Removes the Up/Down arrow and the divider line (issue 961458) for the new layout.
2) Increases the space between the Close and Open-in-tab icons (Issue 961469)
3) Adds a new class OverlayPanelRepaddingTextView for a text view that has
adjustable padding at the end of the text to allow the text width to shrink to
accommodate the multiple icons when the Bar is expanded.
4) Does some sytle/dimen cleanup to make Overlay Panel and PT separate from
Contextual Search and fix a text spacing problem with long titles in PT.

NOTE that the new layout still needs changes: it has a grab bar that intrudes
into the text area. We have a separate bug to move the grab bar up and increase
the overall bar height and round the corners (issue 961454).

BUG=961458, 961469

Change-Id: I832f71e3526fe05759f8512842cb9b4e64becdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606598
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684205}

DomIsAmbiguous: This metric is false only at most 0.476% over the last 1 year.
MaxNodesExceededInFrame: This metric is true only at most %0.342 over the last 1 year.

R=lpz

Bug: 975258
Change-Id: Ic804a93f8323dda441ad1c3ffcde5c499b19fbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721557
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684204}

Bug: 989693
Change-Id: I374adfcba8920f50700da58027fe6c4a98ec19b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737869Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684203}

As discussed in the accessibility section of crbug.com/973982, the PIN
dialog needs to announce errors to screen readers. This change uses an
IronA11yAnnouncer to speak the errors in the PIN dialog when they occur.

BUG=990992

Change-Id: I9e11f994ea90d280c16cc931ef533dbe014b90e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735517Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684202}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f399ecdef769..27f295ee6c4f


Created with:
  gclient setdep -r src-internal@27f295ee6c4f

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:988587,chromium:None,chromium:None,chromium:None
Change-Id: I240bf5f6f0c0987ee050b95c905d3c47ad32b1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737729Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684201}

This updates BundledExchangesParser to parse the new bundle format [1].

Changes:
- Updated the magic header bytes [2]
- Version field is added (we use implementation-specific version string
  "b1\0\0", which matches gen-bundle's output [3])
- Fallback URL (== Primary URL) field is added
- ParseMetadata() returns error type ("format error" or "version error")
  and fallback URL if available
- Updated spec ref comments

The structure change of the index section is not reflected yet. It will
be updated in the next CL.

The test bundle file (hello.wbn) is generated with gen-bundle of
github.com/WICG/webpackage revision a3cef2c, which supports the new
bundle format except for the new index section structure.

[1] https://github.com/WICG/webpackage/pull/450
[2] https://github.com/WICG/webpackage/pull/454
[3] https://github.com/WICG/webpackage/pull/458

Bug: 969596
Change-Id: I95744ed00fdd09d369bb8648d1cdf62ca181d0dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715487Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684200}

Server side gcl http://google3/googledata/googleclient/chrome/finch/gcl_studies/AutofillSaveCardBubbleStringExperiment.gcl

Bug: 961082
Change-Id: Ibc0e489839643a19d0b77345f539dc2289871a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728041Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684199}

Bug: internal 135280530
Change-Id: I611e61735b4537e5db330cb6c78fe05fcb193170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706786
Commit-Queue: Jenny Wong <jyw@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684198}

Currently PDFiumEngine can only generate a single-view layout for
documents.

This CL adds DocumentLayout::GetTwoUpViewLayout() which takes a vector
of pages and returns the pages formatted for two-up view, as well as
updates the size of the layout. This helper function makes the two-up
view layout testable.

This CL also adds PDFiumEngine::LoadPagesInTwoUpView() which calls
DocumentLayout::GetTwoUpViewLayout() to format pages in two-up view
and appends them to |pages_|. This allows PDFiumEngine to render
documents in two-up view.

Bug: 51472
Change-Id: I6b65210f32efc205376d53abaeaa0c6eab84ac2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733737
Commit-Queue: Jeremy Chinsen <chinsenj@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684197}

We're still assessing the impact of the Chrome OS settings split,
which changes page zoom and display zoom behavior on some system UI
surfaces.

Bug: 988754, 988803
Change-Id: I240f1a91d8dcb9175289d93016acec3ac67dfd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731779
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684196}

This CL moves static input from FindNotificationsToShow to the
constructor.

This can help to improve testing and make it easier to add more
features in the future.

Bug: 963304
Change-Id: I0931c72cbcb59bed1506a48c41974eee7435ab77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732478
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684195}

The */interfaces and */mojo directories paths were changed to
*/mojom recently.
This CL updates mojo paths in accordance with that changes and
fixes the wrong path of wallpaper.mojom.

Bug: 990423
Change-Id: I8f9415f161b2fb82765ce7f9294d39bf55b1774c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734174Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#684194}

Now that DocumentLayout exists, move the constants used for document
layout over. Reduce the number of constants to remove redundancies
and update users of the constants to compensate.

After this, it may make sense to move some users of those constants
from PDFiumEngine to DocumentLayout as well.

Change-Id: I8b5e5f0a83b5c0b1448f5f14f86a4df100e73f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733850Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684193}

This behavior follows the spec,
https://drafts.csswg.org/css-contain/#containment-size,
as the statement below.

'Replaced elements must be treated
as having an intrinsic width and height of 0.'

For this behavior, when 'contain: size' is specified,
LayoutReplaced::IntrinsicSize returns zero size
instead of the intrinsic size it actually has.

Before this CL,
|LayoutReplaced::ComputeIntrinsicSizingInfoForReplacedContent|
did early return with "FloatSize()",
but |LayoutReplaced::ComputeReplacedLogicalWidth| has *if statement*
for specified and intrinsic css size,
so *that* early return couldn't be reached.

Addition to it, ComputeIntrinsicSizeFoo uses
|LayoutReplaced::IntrinsicSize| essentially,
and it returned non-zero size and that value was used before this CL.

Bug: 955163
Change-Id: If0309ae5f1adb2e3026ff92bfde2ffb07ba73582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703540Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Joonghun Park <pjh0718@gmail.com>
Cr-Commit-Position: refs/heads/master@{#684192}

Use enum class instead of enum for MaximumFlexSizeRule
enum class is more type safety.

Bug: 940736
Change-Id: I661e67465a1f38e78b336f93df97cb09f1d36f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735447Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#684191}

This reverts commit 8e5eba11.

Reason for revert: This CL is causing the linux-perf-builder to
consistently fail. Here is the link to the first failure
https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/98727.
This CL is in the blame list. 

Original change's description:
> Navi: Remove usage of 'Onboarding' most places in welcome code.
> 
> Bug: 986979
> Change-Id: I19a775d8d10be2792bed68f67d29219ee0ca85d2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728060
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684175}

TBR=sky@chromium.org,hcarmona@chromium.org

Change-Id: I696cbb2c2d1013006a55e73c263abc5a72b183ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986979
Bug: chromium:991026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737812Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#684190}

Added AutotestPrivateGetShelfItemsFunction to the autotestPrivate api.
Made required changes to autotest_private.idl to support ShelfItems as a
return type to JavaScript. Added a test case to AutotestPrivate to
confirm the shelf item is returned properly. Updated HistogramValue enum
for extensions functions with new item.

Test: locally on eve and browser_tests --gtest_filter="AutotestPrivateApiTest.AutotestPrivate"
Bug: 989231
Change-Id: Ic3dead8c31585fcd6cf6a799d1306fabb11f1552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733866
Commit-Queue: Brendan Hansknecht <bhansknecht@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684189}