- 21 Jul, 2020 40 commits
-
-
Evan Stade authored
This reverts commit eb04b682. Reason for revert: lint fix is in ps2 Original change's description: > Revert "Refactor DisplayCutoutController to prepare for componentization." > > This reverts commit eb6596e7. > > Reason for revert: Suspected to have broken compile on Android: > https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13404? > > Original change's description: > > Refactor DisplayCutoutController to prepare for componentization. > > > > DisplayCutoutController is split into DisplayCutoutController > > (destined for //components) and DisplayCutoutTabHelper (which stays > > in //chrome). Relocation/reuse will occur in a follow up CL. > > > > TBR=dtrainor@chromium.org > > Bug: 1095714 > > > > Change-Id: Ie119069ae4756baf73acc23d655665fce1d4c035 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296888 > > Commit-Queue: Evan Stade <estade@chromium.org> > > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790402} > > TBR=dtrainor@chromium.org,estade@chromium.org,beccahughes@chromium.org > > Change-Id: I9821d88e9e06163aae93800ae84ed21fb32ac180 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1095714 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310131 > Reviewed-by: Katie Dektar <katie@chromium.org> > Commit-Queue: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790440} TBR=dtrainor@chromium.org,estade@chromium.org,beccahughes@chromium.org,katie@chromium.org Bug: 1095714 Change-Id: I19ef0731684caf927be643983c5d7161dac9de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310834Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#790568}
-
John Abd-El-Malek authored
It didn't really need it; it was using it as a hint to know when it can be deleted when the frame goes away. A simpler method is to delete itself when it has no more receivers, if it's used in that mode. In the other mode where it's strongly owned, ownership remains the same. Bug: 1072817 Change-Id: I9d7f86b38650093df1c7d53964c3e6123961a16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306013 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790567}
-
Tommy C. Li authored
When the section headers are hidden or shown by a user, currently, screen readers give no indication that anything has changed. This CL fixes that and adds two new explicit announcements: - "Related to recent searches" section shown - "Related to recent searches" section hidden They are announced when the user shows or hides a section. It also fixes a bug in OmniboxPopupContentsView that caused some weird reentrant-like behavior, where updating the popup bounds would cause it to call UpdatePopupAppearance again. This bug suppressed the announcements, so this is needed too. Bug: 1099790 Change-Id: I96d847bc304d91a37ac306e2d9a27438d68856e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291234Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#790566}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df76b72e..f6d3a035 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie84f8af10961a3b389cec4cbc2cdd7151ff6af03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310155Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790565}
-
adamta authored
Detects when the phone's theme changes from light to dark theme (or vice versa) and updates the feed VC with the new theme. Bug: 1085419, 1107843, 1107847 Change-Id: Ibd8a8243adae3e5cafec405b6c6d310bf2d156a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303312 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#790564}
-
Joel Hockey authored
See crbug.com/1106284#c1 for screen shots. If a PWA is showing the download shelf when it navigates away and the theme changes, we must notify that the theme has changed in order to redraw the download shelf correctly. This is required for all PWAs, not just those with tab strips. Bug: 1106284 Change-Id: I43a18cb578ee9ef8870a7bc602b373b16c3c52a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306492 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790563}
-
Josh Nohle authored
Support move semantics needed for expiration scheduler instances in fake scheduler factory. Also, only allow fake scheduler callback to be invoked if scheduler is running. Note: I switch to std::map because I couldn't get base::flat_map to cooperate with move semantics. Bug: b/154864199 Change-Id: Ieef6474e9b1c8733dcb741a34f0ce3981b25fe46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309799 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#790562}
-
Mila Green authored
Updater: Fix ASAN test failure. Reland "Updater: AppWake starts the server instead of doing an update check." This is a reland of 4d324410 Original change's description: > Updater: AppWake starts the server instead of doing an update check. > > Bug: 1105589 > > Change-Id: I6d7e8b0b7858a4f1a538684758644f134318c0a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298045 > Commit-Queue: Mila Green <milagreen@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790139} Bug: 1105589 Change-Id: I7946629e862fbd9d3d42113de16f194be7a56df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309225Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790561}
-
James Long authored
Previously, the users of the graph visualization component would need to ping it whenever there was a data update. Now, the users should supply as props the properties of pageModel that the graph should be reactive to. Since the page is now fully reactive, the "update" buttons for the inbound/outbound components have been removed. The goal of this is to make it easier to add UI components that interface with the visualization component. Bug: 1106107 Change-Id: I0578ad655fc6d13d7cc9cb7e444920846e02438b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310194 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790560}
-
Sasha McIntosh authored
Extends expiry of Renderer4.GpuImageDecodeState.CachePeakUsagePercent UMA. This metric is used to evaluate the finch experiment DecodeJpegToYuv. This UMA can expire after experiment launch. Bug: 1097844 Change-Id: I13fe1fb918d7d0b87562f4e2ec0e34148fd22f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308172Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790559}
-
Sami Kyostila authored
This patch implements a producer backend for Perfetto's client library using the mojo-based PerfettoService. This makes it possible to use Perfetto's client library to emit trace events. Since the perfetto service only supports one producer for each process, we introduce a feature flag (EnablePerfettoClientApiProducer) to enable the client library producer instead of the TraceLog implementation. Note that since no producers are actually ported to the client library yet, no trace events currently are generated when using this flag. Bug: b/158460810, 839071 Change-Id: Ief61793cba9fe6d5fb8e2a9330f9c06cccd0942a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283307 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#790558}
-
Matt Menke authored
QuicClientPushPromiseIndex allows at most one push per URL, which resulted in leaking data across NetworkIsolationKeys. Since this is a quiche-provided interface, the simplest workaround is to just create one per QuicChromiumClientSession instead. Bug: 1105544 Change-Id: I2bc975f4710bdc07f2a24f0ec6785c96000c5deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302831Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#790557}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If232d1b872328d80e0e6d0a661d66093e584bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310393Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#790556}
-
Adlai Holler authored
Bug: skia:104662 Change-Id: I186d6376b5685a1071ae5d57a871383422984b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310889 Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#790555}
-
Tommy Li authored
Currently, we persist to a pref when a user manually hides a suggestion group. This works because all suggestion groups are default-shown. In the near future, we plan to have some suggestion groups be default-hidden. So now, we should persist if a user has manually shown a suggestion group as well. (See go/desktop-chrome-polaris-engdesign for details.) This CL obsoletes the "omnibox.hiddenGroupIds" list pref and instead creates a new "omnibox.suggestionGroupVisibility" dictionary pref, which has the group ID as the key, and stores two possible states: - HIDDEN (1) - SHOWN (2) If the user has never set the preference, we plan to eventually return a third value: - DEFAULT (0) In that case, the callsite will have to decide on the proper default visibility, which will be either a client-side flag or a server-provided hint per-group. One more thing: I've purposely not provided a migration path from the old pref to the new pref. I did this for simplicity sake. I've looked at the UMA, and there are only ~25 count usages of the collapse / expand feature each on Stable in the last 30 days. Across all Channels, there's ~550 each over the last 30 days. I think a significant fraction of that 550 is Chromium developers. In other words, I think simplicity trumps migrating the prefs of the scant few users who've set this pref so far. Bug: 1106096 Change-Id: I8f0bf559f897474c18b9bf90cc33cb8b040cb0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303862 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0bc68bd16484..a5d9c1a45c2b 2020-07-21 danilchap@webrtc.org In DependencyDescriptor rtp header extension drop partial chain support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6987329a0f8f7bd7a9e62fbc5cf23b55cbb2695c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790553}
-
Matt Jones authored
Bug: 1062099 Change-Id: If923b8cd540f6004bc13603d98c81a00c80f4d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307487 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#790552}
-
Ali Juma authored
Change-Id: Id23c088afaa250faf5ac7233deccb94424e9a456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310802Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#790551}
-
evliu authored
This CL adds an API key for the Speech On-Device API (SODA). Usage of the API key is outlined here: go/securing-soda-on-chrome. Bug: 1107615 Change-Id: Ic92418407e17a88426559251e77797bd0b34818b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309133Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#790550}
-
Mohsen Izadi authored
Based on the data gathered from running the experiment on canary/dev and beta, it seems that the disabling latency recovery for both main and impl threads is an overall performance win. So, we are going to re-enable the (now-expired) experiment on stable and move forward with its gradual rollout. Bug: 993895 Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790549}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1106937 Change-Id: Idd4931433c8421187510df98b200b93e51da508c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309757 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#790548}
-
Greg Thompson authored
Resource extraction and file expansion in the mini_installer now use the MiniFile class to manage output files while they are open. It takes care of handle lifetime management and provides a robust way to delete an open file. This change also fixes two potential file leaks. Specifically, a destination file created by either PEResource::WriteToDisk or mini_installer::Expand is now deleted in case of error. BUG=516207 Change-Id: I2ee894d4e6f2d04fbb6cf3355638ee50e8bb1bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303400Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#790547}
-
phillis authored
Bug: 1107962 Change-Id: Ibb57e754136237e906fff151cffae8a2d167901e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310836 Auto-Submit: Phillis Tang <phillis@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790546}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595330901-a1487ea0e73c84091ecbf3f0440329cfe99905ef.profdata to chrome-mac-master-1595354395-0cec5727d5425707de0e31a54a23e974ac70998e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae85a615c155da7b771ac57520342aaeb49fb0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790545}
-
Xianzhu Wang authored
We are removing the function to remove obstacle to integrate paint with LayoutNGBlockFragments. Now always pass image border size to painting timing detectors. This is also more accurate than the visual rect used previously. Visual rect includes visual overflows, borders, etc. which are not part of the image. For the text in FileUploadControl, now report the bounds of the text instead of the control's visual rect which also covers the button and visual overflows. Bug: 1104064 Change-Id: I9974ee67c5f0a0bdc84e0d0530c12c4843b577ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309801 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#790544}
-
Livvie Lin authored
Bug: 1058898 Change-Id: I395d8e95992e2d741882f199fb80a5173db49d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304310Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790543}
-
sczs authored
Bug: 1085419 Change-Id: I88648fb865e96a839b691c762518b2076b5fcd2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311051 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#790542}
-
Matt Jones authored
The GESTURE_DETECTOR property for the scrim is currently unused and doesn't correctly pass motion events back to the mediator as it was originally intended to. This patch correctly delegates event handling to the mediator; there is no behavior change if the GESTURE_DETECTOR property is null or not set. A test has also been added to ensure events can be processed by the detector if set. Bug: 1062099 Change-Id: Ia67f8f6dfa7b16d9f74a71bbe1a73994fe8ed034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305921Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#790541}
-
Pavol Marko authored
Allow TpmChallengeKeySubtle to be instantiated with a nullptr Profile*. Such an instance can only be used to work with machine keys (device-wide keys). This is useful to decouple the device-wide CertProvisioningScheduler from the sign-in Profile. Bug: 1045895 Change-Id: I42382d3be03aa371d4ba31aaebb2891326e24599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189650 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#790540}
-
Josh Nohle authored
The //chrome/browser/nearby_sharing/ directory has subdirectories with their own BUILD files. Those directories cannot currently depend on the Nearby Share enum and pref files, which currently live in the //chrome/browser/nearby_sharing/ directory. Here, we create a //chrome/browser/nearby_sharing/common BUILD target that contains Nearby Share prefs and enums. Change-Id: I9e8daf5660ec4dc22ef002c3cc00a1d715bb5ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306372 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790539}
-
Roger Tawa authored
With recent changes triggered DLP rule names are added to the reported events. This CL is mostly about make sure things are work as expected. Two changes are made: 1/ Remove extra fields from the reported rules. The server is quite strict and rejects reports if they contain bad or extra fields. This CL removes the fields 'id' and 'action' which are not handled. 2/ Rename the "result" field to "eventResult". This was an error I introduced in cl/2288811. With these changes I have verified that event reports are properly accepted by the backend. Bug: 1069109 Change-Id: Ia381da313488eee6f41d71b1ab3928c213003e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308991Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790538}
-
adamta authored
Immediately shows or hides Discover feed from NTP when setting is toggled in the settings menu. Changes setting title from "Article Suggestions" to "Discover" (this may change eventually and the icon will change as well). Bug: 1085419, 1105624 Change-Id: I560b7af4aa41b18493f7853a5b44b504d9c1ad53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302809 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#790537}
-
Peng Huang authored
This CL doesn't reuse the external semaphores, it just adds a new class ExternalSemaphore which will be reused in follow-up CLs. Bug: 1004772,1004774 Change-Id: I28930c3accdd3e004db058e32ff688630c66a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308873Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#790536}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09357ccfa85a..5933d7d54fb8 2020-07-21 johnstiles@google.com Update GrPaint APIs to reflect lack of multiple color processors. 2020-07-21 herb@google.com constify GrAtlasTextOp::Geometry 2020-07-21 johnstiles@google.com Remove support for multiple color processors from GrPaint. 2020-07-21 johnstiles@google.com Update VisualizeCoverageCountFP to accept an input FP. 2020-07-21 mtklein@google.com some small SkVM TODOs 2020-07-21 herb@google.com inline prepareGrGlyphs 2020-07-21 bsalomon@google.com Rename GrCaps fields and methods from MipMap to Mipmap 2020-07-21 csmartdalton@google.com Always return the full remaining buffer capacity from makeSpaceAtLeast 2020-07-21 egdaniel@google.com Add new GrContext::updateBackendTexture call that takes an SkColorType. 2020-07-21 bsalomon@google.com Rename GrBackendTexture::fMipMapped -> fMipmapped 2020-07-21 michaelludwig@google.com Revert "Support moving blocks from one allocator to another" 2020-07-21 bsalomon@google.com Rename GrMipMapsStatus GrMipmapStatus 2020-07-21 michaelludwig@google.com Support moving blocks from one allocator to another 2020-07-21 kjlubick@google.com [canvaskit] Update to 0.17.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I570a9999ca312fee1f9f4612cabf99c3c91881c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790535}
-
Wenhan (Han) Zhang authored
Change-Id: I658ab21b20dbb35d539ee083533c2ec956e1c860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258194Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Cr-Commit-Position: refs/heads/master@{#790534}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0dd63428948f..232115851126 2020-07-21 jmadill@chromium.org Roll chromium_revision b0410bba..fb6cbaf6 (763000:790363) 2020-07-21 syoussefi@chromium.org Add test for deferred clear + attachment gaps 2020-07-21 geofflang@google.com Support EXT_shader_texture_lod on Vulkan. 2020-07-21 nguyenmh@google.com Apply multiprocessing to capture_replay_tests.py 2020-07-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 30aa06f22718 to 4b40207be32d (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I7b828a7dd1f81e49a839125e394e7740778dff0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790533}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9949ab7a4b1c..720e010ba1b2 2020-07-21 ehmaldonado@chromium.org Revert "bot_update: Refactor branch to detach and checkout." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104182 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia47ac5732faca80d1ed924ddc5447e0b07df014a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790532}
-
Dominique Fauteux-Chapleau authored
Bug: 1088124 Change-Id: I9d0e18023d0b81e8fe78cb1f80305b31e727e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298120Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#790531}
-
Erik Chen authored
The file does not provide the preprocessor defines for IN_PROC_BROWSER_TEST_ macros. This documentation update makes it clear to users that they need to manually include "content/public/test/browser_test.h". The header cannot be directly included by in_process_browser_test.h as it produces compile errors: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874211071355292448/+/steps/compile__with_patch_/0/stdout Change-Id: Ie8091857d76e2408a6fdbc471bf97ca544f8c89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308863Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790530}
-
Joshua Peraza authored
498c36b82a03 mac arm64: Provide something more useful from SystemSnapshot::CPURevison e3c94b87f0ef [fuchsia] Move //zircon/system/ulib/fdio to //sdk/lib/fdio fd001f792eb7 build: Make crashpad_dependencies="external" work in the GN build ef8a063055c6 Fuchsia: Propagate failure to initialize exception snapshot 06a688ddc1bc linux: setup a signal stack 9f66d569fb87 linux: put test attachment in temp directory 070b18d326b6 linux: fix alt-stack tests with asan b71bde32e7f9 linux: fix tests with msan Change-Id: I509b8ba9053a71709f8ae24a81dc24d8da4e8fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309758 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#790529}
-