GitLab

Consistently causing WebKit Android (Nexus4) to fail provision_devices.

> [android] Adds constants.GetOutDirectory() and converts test scripts to use it.
> 
> BUG=260494
> TEST=None
> NOTRY=True
> 
> Review URL: https://chromiumcodereview.appspot.com/22903016

TBR=craigdh@chromium.org

Review URL: https://codereview.chromium.org/23926012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222008 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements startCopy and cancelCopy of fileBrowserPrivate APIs.
Note that startCopy works now, but cancellation and progress reporting are not
supported yet.

BUG=279288
TEST=Ran unit_tests and tested manually.
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23604042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222007 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165

Review URL: https://chromiumcodereview.appspot.com/23437026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=287726
TBR=sgurun

Review URL: https://codereview.chromium.org/23441053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222005 0039d316-1c4b-4281-b951-d872f2087c98

We need to pass the CWS OAuth token to the CWS widget in Suggest app dialog, instead of Drive OAuth token. This patch adds the method to fetch the CWS token and replace the drive token with it in Suggest app dialog.

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23549016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222004 0039d316-1c4b-4281-b951-d872f2087c98

Since the PyAuto tests are gone for WebRTC, remove
all references to them so they don't confuse developers.

BUG=225698

Review URL: https://chromiumcodereview.appspot.com/23908004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222003 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 221946 "[Android WebView] Enable spatial navigation / DPAD"
> 
> > [Android WebView] Enable spatial navigation / DPAD
> > 
> > Turn on the --enable-spatial-navigation flag, and also bubble up
> > unhandled DPAD events to the neighboring views in the view tree.
> > Likewise, WebContentsDelegate::TakeFocus() bubble to logical next
> > or previous neighbor view.
> > 
> > Also disabled the FileSystem API while in the area updating flags.
> > 
> > BUG=286698
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23619024
> 
> TBR=joth@chromium.org
> 
> Review URL: https://codereview.chromium.org/23494033

TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/23804007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271321

Review URL: https://chromiumcodereview.appspot.com/23847005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221999 0039d316-1c4b-4281-b951-d872f2087c98

DriveIntegrationServiceFactory::GetForProfile will return the instance
regardless of whether the Drive is enabled or not. GetFileSystemByProfile will
still be looking at enabled state.

BUG=284972
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/23739005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221998 0039d316-1c4b-4281-b951-d872f2087c98

Originally the PreviewPanel class managed only the visibility of the preview
panel.

BUG=241693
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23462020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221997 0039d316-1c4b-4281-b951-d872f2087c98

The path constants are internal implementation details, so they should not be in the publicly used header "file_system_util.h".

They were in the common header for sharing the path constants between tests and the production code, but there's no unavoidable reason that tests have to run on that path.

BUG=258726

Review URL: https://chromiumcodereview.appspot.com/23462021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221996 0039d316-1c4b-4281-b951-d872f2087c98

Since the IMEs has been migrated from native application to
extensions.  There entries are no longer necessary.

BUG=256102

Review URL: https://chromiumcodereview.appspot.com/23548006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221995 0039d316-1c4b-4281-b951-d872f2087c98

The margin of CWS widget on the server has been removed. Thus, we remove the corresponding margin on Files.app side as well.

BUG=none
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23983015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221993 0039d316-1c4b-4281-b951-d872f2087c98

The progress callback interface will be changed as the third parameter
goes to number from boolean. This change make translate.js support
both boolean and number for API migration. Once this change goes to stable
channel, server side library will change to return number to specify error code.

BUG=211308
TEST=none

Review URL: https://chromiumcodereview.appspot.com/24024004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221992 0039d316-1c4b-4281-b951-d872f2087c98

The primary goal of this change is to allow PasswordForm to depend on //
autofill code for password generation. A side benefit is that this change will
allow iOS to cleanly use PasswordForm.

To accommodate the fact that multiple message files need to know about PasswordForm, it is put into a newly-created autofill_param_traits_macros.h rather than autofill_messages.h.

BUG=263121

Review URL: https://chromiumcodereview.appspot.com/23742004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221991 0039d316-1c4b-4281-b951-d872f2087c98

Broke DriveFileSystemExtensionApiTest.FileWatch
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/151979


> file_manager: Remove FileWatchChangedEntry from fileBrowserPrivate
> 
> This type is not in use, and we don't plan to use this any time soon.
> We should add it back when it's needed.
> 
> BUG=257916
> TEST=Files.app works as before
> R=benwells@chromium.org, mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/23956009

TBR=satorux@chromium.org

Review URL: https://codereview.chromium.org/23791005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221990 0039d316-1c4b-4281-b951-d872f2087c98

> [Android WebView] Enable spatial navigation / DPAD
> 
> Turn on the --enable-spatial-navigation flag, and also bubble up
> unhandled DPAD events to the neighboring views in the view tree.
> Likewise, WebContentsDelegate::TakeFocus() bubble to logical next
> or previous neighbor view.
> 
> Also disabled the FileSystem API while in the area updating flags.
> 
> BUG=286698
> 
> Review URL: https://chromiumcodereview.appspot.com/23619024

TBR=joth@chromium.org

Review URL: https://codereview.chromium.org/23494033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221989 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221988 0039d316-1c4b-4281-b951-d872f2087c98

To consolidate fileBrowserPrivate tests into a single directory.
Als add OWNERS, so Files.app team can add tests without approval
from extensions owners.

BUG=231782
TEST=none
R=benwells@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/24024002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221987 0039d316-1c4b-4281-b951-d872f2087c98

These types are no longer used.

BUG=257916
TEST=none
R=benwells@chromium.org, hidehiko@chromium.org

Review URL: https://codereview.chromium.org/23882004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221986 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221985 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157413:157432&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23697003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221984 0039d316-1c4b-4281-b951-d872f2087c98

Originally, PreviewPanel is not used from any code.
This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.

Previously reverted CL: crrev.com/23464030

BUG=284215
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/23662004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221983 0039d316-1c4b-4281-b951-d872f2087c98

This type is not in use, and we don't plan to use this any time soon.
We should add it back when it's needed.

BUG=257916
TEST=Files.app works as before
R=benwells@chromium.org, mtomasz@chromium.org

Review URL: https://codereview.chromium.org/23956009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221982 0039d316-1c4b-4281-b951-d872f2087c98

The term path is incorrect as the parameter is for a URL.

FWIW, the URL looks like:
"filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/external/"
where hhaomjibdihmijegdhdafkllkbggdgoj is the app ID for Files.app.

BUG=284963
TEST=Files.app works as before
R=benwells@chromium.org, kinuko@chromium.org

Review URL: https://codereview.chromium.org/23903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221981 0039d316-1c4b-4281-b951-d872f2087c98

This is API clean up. The mountType is being replaced by VolumeType. This CL
refactors private APIs about the flag.
Note that this is preparation to return Drive as a Volume.

BUG=279276
TEST=Ran unit_tests, browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.
R=benwells@chromium.org, kinaba@chromium.org, satorux@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23658009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221978 0039d316-1c4b-4281-b951-d872f2087c98

"fileUrl" and "errorCode" are no longer in use.

BUG=257916
TEST=Files.app works as before
R=benwells@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23514043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221977 0039d316-1c4b-4281-b951-d872f2087c98

Instead introducing a static FileSystemOperation::Create method.

As a preparation for moving fileapi code from webkit/ to content/.
(file_system_operation.h will be placed under content/public/browser/ while
file_system_operation_impl.{h,cc} will be placed under content/browser/fileapi
and will be hidden from chrome/)

BUG=265770
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/23835005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221976 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221975 0039d316-1c4b-4281-b951-d872f2087c98

Currently the main menu is only modified for app windows when
--enable-app-shims is enabled. This change enables modifying
the main menu whenever app shims are enabled (i.e. when the app
launcher is enabled).

BUG=168080,276052

Review URL: https://chromiumcodereview.appspot.com/23558007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221974 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157410:157412&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24065002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221973 0039d316-1c4b-4281-b951-d872f2087c98

Re-apply and disable for Chrome Frame.

> Revert 221944 "Add UMA to report Preferences File Corruption"
> 
> Breaks chrome_frame_tests on Win Aura.
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1)
> 
> > Add UMA to report Preferences File Corruption
> > Adds PrefMetricsService methods to track changes to user preferences
> > that happen outside of Chrome and report discrepancies via UMA.
> > 
> > BUG=266569
> > 
> > Review URL: https://chromiumcodereview.appspot.com/22676002
> 
> TBR=bbudge@chromium.org
> 
> Review URL: https://codereview.chromium.org/23597020

TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/23788010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221972 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221971 0039d316-1c4b-4281-b951-d872f2087c98

Breaks chrome_frame_tests on Win Aura.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=chrome_frame_tests&builder=Win%20Aura%20Tests%20(1)

> Add UMA to report Preferences File Corruption
> Adds PrefMetricsService methods to track changes to user preferences
> that happen outside of Chrome and report discrepancies via UMA.
> 
> BUG=266569
> 
> Review URL: https://chromiumcodereview.appspot.com/22676002

TBR=bbudge@chromium.org

Review URL: https://codereview.chromium.org/23597020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285016
TEST=YouTube playback works for videos that are available in the VP9 format.

Review URL: https://chromiumcodereview.appspot.com/23463020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269131
TEST=none
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23851009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=none, no functional changes.
R=erg@chromium.org
TBR=thestig # for gyp change.

Review URL: https://chromiumcodereview.appspot.com/23743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221962 0039d316-1c4b-4281-b951-d872f2087c98

It allows us to run an experiment where only chrome.dll is instrumented.

TBR=chrisha@chromium.org, gab@chromium.org
CC=laforge@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23719017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221961 0039d316-1c4b-4281-b951-d872f2087c98

Replace --enable-device-discovery flags with --disable-device-discovery.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23567023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221960 0039d316-1c4b-4281-b951-d872f2087c98

I don't think this is related to the crash I'm seeing, but I noticed
it when looking for dangling TabStripModelObservers.

BUG=286162
TEST=none
R=yoz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23547006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221959 0039d316-1c4b-4281-b951-d872f2087c98