GitLab

MIPS64 requires IAS to be explicitly set.

Few important mips64 related changes were missing in Clang.
With Clang roll to r295762 they are included and
clang does not crash anymore.

Now that build is ok we can switch to IAS as well.

BUG=None.
TEST=gn gen out-gn/mips64-clang --args="is_debug=false target_os=\"android\" target_cpu=\"mips64el\" is_clang=true mips_use_msa=false"
     ninja -C out-gn/mips64-clang system_webview_apk

Review-Url: https://codereview.chromium.org/2720833002
Cr-Commit-Position: refs/heads/master@{#453252}

* Separate params in feature for small and large screens
* Exposed in chrome:flags
* See bug for screenshots

BUG=688338

Review-Url: https://codereview.chromium.org/2714723002
Cr-Commit-Position: refs/heads/master@{#453251}

(patchset #5 id:80001 of https://codereview.chromium.org/2709563002/ )"

This reverts commit 08c967e8.

The cell selection and reload logic was incorrect.
If the same cell was selected again, two identical indexPaths were
passed into -reloadItemsAtIndexPath:.

BUG=686770

Review-Url: https://codereview.chromium.org/2716773003
Cr-Commit-Position: refs/heads/master@{#453250}

Custom view controller transition animations must be designed
so as not to break constraints on the presented/dismissed VC's view.

This CL addresses a broken constraint due to the zoom animator.
The zoom animator will resize the VC's view to a small rect.
However, that rect is smaller in height than the sum of the
height constraints on the subviews of the tab_container.

This CL simply reduces the subview height constant. Since the
transition animation will likely change, there is no need to modify
the zoom animator at this time.

BUG=

Review-Url: https://codereview.chromium.org/2717133002
Cr-Commit-Position: refs/heads/master@{#453249}

PnaclTranslationCacheEntry has a non-thread-safe ref count, and usually
bound to IO thread. However, disk_cache::BackendIO may be destroyed on
CACHE thread, and may drop a reference on it. That causes a data race
on the unprotected ref count.

BUG=688072

Review-Url: https://codereview.chromium.org/2722513002
Cr-Commit-Position: refs/heads/master@{#453248}

BUG=693233
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2711783003
Cr-Commit-Position: refs/heads/master@{#453247}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0dae245e..4ed8f7ed

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2719973002
Cr-Commit-Position: refs/heads/master@{#453246}

When a password field is autofilled, the value is not accessible to JavaScript
until the user clicks or types in the page. To keep track of this, the frames
report such user gestures, and ChromeAutofillClient distributes such a signal
to all other frames in the same WebContent, via their common
AutofillDriverFactory.

This does not work when a new frame is added later, because the browser process
does not keep track whether the user gestures were seen already. Newly added
frames never learn about the user already having clicked in the page.

This CL fixes that by modifying AutofillDriverFactory to remember the
user gestures and notify also drivers added later. The flag is reset on main
page navigation.

The CL also makes parts of the AutofillDriverFactory API public, as long as they
do not modify the drivers map. This results in a slight reordering of methods.

BUG=669045

Review-Url: https://codereview.chromium.org/2603623002
Cr-Commit-Position: refs/heads/master@{#453245}

https://pdfium.googlesource.com/pdfium.git/+log/1d7018e92d31..717a4fc857d6

$ git log 1d7018e92..717a4fc85 --date=short --no-merges --format='%ad %ae %s'
2017-02-24 thestig Remove some pointless checks and assignments.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2723513003
Cr-Commit-Position: refs/heads/master@{#453244}

This finishes moving memory instrumentation code from TracingController
to its own location in //services/resource_coordinator.

BUG=679830
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2694083005
Cr-Commit-Position: refs/heads/master@{#453243}

ScopedPlatformHandle encapsulates ownership of one of various types
of platform-specific resource handles including POSIX file descriptors,
and Windows handles.

The purpose of this type is to have a consistent representation of such
resources for the sake of safe ownership semantics across various API
boundaries, relegating platform-specific details to either the code which
initially acquires the resource or the code which actually uses it.

BUG=None

Review-Url: https://codereview.chromium.org/2705743002
Cr-Commit-Position: refs/heads/master@{#453242}

This test does not need a full FindInPageController, so that is removed from the
test fixture.  Additionally, the find in page unittest files are moved from
ios/chrome/browser/web to ios/chrome/browser/find_in_page.

BUG=691073

Review-Url: https://codereview.chromium.org/2711513002
Cr-Commit-Position: refs/heads/master@{#453241}

This CL adds a variations parameter for launching renderer in WebAPK
process. When enabled, WebAPK would launch Chrome's renderer process as
its own process; otherwise, WebAPK would launch Chrome's renderer
process as Chrome's process.

BUG=692627

Review-Url: https://codereview.chromium.org/2716493002
Cr-Commit-Position: refs/heads/master@{#453240}

This patch adds the necessary logic to allow the user to use the
Payment Method Selection Screen to select the credit card to send to the
website.

BUG=679835

Review-Url: https://codereview.chromium.org/2711973002
Cr-Commit-Position: refs/heads/master@{#453239}

Change log statements from ui/display/manager/chromeos/ that were being
logged in Chrome OS devices unnecessarily. Remove a VLOG(1) added by me
to observe the fix to a bug on beta channel. I believe the bug is fixed
and this isn't necessary anymore. Also change a LOG(WARNNING) to
VLOG(2) for unmatched touchscreen displays. Not all displays are
touchscreens, so this shouldn't be a warning.

BUG=682079

Review-Url: https://codereview.chromium.org/2721633002
Cr-Commit-Position: refs/heads/master@{#453238}

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2700823002
Cr-Commit-Position: refs/heads/master@{#453237}

https://skia.googlesource.com/skia.git/+log/61b721c449d0..ab8e02a4dee7

$ git log 61b721c44..ab8e02a4d --date=short --no-merges --format='%ad %ae %s'
2017-02-27 halcanary SkGradientShader: Fix multi-byte-read-stack-use-after-scope
2017-02-27 mtklein Drop SkRasterPipelineBench N to 15.

Created with:
  roll-dep src/third_party/skia
BUG=694098

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2717363002
Cr-Commit-Position: refs/heads/master@{#453236}

This single callback replaces UrlHashChanged and HistoryStateChanged.

BUG=692331
TEST=page gets translated after same document navigations.

Review-Url: https://codereview.chromium.org/2711363003
Cr-Commit-Position: refs/heads/master@{#453235}

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2703803002
Cr-Commit-Position: refs/heads/master@{#453234}

Merge the addBeginTime and addEndTime methods into a single method
addInstanceTime (that takes a BeginOrEnd argument.) Migrate callers to
the new method, getting rid of SVGSMILElement::handleConditionEvent in
the process.
Also inline some trivial functions in SVGAnimationElement.

BUG=641437

Review-Url: https://codereview.chromium.org/2712343004
Cr-Commit-Position: refs/heads/master@{#453233}

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG=678257

Review-Url: https://codereview.chromium.org/2717603003
Cr-Commit-Position: refs/heads/master@{#453232}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1c1bd4d..b369f97

$ git log 1c1bd4d..b369f97 --date=short --no-merges --format=%ad %ae %s
2017-02-27 tommi@webrtc.org Remove extra call to TimeUntilNextProcess from within Process.
2017-02-27 kthelgason@webrtc.org iOS AppRTCMobile: Fix SocketRocket bug
2017-02-27 henrika@webrtc.org Simplifies FineAudioBuffer by using rtc::Buffer
2017-02-27 tommi@webrtc.org Revert of Use TaskQueue in IncomingVideoStream (patchset #10 id:320001 of https://codereview.webrtc.org/2716473002/ )
2017-02-27 tommi@webrtc.org Fix race in INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO
2017-02-27 tommi@webrtc.org Use TaskQueue in IncomingVideoStream instead of the PlatformThread + event timer approach.
2017-02-27 sprang@webrtc.org Fix race condition in VideoSendStreamTest.ChangingTransportOverhead

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2723503002
Cr-Commit-Position: refs/heads/master@{#453231}

A condition got inverted so that we get the old value after we've
changed it to the new value. This means the old and new value are always
equal. Swap the order of statements to fix problem.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2714973002
Cr-Commit-Position: refs/heads/master@{#453230}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a75c463e8416..645770e4019b

$ git log a75c463e8..645770e40 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 achuith Disable testEnsurePCv1Cold and testEnsurePCv1WarmFromScratch

Created with:
  roll-dep src/third_party/catapult
BUG=694722

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2720693005
Cr-Commit-Position: refs/heads/master@{#453229}

https://pdfium.googlesource.com/pdfium.git/+log/eb38d63ba8a8..1d7018e92d31

$ git log eb38d63ba..1d7018e92 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 dsinclair Whitespace change

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2715263002
Cr-Commit-Position: refs/heads/master@{#453228}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/25400c4c..0dae245e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2717343002
Cr-Commit-Position: refs/heads/master@{#453227}

When native GPU memory buffers were enabled we noticed many crashes
reporting mmap failing.

This CL adds more information when dmabuf mmap fails in the crash report
that is uploaded.
It adds the values of the parameters passed to mmap, the validity of the fd
passed to mmap, the last errno set, and the logical size of the buffer.

Additionally, while we used to always report mmap failing as out of memory,
after this CL we'll differentiate based on the last system error set.

BUG=629521

Review-Url: https://codereview.chromium.org/2710183005
Cr-Commit-Position: refs/heads/master@{#453226}

https://skia.googlesource.com/skia.git/+log/9eac2ea77340..61b721c449d0

$ git log 9eac2ea77..61b721c44 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 borenet Roll Recipe DEPS

Created with:
  roll-dep src/third_party/skia

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2722573002
Cr-Commit-Position: refs/heads/master@{#453225}

Network traffic annotation is added to network request of
ntp_snippets/remote/json_request.

BUG=656607

Review-Url: https://codereview.chromium.org/2709483006
Cr-Commit-Position: refs/heads/master@{#453224}

It's no longer necessary now that we've removed the S5s from the perf
waterfall.

Review-Url: https://codereview.chromium.org/2709103006
Cr-Commit-Position: refs/heads/master@{#453223}

Dragging works correctly as well

BUG=648563

Review-Url: https://codereview.chromium.org/2718763002
Cr-Commit-Position: refs/heads/master@{#453222}

Opening links in the regular profile closes the bottom sheet,
so this makes the behaviour for incognito consistent with that
and fixes the issue of the sheet being open while the tab model
switches from regular to incognito.

BUG=690059

Review-Url: https://codereview.chromium.org/2710323003
Cr-Commit-Position: refs/heads/master@{#453221}

Previously I just disabled the callbacks. In addition to that, send back
an empty configuration and site list, to make the page properly display
that everything is disabled and there are no sites in incognito.

Without this change, the "View JSON" button appears for popular sites,
but causes a crash because there's no PopularSites object.

BUG=682622,696471,681774

Review-Url: https://codereview.chromium.org/2721603002
Cr-Commit-Position: refs/heads/master@{#453220}

BUG=661257

Review-Url: https://codereview.chromium.org/2712703004
Cr-Commit-Position: refs/heads/master@{#453219}

BrowserWindow::CreateBrowserWindow should not assume gfx::NativeWindow is
aura::Window*, so make the code that requires that conditional on USE_AURA.

BUG=None

Review-Url: https://codereview.chromium.org/2714063003
Cr-Commit-Position: refs/heads/master@{#453218}

This change adds docstrings to these scripts, and prints out
these docstrings as description messages when -h is passed.

BUG=692926

Review-Url: https://codereview.chromium.org/2719633002
Cr-Commit-Position: refs/heads/master@{#453217}

Move components/payments:payment_app from common deps to mojo_bindings
public deps since service_worker/service_worker_event_dispatcher.mojom depends on it.

Review-Url: https://codereview.chromium.org/2717933004
Cr-Commit-Position: refs/heads/master@{#453216}

Introduce a couple of ShapeResult::RunInfo helper templates, to separate
the glyph iteration logic from the current glyphBuffer routines.  Refactor
existing clients to use these helpers.

The main objective is to externalize the glyph iteration logic (such that
it can be reused for direct ShapeResultBuffer->text blob construction in
the future), but the CL also includes a couple of tangential refactors:

  * simplify the character index range checks

  * de-templetize fillGlyphBufferForRun() and push the outer run loop into
    it (also renamed to fillGlyphBufferForResult and updated to return the
    total accumulated advance instead of advance delta)

Note on the last point: the TextDirection template param was only used for
index range checking;  with the refactors above, we only branch on
direction when the index is out-of-range - which is uncommon and doesn't
warrant template parametrization.

BUG=574136
R=drott@chromium.org,eae@chromium.org

Review-Url: https://codereview.chromium.org/2715773002
Cr-Commit-Position: refs/heads/master@{#453215}

https://pdfium.googlesource.com/pdfium.git/+log/f2225817ddbe..eb38d63ba8a8

$ git log f2225817d..eb38d63ba --date=short --no-merges --format='%ad %ae %s'
2017-02-27 dsinclair Whitespace change

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2718973003
Cr-Commit-Position: refs/heads/master@{#453214}

CL fixes a typo in ws::Display::num_window_manager_states
method declaration/usage.

TBR=sky@chromium.org

BUG=None

Review-Url: https://codereview.chromium.org/2717333002
Cr-Commit-Position: refs/heads/master@{#453213}