- 14 Apr, 2018 40 commits
-
-
Nico Weber authored
I removed the goma bots in https://chromium-review.googlesource.com/c/chromium/src/+/1012963, but I suppose the goma folks will want to keep testing MSVC with goma for the v8 webrtc pdfium angle waterfalls, so put them back. Removing mb and testing configs is blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=833017 Bug: 820422 Change-Id: I1a35c59afd517eea2a5cbd0b7af2cc9ee5c7d659 Reviewed-on: https://chromium-review.googlesource.com/1013339Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550894}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e290076c8be..c90ccbc26d04 $ git log 2e290076c..c90ccbc26 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf chromeos_config: mark eve-arcnext-chrome-pfq not important. 2018-04-13 cmtice [chromite] Add script to set up env for locally testing fuzz targets. 2018-04-13 marcochen soraka: remove sign type - factory and accessory_rwsig 2017-11-03 dgarrett Reland "config_lib: Remove OverrideConfigForTrybot." 2018-04-13 dgarrett buildbucket_lib: Remove _ah from URLs. 2018-04-13 bmgordon cros lint: Look up pylintrc for all python files 2018-03-14 dgarrett report_stages: Use Logoland build URL for master builder. 2018-03-14 dgarrett validation_pool: Switch to Legoland build links. Created with: roll-dep src/third_party/chromite BUG=chromium:832736,chromium:776955,chromium:None,chromium:None,chromium:821618,chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6c3d1f6d83d8bfb7ea269da65c9f09901668cb37 Reviewed-on: https://chromium-review.googlesource.com/1013395Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550893}
-
Findit authored
This reverts commit b9d68c49. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 550884 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I5ZDY4YzQ5YTMxNDBhYTBhZTQyOWI3NDJkMjkzMjlmYWI1NGVlZjUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27035 Sample Failed Step: mus_ash_unittests Original change's description: > splitview: Grab app for splitscreen only happen on long press. > > The indicators and the item enlarging only happen after long press, or > if the item has been dragged. > > This is preparation for fling to dismiss. It also removes a flicker of > the indidcators when you tap to open a item. > > Also renables a previous flaky test. Tested locally and it is not flaky > no more. > > Test: ash_unittests SplitViewWindowSelectorTest.* > Bug: 817863 > Change-Id: I9c20f2fa9a3c0a9218b3072c5b3d25711ad9c655 > Reviewed-on: https://chromium-review.googlesource.com/996528 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550884} Change-Id: I409e3401d6c171191ca58cece64bb0396b4956f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817863 Reviewed-on: https://chromium-review.googlesource.com/1012477 Cr-Commit-Position: refs/heads/master@{#550892}
-
jdoerrie authored
This change fixes a crash when a BLE Security Key responds after kDeviceTimeout has passed. In the case of a timeout all future messages from the device will be ignored. Bug: 763303 Change-Id: I62ec334195324cadddedc8fea56830147001e555 Reviewed-on: https://chromium-review.googlesource.com/1007083 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550891}
-
Luum Habtemariam authored
Updating metav2 unitttests to reflect v2 case insensitive effective-make-and-model inputs. BUG=chromium:804014 TEST=chromeos_unittests all pass Change-Id: Id5bd86c3ade919588541db757381e41d01149fe9 Reviewed-on: https://chromium-review.googlesource.com/1011239Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#550890}
-
Victor Costan authored
The test had the following behavior: 1) Construct a first mock object. 2) Move the first mock object to a new buffer by memcpy-ing a void*. 3) Construct a second mock object at the first object's address via placement-new. 4) Create a call expectation on the (now moved) first object. 5) Create a call expectation on the second object. 6) Destroy the second object (built at the first object's address). 7) Destroy the (now moved) first object. gmock objects don't support being moved via memcpy, as done by cc::ListContainer::AppendByMoving. In particular, each MOCK_METHODn macro creates a testing::FunctionMocker<> instance which (via testing::internal::FunctionMockerBase<> -> testing::internal::UntypedFunctionMockerBase) contains a list of expectations, which is std::vector<internal::linked_ptr<ExpectationBase>>. googletest's internal::linked_ptr is very similar to Chromium's version, and moving a node breaks the list pointers. So, while the ListContainerTest.AppendByMoving* tests have always used gmock in an unsupported way, the latest googletest roll turned this usage into a crash (debug assert) on Windows debug builds. This CL disables the test that causes the assertion to get the bot green, while a CL fixing all the tests is prepared and reviewed. TBR=chrishtr Bug: 832726 Change-Id: Ice1ff1930d2d2d40231a82bdb29eb5200a05fac7 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1013407Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550889}
-
Wenzhao Zang authored
All the AshTestBase inheritance in //chrome should be removed eventually. Bug: 827062 Change-Id: I78272914a03f75267b72d478bdfe2381a87203df Reviewed-on: https://chromium-review.googlesource.com/1012307Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550888}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79afb66c..a2ca1996 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic7c49e6e9ab1082f3821264c5cfdd063401ba6ac Reviewed-on: https://chromium-review.googlesource.com/1012578Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#550887}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0562e9de04c878f2f31f9c074d3a061e03ecc571 Reviewed-on: https://chromium-review.googlesource.com/1013405Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550886}
-
Jennifer Apacible authored
Currently, when the Picture-in-Picture window is resized, the video (shown as the cc::SurfaceLayer) does not resize with it. This change makes the cc::SurfaceLayer resize with the window. Setting the new cc::SurfaceLayer size is required. |frame_size_in_dip_|, which is set when the SetShowPrimarySurface() is initially called, is used as the maximum size of cc::SurfaceLayer. This size needs to be up to date for cases where the window is resized to be larger than the initial size. BUG: 726621 Change-Id: I77ae4f08c204a84544565c63cc2412cc93746793 Reviewed-on: https://chromium-review.googlesource.com/1011645Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#550885}
-
Sammie Quon authored
The indicators and the item enlarging only happen after long press, or if the item has been dragged. This is preparation for fling to dismiss. It also removes a flicker of the indidcators when you tap to open a item. Also renables a previous flaky test. Tested locally and it is not flaky no more. Test: ash_unittests SplitViewWindowSelectorTest.* Bug: 817863 Change-Id: I9c20f2fa9a3c0a9218b3072c5b3d25711ad9c655 Reviewed-on: https://chromium-review.googlesource.com/996528 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#550884}
-
https://webrtc.googlesource.com/src.git/+log/3acffc3b1668..365381fdf1cd $ git log 3acffc3b1..365381fdf --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:831756,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id11b4397d911eda8fefc1ea35cf47e4e7f1fe30d Reviewed-on: https://chromium-review.googlesource.com/1013397Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550883}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e6bea7b2. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15540 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer TBR=danyao No-Export: true Change-Id: I713dc1bdf4b5f944c4314d400de5d3ac8604ce67 Reviewed-on: https://chromium-review.googlesource.com/1013419 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550882}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c23684514c93..2e290076c8be $ git log c23684514..2e290076c --date=short --no-merges --format='%ad %ae %s' 2018-04-12 pwang chromeos_config: Mark kevin-arcnext important 2018-04-11 dgarrett binhost_test: Update active config definition. 2018-04-13 dgarrett chromeos-config: Add hwtests to eve chrome tot informational. 2018-04-10 pprabhu cbuildbot: Add pre-cq builder to run infra specific unittests. 2018-04-12 manojgupta cros_setup_toolchains: Update list of post cross packages. 2018-04-12 dgarrett chromeos_config: Move chromiumos-sdk to 'utility' group. 2018-04-09 dgarrett remote_try: Remove buildbot specific behaviors. Created with: roll-dep src/third_party/chromite BUG=chromium:831929,chromium:829898,chromium:None,chromium:820330,chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15b87a3f6a81bd9abdfcc59147a98f0d59932383 Reviewed-on: https://chromium-review.googlesource.com/1013383Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550881}
-
Fergal Daly authored
Move the docs inline as method docs and just link from the md file. Change-Id: I286db306b4f01553ac6fa09a271aa65457c76de8 Reviewed-on: https://chromium-review.googlesource.com/1011764Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550880}
-
Jay Civelli authored
Relanding "Move replaying of redirects and response started to ResourceDispatcher". It was breaking when a renderer would access cookies after a redirect, when the NavigationMojoResponse was disabled. The non NavigationMojoResponse code path has been removed, so this should now work. Also addressing a crasher when replaying redirects for deferred responses. Original description: Moving the replaying of redirects and response started notifications for frames from WebURLLoaderImpl to the ResourceDispatcher. This allows to provide the actual ResourceResponseHead to URLLoaderClientImpl::OnReceiveResponse and fixes the bug where IP address and MIME type would not be reported in ResourceLoadComplete notifications for frames. Tbr: kinuko@chromium.org, clamy@chromium.org Bug: 826082 Change-Id: I250fa02e8f82fe4db5dec01ca4d736551464dbc4 Reviewed-on: https://chromium-review.googlesource.com/1007625 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550879}
-
Dirk Pranke authored
This reverts commit 7a7c85f7. Reason for revert: This doesn't seem to have been the problem. I'm now guessing that https://crrev.com/c/996458 was the problem, because that was in the original blamelist, and was reverted, and the test stopped failing when that was reverted, but not this CL. Original change's description: > Revert "Fix custom titlebar minimize button stuck hovered when clicked." > > This reverts commit a6885b53. > > Reason for revert: Speculatively reverting to see if it fixes the failure for AutomationApiTest.CloseTab is failing in site_per_process_browser_tests on Linux Tests (dbg)(1); see crbug.com/833011 and https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71426 > > Original change's description: > > Fix custom titlebar minimize button stuck hovered when clicked. > > > > Normally when a button is clicked we assume the mouse is still hovering > > over it, so we go back to the hovered state and wait for the mouse exit > > event. However, when the minimize button minimizes the window Windows > > gives us the mouse exit event before the mouse up event, so the button > > will get stuck in the hovered state. > > > > This patch fixes this by resetting the button state when it receives > > a window control action, the same way the opaque frame currently solves > > this problem. > > > > Bug: 828591 > > Change-Id: I6e3f27b8f92bcbf3fb8171555702b8cf5326ba21 > > Reviewed-on: https://chromium-review.googlesource.com/1006373 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550733} > > TBR=sky@chromium.org,bsep@chromium.org > > Change-Id: I2809f8bbc666dd87b9a696eb87935cb3bd0f5e7c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 828591 > Reviewed-on: https://chromium-review.googlesource.com/1012476 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550847} TBR=sky@chromium.org,dpranke@chromium.org,bsep@chromium.org Change-Id: I24d630ab51c665b9df680cdcdbfd0ffe5a1b4fe7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828591 Reviewed-on: https://chromium-review.googlesource.com/1013268Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#550878}
-
Dale Curtis authored
Per scheduler-dev@ the approach of constructing a dummy MessageLoop on the stack just for blink::Initialize() is not correct. Instead we must ensure that the loop we give is the main loop used for the rest of the test. This change provides a main loop to all media_blink_unittests via a ScopedTaskEnvironment; this requires removing all existing MessageLoop instantiations from other tests. This was straight forward in all but two cases: WatchTimeReporterTest and VideoDecodeStatsReporterTest. WTRT relied on pumping tasks one at a time, while VDSRT relies on a mock time task runner. The solution was to convert WTRT to a mock time task runner (including injecting a fake TickClock to the base::RepeatingTimer inside WatchTimeReporter) and then switch both tests over installing the base::TestMockTimeTaskRunner in the top level MessageLoop instead of creating their own. In terms of fixing run_all_unittests.cc, it now follows //third_party/blink/renderer/controller/tests/run_all_tests.cc where by blink::Initialize() isn't called until the RunTestSuiteCB is called. This is required because the multi-process test runner creates a scoped MessageLoopForIO and this will fail if we kept our initialization process in TestSuite::Initialize(). BUG=none TEST=all tests still pass. Change-Id: I0549cca4a72614504433271f6ed4b16a00019a71 Reviewed-on: https://chromium-review.googlesource.com/1011647 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#550877}
-
Klaus Weidner authored
The SurfaceTexture supplies a UV transform matrix which does a Y flip. Pass this matrix to the WebVrRenderer for the Surface path, and use an identity matrix for the SharedBuffer path. We had been ignoring the SurfaceTexture's transform and hardcoded an assumption that it's a Y flip, that is now no longer necessary. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I100c4be9211a9985df317c07d8c4906703e554a2 Reviewed-on: https://chromium-review.googlesource.com/1012777Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#550876}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/957760 this will allow migrating the majority of callers of MessageLoop::current() to not even have to use message_loop.h :). R=thestig@chromium.org Bug: 825327 Change-Id: Idfca0575c363463442225a46dbadfc202aab4669 Reviewed-on: https://chromium-review.googlesource.com/1008265 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550875}
-
tzik authored
This removes 'use_once_callback = false' flag from BUILD.gn in services/tracing/public/mojom, and fixes all implementations of the interface. Bug: 714018, Change-Id: If7cec8d89f304b314275239cde4c15aa40ce0386 Reviewed-on: https://chromium-review.googlesource.com/999074Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#550874}
-
Kai Ninomiya authored
These devices tend to be hi-dpi, and low-power. 8x MSAA has also been seen to trigger various bugs, and impacts performance on some devices. Bug: 797243, 730303 Change-Id: I41f1ef387009f1f63dff82ecb1f3737d3a0c22aa Reviewed-on: https://chromium-review.googlesource.com/1013279Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#550873}
-
Nate Fischer authored
This reverts commit 24e28c22. Reason for revert: This appears to be due to infra flakes Original change's description: > AW: add RetryOnFailure to flaky test > > This adds @RetryOnFailure to a flaky Safe Browsing test. This does not > flake very often. > > Bug: 765932 > Change-Id: Ic7bc40863d395b76c821ee9c277b17d82e5c5ff4 > Reviewed-on: https://chromium-review.googlesource.com/688676 > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504804} TBR=boliu@chromium.org,ntfschr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 765932 Change-Id: Ia9a3e06eed325ab486b3d31468e4d04578c30438 Reviewed-on: https://chromium-review.googlesource.com/1013267Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550872}
-
Ramya Nagarajan authored
Mac's default "Edit -> Emoji & Symbols" menu item accelerator is specified as the accelerator for the (MacViews) context menu item. Bug: 827404 Change-Id: Ia030d6d0acebcb8481b39eea6c659f6855f6e5ab Reviewed-on: https://chromium-review.googlesource.com/1011240 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#550871}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I1c497305cdc100ff275e2a51d170735b39c1608a Reviewed-on: https://chromium-review.googlesource.com/1013417Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550870}
-
Dirk Pranke authored
We haven't been uploading the layout test archives on that bot for some time; it looks like at least not since we migrated to the *.pyl files. It's possible this kept timing out when we were recursively uploading the whole directories. Re-enabling this now, let's see what happens. R=martiniss@chromium.org Change-Id: I82f2d866c0725e31baf0c0ae20f31b5a6f351a98 Reviewed-on: https://chromium-review.googlesource.com/1013294Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#550869}
-
Jun Cai authored
This CL implements the relative orientation fusion algorithm using accelerometer and gyroscope. Related reference: https://www.w3.org/TR/motion-sensors/#complementary-filters Bug: 824436 Change-Id: Ia68c380114a09d4f273b0cccb8dab48842ac7901 Reviewed-on: https://chromium-review.googlesource.com/996803 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#550868}
-
Christian Fremerey authored
This reverts commit b909c213. Reason for revert: Re-Disable the flaky test until a fix is found Original change's description: > Revert "Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac" > > This reverts commit cfec3da6. > > Reason for revert: Checking if flakiness is still happening on Mac ASAN bot > > Original change's description: > > Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac > > > > TBR=chfremer@chromium.org > > > > Bug: 810321 > > Change-Id: Ia12ba855ab9fb8e66c9d48c8e66cf91f76f72e08 > > Reviewed-on: https://chromium-review.googlesource.com/908461 > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Commit-Queue: Olga Sharonova <olka@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#535381} > > TBR=olka@chromium.org,chfremer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 810321 > Change-Id: I6e021bca934428cf9c94a34d4f0e874c25868033 > Reviewed-on: https://chromium-review.googlesource.com/1010842 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550380} TBR=olka@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 810321 Change-Id: I68a7e09599e1511e8b4c547e7932e874689ab224 Reviewed-on: https://chromium-review.googlesource.com/1013018Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550867}
-
Hongchan Choi authored
When AudioParameters is created, the channel count defaults to zero when a given ChannelLayout is DISCRETE. This makes the build crash because of CHECK() failure. This CL fixes the crash and also contains the channel layout handling in PulseAudio for the DISCRETE case. Bug: 827668 Test: The repro case on the issue does not crash anymore. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I222422f76df746c9113ca6586be311790048c6e4 Reviewed-on: https://chromium-review.googlesource.com/988306Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550866}
-
Eugene But authored
Changes in crrev.com/c/1008128 to this test were made by mistake. Bug: 830127 Change-Id: Iff0593951683e58b9a3c710a602eb3cd713cbe8a Reviewed-on: https://chromium-review.googlesource.com/1012992 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550865}
-
Kai Ninomiya authored
Reviewed existing usages of is_angle to make sure they didn't need to be changed to is_d3d. Tests: Service/FeatureInfoTest.InitializeWithANGLED3D9Ex Service/FeatureInfoTest.InitializeWithANGLED3D11 Service/FeatureInfoTest.InitializeWithANGLEOpenGL Bug: 806557 Change-Id: Iaf582eaa02cdda7c3e78b0359578cf89680164ba Reviewed-on: https://chromium-review.googlesource.com/1011357 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#550864}
-
Bailey Forrest authored
This is necessary for Web Bluetooth notifications to work on these non-compliant devices. BUG=831878 TEST=cast_bluetooth_unittests, manual Change-Id: I21b83328461311033a34153efee20cf4529eae39 Reviewed-on: https://chromium-review.googlesource.com/1013333 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#550863}
-
Devlin Cronin authored
Use templates to get rid of a bunch of clutter. Bug: None Change-Id: Ib5a51a7439ae54b6f27dcc6bb0e73874c53d0471 Reviewed-on: https://chromium-review.googlesource.com/1013095 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550862}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b8f33bef55b8..adc953f927bd $ git log b8f33bef5..adc953f92 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 tandrii Remove tandrii@ from watching git cl changes. 2018-04-13 ehmaldonado git-cl: Add parallel option to git-cl land. Created with: roll-dep src/third_party/depot_tools BUG=chromium:832566 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I90fcd945d318a7d45d0e4c60e79060becd5aba9a Reviewed-on: https://chromium-review.googlesource.com/1013286Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550861}
-
Alexei Filippov authored
Change-Id: I052a9293bbdab95e8d3fc81b0847ccb824c392d0 Reviewed-on: https://chromium-review.googlesource.com/1013131 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550860}
-
Xi Cheng authored
Change-Id: I4406713382f182bf3441a9abdec2a5eae4f9d37e Reviewed-on: https://chromium-review.googlesource.com/1013086 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550859}
-
Xida Chen authored
Disabling this according to flakiness dashboard TBR=avi@chromium.org NOTRY=TRUE Bug: NONE Change-Id: I59d340f7e96b193ab41289674a7c7887856a781d Reviewed-on: https://chromium-review.googlesource.com/1013380Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550858}
-
enne authored
This reverts commit b27727ab. Reason for revert: maybe causing hangs, definitely causing cut off tiles when rotating. Bug: 832684, 832633 Original change's description: > cc: Add backpressure for speculative raster work > > This adds a limit per raster type of how many outstanding speculative > (i.e. non-required) tasks can be in flight at any given time. Not only > will the task graph not schedule more than this limit, but it will also > wait for these tasks to have been completed on the gpu service side as > well. > > Bug: 816571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iff2cbc5ecaabafa62db6a06c0e8540156bfbe22d > Reviewed-on: https://chromium-review.googlesource.com/998682 > Commit-Queue: enne <enne@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550360} TBR=enne@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816571 Change-Id: I49b618ea978bd21ac97708a68aeaebee25e7f0b0 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1012403Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#550857}
-
Wenzhao Zang authored
These strings are needed for M68. Spec: https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8 TBR=cpu@chromium.org Bug: 811619 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I37f9af3e203984f7dcdeea6eb07b5c22bf6424f0 Reviewed-on: https://chromium-review.googlesource.com/984712Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550856}
-
Ahmed Fakhry authored
The extensions browser actions badges and decorations should be positioned at the corners of the icon area, rather than the corners of the full button's area (i.e. ignoring the paddings). Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=831946#c11 BUG=831946 Change-Id: I977883a3e6127e1f91779a7e73b4adb7fa7c6471 Reviewed-on: https://chromium-review.googlesource.com/1013290Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#550855}
-