- 28 Oct, 2011 40 commits
-
-
asvitkine@chromium.org authored
This makes the drop downs on Mac and Linux match how Windows currently renders these suggestions when they include newline, tab and carriage return characters. Removes invalid characters in matches coming from extension suggestions and apps. BUG=100564 TEST=Manual per bug and added ExtensionAppProviderTest.CreateMatchSanitize KeywordProviderTest.SuggestionMatchSanitize tests. Review URL: http://codereview.chromium.org/8364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107746 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=100856 TEST=Quickly mouse through the avatar menu. The edit link doesn't flicker. Review URL: http://codereview.chromium.org/8344048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107745 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
Chromium side of WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=70065 This drops the Chromium dependency on WebIDBKey::NullType and treats it the same as WebIDBKey::InvalidType. Once this has landed, the second half of the WebKit side can go in and (finally) the default: cases herein ensuring all enumeration parameters are handled can be removed. BUG=98930 TEST= Review URL: http://codereview.chromium.org/8276023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107744 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
failing since http://crrev.com/107712. TBR=nirnimesh@chromium.org BUG=102136 Review URL: http://codereview.chromium.org/8413043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107743 0039d316-1c4b-4281-b951-d872f2087c98
-
droger@google.com authored
BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8413030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107742 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
BUG=102094 TEST=None Review URL: http://codereview.chromium.org/8413040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107741 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
BUG=102075 Review URL: http://codereview.chromium.org/8343060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107740 0039d316-1c4b-4281-b951-d872f2087c98
-
benjhayden@chromium.org authored
BUG=101162 Review URL: http://codereview.chromium.org/8418009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107739 0039d316-1c4b-4281-b951-d872f2087c98
-
leandrogracia@chromium.org authored
Analyzed the problem and tested 30+ times the affected and related tests without problems. Test failure seems to be a non-related flake. Revert 107727 - Revert 107722 - Implement notifications for the DisplayBalloon method on Linux and Mac. BUG=74970 TEST=install background app on window, see desktop notification. Review URL: http://codereview.chromium.org/8375027 TBR=leandrogracia@chromium.org Review URL: http://codereview.chromium.org/8417027 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/8414024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107738 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
We had to use SavePersistentPref() since prefs were not saved during normal shutdown. See http://crosbug.com/19491 which tracks that, now fixed. Leaving SavePersistentPrefs() in WizardController and DetermineAndSaveHardwareKeyboard since those OOBE settings are very important to be saved right away and persist even if Chrome crashes. BUG=chromium-os:20938 TEST=Manual. OOBE: switch language, reboot. Remove user, reboot. Review URL: http://codereview.chromium.org/8341105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107737 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@chromium.org authored
Depends on http://codereview.chromium.org/8247009/ BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107715 Review URL: http://codereview.chromium.org/8362006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107736 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This also wires up GetRestoredBounds(). BUG=99729 TEST=manual: less spam Review URL: http://codereview.chromium.org/8417014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107735 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
BUG=101964 TEST=When doing a user install (not system install) of chrome on a mac, make sure that the default apps are correctly installed into new profiles. Review URL: http://codereview.chromium.org/8400047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107734 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107733 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=chromium-os:22174 TEST= Review URL: http://codereview.chromium.org/8418021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107729 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@chromium.org authored
Fix BrowserThread bug. BUG=None TEST=Linux touch build succeeds. Review URL: http://codereview.chromium.org/8400062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107728 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitrao@chromium.org authored
BUG=74970 TEST=install background app on window, see desktop notification. Review URL: http://codereview.chromium.org/8375027 TBR=leandrogracia@chromium.org Review URL: http://codereview.chromium.org/8417027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107727 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107726 0039d316-1c4b-4281-b951-d872f2087c98
-
reed@google.com authored
Review URL: http://codereview.chromium.org/8416032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107725 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107724 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
BUG=None TEST=None TBR=johnnyg Review URL: http://codereview.chromium.org/8341113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107723 0039d316-1c4b-4281-b951-d872f2087c98
-
leandrogracia@chromium.org authored
BUG=74970 TEST=install background app on window, see desktop notification. Review URL: http://codereview.chromium.org/8375027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107722 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@chromium.org authored
Depends on http://codereview.chromium.org/8247009/ BUG=None TEST=None Review URL: http://codereview.chromium.org/8362006 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/8400059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107720 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=chromium-os:21147 TEST=None. Review URL: http://codereview.chromium.org/8414021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107719 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Clean-up suppressions: remove duplicates from TSan/Mac and TSan/Linux, move a bunch of suppressions to the proper places TBR=oshima BUG=93932,100143 Review URL: http://codereview.chromium.org/8341110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107717 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
R=sky@chromium.org Review URL: http://codereview.chromium.org/8413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107716 0039d316-1c4b-4281-b951-d872f2087c98
-
vollick@chromium.org authored
Depends on http://codereview.chromium.org/8247009/ BUG=None TEST=None Review URL: http://codereview.chromium.org/8362006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107715 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107714 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
BUG=None TEST=None TBR=johnnyg Review URL: http://codereview.chromium.org/8416035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107712 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=100874 TEST=Manual. Launched login screen on Aura. Review URL: http://codereview.chromium.org/8402026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107710 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
This change suppresses leaks in the SkCanvas code in the PrintPreviewUITest.LoadPrintPreviewByURL and updates a rule that is not updated by r107697 <http://crrev.com/107697>. TBR=timurrrr,glider,thestig BUG=102049,93932 TEST=make memcheck bots and TSAN bots green. Review URL: http://codereview.chromium.org/8418019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107709 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
BUG=None TEST=Existing Review URL: http://codereview.chromium.org/8396043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107708 0039d316-1c4b-4281-b951-d872f2087c98
-
mnissler@chromium.org authored
Component extensions and policy-installed extensions shouldn't be affected by the policy blacklist: The former are considered internal UI that happens to be part of an extension, and they should have first-class policy knobs if we want to disable them. For the latter, the admin specifying them is enough indication that they should be installed, and requiring them to explicitly white-listed in some cases is redundant. BUG=chromium-os:16702, chromium-os:21281 TEST=On ChromeOS, configure ExtensionInstallBlacklist = * and load chrome://bookmarks Review URL: http://codereview.chromium.org/8380006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107707 0039d316-1c4b-4281-b951-d872f2087c98
-
joaodasilva@chromium.org authored
BUG=89396 TEST=The translate features work as usual Review URL: http://codereview.chromium.org/8365033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107706 0039d316-1c4b-4281-b951-d872f2087c98
-
marja@chromium.org authored
Moving cookie-spesific logic from HostContentSettingsMap to CookieSettings. Making it explicit that the "is cookie session only" decision only depends on the primary url. Also removes the migration code for the obsolete kCookieBehavior preference. BUG=93335 TEST=CookieSettings.* Review URL: http://codereview.chromium.org/8383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107705 0039d316-1c4b-4281-b951-d872f2087c98
-
battre@chromium.org authored
If a type reflects an array of objects with specified properties, such as here "id": "HttpHeaders", "type": "array", "items": { "type": "object", "properties": {...} }, the API documentation generator would swallow the contents of "properties". The documentation would just contain the information that an array of objects is passed, without details of the keys stored in the objects. This is fixed in this CL. BUG=no TEST=no Review URL: http://codereview.chromium.org/8411001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107704 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
R=dmazzoni@chromium.org BUG=chromium-os:21760 TEST=Change the network state with a11y turned on Review URL: http://codereview.chromium.org/8402023 TBR=zork@chromium.org Review URL: http://codereview.chromium.org/8400057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107702 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107701 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@chromium.org authored
BUG=None TEST=None TBR=johnnyg Review URL: http://codereview.chromium.org/8343055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107700 0039d316-1c4b-4281-b951-d872f2087c98
-