- 06 Jun, 2019 40 commits
-
-
Hiroki Nakagawa authored
This CL enables PlzDedicatedWorker for following tests: - fast/workers - wpt/referrer-policy/ Bug: 971173 Change-Id: I2d53323a8c73b9c695b525725c883928459a5896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647499Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#666605}
-
Jay Harris authored
In future, this will allow applications to query information about how they were launched. Currently, the promise is hard coded to resolve to { cause: 'default', files: [] }. The mojom security review requires that new services be as complete as possible, hence the stubbing that is going on here https://chromium.googlesource.com/chromium/src/+/master/docs/security/mojo.md#Do-not-define-unused-or-unimplemented-things (a previous CL was rejected due to having an incomplete mojo service: https://chromium-review.googlesource.com/c/chromium/src/+/1597516). This CL is a part of file-handling https://github.com/WICG/file-handling/blob/master/EXPLAINER.md Bug: 829689 Change-Id: I03d07d47b5b4c29d8367f465a34e439262e37dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621418Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#666604}
-
Antoine Labour authored
Bug: 969201 Change-Id: I3f827c60721cbccbf0b318fea9b4d90b644e2ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639541 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666603}
-
François Degros authored
Bug: 778674 Change-Id: I7e9586b21be4db311fadd06b2fbd457daf9711b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647498 Commit-Queue: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666602}
-
François Degros authored
Used const/let instead of var. Passed to ExitParser's constructor an object that actually implements the expected interface MetadataParserLogger. Bug: 778674 Change-Id: I788216a1cd835808550e5031ed96837e2f379786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647497Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53391a59f797..2e4a2c7e255e git log 53391a59f797..2e4a2c7e255e --date=short --no-merges --format='%ad %ae %s' 2019-06-06 dberris@chromium.org SheriffRedux: Vendor requests-toolbelt 2019-06-06 dberris@chromium.org SheriffRedux: Vendor requests library Created with: gclient setdep -r src/third_party/catapult@2e4a2c7e255e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:953181 TBR=skyostil@google.com Change-Id: I618424659ce7dea2f9614df6c4b3de468ef02b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666600}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I850dae0aa824b12a07d9b74be41b2bc74e8227df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646542Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#666599}
-
Xianzhu Wang authored
Now force windows editing behavior. TBR=xiaochengh@chromium.org Bug: 966731 Change-Id: I8af3aa3ae0744e6e2a650002eae47fc77b6f88fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646889Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666598}
-
Peter Kotwicz authored
This CL: - Introduces generation of R.color.background_color from the JSON config via mustache - Renames manifest_mustache_pass to mustache_pass BUG=969591 Change-Id: Ic434dc69673dfab19559c59894a3686db58b4e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644752 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666597}
-
Yoichi Osato authored
This patch rename the mojo function and related functions to avoid mixing up/down flow controls. Bug: 967524 Change-Id: I423fa153a410862654ef12d5a68bc9a83dd7b92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644912Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#666596}
-
Leon Han authored
This CL lets ServiceWorkerGlobalScope rely on ServiceWorkerGlobalScopeProxy rather than ServiceWorkerGlobalScopeClient to call WebServiceWorkerContextClient functions, then we remove ServiceWorkerGlobalScopeClient completely. BUG=931142,920854 Change-Id: I9f952b95af1e7d00c1cc9dead1d7c45322a20964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643047 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#666595}
-
Manuel Rego Casasnovas authored
In r666210 we fixed the dimensions of <select> elements with size containment. However the fix was not covering the case when you set "contain: size" to an already existent <select> element. To fix this we need to reset the options width in LayoutMenuList::UpdateOptionsWidth(). BUG=966673 TEST=external/wpt/css/css-contain/contain-size-select-002.html Change-Id: I162134ff050d64e9ff1d824b5747adafb9a993c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647152Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#666594}
-
Sammie Quon authored
This happens for mirrors because we only scale by x for both x and y dimensions, so some windows (ones with insets) that don't scale the same way on the two axes end up having a transparent zone underneath. Also, for WindowPreviewView the view is shifted after the above is fixed. It's because the top inset is used in calculations, but is already taken care of in WindowMirrorView. Test: manual Bug: 962893 Change-Id: Idd2e4676be10de0306aefc7fb112db3a01d9bf1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647138 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#666593}
-
Miyoung Shin authored
This is a part of moving media recorder implementation to blink. This CL moves content/renderer/media_recorder/audio_track_* files to blink and replaces some implementation with blink variant. - std::vector -> blink::Vector - base::Thread -> blink::Thread - main_render_thread_checker_ -> IsMainThread() - base::BindOnce, base::Bind -> WTF::Bind, WTF::BindRepeating - base::RefCountedThreadSafe -> WTF::ThreadSafeRefCounted - Remove base::test::ScopedTaskEnvironment Bug: 960665 Change-Id: I3465f79d8fe052408f2367894c1675dc9025a56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637025 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#666592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e86e1fed26da..0a406538f2fc Created with: gclient setdep -r src-internal@0a406538f2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I305d1ffdb5010ee5b1dab0c63d1b061728da3784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647576Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666591}
-
Darren Shen authored
In a previous patch we moved //ash/keyboard/ui/OWNERS to //ash/keyboard/OWNERS, but forgot to update other files that pointed to the old path. Bug: 961568 Change-Id: I7d800c56ac4f1010a22912985c45534977173d29 No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647072 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#666590}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d71ff5db15ed..53391a59f797 git log d71ff5db15ed..53391a59f797 --date=short --no-merges --format='%ad %ae %s' 2019-06-06 dberris@chromium.org SheriffRedux: Vendor google-auth 2019-06-05 crouleau@chromium.org Revert "Fix media video playback metrics." Created with: gclient setdep -r src/third_party/catapult@53391a59f797 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181,chromium:971441,chromium:965682 TBR=skyostil@google.com Change-Id: I06b3040a003d3658f53b5f733be8dda8951d76bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647459Reviewed-by:
-
Eric Willigers authored
When a web page is downloaded in Android, and then shared using WebShare, the "file name" reported to WebShare starts with "https://". This patch allows such files to be shared. Bug: 965461 Change-Id: If1922c81ade874bb7b8be06d88361e10b2db248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624525Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#666588}
-
Takuto Ikuta authored
I intended to make CQ builderless instead of CI in https://chromium-review.googlesource.com/c/chromium/src/+/1645452 Bug: 954450 Change-Id: I27d546b8ce8e619915133c66e08203f80ee167d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647635 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#666587}
-
Suman Nelson Kancherla authored
testNfcFiresVrdisplayactivate() - fixed by adding the automatic consent dialog handling code. testPresentationPromiseRejectedIfDonCanceled_WebXr() - fixed by specifying --shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_don_setupcomplete.json For the second test, the shared-prefs must be updated on the swarm bots to avoid getting into a regression. Bug: 969024 Change-Id: Iaf88f9c202746eca32f7d8386c852eec43824757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645633 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#666586}
-
Gyuyoung Kim authored
As a third step to deprecate WTF::CString, the bug makes String::Ascii() return std::string. So, all uses of Ascii().data() are replaced with Ascii().c_str() through this CL. Then, all callers of String::Ascii are changed to use std::string instead of WTF::CString. Bug: 950077 Change-Id: I786f958535b2fda4b21a709d2a4b37fa7902f0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640149Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#666585}
-
Ryan Hamilton authored
actual write data in QUIC tests. Adds a new SocketDataPrinter interface to socket_utils.h which can be used to pretty print socket data. Bug: 966534 Change-Id: I8d48f7bc90ed583a311e0696730359ec2d5557e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637450 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#666584}
-
Findit authored
This reverts commit e02ed63a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 666371 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UwMmVkNjNhMTJjZWYwNzU0MDlkN2VlNzc5MWZiOWZlMmJlOTY5YjMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/17261 Sample Failed Step: viz_unittests Original change's description: > Roll src/third_party/skia 9893f8e15152..95253bd0acff (7 commits) > > https://skia.googlesource.com/skia.git/+log/9893f8e15152..95253bd0acff > > > git log 9893f8e15152..95253bd0acff --date=short --no-merges --format='%ad %ae %s' > 2019-06-05 brianosman@google.com Fix SkSL standalone compile errors > 2019-06-05 michaelludwig@google.com Combine GrPerspQuad and GrQuad > 2019-06-05 egdaniel@google.com Move readSurfacePixels and writePixelSurface into GrSurfaceContext. > 2019-06-05 mtklein@google.com Revert "print 1/K floats as fractions" > 2019-06-05 robertphillips@google.com Revise GrDataUtils to be more self-contained > 2019-06-05 jvanverth@google.com Add GrCFResource::reset() to allow Chrome to transition to sk_cf_obj. > 2019-06-05 bsalomon@google.com Add API to invalidate GL texture parameters from GrBackendTexture. > > > Created with: > gclient setdep -r src/third_party/skia@95253bd0acff > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jcgregorio@google.com > > Change-Id: I61fa5725388d3e7d9a6cfcab6f5804ec1dc8bcc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645258 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#666371} No-Presubmit: true No-Tree-Checks: true No-Try: true CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id6b01f5443bfd84d8c177457eeb4db40cd686792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647177 Cr-Commit-Position: refs/heads/master@{#666583}
-
Christopher Lam authored
This CL enables the System Web App Manager by default, which will install Settings as a System Web App, and make Discover and OS Settings use System Web Apps if their respective flags are enabled. The fallout from enabling this is that all tests that are interested in the Settings Window on ChromeOS must call InstallSystemWebAppsForTesting. Bug: 948298, 836128 Change-Id: Ia5e4aab86665c968f181601a61a6722b15d77dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556816Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#666582}
-
Renjie authored
The root cause is not clear yet, so the action we are taking right now is to bypass the crash and check at different places for possible causes of crash. The status of the session is checked and logged. The status of stale host resolution result is also checked and logged. Change-Id: I8408ed89dc2187adf20990b86f85ad246d7e4e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643496Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#666581}
-
Kinuko Yasuda authored
This reverts commit 1fc6dcec. Reason for revert: In order to revert the culprit CL for MSAn failure (see https://chromium-review.googlesource.com/c/chromium/src/+/1647177) Original change's description: > Roll src/third_party/skia 95253bd0acff..928b2997b301 (9 commits) > > https://skia.googlesource.com/skia.git/+log/95253bd0acff..928b2997b301 > > > git log 95253bd0acff..928b2997b301 --date=short --no-merges --format='%ad %ae %s' > 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). > 2019-06-05 egdaniel@google.com Revert "Remove support for copyAsDraw in gpu copySurface." > 2019-06-05 bsalomon@google.com Use 1e-4 rather than 1e-5 as "nonZeroAlpha" in various shader code. > 2019-06-05 egdaniel@google.com Remove support for copyAsDraw in gpu copySurface. > 2019-06-05 mtklein@google.com hoist loop-invariant code out of the loop > 2019-06-05 egdaniel@google.com Make feature structs on GrVkBackendContext const. > 2019-06-05 halcanary@google.com SkPDF: clean up image shader code > 2019-06-05 bsalomon@google.com GrShaderCaps always stores config texture swizzles. > 2019-06-05 brianosman@google.com Remove unused "DropsTileOnZeroDivide" caps bit > > > Created with: > gclient setdep -r src/third_party/skia@928b2997b301 > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jcgregorio@google.com > > Change-Id: Ibe7c817c11483b9b9c88c2b63ecd213be50b7234 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644764 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#666414} TBR=jcgregorio@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I26b8bee6d7cf85f9e5578c9f5987e08d45df970b No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647634Reviewed-by:
-
Kinuko Yasuda authored
This reverts commit 3eaeef45. Reason for revert: In order to revert the culprit CL for MSAn failure (see https://chromium-review.googlesource.com/c/chromium/src/+/1647177) Original change's description: > Roll src/third_party/skia 928b2997b301..e0d90c84e42f (2 commits) > > https://skia.googlesource.com/skia.git/+log/928b2997b301..e0d90c84e42f > > > git log 928b2997b301..e0d90c84e42f --date=short --no-merges --format='%ad %ae %s' > 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). > 2019-06-05 csmartdalton@google.com ccpr: Preserve fill rules for cached paths > > > Created with: > gclient setdep -r src/third_party/skia@e0d90c84e42f > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jcgregorio@google.com > > Change-Id: Ia5abd88548b6d0b3d8af4f521e622148af60820c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644926 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#666462} TBR=jcgregorio@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Ibaf0abbf60add357cf872c25d9a9a11d0f3cdccc No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647495Reviewed-by:
-
Jasmine Chen authored
This CL fixes sync_wait() usage in VCD request manager. sync_wait() returns 0 when the wait is successful. !sync_wait() is true when the wait operation is successful. BUG=None TEST=Recompiled and redeployed Chrome. Change-Id: I6737b039e0c2c7fcfd5a685784a5bc026b3d18ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638209Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Auto-Submit: Jasmine Chen <lnishan@google.com> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#666578}
-
Xiaocheng Hu authored
When a block ends with <br>, |NextWordPositionInternal| used to return BR@AfterNode as the next word position of BR@BeforeNode. This is incorrect as there's no visible position after a block's trailing BR, and therefore the caret ends up not moved. This patch detects this case and moves to the next block if we have reached the end of a block that ends with a BR. Bug: 968334 Change-Id: I277821ef5e85f54e080047750d1c54f68c4f4120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642035 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666577}
-
Kinuko Yasuda authored
This reverts commit 25552431. Reason for revert: In order to revert the culprit CL for MSAn failure (see https://chromium-review.googlesource.com/c/chromium/src/+/1647177) Original change's description: > Roll src/third_party/skia e0d90c84e42f..6b43c30cd702 (3 commits) > > https://skia.googlesource.com/skia.git/+log/e0d90c84e42f..6b43c30cd702 > > > git log e0d90c84e42f..6b43c30cd702 --date=short --no-merges --format='%ad %ae %s' > 2019-06-05 mtklein@google.com add mad_unorm8 instruction > 2019-06-05 mtklein@google.com use u32 in mul_unorm8 > 2019-06-05 mtklein@google.com tidy up register allocation > > > Created with: > gclient setdep -r src/third_party/skia@6b43c30cd702 > > The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jcgregorio@google.com > > Change-Id: Ieb1d0f381d488539549978a12e36fb9012d3c083 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646895 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#666516} TBR=jcgregorio@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I0602aef6efe5a1810c37ec7b053628601c69df87 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646799Reviewed-by:
-
Takuto Ikuta authored
bots adding CL is https://chrome-internal-review.googlesource.com/c/infradata/config/+/1362351 Bug: 954450 Change-Id: Iabc0c3f2aaecde421e6c25afd88e6e9525d3be8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645452Reviewed-by:
-
Chih-Yu Huang authored
This CL implements V4L2SliceVideoDecoder, which is aimed to replace V4L2SliceVideoDecodeAccelerator. BUG=941330 TEST=Run video_decode_accelerator_tests with local change Change-Id: Ib2ec460bf63bcc3c7c0e0b5ab200ca60a7f1cf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519907Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Ting Shao authored
Extend FakeNetworkURLLoaderFactory by making response headers, body and completion status configurable. Bug: 648295 Change-Id: Ib033ab617fb8efba8d3d81c9ea5651801a60a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595656 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#666573}
-
tby authored
For some upcoming logging, we want to log some data most easily available from ash. However, we'd also like to log the subtype (history, bookmark, etc.) of an Omnibox search result. This is currently exposed via ChromeSearchResult::GetSubType. This CL replaces that, moving the data into ash::SearchResultMetadata, so that it's also exposed in ash and available for logging. Bug: 931149 Change-Id: Ieea7461e2f50a0c3503862bd73d03f4ad0b8cfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642909 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666572}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c84b2216ee6c..e86e1fed26da Created with: gclient setdep -r src-internal@e86e1fed26da The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=xidachen@google.com,gayane@google.com,calamity@google.com,kinuko@google.com Change-Id: I348d95585c7561dce6a86ff83bfc9457cd959ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647458Reviewed-by:
-
Jihwan Marc Kim authored
So far, scroll-margin-*, scroll-margin-block-*, scroll-margin-inline-* are defined as simple length property in |IsSimpleLengthPropertyID|. But scroll-margin should not accept percentages, therefore these properties are removed from simple length property. https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-margin https://drafts.csswg.org/css-scroll-snap-1/#propdef-scroll-margin-block The properties are only supported by Blink and Firefox, and Firefox already correctly rejects percentages: https://wpt.fyi/results/css/css-scroll-snap/parsing Bug: 930517 Change-Id: Iaf7286552a8b352c2901a42b8fadc83ce79c9077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640259 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#666570}
-
Sam McNally authored
Background pages must be non-persistent for extensions with this permission. Bug: 967262 Change-Id: Ice9f3070f98455c171123701ebacab5652141637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630377 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#666569}
-
Sam McNally authored
The natively_connectable field is an allow-list for native messaging hosts allowed to initiate a native messaging connection to the extension. The native messaging host must still list the extension's origin in its allowed_origins manifest field for a connection to be allowed. Bug: 967262 Change-Id: Icddddcad8acc68d8169d82209736f93783dfaf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630074 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change file list and file grid view to announce file selection changes when triggered by user input (keyboard, mouse and tap). The following actions are announced on selection changes, via aria-live: 1. Selecting a single file entry. 2. Selecting a range of file entires. 3. Adding a file entry to the current selection. 4. Removing a file entry from the current selection. 5. Selecting all file entries. 6. Deselecting all files entries. Add i18n translation support for these messages. Change ToolbarController, FileGrid and FileTable to receive an {A11yAnnounce} implementation to be able to send aria-live messages. Add getItemLabel to FileGrid, FileTable and FileTableList to be able to retrieve item's label based on the selection index to be able to add the item name/label to the aria message. Change test util RemoteCall.waitAndClickElement to accept modifier keys so we can send Ctrl and Shift modifiers for testing multiple file entry selection in FilesApp integration test. While here, change == and != to === and !==. Also call the constructor |super| instead of "cr.ui.table.TableList.prototype.mergeItems.call". NOTE: Add tests only for Keyboard and Mouse for now, because the touch emulation event isn't triggering file selections yet. Test: browser_tests --gtest_filter="*KeyboardSelectionA11y* : *MouseSelectionA11y*" Bug: 888636 Change-Id: I1bfdcf3987a7bcf8d29bfce6468c3b109f5fb239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638299 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#666567}
-
Marijn Kruisselbrink authored
Permissions are still auto-granted, but this at least hooks up the various mojo exposed operations to check for read or write access. Bug: 878585 Change-Id: I99cfde0451adc87f39ae8314881d0671dd06a168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636399 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#666566}
-
