- 17 Sep, 2019 40 commits
-
-
Nick Burris authored
Ensure a match is bounded by word boundaries. This implementation uses a similar approach to providing FindOptions::kWholeWord to FindBuffer::FindMatchInRange, however that option requires the search text to be a single word. Added tests and a web platform test case. Bug: 924965 Change-Id: Iaa6785181eb29f0d25f64026c3be05d095ace3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803723 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697244}
-
Etienne Bergeron authored
This CL has main goal to remove calls to the FontLink (GDI) fallback fonts. ShapeRuns is trying to find fonts to shape runs. There are cases where the runs are grouped together but they can be rendered with different fonts. Previously, we were trying to determine the fallback font based on the text of the first run, which is arbitrary. We observed cases where this is not true. As an example: // The following text will be split in 3 runs: // 1) u+1F3F3 u+FE0F u+FE0F (Segoe UI Emoji) // 2) u+0020 (Segoe UI) // 3) u+1F308 u+20E0 u+20E0 (Segoe UI Symbol) The current CL is adding a loop around GetFallback(...) to find the corresponding fallback font for each run using the fast fallback mechanism. We believe this may deprecate the usage of the FontLink code. R=robliao@chromium.org,asvitkine@chromium.org CC=drott@chromium.org Bug: 995789 Change-Id: Iced98fa37f20832d7c86c107472e9fb84ec9d277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789844Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697243}
-
Alex Ilin authored
Reason for reland: Changes were made to preserve compatibility with the old version of mojo library. Original change's description: > Remove use of deprecated SharedMemory in chromeos/wilco_dtc_supportd > > Remove use of the deprecated class SharedMemory. Instead use > the new classes: {Write,ReadOnly}SharedMemory{Region,Mapping}. > > The previous code was wrapping the shared memory inside a mojo > handle. Instead, pass directly the ReadOnlySharedMemory to mojo, > this is the preferred way. > > See Chromium Shared Memory Refactor design doc for more details: > https://docs.google.com/document/d/1lk2-7W7Cy7FDqG-6lgS8LRkzXABYTOytf6VUsWNf8-0/edit#heading=h.7nki9mck5t64 > > Bug: 795291 > Change-Id: I7ee031baf80533dac064fc779e31c40fc0eb202f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566307 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Polina Bondarenko <pbond@chromium.org> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667164} Bug: 989503 Change-Id: I42079902caf9ad730e15f8c58d9d834f2dbf0174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729225Reviewed-by:Oleh Lamzin <lamzin@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#697242}
-
Mark Cogan authored
TabStripController relies on -dalloc to stop its various WebStateList observations. If the WebStateList is destroyed before the dealloc runs, the non-empty observer DCHECKs are hit. The upcoming change to WebStateList ownership (see crrev.com/c/1796358) will cause this to happen, for example. To fix this, an explicit -disconnect method is added to TabStripController, and the tab strip coordinator calls it from -stop. Change-Id: I22c2fc967c0b42c544ab93dce17518e93d272f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809298 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#697241}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/747b3409bc2d..a90382fcf675 git log 747b3409bc2d..a90382fcf675 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 bsalomon@google.com Pass color types when creating texture with initial data. Created with: gclient setdep -r src/third_party/skia@a90382fcf675 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I5695816bc3b74c8d6e60890445e8ee69795d501b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697240}
-
Miyoung Shin authored
This CL converts MtpManagerClient{AssociatedPtr, AssociatedPtrInfo} in services and components to the new Mojo type, and uses pending_associated_remote<MtpManagerClient> in mtp_manager.mojom. Bug: 955171 Change-Id: I6fb7561d42ea5dcf6bf6988a0e1d910599202fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804713 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697239}
-
Tim van der Lippe authored
ES modules allow files to explicitly import and export symbols [1]. This patch migrates ARIAUtils.js to an ES module, while maintaining backwards compatibility with existing usages of `window.UI.ARIAUtils`. The build system is updated to copy these modules verbatim, as it no longer require pre-processing to be loaded. The `module.json` no longer includes this file as a script, to make sure it is not double-bundled into `shell.js`. Instead, it is added to the new field `modules`, which contains all modules. By doing so, it becomes clear which files are converted to modules already and which require the legacy references to the global scope. This module and future modules will be imported from `root.js`, which is added to all existing HTML application files. Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import TBR=jochen@chromium.org Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Cr-Commit-Position: refs/heads/master@{#697238}
-
Mohamed Amir Yosef authored
Those member fields are leftovers from earlier implementations that are not needed anymore. Instead we should query the FormFetcher. Change-Id: I76a367c332257dd152cf4d3ec9b18b5f150105a9 Bug: 1004783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809302Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#697237}
-
Randy Rossi authored
This feature flag alters chromecast's handling of gestures that originate from the edges of the screne. When enabled, it is assumed an external side swipe gesture detector is installed handling touch events downstream. The touch exploration controller enters pass through mode when touch events originate from the screen edges. The side swipe detector is also not installed. Bug: None Test: Manual, display assistant Change-Id: I23d35a322c09933fde3ac6989a90a692fb40e221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793249Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697236}
-
sczs authored
Bug: 1004604 Change-Id: If571592b94f7505f1111cd957c3f73950b6060c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808380 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697235}
-
Alex Clarke authored
This web_test occasionally flakes, e.g.: https://test-results.appspot.com/data/layout_results/win10_chromium_x64_rel_ng/366664/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html What's happening is depending on the task order test_runner::WebWidgetTestProxy::AnimateNow sometimes triggers this call stack: 0x7f987bf9bfea blink::MediaControlsImpl::NotifyElementSizeChanged()\n 0x7f987bfa7725 blink::MediaControlsImpl::MediaControlsResizeObserverDelegate::OnResize()\n 0x7f988685877e blink::ResizeObserver::DeliverObservations()\n 0x7f9886867879 blink::ResizeObserverController::DeliverObservations()\n 0x7f98858e0ce6 blink::LocalFrameView::NotifyResizeObservers()\n 0x7f98858ecda9 blink::LocalFrameView::RunStyleAndLayoutLifecyclePhases()::$_8::operator()()\n 0x7f98858e316f blink::LocalFrameView::ForAllNonThrottledLocalFrameViews<>()\n 0x7f98858e1dc0 blink::LocalFrameView::RunStyleAndLayoutLifecyclePhases()\n 0x7f98858e13e1 blink::LocalFrameView::UpdateLifecyclePhasesInternal()\n 0x7f98858e0572 blink::LocalFrameView::UpdateLifecyclePhases()\n 0x7f98858e0068 blink::LocalFrameView::UpdateAllLifecyclePhases()\n 0x7f988660b211 blink::PageAnimator::UpdateAllLifecyclePhases()\n 0x7f9886611a26 blink::PageWidgetDelegate::UpdateLifecycle()\n 0x7f988572bf8d blink::WebViewImpl::UpdateLifecycle()\n 0x7f98859d3842 blink::WebViewFrameWidget::UpdateLifecycle()\n 0x7f989a34bf28 content::RenderWidget::UpdateVisualState()\n 0x7f989a06c440 content::LayerTreeView::UpdateLayerTreeHost()\n 0x7f989266f40d cc::LayerTreeHost::RequestMainFrameUpdate()\n 0x7f98927814a5 cc::SingleThreadProxy::DoBeginMainFrame()\n 0x7f9892781118 cc::SingleThreadProxy::CompositeImmediately()\n 0x7f9892672cdf cc::LayerTreeHost::Composite()\n 0x7f98785c21f1 test_runner::DoComposite()\n 0x7f98785c1ff9 test_runner::WebWidgetTestProxy::SynchronouslyComposite()\n 0x7f98785c1b3d test_runner::WebWidgetTestProxy::AnimateNow()\n 0x7f98785c28a5 base::internal::FunctorTraits<>::Invoke<>()\n 0x7f98785c2787 base::internal::InvokeHelper<>::MakeItSo<>()\n 0x7f98785c26f2 _ZN4base8internal7InvokerINS0_9BindStateIMN11test_runner18WebWidgetTestProxyEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE\n 0x7f98785c2639 base::internal::Invoker<>::RunOnce()\n 0x7f989d879a3e _ZNO4base12OnceCallbackIFvvEE3RunEv\n 0x7f989da24ac8 base::TaskAnnotator::RunTask()\n 0x7f989da758b4 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()\n 0x7f989da7510b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f989da75bfc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f989d92bbad base::MessagePumpDefault::Run()\n 0x7f989da766c9 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()\n 0x7f989d9bac31 base::RunLoop::Run()\n 0x7f989a381332 content::RendererMain()\n 0x7f989a7c4a80 content::RunZygote()\n 0x7f989a7c4e87 content::RunOtherNamedProcessTypeMain()\n 0x7f989a7c5c0d content::ContentMainRunnerImpl::Run()\n 0x7f989a7c1988 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()\n 0x7f9869d1f74e service_manager::Main()\n 0x7f989a7c4893 content::ContentMain()\n 0x55736df1817a main\n 0x7f9871e3952b __libc_start_main\n 0x55736df1802a _start\n That seems fine by itself and it posts a task to run MediaControlsImpl::ElementSizeChangedTimerFired. The problem happens if something removes the video node before the task posts. If that does happen we get this CHECK failure: ERR: [203657:1:0911/141243.637908:FATAL:media_control_slider_element.cc(105)] Check failed: track. \n 0x7f2a964dddbf base::debug::CollectStackTrace()\n 0x7f2a96212c0d base::debug::StackTrace::StackTrace()\n 0x7f2a96212bc8 base::debug::StackTrace::StackTrace()\n 0x7f2a96264629 logging::LogMessage::~LogMessage()\n 0x7f2a748dd9cb blink::MediaControlSliderElement::GetTrackElement()\n 0x7f2a748de145 blink::MediaControlSliderElement::TrackWidth()\n 0x7f2a748dddfb blink::MediaControlSliderElement::SetBeforeSegmentPosition()\n 0x7f2a748e31ec blink::MediaControlTimelineElement::RenderBarSegments()\n 0x7f2a748ebfca blink::MediaControlsImpl::ElementSizeChangedTimerFired()\n 0x7f2a748fa839 blink::TaskRunnerTimer<>::Fired()\n 0x7f2a78c6c719 blink::TimerBase::RunInternal()\n 0x7f2a78c6d405 base::internal::FunctorTraits<>::Invoke<>()\n 0x7f2a78c6d2e7 base::internal::InvokeHelper<>::MakeItSo<>()\n 0x7f2a78c6d252 _ZN4base8internal7InvokerINS0_9BindStateIMN5blink9TimerBaseEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE\n 0x7f2a78c6d199 base::internal::Invoker<>::RunOnce()\n 0x7f2a78635e6e _ZNO4base12OnceCallbackIFvvEE3RunEv\n 0x7f2a786b91fd WTF::ThreadCheckingCallbackWrapper<>::RunInternal()\n 0x7f2a786b7af0 WTF::ThreadCheckingCallbackWrapper<>::Run()\n 0x7f2a786b8955 base::internal::FunctorTraits<>::Invoke<>()\n 0x7f2a786b8861 base::internal::InvokeHelper<>::MakeItSo<>()\n 0x7f2a786b87e2 _ZN4base8internal7InvokerINS0_9BindStateIMN3WTF29ThreadCheckingCallbackWrapperINS_12OnceCallbackIFvvEEES6_EEFvvEJNSt4__Cr10unique_ptrIS8_NSB_14default_deleteIS8_EEEEEEES6_E7RunImplISA_NSB_5tupleIJSF_EEEJLm0EEEEvOT_OT0_NSB_16integer_sequenceImJXspT1_EEEE\n 0x7f2a786b8729 base::internal::Invoker<>::RunOnce()\n 0x7f2a961d2a3e _ZNO4base12OnceCallbackIFvvEE3RunEv\n 0x7f2a9637dac8 base::TaskAnnotator::RunTask()\n 0x7f2a963ce8b4 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()\n 0x7f2a963ce10b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f2a963cebfc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoSomeWork()\n 0x7f2a96284bad base::MessagePumpDefault::Run()\n 0x7f2a963cf6c9 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()\n 0x7f2a96313c31 base::RunLoop::Run()\n 0x7f2a92cda332 content::RendererMain()\n 0x7f2a9311da80 content::RunZygote()\n 0x7f2a9311de87 content::RunOtherNamedProcessTypeMain()\n 0x7f2a9311ec0d content::ContentMainRunnerImpl::Run()\n 0x7f2a9311a988 content::ContentServiceManagerMainDelegate::RunEmbedderProcess()\n 0x7f2a6267674e service_manager::Main()\n 0x7f2a9311d893 content::ContentMain()\n 0x55fb45a7517a main\n 0x7f2a6a79052b __libc_start_main\n 0x55fb45a7502a _start\n This patch fixes that by adding a check to MediaControlsImpl::ElementSizeChangedTimerFired to ensure the MediaElement is still connected. NB these flakes get worse with a planned scheduler change where we want to prioritize loading and cmpositing tasks till FCP. BUG: 971191 Change-Id: I5725c013f8fa98e9cc8a36f634b34c033b15b19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800768Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697234}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/263def0ec958..e7a75776335a git log 263def0ec958..e7a75776335a --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Merge "Add producer for Perfetto Java Heap Profiler." 2019-09-17 fmayer@google.com Add libtinfo5 to sandbox container. Created with: gclient setdep -r src/third_party/perfetto@e7a75776335a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I4b38ae7c7eade1a38cc3cd9ce870ef9d742cd0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808590Reviewed-by:
-
Aaron Leventhal authored
When a <label> changes, Blink uses PostNotification() for the name change on the element pointed to, but DeferTreeUpdate() for the contents of the label element itself. Therefore, the updates can occur at slightly different times. Bug: 1000965 Change-Id: I9d20da6f205c21aeb93e3237009fa905233ad1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803595 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697232}
-
Khushal authored
R=rsesek@chromium.org Bug: 1004559 Change-Id: Ibe9b02724f45b2cf92f5e8a9f8c40ac933a73029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808068 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#697231}
-
Sam Maier authored
These are DoNotInline equivalents, explicitly there to prevent verification failures. Bug: 998231 Change-Id: Idd4c030583eb39c99549a098697339ac11d6dc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775237Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#697230}
-
Tao Bai authored
Add IsExtensionUrl() in PageLoadMetricsEmbedderInterface, so we can decouple extension from page_load_metrics implementation. Bug: 995880 Change-Id: If4255915154302d852281af35bde3bbaf135f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799030 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#697229}
-
Jared Saul authored
Bug: 932818 Change-Id: I231712b7bf5b65374e822e098f9bc6d0cc35614b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807260Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#697228}
-
Xida Chen authored
These two tests already have corresponding tests in wpt, this CL just adds some cases that are not yet covered under wpt. We still keep the prefixed tests to ensure coverage. Tested on both Chrome and Firefox, and they both pass the newly added test cases. Bug: 900581 Change-Id: Ic7ef80eb8d29179080d669b20279b59937c51960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805860Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697227}
-
Alex Turner authored
Adds a NetworkIsolationKey to the requests so that they are still cached when the split cache config is enabled. We set the is_trusted param for a URLLoaderFactory in a safe browsing or system network context as it was previously left unset. Bug: 1003883 Change-Id: I6e93980c6034b11e11b6ab2a0620b377c6c8caa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803873Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
-
Tanisha Mandre authored
Fixes a bug introduced in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1699806 - Add flag check to for the 'Add Payment Method' button in the settings menu. - Make only delete button visible when the flag is disabled. Bug:1004349 Change-Id: Ibd31535a21fe2bd78ba3e06e78467f8048cea1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807353Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Oleg Davydov authored
Methods and initializations which make sense only for extensions tests moved from generic PolicyTest (int policy_test_util.h) to special ExtensionPolicyTest in extension_policy_browsertest.cc. Note that some tests in policy_browsertest.cc use extensions but don't test extension-related policies, so PolicyTest::LoadUpackedExtension remained in PolicyTest. Bug: 1002483 Change-Id: Ia5a0114bb1c2b8b1240cf41ad8e2c977418efe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807219 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697224}
-
Dave Tapuska authored
Check IsAttached() in places where JS events fire. Some GetDocument() checks become redundant since we can't have a null document on an attached frame. BUG=907125 Change-Id: Ia34a65fb71cbd7da16664880998f9054e7fbc726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801735 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#697223}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. All of //chrome/android/java now uses proxy natives except for some classes that require test refactoring prior to conversion. Bug: 929661 Change-Id: Ic3719b3ba688314ccd9527aacc722d4d31d2eb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807062 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a822f4b3c64..e1b777717bc9 git log 4a822f4b3c64..e1b777717bc9 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 srte@webrtc.org Removing deprecated min_pacing_rate alias in StreamsConfig. Created with: gclient setdep -r src/third_party/webrtc@e1b777717bc9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I87564a2436bdf1b03fd396d8d9c309f373949819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808548Reviewed-by:
-
Aaron Krajeski authored
We recently removed logic that used CPU resources for small canvases and instead are using GPU-accelerated canvases, regardless of size. It looks as though this change is causing some crashes in webview, temporarily re-add that logic for webview while a more robust fix is in the works. Bug: 994310 Change-Id: I5efbbd9ae783e2c41c9c2c6246234ba3d513e24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800346Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697220}
-
Miyoung Shin authored
This CL converts MtpManager{Ptr, Request} in services and components to the new Mojo type. Bug: 955171 Change-Id: Iac8e22b1b2b40b3c8417fe3b66628626b349b287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806167Reviewed-by: -
Manu Cornet authored
The crash happens when the display width is less than about 210 pixels, and one clicks on the overflow button. Add a test to prevent future regressions. Bug: 977043 Change-Id: I8d1fa02eee829bf4ca0d45000b66842dcd2e65a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808378Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697218}
-
Lei Zhang authored
- Mark parameters const for SetAccessibilityViewportInfo() and SetAccessibilityDocInfo(). - Fix lint errors. Change-Id: I2d54ac4e4b04acb20b7b86767534b30bfba8541e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794502 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#697217}
-
Niels Möller authored
Intended to enable landing of https://webrtc-review.googlesource.com/c/src/+/153180 Bug: webrtc:8733 Change-Id: If4eccd18aca2ad76d35beb6f8a492797bb1dc5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808841Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#697216}
-
Javier Ernesto Flores Robles authored
Bug: 1001409 Change-Id: I2c97c64a9fded5935dda6142d0be18b00bef230f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803444Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#697215}
-
Nazerke authored
Link for settings in the 'turn on sync' page is wrong blue. This CL sets the kBlueColor dynamic color as a link color, according to the dark mode theme. Bug: 1004685 Change-Id: I6be3e299055dda213a8854cf03f6a6d119d59acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809297Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#697214}
-
Mikel Astiz authored
BUG=1004762 TBR=finnur@chromium.org Change-Id: If7a436a68552104df92e77803c7326b695023929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808844Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697213}
-
Xida Chen authored
This test is an interpolation test, and that should be reflected in the name. This CL change the name of the file. Bug: 900581 Change-Id: Icb9585dfc8454576a4659d52dbbb08268fc2719b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805503Reviewed-by:
-
Jasper Chapman-Black authored
Replace the two-column view for milestone vs canary builds with a one-column view with a toggle for selecting milestone vs canary comparisons. Also enforce certain conditions (mainly: diff-against version must precede original version) Bug: 1001775 Change-Id: Ie2f9b61b93e839898968d586b364883cbfa6c116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807070Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d545bfbb94ca..747b3409bc2d git log d545bfbb94ca..747b3409bc2d --date=short --no-merges --format='%ad %ae %s' 2019-09-17 bsalomon@google.com Fix bug where coverage on interior of stroked rects is applied twice Created with: gclient setdep -r src/third_party/skia@747b3409bc2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I8d7e52296f5bf73de70e4b6607dcb809557750e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808550Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6ca32387e704..263def0ec958 git log 6ca32387e704..263def0ec958 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 fmayer@google.com Fix colspan. 2019-09-17 fmayer@google.com Merge "Reland "Add x86 ASAN to CI builds."" 2019-09-17 fmayer@google.com Merge "Add -S to curl to print errors." 2019-09-17 tneda@google.com Merge "perfetto-ui: Making heap dump marker clickable" Created with: gclient setdep -r src/third_party/perfetto@263def0ec958 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1f167c406ca83b4b55861cb4dd9edf004c2f194b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808549Reviewed-by:
-
Alex Turner authored
This DCHECK was added to validate the hypothesized cause of a bug. The change is no longer necessary and shouldn't be included in the release. Bug: 959194 Bug: 1004429 Change-Id: I48ddf24dfef0372f57d3705600918fe43e6744df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803670Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697208}
-
Javier Ernesto Flores Robles authored
Bug: 1001409 Change-Id: Iabd639d6064bd68127d085b2a29db1ce5267abd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803442Reviewed-by:
-
Benedikt Meurer authored
This adds a bunch of missing values to the "DevToolsPanel" enum, as otherwise all these drawers get logged with the code 0 instead, which makes it impossible to distinguish. Bug: chromium:993562 Change-Id: Icdb11f6c35fe8f521e141c487c6a0b483fa4ee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805663 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1004749 Change-Id: I3c6560e27d38e9880d7bdd2b09235db38ecc336a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809164 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
