- 17 Sep, 2020 40 commits
-
-
Tymofii Chudakov authored
Use category-default-setting-radio component to implement privacy page redesign, which is hidden under a flag. The following content setting categories are redesigned in this CL: - ADS - MIDI_DEVICES - AR - PAYMENT_HANDLERS - AUTOMATIC DOWNLOADS - PLUGINS - BACKGROUND_SYNC - POPUPS - CAMERA - SENSORS - CLIPBOARD - SERIAL_PORTS - FILE_SYSTEM_WRITE - SOUND - GEOLOCATION - UNSANDBOXED_PLUGINS - IMAGES - USB_DEVICES - JAVASCRIPT - VR - MIC - ZOOM_LEVELS Bug: 1113642 Change-Id: If1b3503efa459cb05d83bd7a8dc1fc6933e205b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323390 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807887}
-
Henrique Ferreiro authored
Migrate the legacy IPC message DragHostMsg_StartDragging to the StartDragging Mojo message in blink.mojom.DragDropHost. WebWidgetClient::StartDragging is changed to return a bool. This allows to move the implementation in RenderWidget to WebFrameWidgetBase, but keep the one in WebWidgetTestProxy. See the discussion at https://crbug.com/1039255#c34. Bug: 1039255 Change-Id: I99aac416d6159836a29d65c16c9ec5c88d48479d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320268 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807886}
-
Caitlin Fischer authored
content/ already depends on components/variations in multiple places; see the bug for more details. This will also eliminate the need to add additional variations-related dependencies in content/renderer/DEPS and content/browser/DEPS, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/2411489/2. Bug: 1129078 Change-Id: Id9c8ddef40e70671d4e42ef0b24cdb6239be2f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414842 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#807885}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0a8a3ea25b36..8da60e2523c7 2020-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e4cbd27e to d9fa0d46 (420 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Ibd76df7148eae7af73fcde80ff0c9b0cdf7fd6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807884}
-
Maggie Cai authored
This CL adds a feature flag for using the App Service to provide data for external protocol dialog on Chrome OS. BUG=853604 Change-Id: I4ee2273fc78599c2ec77ec5844f2903a24c187dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415917Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#807883}
-
Nico Weber authored
This is a reland of a359d11d Fix conditional to enable this on the tot bots, not on the non-tot bots. Original change's description: > clang tot bots: Force-enable memoryssa-based dse > > Now that the flag is off-by-default again upstream, let's force it on > on the tot bots to see if things work with it on. > > TBR=akhuang > > Bug: 1127713 > Change-Id: Ib9267b5123472b1c28280d858da7229b140a3b7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415222 > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807727} Bug: 1127713 Change-Id: I1252ee68251279c82da5ef00c06f7f1514780baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416668Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807882}
-
Rune Lillesveen authored
Flaky on multiple platforms. Disabling. TBR=qinmin@chromium.org Bug: 1064435 Change-Id: I3692b20bda7ff481d9502b02df84b3f877ec77f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416449Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#807881}
-
Tanmoy Mollik authored
This cl makes two key changes that should fix this bug. 1. The onPreferenceClickListener in the SignInPreference is too generic. It should only be invoked for managed accounts and generic promos. The code is moved to the setup of the specific states. 2. AccountManagementFragment should check for signed in accounts, not syncing accounts, when MOBILE_IDENTITY_CONSISTENCY is on. Bug: 1128931 Change-Id: Ifbd0fbef5acfdca7412b9ae5056f7208ff59c366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414233 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807880}
-
Joshua Pawlicki authored
This reverts commit 4e4ea3fd. Reason for revert: Speculative revert to fix BrowserTest.CloseWithAppMenuOpen failures on linux-lacros-tester-rel bot. [ RUN ] BrowserTest.CloseWithAppMenuOpen [27984:27984:0917/013814.891745:WARNING:ozone_platform_wayland.cc(203)] Failed to find drm render node path. [27813:28015:0917/013814.933599:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [27813:28015:0917/013814.933632:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [27813:28015:0917/013814.933859:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [27813:28015:0917/013814.934033:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [destroyed object]: error 1: popup parent not constructed Original change's description: > USB devices are only shared with one VM at a time > > Remove map of VmSharingInfo from CrosUsbDeviceInfo since device > is only shared with one VM at a time. > > TBR=khorimoto@chromium.org > > Bug: 1129266 > Change-Id: I2025091bf63eeed538c62d8b39cfbb744339aa64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413716 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807786} TBR=joelhockey@chromium.org,nverne@chromium.org Change-Id: I96cab98518776d10ef10d7c8376eb7379c92d6e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416389Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#807879}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3e98280633a4..aef8a21a695c 2020-09-17 mbonadei@webrtc.org Reland "Switch from rtc_ios_xctest_test to rtc_test". 2020-09-17 mbonadei@webrtc.org Add possibility to override mac_toolchain via .gclient custom_vars. 2020-09-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3f2f2acf..9d25386e (807625:807774) 2020-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a6c88d89..3f2f2acf (807489:807625) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f27d2079dc1d416228cc0c8b7ba95300aa80d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807878}
-
Rohit Agarwal authored
This CL refactors the TabModel related code and tests to support passing profiles instead of boolean for incognito. Bug: 1099642 Change-Id: I05eb4b036a32ed39b518c8034590e52a64cb6197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320276Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#807877}
-
Swapnil authored
The browsertests of note taking on lock screen policy are moved to a separated file. Bug: 1128428 Change-Id: I1f4487e7f84b9f5775d0843c1113af1d261384bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412289 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807876}
-
Caitlin Fischer authored
The status quo implementation generates two types, cached_variation_ids_header_signed_in_ and cached_variation_ids_header_, which are stored in strings. In order to limit the number of VariationIDs included in the header in third-party contexts, four headers are needed. The headers are stored in a map. FYI: While GetClientDataHeader()'s |web_visibility| argument is only Study_GoogleWebVisibility_ANY for the time being, this will not always be the case. This change paves the way for limiting the set of experiment IDs included in X-Client-Data headers sent in third-party contexts. Bug: 1094303 Change-Id: Ifdc502fbc25fc3b09911414198022e059132a83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388763Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#807875}
-
Kevin Ellis authored
First in a series of patches to fix animation of CSS logical properties. Follow up patches will deal with programmatic animations as well as updating animations in response to a change in writing mode or text direction. Bug: 1070627, 865579 Change-Id: Ibce8215bbf8238bbaf2ae2d0d35ddcca5ffdfc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414552Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#807874}
-
sauski authored
Connects the previously introduced Password Leak Detection generated preference to the toggle control present in the security page. This also deprecates the passwords_leak_detection_toggle element and the associated test. Bug: 1063265 Change-Id: I0ddacd706696db6f60fdc2035537c60da594a685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330152 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807873}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I50b51c305a543a69c7d6431e6092a876396b69d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416408Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807872}
-
Morten Stenshorne authored
This bot doesn't have H.264 support, and there should be no need to enable it, since all we care about is layout. Bug: 1129324,840659 Change-Id: I438586eee4e07815bd74b785558064bee69d60b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414304 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#807871}
-
Friedrich Horschig authored
https://crrev.com/c/2403641 was supposed to prevent a rare crash (see linked bug 1049090) but DCHECKed the possible nullptr instead of returning nullptr which only results in a different stacktrace (see linked bug 1129267). Since the crash itself shouldn't have become more prominent, a revert of that CL makes no sense and this upstream fix is sufficient. Bug: 1049090, 1129267 Change-Id: Iff6b6103439cb39c1cd96a09eb7ec6e0a1b31044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414302Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807870}
-
Denis Kuznetsov authored
Focusing element marked as "focus-on-show" is done by oobe-dialog's show() method. MultiStepBehavior triggers this method for elements marked as for-step, but enrollment_screen used legacy layout where each oobe-dialog was additionally wrapped in the <div>, and for-step was set on the enclosing div instead of oobe-dialog. As a result, show() was not called on corresponding oobe-dialog upon step switch, and default focus was not set Bug: 1021608 Change-Id: I5d103f735ff5155a190c0a74c7d215fe293a2c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414189Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#807869}
-
Lei Zhang authored
They are not used anywhere. Change-Id: Iff2aabff98d992d987b57a326c98eb6123533139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414686 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807868}
-
Sébastien Séguin-Gagnon authored
This is a reland of 74b8ec6f Original change's description: > [Empties] Enable the IllustratedEmptyStates field trial testing config. > > Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: sebsg <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805136} Change-Id: Ieb3e461efb4c55e7ef601417819cc4470e8fe4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401398 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#807867}
-
Ian Kilpatrick authored
This patch ensures that we always have a "consistent" fragment-tree (or rather a portion of a fragment-tree if we have legacy nodes). Previously it was possible for a fragment-tree to become inconsistent whenever we performed layout from a subtree root. Now when we layout from a node like this, we rebuild the "spine" of the tree. After this change we'll be able to remove most "PostLayout" calls, except where they are used for building this "consistent" tree. Bug: 1066616 Change-Id: I3993fcc5be1cd9043555ecad553fc569fc985314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407032Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#807866}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/2404384. Bug: 1127046 Change-Id: I282557314ec24e505cd04fa2ad28976d99930740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414411Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#807865}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26d327a7..8e25d6ac Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7b1e90bc5c50fb9b2b10035a097731eb37aee53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416328Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807864}
-
Demetrios Papadopoulos authored
Original CL at r806929 was reverted due to failures on Mac bots. Fixed by moving the test in question from browser_tests to interactive_ui_tests. It's a known issue that tests involving DOM focus don't work on Mac unless they are interactive_ui_tests. Fixed: 1065659 Change-Id: I8ed0d23a7318c5fa28596d0bd9d0b57f41db536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411945Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807863}
-
Rohit Agarwal authored
Incognito Interstitial. This CL adds the logic to close the regular tab where the incognito interstitial bottom sheet is displayed once the user clicks on "Continue" button in the incognito interstitial. Bug: 1125960 Change-Id: Iadab65f07a1177b08d13dd601c52d38f0e5c063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398920 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807862}
-
Clemens Arbesser authored
This fixes an issue where first-time users would not be flagged as such if they simply closed the tab. Now, this is marked as soon as the UI is shown. Bug: b/168281605 Change-Id: Ifcb32d69536ed6f7c8f6acbf68e67287d62c0404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414170 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#807861}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f5ee7c40c31b..25f15e6f33a4 2020-09-17 changhaohan@chromium.org Fix Runtime.instance to return singleton when it exists 2020-09-17 jacktfranklin@chromium.org Fix typo in component server comment 2020-09-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-16 patrick.brosset@microsoft.com Grid: Set a light background color on the persistent grid overlay 2020-09-16 jegarc@microsoft.com Normalize BezierPopoverIcon behavior 2020-09-16 raphaellucena@google.com Add performance.mark() events to Performance Tab -> Timeline UI 2020-09-16 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewPanel.js with TypeScript 2020-09-16 patrick.brosset@microsoft.com Rolling DevTools deps 2020-09-16 jegarc@microsoft.com Normalize ShadowSwatchPopover behavior 2020-09-16 jacktfranklin@chromium.org Fix loading images in components server 2020-09-16 andoli@chromium.org Disables flaky e2e test on the Issues tab 2020-09-16 jacktfranklin@chromium.org Migrate heap snapshot multiple retainers layout test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1047356,chromium:1110817,chromium:1126495,chromium:1126496,chromium:1128534 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I444cf4e5252ba43e9efbd06963377b673a3de288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807860}
-
Alexander Surkov authored
Bug: 1124366 Change-Id: I14e9badd2bef2e5315e5893cbb4fae0a35b13e78 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411702 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807859}
-
Vasilii Sukhanov authored
Fixed: 1126407 Change-Id: I06fc60a4c9800450d41eb8b5d312c25224e8e4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414221 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#807858}
-
Rohit Agarwal authored
Bug: 1127812, 1127852 Change-Id: I1704677ba9e82b3c00589f860b9c43abf5897f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414269Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#807857}
-
Swapnil authored
The browsertests of full screen allowed policy are moved from policy_browsertests to a separate file. Bug: 1128323 Change-Id: I6a470347be838d58b1b2d24b37f8f0bd852bc35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410064 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807856}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/19b910d7964b..6419bddd9b0c 2020-09-17 hao.x.li@intel.com Add buffer lazy initialization before resolve queries on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: If8513d817fb200967b9ceba47ca87b33b316dd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807855}
-
Youkichi Hosoi authored
We are going to mount /home/.shadow/<user-hash>/mount/user/MyFiles instead of /home/chronos/user/MyFiles in the arcvm-mount-myfiles upstart job. In order to achieve it, this CL makes ArcVmClientAdapter pass the Chrome OS user id hash to the upstart job. BUG=b:123641356 TEST=$ components_unittests --gtest_filter="ArcVmClientAdapterTest.*" TEST=Confirm that ${CHROMEOS_USER_ID_HASH} is available in the TEST=arcvm-mount-myfiles upstart job. Change-Id: I4adac56aadd7cf4f5f513921b1ccc7c8f874f077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412112Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807854}
-
Swapnil authored
The browsertests of statistics collector policy are moved from policy_browsertests to a separate file. Bug: 1128322 Change-Id: Ie35643f650c86d710ae470ec51745f8d227a07c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410063 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807853}
-
Benoit Lize authored
This reverts commit 91b2c272. Reason for reland: Don't use `thread_local` Original change's description: > base/allocator: Add a thread cache to PartitionAlloc. > > This CL adds a thread cache to PartitionAlloc. It is optional, only > applies to thread-safe partitions, and uses the same freelist encoding > and bucketing as the main allocator. > > The thread cache is added "in the middle" of the main allocator, that is: > - After all the cookie/tag management > - Before the "raw" allocator. > > That is, the general allocation flow is: > 1. Adjustment of requested size to make room for tags / cookies > 2. Allocation: > a. Call to the thread cache, if it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > 3. Handle cookies/tags, zero allocation if required > > On the deallocation side, the process is reversed: > 1. Check cookies / tags, adjust the pointer > 2. Deallocation > a. Return to the thread cache of possible. If it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > > The thread cache maintains an array of buckets, the same as the parent > allocator. A single thread cache instance is only used by a single > partition. Each bucket is a linked list of allocations, capped to a set > maximum size. Elements in this "freelist" are encoded the same way they > are for the main allocator. > Only the smallest buckets are eligible for caching, to reduce the > memory impact. > > There are several limitations: > - Only a single partition is allowed to have a thread cache > - No periodic purging of thread caches is done > - No statistics are collected > > The last two limitations will be addressed in subsequent CLs. Regarding > the first one, it is not possible to use Chrome's native thread local > storage support, as it allocates. It is also desirable to use > thread_local to improve performance. > > Bug: 998048 > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805697} Bug: 998048 Change-Id: If7fa5c2e1e10bc7dd1d41cdb188840668aad888f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410126Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#807852}
-
Roman Sorokin authored
Update the value on the session start. Fixed: 893938 Change-Id: I949ecfcaba81c6d53d78853d0d4576ac5ae003c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414209 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#807851}
-
Philipp Hancke authored
as buildbots missing H264 comes up frequently. BUG=chromium:840659 Change-Id: I8db4bee8bbbc04d1227d957dcd6a73ee658ec829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414315Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#807850}
-
Vasilii Sukhanov authored
Fixed: 1125731 Change-Id: Icba338d52cce5a05de22e180a046157e22b7726b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410871Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807849}
-
Prashant Nevase authored
I reviewed many of the changes in core dark mode module and recently have been adding many changes. Going forward to assess correctness and completeness, I would like to get involved in reviewing changes related to this module. Bug: None Change-Id: I2bb51c6cbcff3bfb2b18be1a160c70952e1f8839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416188Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#807848}
-