GitLab

BUG=245025

Review URL: https://codereview.chromium.org/267323009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272291 0039d316-1c4b-4281-b951-d872f2087c98

When the window is resized, some drivers clobber the back buffer.
Unfortunately that can happen in the middle of a frame, and so we lose part
of what we've drawn and don't know it until we swapped (resulting in
flashes).

So instead, we create a child window, with a CopyFromParent visual (to avoid
inducing extra blits in the driver), that we can resize exactly in Resize(),
correctly ordered with GL, so that the buffer clobber is at the beginning of the
frame, before we will draw anything to it.

BUG=326995

Review URL: https://codereview.chromium.org/296003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272290 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise the title change applies to the previous navigation entry and causes
trouble.

BUG=376034
TEST=Open settings. Click History, Extensions, Settings, History, Extensions,
    Settings, etc. Drag the back button down. Icons should match titles (and
    the pages the entries should be on).

Review URL: https://codereview.chromium.org/299703012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272289 0039d316-1c4b-4281-b951-d872f2087c98

Added code to enable/disable navigation buttons(prev/Next).
Prev button will be enable only if user can navigate in back direction and 
similarly Next button will be enable only if user can navigate in forward direction.



BUG=374702
NOTRY=true

Review URL: https://codereview.chromium.org/287373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353533
TEST=None
R=sky
TBR=benwells (For trivial change to apps/ui/views/native_app_window_views.cc)

Review URL: https://codereview.chromium.org/282133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272287 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272286 0039d316-1c4b-4281-b951-d872f2087c98

> Roll pdfium to get fixes for build warnings.
> 
> a3f590b  Add Matt Giuca to AUTHORS.
> 4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
> 2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
> 4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
> 6f9095f  Add my @chromium account in the AUTHORS file.
> 54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
> 5ce98f5  Fix warning on Mac.
> 41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.
> 
> R=thestig@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271905
> 
> Review URL: https://codereview.chromium.org/295983005

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/289083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272285 0039d316-1c4b-4281-b951-d872f2087c98

This was meant to go into branch 1985.

> Enable Bluetooth Chrome APIs for M-36 beta.
> 
> BUG=376064
> 
> Review URL: https://codereview.chromium.org/287193008

TBR=tengs@chromium.org

Review URL: https://codereview.chromium.org/296003015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376064

Review URL: https://codereview.chromium.org/287193008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272283 0039d316-1c4b-4281-b951-d872f2087c98

In the Indexed DB spec, schema updates occur synchronously from the
perspective of script, e.g. you can create a store then use it
immediately without waiting for a request to complete. That model was
carried through to the back end, but with a subtle issue that the
deletion of a store or index could "race ahead" of a previously
requested use of it.

Change store/index deletion to take place in order with other
requests, so do all the work (in-memory and backing store) during the
scheduled operation, rather than on IPC receipt. Also change
store/index creation to do all the work (in-memory and backing store)
synchronously, since index population is already preemptively done.

And since this requires shuffling when the "abort" operations should
be queued, rework the API there slightly.

BUG=370056,368271, 362723
R=cmumford@chromium.org,ericu@chromium.org

Review URL: https://codereview.chromium.org/277583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272282 0039d316-1c4b-4281-b951-d872f2087c98

R=perkj@chromium.org,asvitkine@chromium.org

Review URL: https://codereview.chromium.org/291533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272281 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375774
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/289283012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/289283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272279 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272278 0039d316-1c4b-4281-b951-d872f2087c98

a3f590b  Add Matt Giuca to AUTHORS.
4db62f5  Fixed or silenced all warnings and turned on warnings-as-errors.
2c4b046  cf2hints: Fix early loop termination causing hints to be ignored.
4fbe779  Add some blank lines at the end of 3 files to remove the "no newlines at end of file" warning.
6f9095f  Add my @chromium account in the AUTHORS file.
54c1825  Remove "using namespace agg" to make it clear which code is using agg, and also so we can turn compiler warnings into errors.
5ce98f5  Fix warning on Mac.
41f0590  Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library.

R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271905

Review URL: https://codereview.chromium.org/295983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272277 0039d316-1c4b-4281-b951-d872f2087c98

The ThreadProxy does not need to block the main thread anymore, instead
have it post back DidInitializeOutputSurface() with the result of the
process.

We would delete all contents textures on the compositor thread during
OutputSurface creation, which doesn't really make sense, cuz the
ResourceProvider won't be the same one anymore, and this required
blocking the thread.

We also notified the main thread that the OutputSurface was lost when
creating the new output surface.

Instead, post a DidLoseOutputSurface() to the main thread to inform
the LayerTreeHost right away, and have that block and clean up
the contents textures immediately (to be removed when we always do
impl-side painting).

R=enne
BUG=374287

Review URL: https://codereview.chromium.org/287193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272276 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321825
R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/293053015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272274 0039d316-1c4b-4281-b951-d872f2087c98

Do not scale the destination bitmap by the device screen density if
synchronous compositor is being used.

BUG=374815

Review URL: https://codereview.chromium.org/296493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272273 0039d316-1c4b-4281-b951-d872f2087c98

Ignores mouse motion events when mouse is pressed or drag and drop is in progress in TooltipController to prevent scroll jankiness. The tooltip should be hidden in those cases anyway and we can skip early.
This improves scrolling and dragging content, notably with sites like Google maps or sites that use pointer lock such as http://media.tojicode.com/q3bsp/.
It also seems to fix laggy text selection in omnibox (tried before and after the patch.

BUG=370255, 364677
TEST=Follow steps in the bug (drag http://maps.google.com)

Review URL: https://codereview.chromium.org/274753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371005

Review URL: https://codereview.chromium.org/283363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272271 0039d316-1c4b-4281-b951-d872f2087c98

Caused test failure in NotificationsCustomBindingsTest.TestGetUrlSpecs

> Allow high-res bitmaps to be passed in from notifications API.
> 
> Previously the custom binding in JS would prevent an image that's larger
> than the size of the template from being sent to the browser process.
> This relaxes the maximum to be the largest supported scale factor of the machine.
> 
> BUG=239676
> 
> Review URL: https://codereview.chromium.org/256503004

TBR=dewittj@chromium.org

Review URL: https://codereview.chromium.org/296113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272270 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise the request will be gc-ed, and There is no onRequestCancelled invoked.

BUG=375972

Review URL: https://codereview.chromium.org/292183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/297853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272267 0039d316-1c4b-4281-b951-d872f2087c98

USE_GLIB should be used instead of OS_POSIX.

BUG=None

Review URL: https://codereview.chromium.org/299623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272266 0039d316-1c4b-4281-b951-d872f2087c98

The native component is not guarranteed to be initialized before destroy()
is called.

BUG=375726

Review URL: https://codereview.chromium.org/295033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272265 0039d316-1c4b-4281-b951-d872f2087c98

This CL is breaking the asan/lsan bots. A snippet of the failure:

==10649==ERROR: AddressSanitizer: heap-use-after-free on address 0x60b0000d0592 at pc 0xbf31f90 bp 0x7fff0930b610 sp 0x7fff0930b608
WRITE of size 1 at 0x60b0000d0592 thread T0 (browser_tests)
    #0 0xbf31f8f in set_translation_declined components/translate/core/browser/language_state.h:62
    #1 0xbf31f8f in TranslateUIDelegate::TranslationDeclined(bool) components/translate/core/browser/translate_ui_delegate.cc:188
    #2 0x4614bb4 in TranslateBubbleView::WindowClosing() chrome/browser/ui/views/translate/translate_bubble_view.cc:205
    #3 0x4224e9c in views::Widget::OnNativeWidgetDestroying() ui/views/widget/widget.cc:1086
    #4 0x4212c95 in OnWindowDestroying ui/views/widget/native_widget_aura.cc:793
    #5 0x4212c95 in non-virtual thunk to views::NativeWidgetAura::OnWindowDestroying(aura::Window*) ui/views/widget/native_widget_aura.cc:797
    #6 0x60362b7 in aura::Window::~Window() ui/aura/window.cc:225
    #7 0x60388ed in aura::Window::~Window() ui/aura/window.cc:218
    #8 0x421fb19 in views::Widget::CloseNow() ui/views/widget/widget.cc:614
    #9 0x5a03a46 in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:422
    #10 0x5a05ead in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:373
    #11 0x443bda1 in TabStripModel::InternalCloseTab(content::WebContents*, int, bool) chrome/browser/ui/tabs/tab_strip_model.cc:1272
    #12 0x4434198 in TabStripModel::InternalCloseTabs(std::vector\u003Cint, std::allocator\u003Cint> > const&, unsigned int) chrome/browser/ui/tabs/tab_strip_model.cc:1247
    #13 0x4432c73 in TabStripModel::CloseAllTabs() chrome/browser/ui/tabs/tab_strip_model.cc:545
...
0x60b0000d0592 is located 82 bytes inside of 104-byte region [0x60b0000d0540,0x60b0000d05a8)
freed by thread T0 (browser_tests) here:
    #0 0x56fcbb in operator delete(void*) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:94
    #1 0xbf20b7c in TranslateManager::~TranslateManager() components/translate/core/browser/translate_manager.cc:59
    #2 0x2926a06 in operator() base/memory/scoped_ptr.h:137
    #3 0x2926a06 in reset base/memory/scoped_ptr.h:246
    #4 0x2926a06 in reset base/memory/scoped_ptr.h:367
    #5 0x2926a06 in WebContentsDestroyed chrome/browser/translate/translate_tab_helper.cc:314
    #6 0x2926a06 in non-virtual thunk to TranslateTabHelper::WebContentsDestroyed() chrome/browser/translate/translate_tab_helper.cc:315
    #7 0x5a03a46 in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:422
    #8 0x5a05ead in content::WebContentsImpl::~WebContentsImpl() content/browser/web_contents/web_contents_impl.cc:373
    #9 0x443bda1 in TabStripModel::InternalCloseTab(content::WebContents*, int, bool) chrome/browser/ui/tabs/tab_strip_model.cc:1272
    #10 0x4434198 in TabStripModel::InternalCloseTabs(std::vector\u003Cint, std::allocator\u003Cint> > const&, unsigned int) chrome/browser/ui/tabs/tab_strip_model.cc:1247
    #11 0x4432c73 in TabStripModel::CloseAllTabs() chrome/browser/ui/tabs/tab_strip_model.cc:545
...
previously allocated by thread T0 (browser_tests) here:
    #0 0x56f77b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x2923028 in TranslateTabHelper::TranslateTabHelper(content::WebContents*) chrome/browser/translate/translate_tab_helper.cc:78
    #2 0x4428959 in CreateForWebContents content/public/browser/web_contents_user_data.h:38
    #3 0x4428959 in TabHelpers::AttachTabHelpers(content::WebContents*) chrome/browser/ui/tab_helpers.cc:142
...


> LanguageState should be owned by TranslateManager
> 
> LanguageState is currently owned by ContentTranslateManager,
> but it should be moved under TranslateManager
> 
> BUG=345690
> TEST=unittests --gtest_filter=Translate*
> TBR=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/290573013

TBR=naiem.shaik@gmail.com

Review URL: https://codereview.chromium.org/296003014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272264 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed the using:: order.

Merge internal change: 67717614

R=rch@chromium.org, wtc@chromium.org

Review URL: https://codereview.chromium.org/288863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272263 0039d316-1c4b-4281-b951-d872f2087c98

This broke TSan compilation, as the tool dies when attempting to open a non-existent file.

BUG=302040
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/296513014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272262 0039d316-1c4b-4281-b951-d872f2087c98

EGL_KHR_fence_sync is an EGL only extension that is not returned by the
cross-platform glGetString(GL_EXTENSIONS).

Add a workaround for qualcomm devices before 4.4, which had a bug with
the EGL_KHR_fence_sync extension.

BUG=375365,278606,371530

Review URL: https://codereview.chromium.org/292153009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272261 0039d316-1c4b-4281-b951-d872f2087c98

Skia font lookup functions for HarfBuzz are from Blink. Much of the implementation copied from RenderTextWin. In the future we should either move the copied methods up, or get rid of all the other RenderText implementations in favor of this one.

BUG=321868
TBR=behdad@chromium.org

Review URL: https://codereview.chromium.org/152473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272260 0039d316-1c4b-4281-b951-d872f2087c98

Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :(
Fix InterstitialFocus and FindFocusTest.

Add a TestFocusTraversal helper function consolidated from tests.
Simplify TestInterstitialPage and add a WaitForInterstitial helper.
Move test server init to a common SetUpOnMainThread.
Remove unnecessary helpers and includes.

TODO(followup): Fix more tests!
TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/?

BUG=60973,62544,67301,81451,109770,163931
TEST=Automated tests work and stay enabled...
R=sky@chromium.org

Review URL: https://codereview.chromium.org/296523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376211
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/293113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272258 0039d316-1c4b-4281-b951-d872f2087c98

This change is to enable simulation using fake software encoder. It now
respects the target bitrate and fill the fake frame with space
characers.

Review URL: https://codereview.chromium.org/289283014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272257 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374224
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/296043009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272256 0039d316-1c4b-4281-b951-d872f2087c98

The binary_size tool suit includes tools that are useful when trying
to reduce binary size of a program, and chromium related programs
in particular.

This commit (mostly written by andrewhayden@chromium.org for 
Android but ported to generic Linux by bratell@opera.com) adds 
a graphical HTML based output for run_binary_size_analysis.py.
In the generated web page it is possible to dynamically and 
graphically browse the binary and each part of the source tree 
is given a size that reflects its contribution to the binary size.

The run_binary_size_analysis tool is run on compiled binaries 
with symbols and uses nm and addr2line to map parts of the
binary to source code. Since addr2line is slow the operation to map 
binary symbols to source files takes a while but the output is 
well worth it when shrinking programs. See its usage information
for details about how to run it.

This commit also includes the tool explain_binary_size_delta.py 
(textual output) which can be used to understand why a binary 
changed size and in what way. See its usage information for 
details about how to run it.

There are many further improvements possible to to do on these tools.
Search the bug database for Label:Tools-BinarySize for suggestions.

BUG=339059
R=primiano@chromium.org,andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/258633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362881
TEST=Manual, plug in an external mouse and observe it continues working when device is in maximize mode while internal touchpad does not.

Review URL: https://codereview.chromium.org/269633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272254 0039d316-1c4b-4281-b951-d872f2087c98

DeviceMotionService was replaced by the more general
device_inertial_sensor_service class in r219007.
Cleaning up a the leftovers and some unused class/includes.

Review URL: https://codereview.chromium.org/285373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272253 0039d316-1c4b-4281-b951-d872f2087c98

Update for CL https://codereview.chromium.org/273643002

BUG=376261

Review URL: https://codereview.chromium.org/296113007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327817

Review URL: https://codereview.chromium.org/293543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272251 0039d316-1c4b-4281-b951-d872f2087c98