- 07 May, 2018 38 commits
-
-
stkhapugin@chromium.org authored
Adds a new metric that logs users focusing and immediately defocusing the omnibox without changing it or copying it. This should allow to see the regression when the steady state location bar will be introduced. Bug: 837164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf177b57ca1781930e21c57f9c40dc829aac0982 Reviewed-on: https://chromium-review.googlesource.com/1030190Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556399}
-
Vadym Doroshenko authored
When Password Manager deals with form action it gets it with GetCanonicalActionForForm. But when FormData is created in WebFormElementToFormData another way of receiving action is used (difference is that now in WebFormElementToFormData params and auth is not stripped). It looks that using GetCanonicalActionForForm is more robust and right way. It shouldn't influence autofill in any way: 1.Signature calculation is based on action scheme and host that wouldn't change. 2.Autofill doesn't use action for filling. Bug: 831123 Change-Id: Id8ea5fd80bbfb6a3e9c354fecb2b21ad868283a6 Reviewed-on: https://chromium-review.googlesource.com/1041952Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#556398}
-
Max Morin authored
This reverts commit ef15ddc5. Reason for revert: Crashing on WebRTC bot: https://build.chromium.org/deprecated/chromium.webrtc/builders/Win10%20Tester/builds/28286 Stack trace: base::debug::StackTrace::StackTrace [0x02F08F00+32] base::debug::StackTrace::StackTrace [0x02EDEACD+13] logging::LogMessage::~LogMessage [0x02E9DD40+80] base::ThreadTaskRunnerHandle::Get [0x02EA23ED+189] std::make_unique<media::VideoCaptureDeviceClient,std::unique_ptr<media::VideoFrameReceiverOnTaskRunner,std::default_delete<media::VideoFrameReceiverOnTaskRunner> >,scoped_refptr<media::VideoCaptureBufferPool> &,base::RepeatingCallback<std::unique_ptr<medi [0x024D0D18+178] base::internal::FunctorTraits<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerator>)>,base::Repeatin [0x024D1330+70] base::internal::Invoker<base::internal::BindState<std::unique_ptr<media::VideoCaptureJpegDecoder,std::default_delete<media::VideoCaptureJpegDecoder> > (__cdecl*)(base::RepeatingCallback<void __cdecl(mojo::InterfaceRequest<media::mojom::JpegDecodeAccelerat [0x024D12E1+33] media::VideoCaptureDeviceClient::OnIncomingCapturedData [0x03F23016+246] media::VideoCaptureDeviceWin::FrameReceived [0x03F2B124+228] media::SinkInputPin::Receive [0x03F2BF05+181] (No symbol) [0x6EB233FB] (No symbol) [0x6EB232F7] (No symbol) [0x6EB401BA] (No symbol) [0x6EB2420F] (No symbol) [0x6EB37E3B] BaseThreadInitThunk [0x763F8654+36] RtlGetAppContainerNamedObjectPath [0x77254B17+311] RtlGetAppContainerNamedObjectPath [0x77254AE7+263] Original change's description: > [Video Capture Service] Support accelerated jpeg decoding > > * Move/rename class content::VideoCaptureGpuJpegDecoder to > media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order > to make it reusable for the video capture service. (I was unable to convince > Gerrit that this is a move/rename. Sorry for this making it harder to review.) > * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface > ui.mojom.GpuMemoryBufferFactory > * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface > ui.mojom.GpuMemoryBufferFactory. > * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService > from Browser into video capture service when starting up the service. > * Enable the existing-but-disabled test cases for accelerated jpeg decoding in > combination with video capture service > > Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing > > Bug: 820608, 720604 > Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.* > Change-Id: Ic9860e4f846dc0abfc85fec673b1d9c15b99c7d1 > Reviewed-on: https://chromium-review.googlesource.com/971302 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556197} TBR=avi@chromium.org,sadrul@chromium.org,jcliang@chromium.org,tsepez@chromium.org,sandersd@chromium.org,emircan@chromium.org,mojahsu@chromium.org,piman@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 820608, 720604 Change-Id: I518790cfb4eede5fd66d1f2862043285992c8af2 Reviewed-on: https://chromium-review.googlesource.com/1046525Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556397}
-
Vadym Doroshenko authored
It's leftover from https://chromium-review.googlesource.com/c/chromium/src/+/1026111 where these methods where moved to password_form_filling.h but their definition was not removed from password_manager.h. Bug: None Change-Id: I51362bd8874dc89c0db5075cd4fbf403bdbacc49 Reviewed-on: https://chromium-review.googlesource.com/1044222Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#556396}
-
Hans Wennborg authored
Apparently the cv-qualifier of a function type must match, during deduction, see http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1584 Recent Clang versions error about this so the code must be adjusted. Bug: 840251 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I715da586731ee97a7c5bfc27b522454dac14d316 Reviewed-on: https://chromium-review.googlesource.com/1046588 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
As part of ongoing scheduler architecture refactoring, this patch updates NonMainThreadScheduler so it can be used in place of WebSchedulerImpl. Specifically, this patch does the following: * Let NonMainThreadScheduler inherit from ThreadScheduler (in addition to WebThreadScheduler). * Implement required virtual functions. * Remove WebSchedulerImpl instance from WebThreadImplForWorkerScheduler, and make it work with NonMainThreadScheduler. Now, WebThreadImplForWorkerScheduler works without relying on WebSchedulerImpl. WebSchedulerImpl is still used by RendererWebSchedulerImpl, so the class itself is not removed yet. This patch adds post-constructor initialization to NonMainThreadScheduler in order to initialize a member requiring a virtual function call. The work is done in the Init() function which is now a non-virtual function of the class, and the original virtual Init() function is renamed to InitImpl(), which is called from Init(). Bug: 826203 Change-Id: I7499fb1df197b760e2289414020f7136e3545a46 Reviewed-on: https://chromium-review.googlesource.com/1032452 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556394}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I755155128114101f02a0871a3bcd9bebe93639d5 Reviewed-on: https://chromium-review.googlesource.com/1046380 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556393}
-
Max Morin authored
This facilitates further development until logging stuff is ready. No-Try since last PS only added a comment. No-Try: true Bug: 812557 Change-Id: I2121ea9d485c7db999b8d89d9fa0039ef9ab8136 Reviewed-on: https://chromium-review.googlesource.com/1046206 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#556392}
-
Rune Lillesveen authored
Don't emit new lines before/after display:contents elements. Bug: 837452 Change-Id: I9e43f836d569b6435672c36f5c50a13605fbdc21 Reviewed-on: https://chromium-review.googlesource.com/1042285Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#556391}
-
Marina Ciocea authored
Used by AudioInputStreamBroker (introduced in dependent CL) instead of AudioInputDeviceManager::KeyboardMicRegistration implementation, in order to avoid thread jumps and to keep broker interface simple. AudioInputDeviceManager::KeyboardMicRegistration will be removed after switching to audio service input streams. Bug: 828868 Change-Id: I41aac3e01faeb0d4d47f98726bc069640fb346e3 Reviewed-on: https://chromium-review.googlesource.com/1044216 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
I forgot to patch dynamic_annotations following the instructions in README.chromium when I rolled Abseil last time. TBR=phoglund@chromium.org Bug: None Change-Id: Ib295b0b9d59cb50853f552b5c38a5b1d54b50a3f Reviewed-on: https://chromium-review.googlesource.com/1046054Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#556389}
-
rhalavati@chromium.org authored
Socket patterns are no longer required in traffic annotation tests, hence they are removed from traffic_annotation_extractor clang tool. The original plan was to have network traffic annotation as an optional argument of socket create functions, and we needed to check if the argument existed for all calls that originate from Chrome. This is now changed to having annotations as a mandatory argument of the socket write functions, and as it is enforced by the compiler, we do not need to test it. Bug: 690323 Change-Id: I101fb7295662c3488807091cb9a8686cfc87d249 Reviewed-on: https://chromium-review.googlesource.com/1046087 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556388}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3059fd7dba63..b9ff578f32e7 $ git log 3059fd7db..b9ff578f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 wangqing-hf Add name to AUTHORS. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I396ab1a4ba46207261e7bee84c02dca6f9d697e7 Reviewed-on: https://chromium-review.googlesource.com/1046160Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556387}
-
Yuta Kitamura authored
This patch moves source files that only serve the main thread scheduler from renderer/ to main_thread/, which is the new home for those files after the ongoing scheduler architecture refactoring. All moved headers are only included from main_thread/, with the exception of auto_advancing_virtual_time_domain.h which is used by a test in common/, which should be OK. Bug: 826203 Change-Id: I7ea7594cca5c2ebf66805db0dfacd0183cc7a6d4 Reviewed-on: https://chromium-review.googlesource.com/1038944 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=sammiequon@google.com Change-Id: Ib81a49d4529985630cd33bc89941331cf3bc7e4e Reviewed-on: https://chromium-review.googlesource.com/1046248Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556385}
-
Yoshifumi Inoue authored
This patch makes |TextIteratorTextState| to represent relative position by explicit classification |PositionNodeType| with functions to emit code unit for each |PositionNodeType| instead of start and end offsets and computing parent node when emitting for improving code health. Before this patch, relative positions are encoded into start offset and end offset arguments of |SpliceBufer(code_unit, node, start, end)| as start=0, end=0 code_unit is emitted before node. start=0, end=1 code_unit is emitted as node. start=1, end=1 code_unit is emitted after node. in |TextIterator|. |SimpleBackwardTextIterator| passes |start| and |end| offsets of container node instead of encoded number of above. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1023502 Make CharacterIterator: :GetPosition{Before,After}() not to crash with block content Change-Id: I4be96f877fbcf1be52d2c4bc876226777353dc9a Reviewed-on: https://chromium-review.googlesource.com/1029393 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#556384}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic26f5efb7353ea1a768b08d034803c6aa155d010 Reviewed-on: https://chromium-review.googlesource.com/1046374Reviewed-by:
-
Hajime Hoshi authored
This method is not used anywhere. Change-Id: I55d636d3b3fa789a25041c680b35fece5ef78c64 Reviewed-on: https://chromium-review.googlesource.com/1032193Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit 2f276c3b. Reason for revert: Caused text rendering regression in Windows. crbug.com/840010 Original change's description: > Roll src/third_party/skia/ 05cfcff70..b9a1e688f (15 commits) > > https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c > > $ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s' > 2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice > 2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs. > 2018-05-04 bungeman Allow finer rotation in Viewer app. > 2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)" > 2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag > 2018-05-04 bsalomon Remove could not invert matrix SkDebugfs > 2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops. > 2018-05-02 herb Remove android specific code > 2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times. > 2018-05-04 fmalita [skottie] Disable on Android Framework builds > 2018-05-04 borenet [recipes] Remove core.setup() > 2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1 > 2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2) > 2018-05-04 caryclark Revert "Reland "remove obsolete color defines"" > 2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer > > Created with: > roll-dep src/third_party/skia > BUG=chromium:836113 > > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=brianosman@chromium.org > > Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec > Reviewed-on: https://chromium-review.googlesource.com/1044782 > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#556184} TBR=brianosman@google.com,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:836113,chromium:840010 Change-Id: Id9ab44b4ffe8b7bc3f3b267d2f27a732d97f5161 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1046286 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556381}
-
Victor Costan authored
OnRegistrationStored is guaranteed to be called after a ServiceWorkerRegistration has been persisted to ServiceWorkerStorage, so observers can assume that methods like ServiceWorkerStorage::GetUserData will find the registration. Bug: 729800 Change-Id: I35181050b2f35a3b82c4f8e5a22383905b9bc482 Reviewed-on: https://chromium-review.googlesource.com/1043064 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#556380}
-
Adam Rice authored
The checks of entry.encodedBodySize and entry.decodedBodySize in the http/tests/misc/resource-timing-sizes-multipart.html layout test were disabled because the values of those fields were nonsense. Those fields now have meaningful values, so re-enable the checks. BUG=631004 Change-Id: Id7902c194d03b4f26b9bdab5c891aa21cbddd01c Reviewed-on: https://chromium-review.googlesource.com/1036965Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556379}
-
Tetsui Ohkubo authored
As described in the design doc, old SystemTray class is going to be replaced by UnifiedSystemTray class. Model variables of SystemTrayItems will be decoupled into SystemTrayModel, and tray icons will be implemented in UnifiedSystemTray by obseving the models. This is the initial CL to replace the old SystemTray button by new UnifiedSystemTray button. Old SystemTray still has unrelated logic e.g. notification generation, so at this point we still instantiate SystemTray and just set the visibility to false. When we finish refactoring to move all unrelated logic to outside SystemTray, we can stop instantiating it. Screenshot: http://screen/jVCtkJgKCXa Design doc: go/cros-qs-restyling TEST=manual BUG=836134 Change-Id: I89e708ad239fb93aee5993fd10ace7fdeaab6673 Reviewed-on: https://chromium-review.googlesource.com/1025495 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556378}
-
Noel Gordon authored
Put AddEntriesMessage first in the code to introduce the concept, move TestEntryInfo afterward (it's just a helper). Run 'git cl format' over this file to format the enum's per style. No change in behavior, no new tests. Tbr: slangley, yamaguchi-san Bug: 833834 Change-Id: I4ea9333b090e4beead7217c843d3416c927ed933 Reviewed-on: https://chromium-review.googlesource.com/1045959Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556377}
-
Sasha Morrissey authored
Adds the following 4 new UMAs: FileBrowser.DirectoryTree.SelectTopLevelExpand FileBrowser.DirectoryTree.SelectTopLevelEntry FileBrowser.DirectoryTree.SelectExpand FileBrowser.DirectoryTree.SelectEntry These record when certain entries are selected in the Directory Tree (the navigation on the LHS of the Files App). etc), select expand next to these entries, and select folders inside these entries. Then check chrome://histograms to ensure UMA was recorded correctly. Test: Select different directories in the tree (Drive, Add New Services, Bug: 397213 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I493d34c93d292e6a4d8b15594308486a96ddd644 Reviewed-on: https://chromium-review.googlesource.com/954774 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#556376}
-
Sasha Morrissey authored
Adds a 'Manage in Drive' button to the context menu for entries in the Files app for ChromeOS. Creates a new DriveManageAction which appears enabled only for non-directory entries (for now) in Drive when offline mode is not enabled. Uses getEntryProperties() for the entry to get its 'alternateUrl' (provided by the Drive Sync API) and navigates to this URL in the browser. 'Manage in Drive', ensure the browser window opens and navigates to the file. Test: Right-click on a file in Google Drive in the File Manager, select Bug: 831480 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieaa359b9e825bef166ea25ec23ae1693681d91f7 Reviewed-on: https://chromium-review.googlesource.com/1011465 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
-
Victor Costan authored
The ServiceWorkerContextCore constructor declaration uses user_data_directory as the name of its base::FilePath argument. However, the definition renames the argument to "path". This less expressive name is then used in ServiceWorkerStorage. This CL replaces "path" with "user_data_directory". This adds clarity to the code and adds consistency between declaration / definition argument names. Change-Id: Ib5dc48d5c935a84e654b8b057858fb18b2be6ee5 Reviewed-on: https://chromium-review.googlesource.com/1045909Reviewed-by:
-
Matt Falkenhagen authored
According to UMA this doesn't happen since 65. The original bug about a reused/crashed process host was probably fixed when we removed the extra thread hops after allocating a process. Then the remaining bug issue 781313 was fixed in 65, which was causing a process from the wrong storage partition to be allocated. Also simplify SendStartWorker() by removing the return value. Change-Id: I0dddd731c4c512e21b4644b19b074b8bcbdfcd5b Reviewed-on: https://chromium-review.googlesource.com/1037048Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#556373}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia33e986c7be678e90351a0a0dd6e08cd8903137a Reviewed-on: https://chromium-review.googlesource.com/1046004Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#556372}
-
Tetsui Ohkubo authored
ChromeOS.SystemTray.TimeToClick metrics for UnifiedSystemTray was recorded in old SystemTray class. Reference from UnifiedSystemTray to SystemTray will be removed in the future, so this is not preferable. This CL adds Delegate to TimeToClickRecorder to fix this. TEST=manual(chrome://histograms) BUG=834462 Change-Id: I249ae40bb471d833bcc24242ade9efc778e295df Reviewed-on: https://chromium-review.googlesource.com/1029565 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Patti authored
Currently, All Site list entries are not reuseable. These will eventually become entries that represent an ETLD+1 site, with a list of origins as its children, so factor out the existing entries into a separate Polymer element. This is needed as they will also in future be used as site-list entries. This patch also fixes the UI in All Sites to have entries on a single line, when previously the icon, origin and arrow displayed were misaligned. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I66315496599f8c8d04309048ca897585a3bb431c Reviewed-on: https://chromium-review.googlesource.com/1041628 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#556370}
-
Yuri Wiitala authored
When the Audio Service will be running in its standalone process, the worker thread will be used to drive the audio flows for the loopback streams, as well as all the fake streams (including the those used for muting). These things should not become blocked by long-running control tasks on the main thread. Bug: 824019 Change-Id: I6b7fd4cb110842c70a26072161dc91929ed4f19d Reviewed-on: https://chromium-review.googlesource.com/1046153 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Patti authored
Refactor TableView and TableModel so that the size of the icon requested is provided when the TableView is retrieving the icon. This avoids duplicating the icon size in places other than TableView, and fixes one specific issue where the bluetooth connected icon used in the device chooser dialog did not specify any size, triggering a DCHECK. Bug: 838052 Change-Id: I14e7463b086c77615286e38100fe7e0f94d8fd34 Reviewed-on: https://chromium-review.googlesource.com/1036684 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556368}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 44700b6e. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17090 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6f81262b031ca2d8d4db9c388b1f212b89e930b4 Reviewed-on: https://chromium-review.googlesource.com/1046139 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556367}
-
John Abd-El-Malek authored
Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9a74ae26c42cf2672d382d178da76f22f5758fb2 Reviewed-on: https://chromium-review.googlesource.com/1045555 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Hiroshi Ichikawa authored
Before this change, added script commands were cleared when state restoration (-decodeRestorableStateWithCoder:) happens for a CWVWebView. The script commands are preserved after this change. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I06b3d7ebedc3216930516ecadcef84ab943f5a1f Reviewed-on: https://chromium-review.googlesource.com/1032316 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#556365}
-
Sam McNally authored
Bug: 823607 Change-Id: I763d48015011dc4cb59d1e5d15cc78b9cf13f2b7 Reviewed-on: https://chromium-review.googlesource.com/1032271Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
These tests are timing out on Mac: * virtual/layout_ng/fast/inline/inline-empty-block-continuation-remove.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-block-from-content-after-spanner.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-block-from-content-before-spanner.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-block-from-content-between-spanners.html * virtual/layout_ng_experimental/fast/multicol/dynamic/remove-inline-and-spanner-after-spanner-foreignObject.html TBR=eae@chromium.org Bug: 840208 Change-Id: Ibf439881543b665ac8065c2b0bc2db4148ac2d1e Reviewed-on: https://chromium-review.googlesource.com/1045956Reviewed-by:
-
Noel Gordon authored
Add FileManageBrowserTestBase private helper routines: IsGuestModeTest and IsIncognitoModeTest to return true when the test extension browser test has that GetGuestMode(). Use the helpers everywhere. The "isInGuestMode" command actually wants to know if the test runs in guest or incognito mode, or not. Write that out explicitly in its code and add LOG(INFO) and ASSERT_EQ() for even more explanation. Move "isInGuestMode" command so it's the first, move "getTestCaseName" command so it's third, to match the call order the test extensions use to call them: isInGuestMode, getRootPaths, getTestCaseName [1]. Minor change to getRootPaths: call the variable downloads_root. [1] The test extensions call in this order always and once these three are done, the test extensions start running the test case. Another way to think about it is: these three commands are preliminary set-up that every Files.app browser test case requires. All remaining commands are specific to the current test case. Bug: 833834 Change-Id: Ida01b88e745df6bf4b760aa421d36c5d8e872ecd Reviewed-on: https://chromium-review.googlesource.com/1043672Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556362}
-
- 06 May, 2018 2 commits
-
-
Noel Gordon authored
Bug: 833834 Change-Id: I4eb15bf48c996adad73f72597718b82af1069654 Reviewed-on: https://chromium-review.googlesource.com/1045948 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: Icd0d30ca1665e843d13c9d3521d3038a08a8488b Reviewed-on: https://chromium-review.googlesource.com/1043007 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556360}
-
