- 24 Sep, 2019 40 commits
-
-
Rika Fujimaki authored
Since we don't use ScriptState* in CreateNull(), we replace CreateNull(ScriptState*) with CreateNull(Isolate*). Bug: 998994 Change-Id: I4462f6c02cdf5d9c69f327250c828848f1487a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792025 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#699320}
-
Rika Fujimaki authored
Replace ScriptValue(ScriptState*, v8::MaybeLocal<T>) with ScriptValue(Isolate*, v8::MaybeLocal<T>) because we removed ScriptValue::script_state_. Bug: 998994 Change-Id: Iba92035475aa6529f091700473e0246ba7f93f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792022 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
-
Ulan Degenbaev authored
This adds browse:tools:sheets:2019 story that loads a large spreadsheet and triggers column recalculation operations. Since most of the heavy operations are performed in a web worker, the story will be useful for optimizing JavaScript and garbage collection performance in web workers. The story also supports the new reported_by_page loading metrics to catch regressions in high-level metrics tracked by GSuite team. More context in b/139436165 Bug:chromium:1007178 Change-Id: Ie4921d00ddea3545ec27086fe990b423d96b8280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761597Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699318}
-
Rune Lillesveen authored
The devtools protocol needs a generic way of forcing media feature values for matching media queries. This CL introduces the mechanism and adds the code for allowing override of the preferred color scheme for matching the prefers-color-scheme media query and computing the used value for the CSS color-scheme property. Bug: 1004647 Change-Id: I980522bcc606d65b51efd49ac2facbbf6a3dbd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820798 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#699317}
-
Dominick Ng authored
When these two tests are run together, one always fails. MSAN reveals that there is some use-after-free in these tests. Disable them for now. Recent flakiness: https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/384207 Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=PlatformUtilPosixTest. TBR=avi@chromium.org BUG=1007240 Change-Id: I961d3ed160821bd82299944cba2e827887fad7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821700Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#699316}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4ec0ef8e1b3..ed80390b177f git log a4ec0ef8e1b3..ed80390b177f --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ilkos@google.com Get unsymbolized frames proto Created with: gclient setdep -r src/third_party/perfetto@ed80390b177f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iafdc788ea7bc348de08e51a94a46e7b3877b22fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699315}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Bug: 878390 Change-Id: I0524c6394bc101490c966abf6ec89ca27a25ffea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816470 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This change converts ContentIndexService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I341bbb5f57c48d9a5595291a51fc432cd5e351e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813557 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699313}
-
François Beaufort authored
A new getSwapChainPreferredFormat method is added to GPUCanvasContext. It returns a promise that always resolves with "bgra8unorm" texture format for now. Another CL will change this later. Bug: 877147, 1007166 Change-Id: I6fbe0f0b2c0300946ffa092031e8271754f7a424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814822Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#699312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc1ab03f429d..2ff9cca70ed5 Created with: gclient setdep -r src-internal@2ff9cca70ed5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3c34ac37fa0d2645a897bb3250ba1724b7e32f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699311}
-
Philip Jägenstedt authored
These tests failed to pass CQ here: https://chromium-review.googlesource.com/c/chromium/src/+/1820857/ https://ci.chromium.org/p/chromium/builders/try/linux-rel/198937 TBR=lukasza,alexmos Bug: 1007228 Bug: 1007229 Change-Id: If8ac51779c823ff1db57ac3069075c91d58e9825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821481Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#699310}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/778af2fd..da223de4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4e0bec36bff502b43776f93461bec549c33b4565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821542Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699309}
-
Mohamed Amir Yosef authored
There is only one implementation for this interface. It was introduced while migration to the NewPasswordFormManager. Since this migration has happened already, it's not needed anymore. TBR=vasilii@chromium.org Change-Id: Ib30739232c1055f70500a1e1df3d942d3200fd66 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821078 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699308}
-
François Beaufort authored
This CL removes the dictionary member "label" from GPUPipelineDescriptorBase and GPUShaderModuleDescriptor as it is not used yet. Later, those will inherit from GPUObjectDescriptorBase that contain an optional member dictionary "label". Bug: 877147 Change-Id: I32c983e1a2fa4f0d3d1dc951978da457268626c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820740 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL makes sure GPUVertexAttributeDescriptor is defined as in WebGPU spec https://gpuweb.github.io/gpuweb/#dictdef-gpuvertexattributedescriptor Bug: 877147 Change-Id: I16a74545351da60eb802d8e6691fe2a64cb8d64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821217 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL renames GPUSamplerDescriptor compareFunction to compare as specified in https://gpuweb.github.io/gpuweb/#dictdef-gpusamplerdescriptor Bug: 877147 Change-Id: Ib5de8ffd802e40540049cedde9fccf0192dd4568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820741 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
-
nancy authored
BUG=1005640 Change-Id: I6a1ecc2506df4d7f88e6767f71abcfdcc6f436c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816488 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Since the launch plan was changed, it's better not to have an entry in the fieldtrial_testing_config. We turned down the feature on all platforms, except for cast, and will relaunch it at m79 with enterprise friendly mitigation. We continue to run affected tests at dedicated oor-cors fyi bots. Bug: 905971 Change-Id: I9270b149ce5bd4131c485c29a81cb1a2a4221c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800137 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699303}
-
Tim van der Lippe authored
We are going to update the version of Esprima to understand dynamic imports, but it turned out that this script was actually using a completely different version of Esprima. Update this path to resolve to our devtools-node-modules instead. Bug: 1006759 Change-Id: I1f0b791a5afe86e94258b7b3a044f7e756b923f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821559 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699302}
-
Marc Treib authored
Some deprecated fields were instead commented out, or prefixed with "deprecated_". Better to properly remove them, and make sure the tags aren't accidentally reused. Bug: 950904 Change-Id: Ibe7515c1658adc2076f775281b5b928bc16687d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820802Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699301}
-
Alex Ilin authored
This CL adds a new test DemoSignInTest::WebSignInAndSignOut to the suite of live SignIn tests. This test goes through the following steps: - Sign in via accounts.google.com/addsession - Check that the refresh token and cookie are added to Chrome - Repeat the steps above to add a second account - Sign out via accounts.google.com/logout - Check that the token and cookie are removed from Chrome - Check that the primary account wasn't added to Chrome This CL also modifies the existing DemoSignInTest::SimpleSignInFlow test to reuse a newly introduced helper method and use IdentityManager to verify cookies instead of probing chrome://signin-internals. Bug: 1006258 Change-Id: Ib313d69877a3e6fb09667d022acc952e973b5ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818526 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699300}
-
David Roger authored
This is a code simplification. It replaces two callbacks by one observer, which is simpler. It will be even more useful in the future, as there are plans to add more observer functions. Change-Id: I460be36cef07ab8639eab4a1d2ddafac7b8dd739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806579 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#699299}
-
Mugdha Lakhani authored
When BackgroundSyncManager is notified of a change in network connectivity, we immediately proceed to calculate two lists of one-shot and periodic Background Sync registrations that we're ready to fire events for. For each registration, we individually check whether there is connectivity. This is wasteful. This CL adds a check before calling FireReadyEvents() and bails out if there is no connectivity. Bug: 574478 Change-Id: Iaf1bfe8552edbfbfbef8e6d8ffb0ab1acacaf341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816569 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#699298}
-
Boris Sazonov authored
Replaces separate Runnable callback and WipeDataHooks with a single SignOutCallback. Bug: 906581 Change-Id: I5f26c98a90eb947de311900eecfcb9be5d6b37cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820738 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699297}
-
Marc Treib authored
This was another type of protocol message next to GET_UPDATES and COMMIT, which hadn't been used in a long time. This CL removes the corresponding protos. Bug: 960755 Change-Id: Iabfafd349f1eac4acc453fe8f668667028ce2341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820799Reviewed-by:
-
Nico Weber authored
No intended behavior change. Bug: 961769 Change-Id: Ifc1ed842689209dd5f66a83d6df4d5f1063133e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815911Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#699295}
-
Mia Glaese authored
Formatted tab carousel header. Changed feed surface to allow for different/no feed header. Changed/formatted feed header for Single Surface. Removed feed header for Explore Pane in Two Pane Surface. Before Single Surface: https://drive.google.com/file/d/192XyBnXfhxGxOjVv1kW_ac1uuPxFFG6b/view?usp=sharing Explore Pane: https://drive.google.com/file/d/1BhIuD_HJDkpUmr-huuo_6sCNw_PU5z2C/view?usp=sharing After Single Surface: https://drive.google.com/file/d/1VdrxIBHJ1trovSyJesPa4qjg2pzGPa8s/view?usp=sharing Explore Pane: https://drive.google.com/file/d/1hbZ-0OEYCA4ycWdBYD2g_LwtOBAeNOaU/view?usp=sharing Bug: 982018 Change-Id: Ica548d2007a9c9d029fb9a15369630a8b1fe0ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792857 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#699294}
-
Tanmoy Mollik authored
Bug: 988644 Change-Id: I663ab039d6399005ebe23af10da3e3fab8665f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819314Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I47e8afb9a4e51b448f9a52e9cab36b4cfac8924c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821418Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/55783c1d0403..a4ec0ef8e1b3 git log 55783c1d0403..a4ec0ef8e1b3 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 fmayer@google.com Merge "Read ModuleSymbols from trace." Created with: gclient setdep -r src/third_party/perfetto@a4ec0ef8e1b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I626b8e9029bb34335bdc5e0f3344c1a804bdd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821417Reviewed-by:
-
Javier Fernandez authored
This is a reland of a445d168.. The original patch has been reverted due to a performance regression, described in bug #1002700. Additionally, this patch solves some cases not covered by the original patch, specifically when using 'non-auto' values for the grid item's min-width property. It also provides additional regressions tests. Finally, the performance regression is solved by checking out whether the grid item needs layout before considering to clear the Override size. Original change's description: > [css-grid] Clear the override width for computing percent margins > > When calculating the min-content contribution of a grid item of an auto > sized grid track we must consider the grid item's margin. When the grid > item's area is indefinite, a percent margin is resolved to zero. > However, when performing a relayout, the percent margin may be solved > against the previously computed grid area, since the grid item has > already an OverrideContainingBlockLogicalWidth value. > > In order to re-compute the percent margin properly, we need to clear > the previously override value. It's important be careful of not > clearing the override value set during intrinsic size, since we need > it for the actual layout phase. Hence, we only reset the 'override' > value when we are executing a definite strategy. > > Bug: 834643 > Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694849} Bug: 834643, 942811 Change-Id: Id6fdf52fab471ebefecb2c087c086faf0e3f5dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796323 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#699290}
-
Mikhail Khokhlov authored
This formatter takes serialized histograms from test artifacts, adds diagnostics to them and saves to a file. Ad-hoc values are not supported yet. Bug: 981349 Change-Id: Iab6cbf40d4e3ddc118603a4eaa38dc58a9ae8163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796670 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
-
Rika Fujimaki authored
Replace ScriptState* with Isolate* We replace SharedPersistent with WorldSafeV8Reference to remove persistent, and to ensure v8::Local<v8::Value> is world safe. (ref. V8Value()) We also replace ScriptState* with Isolate* because ScriptValue doesn't depend on context any more. Bug: 1000152, 998994 Change-Id: If232d1da9579cf73157e400bf0c40950b2f3a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787672 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. Bug: 955171, 978694, 936482 Change-Id: Iac89ba3a94f06af9ae87887d72bafc998bc0a768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816462 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699287}
-
Hans Wennborg authored
After the Python 3 conversion, there is now an extra space in the output. This shows the problem: >>> print "a\n", "b" a b >>> from __future__ import print_function >>> print("a\n", "b") a b Fix it by specifying sep="". TBR=thakis Bug: 1007195 Change-Id: I20fea51951d552fcffee4704bd515c54bb84ef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821598Reviewed-by:Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#699286}
-
Peter Marshall authored
Remove the toggled title from ToolbarSettingToggle which is not used by any caller. Remove optGroup from ToolbarSettingComboBox which is not used by any caller. Change-Id: I1a2849d090b458ba807bf7aa6d59f06b66b24821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817886 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Bo Liu authored
Loading "file://" on higher versions of android will simply hang instead of finish in an error, thus causing the test to fail. Presumably on higher versions with dynamic permissions, browser is waiting for user consent which is probably not implemented in content shell or tests. Change it to link to itself instead, which is guaranteed to work. Bug: 990854 Change-Id: I6501deb0899a4c99f4a917e5ee1fd6ae144cdff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817100 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699284}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media_router.mojom.MediaStatusObserver interface, and adapt unit tests. Bug: 955171 Change-Id: I264e9bf9df22cb7ffe6418a4513b4260b39ee7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813506 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
Richard Townsend authored
Bug: 1006732 Change-Id: If244b1ee9915b148d64ed62497a04736b191e0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819500 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
-
Miyoung Shin authored
This change converts ContactsManager mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I9fbce895d342faa2de8d9be6fa66d8198820f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815925Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
