- 20 Aug, 2019 40 commits
-
-
Martin Kreichgauer authored
AreGetAssertionRequestMapKeysCorrect() contained a tautological comparison. Also clean up the surrounding code a little. Bug: 995867 Change-Id: Ib585f08a9727d604dfc8af07cc0cb67d8e524fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762579 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#688724}
-
Shakti Sahu authored
As per the discussions, added few changes to the accessibility mode : 1 - Removed announceForAccessibility calls 2 - Removed dismiss on timeout from the IPH when on a11y mode Bug: 871455 Change-Id: I1d5f47ac5cfb7bcf890b539552d69fff01503456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759203Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688723}
-
Elly Fong-Jones authored
These tests were disabled a while ago when they broke. This change: 1) Implements some parts of FakeKeystoneGlue and FakeKeystoneRegistration so that these tests pass 2) Updates the BasicUse test to more closely check the contract of KeystoneGlue Bug: 16360 Change-Id: Ic28de2440f792751cf856e8ea61d5ff309c23f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757368 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688722}
-
Jamie Walch authored
Change-Id: I402f691a57d73ca287441d202034418f5a9a3920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726905 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#688721}
-
Bettina authored
This change depends on cr/1693188. Bug: 914410 Change-Id: I510f2e63c924bc7860325601d6c4d1b93c542091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709893Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#688720}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/81080a729af568f7b5fde92b9170cc17065027c9..44544d9d2d624cbfff9b1e77cb77f8dfc70d073c Bug: none Change-Id: I588aaa765ae59dd85a6f236ef7d861ae0e9f293c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760871 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#688719}
-
Joshua Peraza authored
8edbc7439b2b codereview.settings: stop forcing squashing 64399c514ff2 Implement Exception context for minidump 6b5e30db285f Fix signed-unsigned-wchar build failure efaebfc482b7 fuchsia: Capture from SP (+slop) to stack base, rather than entire stack ec56fc6a38f0 linux: add Get/SetHandlerSocket() 3a6c6012ba2b linux: override exception thread ID Change-Id: I2a9c12ec841ec053d7558a7e2d40dee0587fe1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762682Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#688718}
-
Yi Gu authored
The drag and drop issue with Viz hit testing has been fixed in crrev.com/c/1693442. Bug: None Change-Id: Ifbca617f1a0391dc6bd6465d0ee0de1c1aba3d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761776Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688717}
-
Matt Reynolds authored
Previously, HID gamepad haptics duplicated the OS-specific logic for writing HID output reports. This CL factors out the duplicated logic. BUG=984155 Change-Id: I31001415f840a169a261ee9c1e84030e0e6ee17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754666 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#688716}
-
Etienne Bergeron authored
This CL is fixes the unit tests for the PlatformFontSkiaOnWindows experiment. 1) It fixes the off-by one due to rounding (e.g. font height computation). 2) It uses the DirectWrite Skia font manager by default; otherwise the default is the GDI font manager which is not giving the appropriate metrics. 1) Off-by-one due to rounding: PlatformFontWin is computing the font metrics with Skia in the function PlatformFontWin::CreateHFontRefFromSkia. See: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_win.cc?l=515 SkFontMetrics skia_metrics; font.getMetrics(&skia_metrics); const int height = std::ceil(skia_metrics.fDescent - skia_metrics.fAscent); PlatformFontSkia is computing it this way (ComputeMetricsIfNecessary): See: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_skia.cc?l=342 SkFontMetrics skia_metrics; font.getMetrics(&skia_metrics); ascent_pixels_ = SkScalarCeilToInt(-metrics.fAscent); height_pixels_ = ascent_pixels_ + SkScalarCeilToInt(metrics.fDescent); The height computation is also not consistent with the way it's computed on Mac(platform_font_mac). See: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_mac.mm?q=platformfont+mac&dr=C&l=355 height_ = ceil(ascent_ + std::abs([font descender]) + [font leading]); This difference is making the font height on linux/windows off by one pixel. Unittests were adjusted for these off-by-one on each platform. The migration of PlatformFontWin to PlatformFontSkia is making these tests to fail. Ideally, we should choose one implementation and fix the code. To ease the migration, this CL implements on Windows the same computation used in PlatformFontWin to minimize the visible changes in Chrome. 2) DirectWrite Font Manager The unittests are not calling InitializeDirectWrite(..) to force an override of the Skia font manager. The browser code currently fails if the font manager is not set to DirectWrite. Unfortunately, the unittests are not calling the initialization function and were using by default the GDI adapter. The simple way to fix this issue is to ensures that Chrome code (browser and tests) are only using the DirectWrite version. This is fine since WinXP is no longer maintained and DirectWrite is always available on Win7+. Bug: 944227 R=robliao@chromium.org, asvitkine@chromium.org Change-Id: Ide54b96d576c5e4ec862dabb5aef6c735a3ffdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721453 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688715}
-
Gabriel Charette authored
This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 for the documentation update (while not yet mandatory, it's already the desired syntax while we fix the remaining straddlers). TBR=fdoray@chromium.org Bug: 968047 Change-Id: I7e897f4ecb2ba6075ba754695bbbd30ff0439de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759055 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688714}
-
Matt Menke authored
This CL adds NetworkIsolationKey as an argument to AlternativeServiceInfoVector methods in HttpServerProperties, and makes consumers pass in the correct key. Bug: 969890 Change-Id: Icc25b3a944f574522c52d5f1035fdb26539e0b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754271 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688713}
-
Steven Bingler authored
The mode policy, DnsOverHttpsMode, has 3 possible values: off, automatic, and secure; these set the DNS-over-HTTPS mode to off, automatic, and secure mode respectively. secure will be, initially, unsupported and will map to off. This policy will also have an enterprise default value of off so that enterprise machines will not take part in the DNS-over-HTTPS experiment by default. Bug: 955454 Change-Id: I776ff016aa01b18dd507facd0e6a11a6b4d2f310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752931Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#688712}
-
Chris Palmer authored
Bug: 984742 Change-Id: I35a17fc8b923c949125ff63511c424143f3f80e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761402 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688711}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e6ff7901. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/encoding NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I322a3959f77d129ec0954968a96ba98cc102b0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758465Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688710}
-
Fredrik Söderquist authored
Use the StringHasher::ComputeHash() helper. Change-Id: Ic43c19467a9d15f1b82c4ac586ebe7b80f937c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762220Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#688709}
-
Corentin Wallez authored
These were removed from WebGPU because they cannot be supported everywhere, for example on recent Qualcomm chips. BUG=dawn:128 Change-Id: I235539916730001ad329f9ad067da7599e109360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760959 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#688708}
-
Evan Stade authored
Wait for theme update by listening for notification instead of RunUntilIdle. This fix is prospective: I couldn't get it to flake locally with or without the change. Bug: 995851 Change-Id: I5a3a4dda389178f6e3dd114ee14da9ea593254d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762353Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#688707}
-
Yue Li authored
Some spacing updates and move the voice match animation to the middle. Bug: 994462 Test: Manual test Change-Id: Id81f555cdfd6d620138831c426ba8ae6eb77e8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761647 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688706}
-
Yi Gu authored
Previously we had both kEnableVizHitTestDrawQuad (VizHitTesting v1) and kEnableVizHitTestSurfaceLayer(v2). After v1 being shipped, the function IsVizHitTestingDrawQuadEnabled() was no longer useful. It just returns !IsVizHitTestingSurfaceLayerEnabled(). Bug: 917015 Change-Id: Id7791763704235238cf0cfbc91bbf580128fa543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762588Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688705}
-
minch authored
kSeparatorOnLightBackgroundColor and kSeparatorOnDarkBackgroundColor inside default_color_constants.h are actually not needed. Their colors are the same as AshColorProvider::ContentLayerType::kSeperator. Bug: 982950 Change-Id: Iba8c638db130d3cebb22008696d115c31697c86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761105Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688704}
-
minch authored
Color for the auto click menu button is actually SK_ColorWHITE, 10%, not kUnifiedMenuButtonColor (gfx::kGoogleGrey200). Color for the separators between scroll pad buttons is actually ../Base/Content/Separator, kScrollpadStrokeColor is not needed. See spec: https://spec.googleplex.com/crosux-spec/feature-specs/accessibility-auto-click.html And the color of kStackingNotificationCounterLabelColor (0x5f, 0x64, 0x68) is actually should be gfx::kGoogleGrey700 (0x5F, 0x63, 0x68). See spec at https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQpLhKoE-Okp/files/MCH8Xi1gx9PQWEsGsKPbLGpxwMSJbxAVNpw Bug: 982950 Change-Id: I4fdb7538b174964d1a9130fedee2f418128ee6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761211Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#688703}
-
Kristi Park authored
CSS variables cannot be used in pseudo elements. Bug: 995664 Change-Id: Id607d2b27ba65fd1ca056a89976def2251ea7dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762577 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#688702}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bbfec9db84cf..916a904fb7f2 git log bbfec9db84cf..916a904fb7f2 --date=short --no-merges --format='%ad %ae %s' 2019-08-20 jlavrova@google.com Placeholders implementation + unit tests 2019-08-20 reed@google.com make pathiter bench a little more realistic 2019-08-20 halcanary@google.com RELEASE_NOTES: note change to SkMallocPixelRef 2019-08-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@916a904fb7f2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I0a319c34a907fa3bcb1528ffb705034f5036fecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688701}
-
Nina Satragno authored
Add the `RemoveAllCredentials` WebAuthn command to ChromeDriver. This is one in a series of patches intended to create a Testing API for WebAuthn, for use in Web Platform Tests and by external webauthn tests. For an overview of overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: I2fd4ec95163487f955b746db8044f98aa9dd90db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761484Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#688700}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/1749845 inadvertently removed the ability to change the current tab model before tab models have been initialized. This CL fixes that by refactoring how initial incognito state is set when the tabmodelselector is initialized. Bug: 995680 Change-Id: I1136d1365078db50decd5868f12445bdbfad65a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761485 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688699}
-
Yang Guo authored
Currently we always drop the last trace event due to the way the time range for a process is computed. Change-Id: I1c68d73269753ef90b2c95cbb654ffb20af5ef59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751189Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688698}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/428149962b00..0d7ff782762c git log 428149962b00..0d7ff782762c --date=short --no-merges --format='%ad %ae %s' 2019-08-20 simonhatch@chromium.org Dashboard - Rework update_test_suite_descriptors a bit. Created with: gclient setdep -r src/third_party/catapult@0d7ff782762c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:992162 Change-Id: I59b64502b94f128c89cba62fe4d1bed54d946c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761684Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688697}
-
Haiyang Pan authored
win-10-perf, linux-perf, mac-10_13_laptop_high_end-perf, and android-pixel2-perf Commands used to update/generate the data are: src/tools/perf/generate_perf_data src/tools/perf/generate_perf_sharding update \ -b win-10-perf \ -b linux-perf \ -b mac-10_13_laptop_high_end-perf \ -b android-pixel2-perf Bug: 954861 Change-Id: Ia22c8b5b07d61b1eed186f21c5ad85d522f7fedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756090 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#688696}
-
Madeleine Barowsky authored
This change attaches a string |image_type_| to ScopedImageDecodeTasks, representing the file extension of the image to be decoded. When the task is complete and the destructor records the duration, we record an additional UMA if it's a WebP image called Renderer4.ImageDecodeTaskDuration.WebP.{Software, Gpu}. Bug: 966008 Change-Id: I4f7d3837df94facbb637c0402c6bcce66aae2a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760875Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#688695}
-
Tommy Steimel authored
This CL modifies the logic for enabling GMC by default. This fixes an issue where GMC was enabled by default on ChromeOS. Bug: 995836 Change-Id: I6b38423043a9c50480dc255eb9a12dc2500cb714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761779Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688694}
-
Nick Harper authored
The HSTS header served by bitbucket.org now has the includeSubDomains directive as well as preload, so it can be moved to the bulk entries section of the preload list and set the include_subdomains flag. Change-Id: I3ec1a1b4c10f00fc1696760c72be602775ccc949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761521 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#688693}
-
Lan Wei authored
In ExecutePerformActions function, we dispatch key events first, mouse events then touch events, but we should dispatch whatever actions come first in the action sequence. This CL changes high level of structures of processing actions and dispatching events in the action sequence, and I still need to refactor some details when procession the actions in a following CL. Bug: 606367 Change-Id: I46e02e547d0e5d5c2ddcdc949efc6b141142ea2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759855Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#688692}
-
Daksh Idnani authored
On dual-GPU machines, we should ensure that the high-performance GPU is active during WebGL conformance tests. Bug: 985486, 984780, angleproject:3701 Change-Id: I93280f9335d919af9fbbf77e008dd3582a20c501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761430 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688691}
-
Maggie Chen authored
This reverts commit 752f7f2c. Reason for revert: <Watchdog V2 causes crashes in the bots and it falls back to SwiftShader. bug 995372> Original change's description: > Enable GpuWatchdogV2 in Field trial testing for all platforms > > Bug: 949839 > Change-Id: I5939069144719c501209af3cda3b7693f61f8866 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682315 > Commit-Queue: Maggie Chen <magchen@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688375} TBR=isherman@chromium.org,zmo@chromium.org,magchen@chromium.org Change-Id: I2f64da411b2289265c1a9657fae85c083953bfb8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761559Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688690}
-
Gabriel Charette authored
This is a partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/1635827 for the task traits additions that were already LGTM'ed. TBR=fdoray@chromium.org Bug: 968047 Change-Id: I2dc33aadae040b12e58157c80c343a055ed441f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762417 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#688689}
-
Sammie Quon authored
It's only used for ash, but I think it makes most sense to be in transform_util.cc. Test: added test Bug: none Change-Id: I6cef151a97a1841e57db17083320bd444bb24b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756924Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#688688}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f624b9be..15b9f9d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5079b45577a3365d646820b164e92a0ea33e9b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758466Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688687}
-
Lutz Justen authored
Tickets should be forwardable by default to match the behavior for Chromad. This was an oversight. BUG=None TEST=Tested manually that getting tickets still works Change-Id: If35ba1d73e4348c3d87f6a685d509c24bdf5f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753929Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#688686}
-
Koji Ishii authored
This patch moves |EnsureNodeId()| to inside of |NGTextFragmentPainter::Paint()| from its callers. All callers do the same preparations, this unifies them Bug: 924681 Change-Id: I3f0ca7d1ca418943604254ffd425df4e9edb7c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761872 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688685}
-