- 11 Sep, 2019 40 commits
-
-
arthursonzogni authored
Content's embedders are not notified the visible URL has been invalidated. This CL adds a regression test showing this. Bug: 998284. Change-Id: Ib3a239d65f98209688b3b682cbe9a6184707c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780822 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695543}
-
Hiroki Nakagawa authored
This CL removes the "externalfile" scheme support from URLLoaderFactories for service worker updated script loading. The scheme is used for loading files from ChromeOS-specific local file systems (e.g., "Downloads" and "removable"): https://cs.chromium.org/chromium/src/chrome/browser/chromeos/fileapi/file_system_backend.h?rcl=7bd9f2e138d37076a1ed3380126be8d00ae3837c&l=38 Service workers never support the scheme: https://cs.chromium.org/chromium/src/chrome/common/chrome_content_client.cc?rcl=013d0ec7da2f2c1b4c78af14fa1bdc83290dfb35&l=645 https://cs.chromium.org/chromium/src/content/browser/service_worker/embedded_worker_instance.cc?l=1092-1095&rcl=183f7e64155459d1c5f50155234a176e4fce7b3f See the following comment for the context: https://chromium-review.googlesource.com/c/chromium/src/+/1669251/7/chrome/browser/chrome_content_browser_client.cc#4893 Bug: 648295, 964229 Change-Id: I4d18bb972f38eba4498b109e595627a43cfdc6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798102 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695542}
-
nancy authored
BUG=998004 Change-Id: I3bccc70e1a2d372585bf015ebc0b808b43b4be85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787618Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695541}
-
Julie Jeongeun Kim authored
This CL converts MediaCapsObserverPtr to new Mojo types. It uses Receiver, ReceiverSet, RemoteSet, and PendingRemote or Remote instead of Binding, BindingSet, InterfacePtrSet and MediaCapsObserverPtr. Bug: 955171 Change-Id: I26460b5c0a13f858997c6141d6ca437cb84a674d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786704 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695540}
-
Jan Wilken Dörrie authored
This change adds an explicit base::WriteInto overload for std::wstring for Windows. For now this method is called WriteIntoW, as otherwise it would cause redefinition errors with the other overloads as long as base::string16 is std::wstring on Windows. Bug: 911896 Change-Id: Icaa681c6d0e1bcefcd4096e59194213dace14f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796432Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695539}
-
Fredrik Söderquist authored
This splits said method into a CheckAndUpdateInterval() and an UpdateActiveState(). CheckForNewRestartInterval() is also folded into the former. Bug: 998526 Change-Id: Ie1b10e06cfc0aed64e8576c820c59978596c5083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795428 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#695538}
-
Pâris MEULEMAN authored
This CL creates the java counterpart of the PrimaryAccountMutator, and modifies SigninManager java to use it instead of going through the C++ API. The aim is to have SigninManager.java interact with IdentityManager solely through its java interface, for which a few follow ups are required. Bug: 934688 Change-Id: Ic2b893d5831d53b2ea6df5184fd5f7894c665924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784721 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#695537}
-
Marc Treib authored
According to the linked bug, the reason for disabling the test has been long resolved. Bug: 84575 Change-Id: I21847fb8199ddedae72db3d58facc7f801db1453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796423 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695536}
-
Marc Treib authored
It was used in the old E2E test setup, which hasn't been active for a while. The new E2E setup won't need it (it'll have real invalidations). Bug: none Change-Id: I789bc07f10bfde6209ef01057e934893d8faf318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796343 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts MediaCapsRequest and MediaCapsPtr to new Mojo types. Bug: 955171 Change-Id: I8fd9b87f2027b5abc3ffbfda942894eaf19e5865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788430 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7f7236f1eba0..c0e9807094ef git log 7f7236f1eba0..c0e9807094ef --date=short --no-merges --format='%ad %ae %s' 2019-09-10 zoddicus@users.noreply.github.com Handle creating a new constant failing gracefully (#2848) 2019-09-10 afdx@google.com Rework management of probabilities in spirv-fuzz (#2839) 2019-09-10 afdx@google.com Fix add-dead-break and add-dead-continue passes to respect dominance (#2838) 2019-09-10 stevenperron@google.com Handle id overflow in the ssa rewriter. (#2845) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c0e9807094ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,syoussefi@chromium.org Bug: None Change-Id: I5550e6b4bb6d1089aca2a034e55137d097cf38f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695533}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea8664557d2e..df70582bd999 Created with: gclient setdep -r src-internal@df70582bd999 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4e4b398376507e8b7df62b610932a6f1f80f9c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797280Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695532}
-
Javier Fernandez authored
This reverts commit a445d168. Reason for revert: It caused a performance regression (issue #1002700) Original change's description: > [css-grid] Clear the override width for computing percent margins > > When calculating the min-content contribution of a grid item of an auto > sized grid track we must consider the grid item's margin. When the grid > item's area is indefinite, a percent margin is resolved to zero. > However, when performing a relayout, the percent margin may be solved > against the previously computed grid area, since the grid item has > already an OverrideContainingBlockLogicalWidth value. > > In order to re-compute the percent margin properly, we need to clear > the previously override value. It's important be careful of not > clearing the override value set during intrinsic size, since we need > it for the actual layout phase. Hence, we only reset the 'override' > value when we are executing a definite strategy. > > Bug: 834643 > Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694849} TBR=cbiesinger@chromium.org,jfernandez@igalia.com,rego@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834643, 1002700 Change-Id: I66f2b94417be0c74dc408bc55eee3a8d44447480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796803Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#695531}
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a completely mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format Bug: 646113 Change-Id: Ia29bc02040a056e518737f2b11f1cd0b66b0e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796430Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695530}
-
Miyoung Shin authored
This CL converts JsonParserPtr and JsonParserRequest in chrome, services and extension to the new Mojo type. Bug: 955171 Change-Id: I6f7ad277b5d2885c680b1c62681af6588d04c8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792395 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695529}
-
vitaliii authored
Mark virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/scrollbar-button-gesture-target.html as flaky on Linux. TBR=bokan@chromium.org Bug: 1002828 No-try: true No-Presubmit: true Change-Id: Iecae0559e773fe4c4925fdae3be66b1020710405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796552Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695528}
-
Pâris MEULEMAN authored
As discussed in crrev.com/c/1784721, CoreAccountId.java and CoreAccountInfo.java should not assume that the CoreAccountId is a Gaia ID, until the completion of the Account ID migration, and rather align their behavior with their C++ counterpart. Bug: 934688 Change-Id: I9245811511c606dc4f56c8a5982cd937ef567d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795583 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts NetworkContextPtr in components, jingle, and services to new Mojo types. Bug: 955171, 978694 Change-Id: Ibf28021f468cb896bb529b7a041a936363a73858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787670Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#695526}
-
Makoto Shimazu authored
TBR=ricea@chromium.org No-Try: true Bug: 1002780 Change-Id: I3efb051c06fd15bb754cbf78269c6b6610bf78b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797944Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695525}
-
Yutaka Hirano authored
It seems always true. Bug: None Change-Id: I90c2022070f33c4042ed436627c853cf64e6fd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797524Reviewed-by:
-
Dominic Farolino authored
This CL addresses a problem with SecurityPolicy::GenerateReferrer when it comes to checking the same-origin-ness of a request. The WebAppSec Referrer Policy Standard defines a same-origin request [1] as one where the request's origin and current URL are same-origin with each other. This comparison is done in "determine a request's referrer" algorithm. The analogous place in our implementation is SecurityPolicy::GenerateReferrer. Before this CL, GenerateReferrer would determine a request's same-origin-ness by comparing the origin of the request's referrer string and the origin of the request's current URL. Most of the time this was sufficient, as the request's referrer string is almost always same-origin with the request's origin (initiator in Blink). With descendant module scripts and worklets however, the origin of the request's referrer string and request's origin (initiator) could be different, which breaks the correctness of our GenerateReferrer method. This CL introduces a blink::SecurityOrigin parameter to the GenerateReferrer method, so that correct same-origin comparisons can be carried out. In all GenerateReferrer call-sites, an appropriate origin is passed in. The original CL [2] was reverted because the semantics of SecurityPolicy::GenerateReferrer were not kept in sync with the similar logic in net::URLRequestJob::ComputeReferrerForPolicy, which caused a DumpWithoutCrashing bug seen in https://crbug.com/1000614, and request cancellations. This reland updates the ComputeReferrerForPolicy logic to match the corresponding Blink logic, and includes documentation mentioning that changes to one section should be reflected in the other. This CL also includes web platform tests for the scenario in the aforementioned bug, which pass with this CL, as well as net unit tests for RedirectInfo and URLRequestJob. [1]: https://www.w3.org/TR/referrer-policy/#same-origin-request [2]: https://crrev.com/c/1768501 Bug: 786862 Change-Id: I1deeaae8191b07856c593ddb2486297344e0b846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786260 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#695523}
-
Takashi Toyoshima authored
This patch adds test cases that an Extension injects response headers to deceive CORS checks. If OOR-CORS is enabled, such injections need 'extraHeaders' option to work in expected ways. Bug: 1000554 Change-Id: Ieef9223b1abd798bea215cfec1fb706aabd0a610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792207Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695522}
-
Miyoung Shin authored
This CL converts BluetoothDeviceAccessProviderPtr and BluetoothDeviceAccessProviderClientPtr in chromecast to the new Mojo type, and uses pending_remote<BluetoothDeviceAccessProviderClient> in web_bluetooth.mojom of chromecast. Bug: 955171 Change-Id: Ibc71e633b842f52ea7c37e9e93d11d4bc293713a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786703Reviewed-by:
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ieaf6f34b8b13eb06f64743dfa1cbbcd9bd7e7fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795467 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a mostly mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format - Manually fixing the breakage in cryptotoken_private_api_unittest.cc Bug: 646113 Change-Id: I78dace264e92ef39dcc18b094d064057e06c3d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796431Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695519}
-
Gyuyoung Kim authored
This CL applies pending_receiver to the first argument of CreateBarcodeDetection in BarcodeDetectionProvider interface. Bug: 955171 Change-Id: Ib86754b3d5989d555a8c0ed536df78e22b540dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792212Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/881c56bc0687..9fafe62237ad git log 881c56bc0687..9fafe62237ad --date=short --no-merges --format='%ad %ae %s' 2019-09-11 thestig@chromium.org Roll v8/ 33faa512c..9ddd0c4c1 (521 commits) 2019-09-11 thestig@chromium.org Roll tools/clang/ 656fd11bb..2fef805e5 (7 commits) 2019-09-11 thestig@chromium.org Roll build/ 127a04882..f3a03b22d (102 commits; 1 trivial rolls) 2019-09-11 thestig@chromium.org Roll DEPS to update to Clang 10.0. 2019-09-11 thestig@chromium.org Roll DEPS to upgrade Android NDK to r20. 2019-09-11 thestig@chromium.org Roll build/ f0964b29a..b9e0d9224 (18 commits) 2019-09-10 nigi@chromium.org [SkiaPaths] Merge |m_positions| and |m_glyphs| into a new class. Created with: gclient setdep -r src/third_party/pdfium@9fafe62237ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I63e6941f61343a4604d36bacee1423572b2f74af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797489Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b12a4f73. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" 30dde1e3 "[LayoutNG] Fix `vertical-align: top/bottom` with leading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6bcfd3cbd8592903be437e117c94f44d0e5cdc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797757Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695516}
-
Julie Jeongeun Kim authored
This CL converts MemoryPressureObserverPtr to new Mojo types. It also updates AddObserver from memory_pressure.mojom and methods and members which implements it to new Mojo types. Bug: 955171 Change-Id: Ia4b1d611f9c5b698c0d7214553166a539fed768d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788965 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Koji Ishii authored
TBR=futhark@chromium.org NOTRY=true Bug: 953479, 1002815 Change-Id: I3137b75adcca5b7cf5e27f0a2cf4275535139be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797962Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695514}
-
Sergio Villar Senin authored
The build was broken due to https://crrev.com/c/1784242. Added the time.h include which is no longer included by the other headers. Bug: 737867 Change-Id: Ifd2c288d54244d1bf22b14dd99c22555c5c854a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796345Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#695513}
-
Yoshifumi Inoue authored
This patch gets rid of redundant |DCHECK| in |NGInlineNodeDataEditor::Run()|. When removing "0" from <p dir=rtl>0(xy)5<p>, we have 5 items before delete: "0", "(", "xy", ")" "5" The redundant DCHECK() hits at "(". Bug: 1000685 Change-Id: I6ad6295e1267e748c762f5a783b47b1416a68fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797826 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
Alex Danilo authored
Bug: 1002724 Change-Id: I09e8e04ede3e76af08f47223728d37bf069a407d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795470 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695511}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b23a4f9d9442..14318c140949 git log b23a4f9d9442..14318c140949 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 58c5b07b47cf..0b8eca795349 (3 commits) 2019-09-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@14318c140949 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None Change-Id: I0f4fe5fc2ffe38c53763d8df82d68f58d415a1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797281Reviewed-by:
-
Yuki Shiino authored
This is a reland of 468160f8 Original change's description: > v8binding: Make the wrapper check stricter. > > Uses a new V8 API, v8::Object::IsApiWrapper, to improve the > check to determine whether a given v8::Value is a wrapper > object or not. > > Bug: 999262 > Change-Id: I844b20e6a36e1126fdbaf203db75b4c669ba385f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777354 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692629} Bug: 999262 Change-Id: I58a4fabb775d42f0b1ae2463cbc2d95333565e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794325Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#695509}
-
Yoshifumi Inoue authored
This patch is follow-up of CLs[1][2], both CLs make |NGTextFragmentPainter| slower by spliting function, introducing if-statements to check whether |NGPaintFragment| or |NGFragmentItem| and construct |NGFragmentItem| from |NGPhysicalTextFragment|. This patch changes |NGTextFragmentPainter| to template class and specialize to |NGInlineCursor| for |NGFragmentItem|, and |NGTextPainterCursor| for |NGPaintFragment| and |NGPhysicalTextFragment| to avoid function splitting and type checking if-statement. [1] http://crrev.com/c/1758030 [NGFragmentItem] Support painting text [2] http://crrev.com/c/1783689 Making NGTextFragmentPainter to paint document marker with NGFragmentItem Bug: 1000267 Change-Id: I2f29db81a9c098c37553abbb63d08accf708cc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794542 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLMetaElement> as new downcast helper 2. Use IsA<HTMLMetaElement>(element) in place of IsHTMLMetaElement(element) Bug: 891908 Change-Id: I36dcb12b1e8be1bbc5221284a882a4fa415e553b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792690Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#695507}
-
Makoto Shimazu authored
TBR=antrim@chromium.org No-Try: true Bug: 997685 Change-Id: I67b7e92664bb819fdecf80cdf252a34f021d719d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797828Reviewed-by:
-
Rika Fujimaki authored
We made ScriptValue Traceable to replace SharedPersistent with TraceWrapperV8Reference in a follow-up CL. In this CL, most of the changes are just: - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because ScriptValue has a Trace method. - Add a trace method for ScriptValue and ScriptPromise since they have objects to Trace. We recommend you to mainly check - script_value.h where I add VectorTraits. - script_promise.h where I add VectorTraits. - v8_callback_function.py where I add a code to generate HeapVector. - v8_types.py * Add ScriptValue and ScriptPromise to "is_traceable==True" which is used to generate Trace method & HeapVector. + I removed code to detect leak around ScriptPromise because ScriptPromise no longer has persistent which may cause memory leak. Bug: 998994 Change-Id: I63fcbf01de099577fe14045785b3072c615d78c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792583Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts RenderFrameMetadataObserverClientRequest, RenderFrameMetadataObserverClientPtr, and RenderFrameMetadataObserverClientPtrInfo to new Mojo types. It also updates RegisterRenderFrameMetadataObserver from frame_sink_provider.mojom and methods and members which implements it with new Mojo types. Bug: 955171 Change-Id: I1f1fefe865bff8e29b47f437b699e6ac55612881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795524 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
